23633 2009-01-29 17:09:31 -0800 The test transitions/transition-end-event-nested.html occasionally fails 2009-02-02 11:13:06 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Normal --- 1 sky sky oldest_to_newest 107629 0 sky 2009-01-29 17:09:31 -0800 At least on Chromium debug builds. I suspect this is because some times the timeout is called before the events finish. 107630 1 27171 sky 2009-01-29 17:19:14 -0800 Created attachment 27171 Fix This patch does two things: 1. Ups the timeout to 2 seconds. 2. Makes test exit as soon as all events are received. With 2 the tests should be able to run as fast as possible. 107728 2 27171 darin 2009-01-30 10:36:49 -0800 Comment on attachment 27171 Fix Looks OK as is. But also, if we hit the timeout, then I'd like to see the test fail more directly rather than just calling processEndEvents. r=me 107986 3 fishd 2009-02-02 11:13:06 -0800 http://trac.webkit.org/changeset/40480 27171 2009-01-29 17:19:14 -0800 2009-01-30 10:36:49 -0800 Fix 23633.patch text/plain 3008 sky SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDQwMzg4KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMjAgQEAKKzIwMDktMDEtMjkgIFNjb3R0IFZpb2xldCAgPHNr eUBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzYzMworICAg ICAgICBCdWcgMjM2MzM6IFRoZSB0ZXN0IHRyYW5zaXRpb25zL3RyYW5zaXRpb24tZW5kLWV2ZW50 LW5lc3RlZC5odG1sIG9jY2FzaW9uYWxseSBmYWlscworCisgICAgICAgIFVwcyB0aGUgdGltZW91 dCBvZiB0aGUgdGVzdCB0cmFuc2l0aW9ucy90cmFuc2l0aW9uLWVuZC1ldmVudC1uZXN0ZWQuaHRt bAorICAgICAgICBhbmQgbWFrZXMgdGhlIHRlc3QgZXhpdCBhcyBzb29uIGFzIGFsbCBldmVudHMg cmVjZWl2ZWQuCisJCisgICAgICAgICogdHJhbnNpdGlvbnMvdHJhbnNpdGlvbi1lbmQtZXZlbnQt aGVscGVycy5qczoKKyAgICAgICAgKHJlY29yZFRyYW5zaXRpb25FbmRFdmVudCk6CisgICAgICAg IChydW5UcmFuc2l0aW9uVGVzdC5zdGFydFRlc3QuX2VuZEZ1bmN0aW9uKToKKyAgICAgICAgKHJ1 blRyYW5zaXRpb25UZXN0LnN0YXJ0VGVzdCk6CisgICAgICAgIChydW5UcmFuc2l0aW9uVGVzdCk6 CisgICAgICAgICogdHJhbnNpdGlvbnMvdHJhbnNpdGlvbi1lbmQtZXZlbnQtbmVzdGVkLmh0bWw6 CisKIDIwMDktMDEtMjkgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KIAogICAgICAg ICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IExheW91dFRlc3RzL3RyYW5zaXRpb25z L3RyYW5zaXRpb24tZW5kLWV2ZW50LWhlbHBlcnMuanMKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz dHMvdHJhbnNpdGlvbnMvdHJhbnNpdGlvbi1lbmQtZXZlbnQtaGVscGVycy5qcwkocmV2aXNpb24g NDAzODgpCisrKyBMYXlvdXRUZXN0cy90cmFuc2l0aW9ucy90cmFuc2l0aW9uLWVuZC1ldmVudC1o ZWxwZXJzLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0xLDQgKzEsOCBAQAogdmFyIF9yZWNvcmRlZEV2 ZW50cyA9IG5ldyBBcnJheSgpOworLy8gTnVtYmVyIG9mIGV2ZW50cyB3ZSdyZSBzdXBwb3NlZCB0 byByZWNlaXZlLgordmFyIF9leHBlY3RlZEV2ZW50Q291bnQgPSAwOworLy8gRnVuY3Rpb24gaW52 b2tlZCB3aGVuIHdlJ3ZlIHJlY2VpdmVkIF9leHBlY3RlZEV2ZW50Q291bnQgZXZlbnRzLgordmFy IF9lbmRGdW5jdGlvbjsKIAogLyogQ2FsbCB0aGlzIGZ1bmN0aW9uIHRvIHJlY29yZCBtYW51YWxs eSB0cmFuc2l0aW9uIGVuZCBldmVudHM6CiAKQEAgLTE2LDYgKzIwLDggQEAgZnVuY3Rpb24gcmVj b3JkVHJhbnNpdGlvbkVuZEV2ZW50KGV2ZW50KQogICAgIGV2ZW50LnRhcmdldC5pZCwKICAgICBN YXRoLnJvdW5kKGV2ZW50LmVsYXBzZWRUaW1lICogMTAwMCkgLyAxMDAwIC8vIHJvdW5kIHRvIG1z IHRvIGF2b2lkIGZsb2F0aW5nIHBvaW50IGltcHJlY2lzaW9uCiAgICAgXSk7CisgIGlmIChfcmVj b3JkZWRFdmVudHMubGVuZ3RoID09IF9leHBlY3RlZEV2ZW50Q291bnQpCisgICAgX2VuZEZ1bmN0 aW9uKCk7CiB9CiAKIC8qIFRoaXMgaXMgdGhlIGhlbHBlciBmdW5jdGlvbiB0byBydW4gdHJhbnNp dGlvbiBlbmQgZXZlbnQgdGVzdHM6CkBAIC0zOSw3ICs0NSw4IEBAIEZ1bmN0aW9uIHBhcmFtZXRl cnM6CiAqLwogZnVuY3Rpb24gcnVuVHJhbnNpdGlvblRlc3QoZXhwZWN0ZWQsIHRpbWVvdXQsIGNh bGxiYWNrKQogewotICAKKyAgX2V4cGVjdGVkRXZlbnRDb3VudCA9IGV4cGVjdGVkLmxlbmd0aDsK KwogICBpZiAod2luZG93LmxheW91dFRlc3RDb250cm9sbGVyKSB7CiAgICAgbGF5b3V0VGVzdENv bnRyb2xsZXIuZHVtcEFzVGV4dCgpOwogICAgIGxheW91dFRlc3RDb250cm9sbGVyLndhaXRVbnRp bERvbmUoKTsKQEAgLTEzMyw3ICsxNDAsOCBAQCBmdW5jdGlvbiBydW5UcmFuc2l0aW9uVGVzdChl eHBlY3RlZCwgdGltCiAgICAgICB9CiAgICAgfQogICAgIAotICAgIHdpbmRvdy5zZXRUaW1lb3V0 KGZ1bmN0aW9uKCkgeyBwcm9jZXNzRW5kRXZlbnRzKGV4cGVjdGVkKTsgfSwgdGltZW91dCAqIDEw MDApOworICAgIF9lbmRGdW5jdGlvbiA9IGZ1bmN0aW9uKCkgeyBwcm9jZXNzRW5kRXZlbnRzKGV4 cGVjdGVkKTsgfTsKKyAgICB3aW5kb3cuc2V0VGltZW91dChfZW5kRnVuY3Rpb24sIHRpbWVvdXQg KiAxMDAwKTsKICAgfQogICAKICAgd2luZG93LmFkZEV2ZW50TGlzdGVuZXIoJ2xvYWQnLCBmdW5j dGlvbigpIHsgc3RhcnRUZXN0KGV4cGVjdGVkLCB0aW1lb3V0LCBjYWxsYmFjaykgfSwgZmFsc2Up OwpJbmRleDogTGF5b3V0VGVzdHMvdHJhbnNpdGlvbnMvdHJhbnNpdGlvbi1lbmQtZXZlbnQtbmVz dGVkLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvdHJhbnNpdGlvbnMvdHJhbnNpdGlv bi1lbmQtZXZlbnQtbmVzdGVkLmh0bWwJKHJldmlzaW9uIDQwMzg4KQorKysgTGF5b3V0VGVzdHMv dHJhbnNpdGlvbnMvdHJhbnNpdGlvbi1lbmQtZXZlbnQtbmVzdGVkLmh0bWwJKHdvcmtpbmcgY29w eSkKQEAgLTc3LDcgKzc3LDcgQEAKICAgICAgIGJveC5jbGFzc05hbWUgPSAiYm94IGJveDEiOwog ICAgIH0KICAgICAKLSAgICBydW5UcmFuc2l0aW9uVGVzdChleHBlY3RlZEVuZEV2ZW50cywgMS4w LCBzZXR1cFRlc3QpOworICAgIHJ1blRyYW5zaXRpb25UZXN0KGV4cGVjdGVkRW5kRXZlbnRzLCAy LjAsIHNldHVwVGVzdCk7CiAgICAgCiAgIDwvc2NyaXB0PgogPC9oZWFkPgo=