236327 2022-02-08 14:23:44 -0800 Invoke generate-xcfilelists with Python 3 2022-02-10 15:08:37 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 emw emw ap jbedard webkit-bug-importer oldest_to_newest 1838873 0 emw 2022-02-08 14:23:44 -0800 Use of unversioned 'python' in Mac builds causing failures in 12.3 1838874 1 451303 emw 2022-02-08 14:24:49 -0800 Created attachment 451303 Patch 1838875 2 451303 emw 2022-02-08 14:25:56 -0800 Comment on attachment 451303 Patch I still need to test this in the latest 12.3 beta seed before this is ready to land. 1838877 3 webkit-bug-importer 2022-02-08 14:26:59 -0800 <rdar://problem/88652152> 1839000 4 emw 2022-02-08 20:36:15 -0800 Unfortunately, this will take some more work. The next script to fail (on my machine) is JavaScriptCore's "Check .xcfilelists". Fixing its shebang doesn't suffice, it still fails with PhaseScriptExecution Check\ .xcfilelists /Volumes/Data/OpenSource/WebKitBuild/JavaScriptCore.build/Debug/JavaScriptCore.build/Script-53609F9021DFFA9C008FA60A.sh cd /Volumes/Data/OpenSource/Source/JavaScriptCore /bin/sh -c /Volumes/Data/OpenSource/WebKitBuild/JavaScriptCore.build/Debug/JavaScriptCore.build/Script-53609F9021DFFA9C008FA60A.sh Traceback (most recent call last): File "/Volumes/Data/Internal/Tools/Scripts/../../../OpenSource/Tools/Scripts/generate-xcfilelists", line 59, in <module> application_class = apple_additions().get_generate_xcfilelists_application() if apple_additions() else Application File "/Volumes/Data/Internal/Tools/Scripts/apple_additions/__init__.py", line 129, in get_generate_xcfilelists_application from apple_additions.generate_xcfilelists_internal_application import InternalApplication File "/Volumes/Data/Internal/Tools/Scripts/apple_additions/generate_xcfilelists_internal_application.py", line 7, in <module> import generate_xcfilelists_internal_generators as Generators ModuleNotFoundError: No module named 'generate_xcfilelists_internal_generators' Command /bin/sh failed with exit code 1 Perhaps there are some actual python2 dependencies in this library :\ 1839516 5 451489 emw 2022-02-09 20:02:50 -0800 Created attachment 451489 python -> python3 in WebKit.xcodeproj, build scripts Updates shebang lines for a couple of scripts needed to make internal builds. 1839858 6 451489 emw 2022-02-10 11:46:22 -0800 Comment on attachment 451489 python -> python3 in WebKit.xcodeproj, build scripts `build-jsc` works locally, so I think the failure was a flake. cq+ 1839987 7 ews-feeder 2022-02-10 15:08:33 -0800 Committed r289584 (247099@main): <https://commits.webkit.org/247099@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451489. 451303 2022-02-08 14:24:49 -0800 2022-02-09 20:02:50 -0800 Patch bug-236327-20220208142449.patch text/plain 3051 emw U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5MzU3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGU1YmNkNTZjNjlhNGZmYzY1 OWE1MjlmNDQzMDM2MmY1MjU5YTcyMWEuLjBhNzUzNGRjNzk3OGI4ZDJlNDdkZGNkZGJkODlmN2Y5 ZmU1MzEzMzEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMjItMDItMDggIEVsbGlvdHQg V2lsbGlhbXMgIDxlbXdAYXBwbGUuY29tPgorCisgICAgICAgIFVzZSBvZiB1bnZlcnNpb25lZCAn cHl0aG9uJyBpbiBNYWMgYnVpbGRzIGNhdXNpbmcgZmFpbHVyZXMgaW4gMTIuMworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM2MzI3CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBXZWJLaXQueGNvZGVwcm9q L3Byb2plY3QucGJ4cHJvajogcy9weXRob24vcHl0aG9uMyBpbiAiUmVwbGFjZSBXZWJLaXRBZGRp dGlvbnMgaW4KKyAgICAgICAgRnJhbWV3b3JrIEhlYWRlcnMiIHBoYXNlLgorCiAyMDIyLTAyLTA3 ICBCZW4gTmhhbSAgPG5oYW1AYXBwbGUuY29tPgogCiAgICAgICAgIEFkZCBQdXNoU2VydmljZQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9XZWJLaXQueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJv aiBiL1NvdXJjZS9XZWJLaXQvV2ViS2l0Lnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2oKaW5kZXgg ZWE2NTg3YzU3NzYyMmUyYWQ1MWYzYzUxMzNlYWU5ZmY2NjNhNTQ3NC4uYmIzZWRiZmVhOTY2MzA0 N2NhNGI1MWQyMWQzMTQ5ODhlOTA1YmU1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJL aXQueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvagorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYktpdC54 Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCkBAIC0xNTQxMCw3ICsxNTQxMCw3IEBACiAJCQkpOwog CQkJcnVuT25seUZvckRlcGxveW1lbnRQb3N0cHJvY2Vzc2luZyA9IDA7CiAJCQlzaGVsbFBhdGgg PSAvYmluL3NoOwotCQkJc2hlbGxTY3JpcHQgPSAiaWYgWyBcIiR7WENPREVfVkVSU0lPTl9BQ1RV QUx9XCIgLWdlIFwiMTE0MFwiIC1hIFwiJHtXS19VU0VfTkVXX0JVSUxEX1NZU1RFTX1cIiA9IFwi WUVTXCIgXTsgdGhlblxuICAgICMgSW4gdGhpcyBjb25maWd1cmF0aW9uLCBwb3N0LXByb2Nlc3Np bmcgaXMgcGVyZm9ybWVkIGF0IHRoZSBzYW1lIHRpbWUgYXMgY29weWluZyBpbiB0aGUgcG9zdHBy b2Nlc3MtaGVhZGVyLXJ1bGUgc2NyaXB0LCBzbyB0aGVyZSdzIG5vIG5lZWQgZm9yIHRoaXMgc2Vw YXJhdGUgc3RlcC5cbiAgICBleGl0IDBcbmZpXG5cbmlmIFsgXCIke0FDVElPTn1cIiA9IFwiYW5h bHl6ZVwiIC1vIFwiJHtBQ1RJT059XCIgPSBcImJ1aWxkXCIgLW8gXCIke0FDVElPTn1cIiA9IFwi aW5zdGFsbFwiIC1vIFwiJHtBQ1RJT059XCIgPSBcImluc3RhbGxoZHJzXCIgLW8gXCIke0FDVElP Tn1cIiA9IFwiaW5zdGFsbGFwaVwiIF07IHRoZW5cbiAgICBmb3IgSEVBREVSU19ESVJFQ1RPUlkg aW4gXCIke1BVQkxJQ19IRUFERVJTX0ZPTERFUl9QQVRIfVwiIFwiJHtQUklWQVRFX0hFQURFUlNf Rk9MREVSX1BBVEh9XCI7IGRvXG4gICAgICAgIGZvciBIRUFERVJfUEFUSCBpbiBcIiR7VEFSR0VU X0JVSUxEX0RJUn0vJHtIRUFERVJTX0RJUkVDVE9SWX0vXCIqLio7IGRvXG4gICAgICAgICAgICBp ZiBbWyAhIC16IGBncmVwICcjaW1wb3J0IDxXZWJLaXRBZGRpdGlvbnMvLio+JyBcIiR7SEVBREVS X1BBVEh9XCJgIF1dOyB0aGVuXG4gICAgICAgICAgICAgICAgcHl0aG9uIFwiJHtTUkNST09UfS9t YWMvcmVwbGFjZS13ZWJraXQtYWRkaXRpb25zLWluY2x1ZGVzLnB5XCIgXCIke0hFQURFUl9QQVRI fVwiIFwiJHtCVUlMVF9QUk9EVUNUU19ESVJ9XCIgXCIke1NES1JPT1R9XCIgfHwgZXhpdCAkP1xu ICAgICAgICAgICAgZmlcbiAgICAgICAgZG9uZVxuICAgIGRvbmVcbmZpXG5cblxuIjsKKwkJCXNo ZWxsU2NyaXB0ID0gImlmIFsgXCIke1hDT0RFX1ZFUlNJT05fQUNUVUFMfVwiIC1nZSBcIjExNDBc IiAtYSBcIiR7V0tfVVNFX05FV19CVUlMRF9TWVNURU19XCIgPSBcIllFU1wiIF07IHRoZW5cbiAg ICAjIEluIHRoaXMgY29uZmlndXJhdGlvbiwgcG9zdC1wcm9jZXNzaW5nIGlzIHBlcmZvcm1lZCBh dCB0aGUgc2FtZSB0aW1lIGFzIGNvcHlpbmcgaW4gdGhlIHBvc3Rwcm9jZXNzLWhlYWRlci1ydWxl IHNjcmlwdCwgc28gdGhlcmUncyBubyBuZWVkIGZvciB0aGlzIHNlcGFyYXRlIHN0ZXAuXG4gICAg ZXhpdCAwXG5maVxuXG5pZiBbIFwiJHtBQ1RJT059XCIgPSBcImFuYWx5emVcIiAtbyBcIiR7QUNU SU9OfVwiID0gXCJidWlsZFwiIC1vIFwiJHtBQ1RJT059XCIgPSBcImluc3RhbGxcIiAtbyBcIiR7 QUNUSU9OfVwiID0gXCJpbnN0YWxsaGRyc1wiIC1vIFwiJHtBQ1RJT059XCIgPSBcImluc3RhbGxh cGlcIiBdOyB0aGVuXG4gICAgZm9yIEhFQURFUlNfRElSRUNUT1JZIGluIFwiJHtQVUJMSUNfSEVB REVSU19GT0xERVJfUEFUSH1cIiBcIiR7UFJJVkFURV9IRUFERVJTX0ZPTERFUl9QQVRIfVwiOyBk b1xuICAgICAgICBmb3IgSEVBREVSX1BBVEggaW4gXCIke1RBUkdFVF9CVUlMRF9ESVJ9LyR7SEVB REVSU19ESVJFQ1RPUll9L1wiKi4qOyBkb1xuICAgICAgICAgICAgaWYgW1sgISAteiBgZ3JlcCAn I2ltcG9ydCA8V2ViS2l0QWRkaXRpb25zLy4qPicgXCIke0hFQURFUl9QQVRIfVwiYCBdXTsgdGhl blxuICAgICAgICAgICAgICAgIHB5dGhvbjMgXCIke1NSQ1JPT1R9L21hYy9yZXBsYWNlLXdlYmtp dC1hZGRpdGlvbnMtaW5jbHVkZXMucHlcIiBcIiR7SEVBREVSX1BBVEh9XCIgXCIke0JVSUxUX1BS T0RVQ1RTX0RJUn1cIiBcIiR7U0RLUk9PVH1cIiB8fCBleGl0ICQ/XG4gICAgICAgICAgICBmaVxu ICAgICAgICBkb25lXG4gICAgZG9uZVxuZmlcblxuXG4iOwogCQl9OwogLyogRW5kIFBCWFNoZWxs U2NyaXB0QnVpbGRQaGFzZSBzZWN0aW9uICovCiAK 451489 2022-02-09 20:02:50 -0800 2022-02-10 15:08:36 -0800 python -> python3 in WebKit.xcodeproj, build scripts fix-unversioned-python-usage.patch text/plain 3667 emw ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFu Z2VMb2cKaW5kZXggYjIxZDAxZjk0Y2E5Li5hMjQxNjk0MjUxNDAgMTAwNjQ0Ci0tLSBhL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTMgQEAKKzIwMjItMDItMDggIEVsbGlvdHQgV2lsbGlhbXMgIDxlbXdAYXBwbGUuY29tPgor CisgICAgICAgIFVzZSBvZiB1bnZlcnNpb25lZCAncHl0aG9uJyBpbiBNYWMgYnVpbGRzIGNhdXNp bmcgZmFpbHVyZXMgaW4gMTIuMworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MjM2MzI3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBXZWJLaXQueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvajogcHl0aG9uIC0+ IHB5dGhvbjMgaW4gIlJlcGxhY2UgV2ViS2l0QWRkaXRpb25zIGluCisgICAgICAgIEZyYW1ld29y ayBIZWFkZXJzIiBwaGFzZS4KKwogMjAyMi0wMi0wOSAgQW50b2luZSBRdWludCAgPGdyYW91dHNA d2Via2l0Lm9yZz4KIAogICAgICAgICBbbW9kZWxdIGltcHJvdmUgc2l6aW5nIG9uIG1hY09TCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1dlYktpdC54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9q IGIvU291cmNlL1dlYktpdC9XZWJLaXQueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvagppbmRleCAz ZmNjMWYxYmY3OTEuLjhmYjJlNjRmNTAzOCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9XZWJL aXQueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvagorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYktpdC54 Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCkBAIC0xNTQzOCw3ICsxNTQzOCw3IEBACiAJCQkpOwog CQkJcnVuT25seUZvckRlcGxveW1lbnRQb3N0cHJvY2Vzc2luZyA9IDA7CiAJCQlzaGVsbFBhdGgg PSAvYmluL3NoOwotCQkJc2hlbGxTY3JpcHQgPSAiaWYgWyBcIiR7WENPREVfVkVSU0lPTl9BQ1RV QUx9XCIgLWdlIFwiMTE0MFwiIC1hIFwiJHtXS19VU0VfTkVXX0JVSUxEX1NZU1RFTX1cIiA9IFwi WUVTXCIgXTsgdGhlblxuICAgICMgSW4gdGhpcyBjb25maWd1cmF0aW9uLCBwb3N0LXByb2Nlc3Np bmcgaXMgcGVyZm9ybWVkIGF0IHRoZSBzYW1lIHRpbWUgYXMgY29weWluZyBpbiB0aGUgcG9zdHBy b2Nlc3MtaGVhZGVyLXJ1bGUgc2NyaXB0LCBzbyB0aGVyZSdzIG5vIG5lZWQgZm9yIHRoaXMgc2Vw YXJhdGUgc3RlcC5cbiAgICBleGl0IDBcbmZpXG5cbmlmIFsgXCIke0FDVElPTn1cIiA9IFwiYW5h bHl6ZVwiIC1vIFwiJHtBQ1RJT059XCIgPSBcImJ1aWxkXCIgLW8gXCIke0FDVElPTn1cIiA9IFwi aW5zdGFsbFwiIC1vIFwiJHtBQ1RJT059XCIgPSBcImluc3RhbGxoZHJzXCIgLW8gXCIke0FDVElP Tn1cIiA9IFwiaW5zdGFsbGFwaVwiIF07IHRoZW5cbiAgICBmb3IgSEVBREVSU19ESVJFQ1RPUlkg aW4gXCIke1BVQkxJQ19IRUFERVJTX0ZPTERFUl9QQVRIfVwiIFwiJHtQUklWQVRFX0hFQURFUlNf Rk9MREVSX1BBVEh9XCI7IGRvXG4gICAgICAgIGZvciBIRUFERVJfUEFUSCBpbiBcIiR7VEFSR0VU X0JVSUxEX0RJUn0vJHtIRUFERVJTX0RJUkVDVE9SWX0vXCIqLio7IGRvXG4gICAgICAgICAgICBp ZiBbWyAhIC16IGBncmVwICcjaW1wb3J0IDxXZWJLaXRBZGRpdGlvbnMvLio+JyBcIiR7SEVBREVS X1BBVEh9XCJgIF1dOyB0aGVuXG4gICAgICAgICAgICAgICAgcHl0aG9uIFwiJHtTUkNST09UfS9t YWMvcmVwbGFjZS13ZWJraXQtYWRkaXRpb25zLWluY2x1ZGVzLnB5XCIgXCIke0hFQURFUl9QQVRI fVwiIFwiJHtCVUlMVF9QUk9EVUNUU19ESVJ9XCIgXCIke1NES1JPT1R9XCIgfHwgZXhpdCAkP1xu ICAgICAgICAgICAgZmlcbiAgICAgICAgZG9uZVxuICAgIGRvbmVcbmZpXG5cblxuIjsKKwkJCXNo ZWxsU2NyaXB0ID0gImlmIFsgXCIke1hDT0RFX1ZFUlNJT05fQUNUVUFMfVwiIC1nZSBcIjExNDBc IiAtYSBcIiR7V0tfVVNFX05FV19CVUlMRF9TWVNURU19XCIgPSBcIllFU1wiIF07IHRoZW5cbiAg ICAjIEluIHRoaXMgY29uZmlndXJhdGlvbiwgcG9zdC1wcm9jZXNzaW5nIGlzIHBlcmZvcm1lZCBh dCB0aGUgc2FtZSB0aW1lIGFzIGNvcHlpbmcgaW4gdGhlIHBvc3Rwcm9jZXNzLWhlYWRlci1ydWxl IHNjcmlwdCwgc28gdGhlcmUncyBubyBuZWVkIGZvciB0aGlzIHNlcGFyYXRlIHN0ZXAuXG4gICAg ZXhpdCAwXG5maVxuXG5pZiBbIFwiJHtBQ1RJT059XCIgPSBcImFuYWx5emVcIiAtbyBcIiR7QUNU SU9OfVwiID0gXCJidWlsZFwiIC1vIFwiJHtBQ1RJT059XCIgPSBcImluc3RhbGxcIiAtbyBcIiR7 QUNUSU9OfVwiID0gXCJpbnN0YWxsaGRyc1wiIC1vIFwiJHtBQ1RJT059XCIgPSBcImluc3RhbGxh cGlcIiBdOyB0aGVuXG4gICAgZm9yIEhFQURFUlNfRElSRUNUT1JZIGluIFwiJHtQVUJMSUNfSEVB REVSU19GT0xERVJfUEFUSH1cIiBcIiR7UFJJVkFURV9IRUFERVJTX0ZPTERFUl9QQVRIfVwiOyBk b1xuICAgICAgICBmb3IgSEVBREVSX1BBVEggaW4gXCIke1RBUkdFVF9CVUlMRF9ESVJ9LyR7SEVB REVSU19ESVJFQ1RPUll9L1wiKi4qOyBkb1xuICAgICAgICAgICAgaWYgW1sgISAteiBgZ3JlcCAn I2ltcG9ydCA8V2ViS2l0QWRkaXRpb25zLy4qPicgXCIke0hFQURFUl9QQVRIfVwiYCBdXTsgdGhl blxuICAgICAgICAgICAgICAgIHB5dGhvbjMgXCIke1NSQ1JPT1R9L21hYy9yZXBsYWNlLXdlYmtp dC1hZGRpdGlvbnMtaW5jbHVkZXMucHlcIiBcIiR7SEVBREVSX1BBVEh9XCIgXCIke0JVSUxUX1BS T0RVQ1RTX0RJUn1cIiBcIiR7U0RLUk9PVH1cIiB8fCBleGl0ICQ/XG4gICAgICAgICAgICBmaVxu ICAgICAgICBkb25lXG4gICAgZG9uZVxuZmlcblxuXG4iOwogCQl9OwogLyogRW5kIFBCWFNoZWxs U2NyaXB0QnVpbGRQaGFzZSBzZWN0aW9uICovCiAKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMv ZXh0cmFjdC1kZXBlbmRlbmNpZXMtZnJvbS1tYWtlZmlsZSBiL1Rvb2xzL1NjcmlwdHMvZXh0cmFj dC1kZXBlbmRlbmNpZXMtZnJvbS1tYWtlZmlsZQppbmRleCBjYWY2ZmQxMDFhNDMuLjZiNGU1MzQz OWExYyAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0cy9leHRyYWN0LWRlcGVuZGVuY2llcy1mcm9t LW1ha2VmaWxlCisrKyBiL1Rvb2xzL1NjcmlwdHMvZXh0cmFjdC1kZXBlbmRlbmNpZXMtZnJvbS1t YWtlZmlsZQpAQCAtMSw0ICsxLDQgQEAKLSMhL3Vzci9iaW4vZW52IHB5dGhvbgorIyEvdXNyL2Jp bi9lbnYgcHl0aG9uMwogIyB2aW06IHNldCBmdD1weXRob246CiAjIC0qLSBjb2Rpbmc6IHV0Zi04 IC0qLQogIwpkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9nZW5lcmF0ZS14Y2ZpbGVsaXN0cyBi L1Rvb2xzL1NjcmlwdHMvZ2VuZXJhdGUteGNmaWxlbGlzdHMKaW5kZXggMDQyYTY2Y2IxZTBkLi5l ODZhM2U2Yjg5MjkgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvZ2VuZXJhdGUteGNmaWxlbGlz dHMKKysrIGIvVG9vbHMvU2NyaXB0cy9nZW5lcmF0ZS14Y2ZpbGVsaXN0cwpAQCAtMSw0ICsxLDQg QEAKLSMhL3Vzci9iaW4vZW52IHB5dGhvbgorIyEvdXNyL2Jpbi9lbnYgcHl0aG9uMwogIyAtKi0g Y29kaW5nOiB1dGYtOCAtKi0KICMKICMgQ29weXJpZ2h0IChDKSAyMDE5IEFwcGxlIEluYy4gIEFs bCByaWdodHMgcmVzZXJ2ZWQuCg==