236325 2022-02-08 13:25:55 -0800 REGRESSION (r288804): fast/forms/visual-hebrew-text-field.html is failing 2022-02-14 18:17:34 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tsavell rniwa ap dino koivisto mmaxfield rniwa simon.fraser webkit-bot-watchers-bugzilla webkit-bug-importer zalan oldest_to_newest 1838857 0 tsavell 2022-02-08 13:25:55 -0800 fast/forms/visual-hebrew-text-field.html this test is failing constantly after the changes in https://trac.webkit.org/changeset/288804/webkit History: https://results.webkit.org/?suite=layout-tests&test=fast%2Fforms%2Fvisual-hebrew-text-field.html Diff: --- /Volumes/Data/worker/monterey-release-applesilicon-tests-wk2/build/layout-test-results/fast/forms/visual-hebrew-text-field-expected.txt +++ /Volumes/Data/worker/monterey-release-applesilicon-tests-wk2/build/layout-test-results/fast/forms/visual-hebrew-text-field-actual.txt @@ -3,26 +3,27 @@ layer at (0,0) size 800x600 RenderBlock {HTML} at (0,0) size 800x600 RenderBody {BODY} at (8,8) size 784x584 - RenderBlock {P} at (0,0) size 784x36 - RenderText {#text} at (0,0) size 218x18 - text run at (0,0) width 218: "This tests for a regression against " - RenderInline {I} at (0,0) size 783x36 - RenderInline {A} at (0,0) size 354x18 [color=#0000EE] - RenderText {#text} at (217,0) size 354x18 - text run at (217,0) width 354: "http://bugzilla.opendarwin.org/show_bug.cgi?id=8076" - RenderText {#text} at (570,0) size 783x36 - text run at (570,0) width 213: " REGRESSION: native text fields" - text run at (0,18) width 251: "are reversed on \"visual Hebrew\" pages" - RenderText {#text} at (250,18) size 5x18 - text run at (250,18) width 5: "." - RenderBlock {HR} at (0,52) size 784x2 [border: (1px inset #000000)] - RenderBlock {P} at (0,70) size 784x19 - RenderText {#text} at (0,1) size 286x18 - text run at (0,1) width 286: "Text in the field should look like this: \x{5E8}\x{5D5}\x{5EA}\x{5E4}\x{5DB}" - RenderBlock (anonymous) at (0,105) size 784x23 - RenderTextControl {INPUT} at (2,2) size 147x19 [bgcolor=#FFFFFF] [border: (2px inset #000000)] + RenderBlock {P} at (0,0) size 784x84 + RenderText {#text} at (0,0) size 327x28 + text run at (0,0) width 327: "This tests for a regression against " + RenderInline {I} at (0,0) size 774x84 + RenderInline {A} at (0,0) size 774x56 [color=#0000EE] + RenderText {#text} at (326,0) size 774x56 + text run at (326,0) width 448: "http://bugzilla.opendarwin.org/show_bug.cgi?" + text run at (0,28) width 83: "id=8076" + RenderText {#text} at (82,28) size 720x56 + text run at (82,28) width 638: " REGRESSION: native text fields are reversed on \"visual Hebrew\"" + text run at (0,56) width 56: "pages" + RenderText {#text} at (55,56) size 7x28 + text run at (55,56) width 7: "." + RenderBlock {HR} at (0,108) size 784x2 [border: (1px inset #000000)] + RenderBlock {P} at (0,134) size 784x29 + RenderText {#text} at (0,1) size 429x28 + text run at (0,1) width 429: "Text in the field should look like this: \x{5E8}\x{5D5}\x{5EA}\x{5E4}\x{5DB}" + RenderBlock (anonymous) at (0,187) size 784x38 + RenderTextControl {INPUT} at (2,2) size 302x34 [bgcolor=#FFFFFF] [border: (2px inset #000000)] RenderText {#text} at (0,0) size 0x0 -layer at (13,118) size 141x13 - RenderBlock {DIV} at (3,3) size 141x13 - RenderText {#text} at (0,0) size 31x13 - text run at (0,0) width 31 RTL: "\x{5DB}\x{5E4}\x{5EA}\x{5D5}\x{5E8}" +layer at (13,200) size 296x28 + RenderBlock {DIV} at (3,3) size 296x28 + RenderText {#text} at (0,0) size 66x28 + text run at (0,0) width 66 RTL: "\x{5DB}\x{5E4}\x{5EA}\x{5D5}\x{5E8}" 1838858 1 webkit-bug-importer 2022-02-08 13:27:09 -0800 <rdar://problem/88648904> 1839315 2 rniwa 2022-02-09 11:33:28 -0800 Huh, very strange. I guess I should confirm it locally and figure out how on the earth that change would have caused this test failure. 1841298 3 ap 2022-02-14 09:55:09 -0800 Ryosuke, do you expect to have the time to look into this in near future? If not, we should just revert. 1841357 4 rniwa 2022-02-14 12:23:16 -0800 (In reply to Alexey Proskuryakov from comment #3) > Ryosuke, do you expect to have the time to look into this in near future? If > not, we should just revert. Yeah, I'm going to look into this today. 1841374 5 rniwa 2022-02-14 13:07:30 -0800 The test passes when ran on its own so it's some kind of inter-test states. 1841431 6 rniwa 2022-02-14 15:27:59 -0800 This seems to be an issue with font loading code leaking some kind of inter-test dependency / states. For now, I'm gonna workaround it by forcing a different test options in the test itself to emulate the environment in which test ran prior to r288804 1841433 7 451948 rniwa 2022-02-14 15:28:42 -0800 Created attachment 451948 Patch 1841472 8 ap 2022-02-14 16:33:07 -0800 Nice. It this a test harness bug of some kind that the test used to run in this unusual environment prior to r288804? I'm not quite following what changed. Understood that there is font loading issue too. 1841484 9 rniwa 2022-02-14 16:53:29 -0800 (In reply to Alexey Proskuryakov from comment #8) > Nice. It this a test harness bug of some kind that the test used to run in > this unusual environment prior to r288804? I'm not quite following what > changed. Yeah, so prior to r288804, we had another test which ran immediately before this test that enabled keygen element and that seems to have somehow clear(?) some kind of test interdependent state. I'm using emulating the same effect by forcing ephemeral session here. It's somewhat of a fragile fix but it's probably more important for this test to get back running instead of root causing whatever font loading issue we may have here. 1841515 10 ews-feeder 2022-02-14 18:17:28 -0800 Committed r289787 (247252@main): <https://commits.webkit.org/247252@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451948. 451948 2022-02-14 15:28:42 -0800 2022-02-14 18:17:32 -0800 Patch bug-236325-20220214152841.patch text/plain 1499 rniwa U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4ODA0CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKaW5kZXggNDRhZmRjMzZlMDA5YTVlMjIwM2Yy ODA4YzIxOWQ4OGFlMTdjN2QxMC4uMzg1OTU5MmQ2NDA4MDA5NWQ4NTYyODgxMmI5MWZjMDNiMzlh ZTI2YiAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3Rz L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIyLTAyLTE0ICBSeW9zdWtlIE5pd2EgIDxy bml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04gKHIyODg4MDQpOiBmYXN0L2Zv cm1zL3Zpc3VhbC1oZWJyZXctdGV4dC1maWVsZC5odG1sIGlzIGZhaWxpbmcKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNjMyNQorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSB0ZXN0IGZhaWx1cmUgaXMg Y2F1c2VkIGJ5IHByZS1leGlzdGluZyBpbnRlci10ZXN0IGRlcGVuZGVuY2llcy4KKyAgICAgICAg V29ya2Fyb3VuZCB3aGF0ZXZlciB0aGUgdW5kZXJseWluZyBjYXVzZSBmb3IgdGhlIHRlc3QgZmFp bHVyZSBieSBmb3JjaW5nCisgICAgICAgIHRoZSB1c2Ugb2YgZXBoZW1lcmFsIHNlc3Npb24gZm9y IG5vdy4KKworICAgICAgICAqIGZhc3QvZm9ybXMvdmlzdWFsLWhlYnJldy10ZXh0LWZpZWxkLmh0 bWw6CisKIDIwMjItMDEtMzAgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgRGVsZXRlIGNvZGUgZm9yIGtleWdlbiBlbGVtZW50CmRpZmYgLS1naXQgYS9MYXlvdXRU ZXN0cy9mYXN0L2Zvcm1zL3Zpc3VhbC1oZWJyZXctdGV4dC1maWVsZC5odG1sIGIvTGF5b3V0VGVz dHMvZmFzdC9mb3Jtcy92aXN1YWwtaGVicmV3LXRleHQtZmllbGQuaHRtbAppbmRleCA4YjMxYzlm MzhmMTM2M2Q2Y2UzYzA4ODFkZWRiMjRkYjA0ZDZkYWU4Li5hMTU4MDAyZTQ0NjQxNTIzYTNhYmJl NGEzMDk0ZTVmZjRmNTcyOGFkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9mYXN0L2Zvcm1zL3Zp c3VhbC1oZWJyZXctdGV4dC1maWVsZC5odG1sCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZm9ybXMv dmlzdWFsLWhlYnJldy10ZXh0LWZpZWxkLmh0bWwKQEAgLTEsNCArMSw1IEBACi08aHRtbD4KKzxo dG1sPjwhLS0gd2Via2l0LXRlc3QtcnVubmVyIFsgdXNlRXBoZW1lcmFsU2Vzc2lvbj10cnVlIF0g LS0+Cis8IS0tIEZJWE1FOiBXZSBzaG91bGRuJ3QgaGF2ZSB0byB1c2UgZXBoZW1lcmFsIHNlc3Np b24gYnV0IHRoZSB0ZXN0IGZhaWxzIHdpdGhvdXQgaXQgZm9yIG5vdy4gU2VlIHdlYmtpdC5vcmcv Yi8yMzYzMjUgLS0+CiA8aGVhZD4KIDxtZXRhIGh0dHAtZXF1aXY9IkNvbnRlbnQtVHlwZSIgY29u dGVudD0idGV4dC9odG1sOyBjaGFyc2V0PWlzby04ODU5LTgiPgogPHRpdGxlPi1raHRtbC1ydGwt b3JkZXJpbmc8L3RpdGxlPgo=