236322 2022-02-08 12:48:20 -0800 Dialog's "previously focused element" and focus-visible 2022-02-15 09:30:38 -0800 1 1 1 Unclassified WebKit DOM Safari Technology Preview Mac (Intel) macOS 12 NEW InRadar P2 Normal --- 84635 1 darin.senneff webkit-unassigned koivisto ntim rego webkit-bug-importer oldest_to_newest 1838838 0 darin.senneff 2022-02-08 12:48:20 -0800 When closing a <dialog> element, focus is only moved back to the "previously focused element" if a keyboard was used to initially show the dialog. I'm assuming this has to do with the focus-visible algorithm, as a click doesn't normally put visible focus on a button. But because the <dialog> autofocuses a button upon being opened, it's possible users will then use the keyboard to close the modal rather than click – by pressing the ENTER, SPACE, or ESC keys. In these cases where the user has changed their input method from click/tap to keyboard, should the previous element now receive focus? I think regardless of the input method used to close a modal, focus should be placed on the previous element to help re-orient the user. But at minimum I think it should in cases where a keyboard was used to close the <dialog>. Looking at the spec's dialog focusing steps, this edge case seems beyond that. But think there's value in it. 1839152 1 rego 2022-02-09 07:51:37 -0800 Hi, thanks for the bug report. If you're testing this on Mac, <button> are not mouse focusable on Mac (see https://bugs.webkit.org/show_bug.cgi?id=229895 for more details). So I guess that when you close the dialog, if it was opened by a button, it's not going to be focused when you close it. I've tested on WebKitGTK (Linux), and the button that opens the dialog gets focused when I close it. If the problem is unrelated to the buttons not being click focusable on Mac, could you please create a test case reproducing the issue? 1839156 2 darin.senneff 2022-02-09 08:01:50 -0800 Yup, I get the non-focusable button if the <dialog> is opened and closed with a mouse. And that if its opened and closed with a keyboard that the button does get focus. But what if the <dialog> is opened with a mouse but closed with a keyboard? Since the element autofocuses a button upon opening (and can be closed with the ESC key), it's likely that some users will switch to a keyboard after originally opening the <dialog> with their mouse/finger. In those cases, doesn't it make sense to put keyboard focus to the button? 1841753 3 webkit-bug-importer 2022-02-15 09:30:38 -0800 <rdar://problem/88969727>