236309 2022-02-08 09:43:00 -0800 Register strings in CSSTokenizer created from preprocessing 2022-02-09 11:40:30 -0800 1 1 1 Unclassified WebKit WebKit Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 gnavamarino gnavamarino esprehn+autocc ews-watchlist glenn gyuyoung.kim macpherson menard msaboff sam webkit-bug-importer oldest_to_newest 1838721 0 gnavamarino 2022-02-08 09:43:00 -0800 This will align with what is currently done for strings with escapes in CSSTokenizer::consumeName(). 1838725 1 gnavamarino 2022-02-08 09:46:04 -0800 <rdar://problem/88321921> 1838726 2 451262 gnavamarino 2022-02-08 09:46:49 -0800 Created attachment 451262 Patch 1838738 3 451262 sam 2022-02-08 10:00:16 -0800 Comment on attachment 451262 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451262&action=review > Source/WebCore/ChangeLog:9 > + Register strings in CSSTokenizer created from preprocessing. This will align with > + what is currently done for strings with escapes in CSSTokenizer::consumeName(). What is the benefit of this change? 1838749 4 gnavamarino 2022-02-08 10:17:30 -0800 (In reply to Sam Weinig from comment #3) > Comment on attachment 451262 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=451262&action=review > > > Source/WebCore/ChangeLog:9 > > + Register strings in CSSTokenizer created from preprocessing. This will align with > > + what is currently done for strings with escapes in CSSTokenizer::consumeName(). > > What is the benefit of this change? Otherwise the string can go out of scope. 1839320 5 ews-feeder 2022-02-09 11:40:26 -0800 Committed r289493 (247031@main): <https://commits.webkit.org/247031@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451262. 451262 2022-02-08 09:46:49 -0800 2022-02-09 11:40:28 -0800 Patch bug-236309-20220208094648.patch text/plain 5875 gnavamarino U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5MzgxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDU4ZjRlYTJkNzY2ZDJl NGZiNmMzMWM3NjdjN2YyODcxYTA4Y2EyOS4uOWE5MzBlYThjZDJkZTNkNTQwYzgzMjllOTMzZTBk NTgzYTM4Y2MyMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIxIEBACisyMDIyLTAyLTA4ICBHYWJy aWVsIE5hdmEgTWFyaW5vICA8Z25hdmFtYXJpbm9AYXBwbGUuY29tPgorCisgICAgICAgIFJlZ2lz dGVyIHN0cmluZ3MgaW4gQ1NTVG9rZW5pemVyIGNyZWF0ZWQgZnJvbSBwcmVwcm9jZXNzaW5nCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzYzMDkKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZWdpc3RlciBz dHJpbmdzIGluIENTU1Rva2VuaXplciBjcmVhdGVkIGZyb20gcHJlcHJvY2Vzc2luZy4gVGhpcyB3 aWxsIGFsaWduIHdpdGgKKyAgICAgICAgd2hhdCBpcyBjdXJyZW50bHkgZG9uZSBmb3Igc3RyaW5n cyB3aXRoIGVzY2FwZXMgaW4gQ1NTVG9rZW5pemVyOjpjb25zdW1lTmFtZSgpLgorCisgICAgICAg ICogY3NzL3BhcnNlci9DU1NUb2tlbml6ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTVG9r ZW5pemVyOjpwcmVwcm9jZXNzU3RyaW5nKToKKyAgICAgICAgKFdlYkNvcmU6OkNTU1Rva2VuaXpl cjo6dHJ5Q3JlYXRlKToKKyAgICAgICAgKFdlYkNvcmU6OkNTU1Rva2VuaXplcjo6Q1NTVG9rZW5p emVyKToKKyAgICAgICAgKFdlYkNvcmU6OnByZXByb2Nlc3NTdHJpbmcpOiBEZWxldGVkLgorICAg ICAgICAqIGNzcy9wYXJzZXIvQ1NTVG9rZW5pemVyLmg6CisgICAgICAgICogY3NzL3BhcnNlci9D U1NUb2tlbml6ZXJJbnB1dFN0cmVhbS5oOgorCiAyMDIyLTAyLTA4ICBNYXR0IFdvb2Ryb3cgIDxt YXR0d29vZHJvd0BhcHBsZS5jb20+CiAKICAgICAgICAgUmV0dXJuICdub25lJyBmb3IgdGhlIGNv bXB1dGVkIHN0eWxlIG9mIG1hc2sgd2hlbiB0aGVyZSBhcmUgbm8gbWFzayBpbWFnZXMKZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9wYXJzZXIvQ1NTVG9rZW5pemVyLmNwcCBiL1NvdXJj ZS9XZWJDb3JlL2Nzcy9wYXJzZXIvQ1NTVG9rZW5pemVyLmNwcAppbmRleCA0MGYzMzFiYzEwYTQ2 MWFhMWVhNzFmYjU1OGU1NzRlNTEwNThhZTU4Li5jM2FhOWI0MjIwZmEyMmUxMzExYzRkMThlNTFi NGE2ZDJjZGE0MjJiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3MvcGFyc2VyL0NTU1Rv a2VuaXplci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL3BhcnNlci9DU1NUb2tlbml6ZXIu Y3BwCkBAIC00MywxOSArNDMsMjMgQEAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogLy8gaHR0cHM6 Ly9kcmFmdHMuY3Nzd2cub3JnL2Nzcy1zeW50YXgvI2lucHV0LXByZXByb2Nlc3NpbmcKLXN0YXRp YyBTdHJpbmcgcHJlcHJvY2Vzc1N0cmluZyhTdHJpbmcgc3RyaW5nKQorU3RyaW5nIENTU1Rva2Vu aXplcjo6cHJlcHJvY2Vzc1N0cmluZyhTdHJpbmcgc3RyaW5nKQogewogICAgIC8vIFdlIGRvbid0 IHJlcGxhY2UgJ1xyJyBhbmQgJ1xmJyB3aXRoICdcbicgYXMgdGhlIHNwZWNpZmljYXRpb24gc3Vn Z2VzdHMsIGluc3RlYWQKICAgICAvLyB3ZSB0cmVhdCB0aGVtIGFsbCB0aGUgc2FtZSBpbiB0aGUg aXNOZXdMaW5lIGZ1bmN0aW9uIGJlbG93LgorICAgIFN0cmluZ0ltcGwqIG9sZEltcGwgPSBzdHJp bmcuaW1wbCgpOwogICAgIHN0cmluZy5yZXBsYWNlKCdcMCcsIHJlcGxhY2VtZW50Q2hhcmFjdGVy KTsKLSAgICByZXR1cm4gcmVwbGFjZVVucGFpcmVkU3Vycm9nYXRlc1dpdGhSZXBsYWNlbWVudENo YXJhY3RlcihXVEZNb3ZlKHN0cmluZykpOworICAgIFN0cmluZyByZXBsYWNlZCA9IHJlcGxhY2VV bnBhaXJlZFN1cnJvZ2F0ZXNXaXRoUmVwbGFjZW1lbnRDaGFyYWN0ZXIoV1RGTW92ZShzdHJpbmcp KTsKKyAgICBpZiAocmVwbGFjZWQuaW1wbCgpICE9IG9sZEltcGwpCisgICAgICAgIHJlZ2lzdGVy U3RyaW5nKHJlcGxhY2VkKTsKKyAgICByZXR1cm4gcmVwbGFjZWQ7CiB9CiAKIHN0ZDo6dW5pcXVl X3B0cjxDU1NUb2tlbml6ZXI+IENTU1Rva2VuaXplcjo6dHJ5Q3JlYXRlKGNvbnN0IFN0cmluZyYg c3RyaW5nKQogewogICAgIGJvb2wgc3VjY2VzcyA9IHRydWU7CiAgICAgLy8gV2UgY2FuJ3QgdXNl IG1ha2VVbmlxdWUgaGVyZSBiZWNhdXNlIGl0IGRvZXMgbm90IGhhdmUgYWNjZXNzIHRvIHRoaXMg cHJpdmF0ZSBjb25zdHJ1Y3Rvci4KLSAgICBhdXRvIHRva2VuaXplciA9IHN0ZDo6dW5pcXVlX3B0 cjxDU1NUb2tlbml6ZXI+KG5ldyBDU1NUb2tlbml6ZXIocHJlcHJvY2Vzc1N0cmluZyhzdHJpbmcp LCBudWxscHRyLCAmc3VjY2VzcykpOworICAgIGF1dG8gdG9rZW5pemVyID0gc3RkOjp1bmlxdWVf cHRyPENTU1Rva2VuaXplcj4obmV3IENTU1Rva2VuaXplcihzdHJpbmcsIG51bGxwdHIsICZzdWNj ZXNzKSk7CiAgICAgaWYgKFVOTElLRUxZKCFzdWNjZXNzKSkKICAgICAgICAgcmV0dXJuIG51bGxw dHI7CiAgICAgcmV0dXJuIHRva2VuaXplcjsKQEAgLTY1LDI0ICs2OSwyNCBAQCBzdGQ6OnVuaXF1 ZV9wdHI8Q1NTVG9rZW5pemVyPiBDU1NUb2tlbml6ZXI6OnRyeUNyZWF0ZShjb25zdCBTdHJpbmcm IHN0cmluZywgQ1NTUAogewogICAgIGJvb2wgc3VjY2VzcyA9IHRydWU7CiAgICAgLy8gV2UgY2Fu J3QgdXNlIG1ha2VVbmlxdWUgaGVyZSBiZWNhdXNlIGl0IGRvZXMgbm90IGhhdmUgYWNjZXNzIHRv IHRoaXMgcHJpdmF0ZSBjb25zdHJ1Y3Rvci4KLSAgICBhdXRvIHRva2VuaXplciA9IHN0ZDo6dW5p cXVlX3B0cjxDU1NUb2tlbml6ZXI+KG5ldyBDU1NUb2tlbml6ZXIocHJlcHJvY2Vzc1N0cmluZyhz dHJpbmcpLCAmd3JhcHBlciwgJnN1Y2Nlc3MpKTsKKyAgICBhdXRvIHRva2VuaXplciA9IHN0ZDo6 dW5pcXVlX3B0cjxDU1NUb2tlbml6ZXI+KG5ldyBDU1NUb2tlbml6ZXIoc3RyaW5nLCAmd3JhcHBl ciwgJnN1Y2Nlc3MpKTsKICAgICBpZiAoVU5MSUtFTFkoIXN1Y2Nlc3MpKQogICAgICAgICByZXR1 cm4gbnVsbHB0cjsKICAgICByZXR1cm4gdG9rZW5pemVyOwogfQogCiBDU1NUb2tlbml6ZXI6OkNT U1Rva2VuaXplcihjb25zdCBTdHJpbmcmIHN0cmluZykKLSAgICA6IENTU1Rva2VuaXplcihwcmVw cm9jZXNzU3RyaW5nKHN0cmluZyksIG51bGxwdHIsIG51bGxwdHIpCisgICAgOiBDU1NUb2tlbml6 ZXIoc3RyaW5nLCBudWxscHRyLCBudWxscHRyKQogewogfQogCiBDU1NUb2tlbml6ZXI6OkNTU1Rv a2VuaXplcihjb25zdCBTdHJpbmcmIHN0cmluZywgQ1NTUGFyc2VyT2JzZXJ2ZXJXcmFwcGVyJiB3 cmFwcGVyKQotICAgIDogQ1NTVG9rZW5pemVyKHByZXByb2Nlc3NTdHJpbmcoc3RyaW5nKSwgJndy YXBwZXIsIG51bGxwdHIpCisgICAgOiBDU1NUb2tlbml6ZXIoc3RyaW5nLCAmd3JhcHBlciwgbnVs bHB0cikKIHsKIH0KIAotQ1NTVG9rZW5pemVyOjpDU1NUb2tlbml6ZXIoU3RyaW5nJiYgc3RyaW5n LCBDU1NQYXJzZXJPYnNlcnZlcldyYXBwZXIqIHdyYXBwZXIsIGJvb2wqIGNvbnN0cnVjdGlvblN1 Y2Nlc3NQdHIpCi0gICAgOiBtX2lucHV0KHN0cmluZykKK0NTU1Rva2VuaXplcjo6Q1NTVG9rZW5p emVyKGNvbnN0IFN0cmluZyYgc3RyaW5nLCBDU1NQYXJzZXJPYnNlcnZlcldyYXBwZXIqIHdyYXBw ZXIsIGJvb2wqIGNvbnN0cnVjdGlvblN1Y2Nlc3NQdHIpCisgICAgOiBtX2lucHV0KHByZXByb2Nl c3NTdHJpbmcoc3RyaW5nKSkKIHsKICAgICBpZiAoY29uc3RydWN0aW9uU3VjY2Vzc1B0cikKICAg ICAgICAgKmNvbnN0cnVjdGlvblN1Y2Nlc3NQdHIgPSB0cnVlOwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvY3NzL3BhcnNlci9DU1NUb2tlbml6ZXIuaCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9w YXJzZXIvQ1NTVG9rZW5pemVyLmgKaW5kZXggMjEwMDkxNzAzOGIxMGY2MmE3ZmEyNTMwMzMxNmRj YmZkYzVkZGFlMi4uYjVhNDc0M2ViNjNlYWI2YzMwMjI2M2I0MTkyMDBhY2MyN2Q0NGE2YyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL3BhcnNlci9DU1NUb2tlbml6ZXIuaAorKysgYi9T b3VyY2UvV2ViQ29yZS9jc3MvcGFyc2VyL0NTU1Rva2VuaXplci5oCkBAIC01NywxMyArNTcsMTUg QEAgcHVibGljOgogICAgIFZlY3RvcjxTdHJpbmc+JiYgZXNjYXBlZFN0cmluZ3NGb3JBZG9wdGlv bigpIHsgcmV0dXJuIFdURk1vdmUobV9zdHJpbmdQb29sKTsgfQogCiBwcml2YXRlOgotICAgIENT U1Rva2VuaXplcihTdHJpbmcmJiwgQ1NTUGFyc2VyT2JzZXJ2ZXJXcmFwcGVyKiwgYm9vbCogY29u c3RydWN0aW9uU3VjY2Vzcyk7CisgICAgQ1NTVG9rZW5pemVyKGNvbnN0IFN0cmluZyYsIENTU1Bh cnNlck9ic2VydmVyV3JhcHBlciosIGJvb2wqIGNvbnN0cnVjdGlvblN1Y2Nlc3MpOwogCiAgICAg Q1NTUGFyc2VyVG9rZW4gbmV4dFRva2VuKCk7CiAKICAgICBVQ2hhciBjb25zdW1lKCk7CiAgICAg dm9pZCByZWNvbnN1bWUoVUNoYXIpOwogCisgICAgU3RyaW5nIHByZXByb2Nlc3NTdHJpbmcoU3Ry aW5nKTsKKwogICAgIENTU1BhcnNlclRva2VuIGNvbnN1bWVOdW1lcmljVG9rZW4oKTsKICAgICBD U1NQYXJzZXJUb2tlbiBjb25zdW1lSWRlbnRMaWtlVG9rZW4oKTsKICAgICBDU1NQYXJzZXJUb2tl biBjb25zdW1lTnVtYmVyKCk7CkBAIC0xMjIsMTEgKzEyNCwxMCBAQCBwcml2YXRlOgogICAgIHN0 YXRpYyBjb25zdCBDb2RlUG9pbnQgY29kZVBvaW50c1tdOwogCiAgICAgVmVjdG9yPENTU1BhcnNl clRva2VuVHlwZSwgOD4gbV9ibG9ja1N0YWNrOwotICAgIENTU1Rva2VuaXplcklucHV0U3RyZWFt IG1faW5wdXQ7Ci0gICAgCiAgICAgVmVjdG9yPENTU1BhcnNlclRva2VuLCAzMj4gbV90b2tlbnM7 CiAgICAgLy8gV2Ugb25seSBhbGxvY2F0ZSBzdHJpbmdzIHdoZW4gZXNjYXBlcyBhcmUgdXNlZC4K ICAgICBWZWN0b3I8U3RyaW5nPiBtX3N0cmluZ1Bvb2w7CisgICAgQ1NTVG9rZW5pemVySW5wdXRT dHJlYW0gbV9pbnB1dDsKIH07CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL2Nzcy9wYXJzZXIvQ1NTVG9rZW5pemVySW5wdXRTdHJlYW0uaCBiL1Nv dXJjZS9XZWJDb3JlL2Nzcy9wYXJzZXIvQ1NTVG9rZW5pemVySW5wdXRTdHJlYW0uaAppbmRleCA2 N2ZkOThmNGUzMDIxZDc5NGMzMmJiYWQyNzI1YzgzZDU1NjczNjFhLi4xMjU1MGIyYjU0MDAyYWRj NzRlZDJhMGJkNThmNWU5YzhlM2FjMDZiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9jc3Mv cGFyc2VyL0NTU1Rva2VuaXplcklucHV0U3RyZWFtLmgKKysrIGIvU291cmNlL1dlYkNvcmUvY3Nz L3BhcnNlci9DU1NUb2tlbml6ZXJJbnB1dFN0cmVhbS5oCkBAIC00MSw4ICs0MSw3IEBAIGNsYXNz IENTU1Rva2VuaXplcklucHV0U3RyZWFtIHsKIHB1YmxpYzoKICAgICBleHBsaWNpdCBDU1NUb2tl bml6ZXJJbnB1dFN0cmVhbShjb25zdCBTdHJpbmcmIGlucHV0KTsKIAotICAgIC8vIEdldHMgdGhl IGNoYXIgaW4gdGhlIHN0cmVhbSByZXBsYWNpbmcgTlVMIGNoYXJhY3RlcnMgd2l0aCBhIHVuaWNv ZGUKLSAgICAvLyByZXBsYWNlbWVudCBjaGFyYWN0ZXIuIFdpbGwgcmV0dXJuIChOVUwpIGtFbmRP ZkZpbGVNYXJrZXIgd2hlbiBhdCB0aGUKKyAgICAvLyBHZXRzIHRoZSBjaGFyIGluIHRoZSBzdHJl YW0uIFdpbGwgcmV0dXJuIChOVUwpIGtFbmRPZkZpbGVNYXJrZXIgd2hlbiBhdCB0aGUKICAgICAv LyBlbmQgb2YgdGhlIHN0cmVhbS4KICAgICBVQ2hhciBuZXh0SW5wdXRDaGFyKCkgY29uc3QKICAg ICB7Cg==