236295 2022-02-08 02:49:45 -0800 [WPE] Developer extras are always enabled by default 2022-02-08 04:33:28 -0800 1 1 1 Unclassified WebKit WPE WebKit WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 aperez aperez alex bugs-noreply cgarcia zdobersek oldest_to_newest 1838589 0 aperez 2022-02-08 02:49:45 -0800 Currently in WPEView.cpp there is a call to enable the option unconditionally, around line 64: if (preferences) { preferences->setAcceleratedCompositingEnabled(true); preferences->setForceCompositingMode(true); preferences->setThreadedScrollingEnabled(true); preferences->setWebGLEnabled(true); preferences->setDeveloperExtrasEnabled(true); } This should be disabled by default, and when needed users would opt-in with webkit_settings_set_enable_developer_extras(settings, TRUE) via the public API. 1838591 1 451229 aperez 2022-02-08 03:00:10 -0800 Created attachment 451229 Patch 1838618 2 ews-feeder 2022-02-08 04:33:24 -0800 Committed r289366 (246954@main): <https://commits.webkit.org/246954@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451229. 451229 2022-02-08 03:00:10 -0800 2022-02-08 04:33:26 -0800 Patch bug-236295-20220208130008.patch text/plain 1371 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5MzYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGU1YmNkNTZjNjlhNGZmYzY1 OWE1MjlmNDQzMDM2MmY1MjU5YTcyMWEuLjE0YzZlY2NhY2U1MjM4MjI5NmIwNDAyNjRkNGMyNjcz YTY1YTQ3ZGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjItMDItMDggIEFkcmlhbiBQ ZXJleiBkZSBDYXN0cm8gIDxhcGVyZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbV1BFXSBEZXZl bG9wZXIgZXh0cmFzIGFyZSBhbHdheXMgZW5hYmxlZCBieSBkZWZhdWx0CisgICAgICAgIGh0dHBz Oi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzYyOTUKKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMuCisKKyAgICAg ICAgKiBVSVByb2Nlc3MvQVBJL3dwZS9XUEVWaWV3LmNwcDoKKyAgICAgICAgKFZpZXc6OlZpZXcp OiBSZW1vdmUgY2FsbCB0byB1bmNvbmRpdGlvbmFsbHkgc2V0IHRoZSBkZXZlbG9wZXIgZXh0cmFz IHNldHRpbmcuCisKIDIwMjItMDItMDcgIEJlbiBOaGFtICA8bmhhbUBhcHBsZS5jb20+CiAKICAg ICAgICAgQWRkIFB1c2hTZXJ2aWNlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9BUEkvd3BlL1dQRVZpZXcuY3BwIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvQVBJL3dwZS9X UEVWaWV3LmNwcAppbmRleCA1NTM2ZmJjNTQzMDk2OWUxNjYwMDMyYjI0OWM2YmM4NDY1M2MyMzNh Li41MTY0NTliMzE0MDljNzA2MWU1NDZmZGQwMmI5OGVkZTM0YmE2ZjNkIDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L1VJUHJvY2Vzcy9BUEkvd3BlL1dQRVZpZXcuY3BwCisrKyBiL1NvdXJjZS9X ZWJLaXQvVUlQcm9jZXNzL0FQSS93cGUvV1BFVmlldy5jcHAKQEAgLTY2LDcgKzY2LDYgQEAgVmll dzo6VmlldyhzdHJ1Y3Qgd3BlX3ZpZXdfYmFja2VuZCogYmFja2VuZCwgY29uc3QgQVBJOjpQYWdl Q29uZmlndXJhdGlvbiYgYmFzZUMKICAgICAgICAgcHJlZmVyZW5jZXMtPnNldEZvcmNlQ29tcG9z aXRpbmdNb2RlKHRydWUpOwogICAgICAgICBwcmVmZXJlbmNlcy0+c2V0VGhyZWFkZWRTY3JvbGxp bmdFbmFibGVkKHRydWUpOwogICAgICAgICBwcmVmZXJlbmNlcy0+c2V0V2ViR0xFbmFibGVkKHRy dWUpOwotICAgICAgICBwcmVmZXJlbmNlcy0+c2V0RGV2ZWxvcGVyRXh0cmFzRW5hYmxlZCh0cnVl KTsKICAgICB9CiAKICAgICBhdXRvKiBwb29sID0gY29uZmlndXJhdGlvbi0+cHJvY2Vzc1Bvb2wo KTsK