23627 2009-01-29 15:18:47 -0800 PLATFORM(SKIA) build bustage in SVGPaintServer.cpp 2009-01-29 16:40:07 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 fishd fishd oldest_to_newest 107592 0 fishd 2009-01-29 15:18:47 -0800 PLATFORM(SKIA) build bustage in SVGPaintServer.cpp Simple patch coming up... 107593 1 27164 fishd 2009-01-29 15:19:31 -0800 Created attachment 27164 v1 patch 107594 2 27164 mitz 2009-01-29 15:20:53 -0800 Comment on attachment 27164 v1 patch I wonder if this won't trigger the unused parameters warning on non-Skia platforms. 107596 3 fishd 2009-01-29 15:22:39 -0800 Oh, I didn't realize that warning was enabled. I guess I could move the entire function into the #ifdef. 107597 4 27164 darin 2009-01-29 15:28:10 -0800 Comment on attachment 27164 v1 patch This will break the build on Mac OS X unless you use UNUSED_PARAM when it's not PLATFORM(SKIA). 107598 5 27165 fishd 2009-01-29 15:32:01 -0800 Created attachment 27165 v2 patch 107599 6 27165 darin 2009-01-29 15:33:43 -0800 Comment on attachment 27165 v2 patch > +#else > +void SVGPaintServer::teardown(GraphicsContext*&, const RenderObject*, SVGPaintTargetType, bool) const > +{ > +#endif Missing a brace here. Please fix that! 107601 7 27167 fishd 2009-01-29 15:35:47 -0800 Created attachment 27167 v3 patch 3rd times a charm :) 107612 8 eric 2009-01-29 16:08:53 -0800 I don't understand why this is necessary? Why doesn't Skia want the standard "teardown" function? Skia should be using the standard PatternSkia.cpp and GradientSkia.cpp abstractions instead of any custom SVGPaintServer* classes these days... 107618 9 fishd 2009-01-29 16:30:27 -0800 That's a great question. I think the FIXME implies a desire to clean that up. I was just hoping to "fix bustage" in existing code. Can I postpone cleanup to a subsequent bug? 107620 10 27167 eric 2009-01-29 16:34:06 -0800 Comment on attachment 27167 v3 patch Oh, I'm sorry. I thought you were adding the #ifdefs, I didn't realize they were already there. Yes, this is totally fine. 107621 11 fishd 2009-01-29 16:40:07 -0800 http://trac.webkit.org/changeset/40385 27164 2009-01-29 15:19:31 -0800 2009-01-29 15:32:01 -0800 v1 patch svg_1.diff text/plain 1422 fishd SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQwMzc4 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMDEt MjkgIERhcmluIEZpc2hlciAgPGRhcmluQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjM2MjcKKyAgICAgICAgRml4IHRoZSBQTEFURk9STShTS0lBKSBidWls ZC4KKworICAgICAgICAqIHN2Zy9ncmFwaGljcy9TVkdQYWludFNlcnZlci5jcHA6CisgICAgICAg IChXZWJDb3JlOjpTVkdQYWludFNlcnZlcjo6dGVhcmRvd24pOgorCiAyMDA5LTAxLTI5ICBEYXZp ZCBIeWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KIAogICAgICAgICBNb3ZlIHRoZSBsaW5lIGJveCBs aXN0IG1lbWJlciBvdXQgb2YgUmVuZGVyRmxvdyBhbmQgZG93biBpbnRvIFJlbmRlckJsb2NrIGFu ZCBSZW5kZXJJbmxpbmUuICBFbGltaW5hdGUgUmVuZGVyRmxvdyBmcm9tIHRoZSB0cmVlLgpJbmRl eDogc3ZnL2dyYXBoaWNzL1NWR1BhaW50U2VydmVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBzdmcvZ3Jh cGhpY3MvU1ZHUGFpbnRTZXJ2ZXIuY3BwCShyZXZpc2lvbiA0MDMxNCkKKysrIHN2Zy9ncmFwaGlj cy9TVkdQYWludFNlcnZlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM3LDYgKzM3LDEwIEBACiAj aW5jbHVkZSAiU1ZHU3R5bGVkRWxlbWVudC5oIgogI2luY2x1ZGUgIlNWR1VSSVJlZmVyZW5jZS5o IgogCisjaWYgUExBVEZPUk0oU0tJQSkKKyNpbmNsdWRlICJQbGF0Zm9ybUNvbnRleHRTa2lhLmgi CisjZW5kaWYKKwogbmFtZXNwYWNlIFdlYkNvcmUgewogCiBTVkdQYWludFNlcnZlcjo6U1ZHUGFp bnRTZXJ2ZXIoKQpAQCAtMTc5LDcgKzE4Myw3IEBAIHZvaWQgU1ZHUGFpbnRTZXJ2ZXI6OnJlbmRl clBhdGgoR3JhcGhpY3MKICAgICAgICAgY29udGV4dC0+c3Ryb2tlUGF0aCgpOwogfQogCi12b2lk IFNWR1BhaW50U2VydmVyOjp0ZWFyZG93bihHcmFwaGljc0NvbnRleHQqJiwgY29uc3QgUmVuZGVy T2JqZWN0KiwgU1ZHUGFpbnRUYXJnZXRUeXBlLCBib29sKSBjb25zdAordm9pZCBTVkdQYWludFNl cnZlcjo6dGVhcmRvd24oR3JhcGhpY3NDb250ZXh0KiYgY29udGV4dCwgY29uc3QgUmVuZGVyT2Jq ZWN0KiwgU1ZHUGFpbnRUYXJnZXRUeXBlLCBib29sKSBjb25zdAogewogI2lmIFBMQVRGT1JNKFNL SUEpCiAgICAgLy8gRklYTUU6IE1vdmUgdGhpcyBpbnRvIHRoZSBHcmFwaGljc0NvbnRleHQK 27165 2009-01-29 15:32:01 -0800 2009-01-29 15:35:47 -0800 v2 patch svg_2.diff text/plain 1943 fishd SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQwMzc4 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMDEt MjkgIERhcmluIEZpc2hlciAgPGRhcmluQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjM2MjcKKyAgICAgICAgRml4IHRoZSBQTEFURk9STShTS0lBKSBidWls ZC4KKworICAgICAgICAqIHN2Zy9ncmFwaGljcy9TVkdQYWludFNlcnZlci5jcHA6CisgICAgICAg IChXZWJDb3JlOjpTVkdQYWludFNlcnZlcjo6dGVhcmRvd24pOgorCiAyMDA5LTAxLTI5ICBEYXZp ZCBIeWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KIAogICAgICAgICBNb3ZlIHRoZSBsaW5lIGJveCBs aXN0IG1lbWJlciBvdXQgb2YgUmVuZGVyRmxvdyBhbmQgZG93biBpbnRvIFJlbmRlckJsb2NrIGFu ZCBSZW5kZXJJbmxpbmUuICBFbGltaW5hdGUgUmVuZGVyRmxvdyBmcm9tIHRoZSB0cmVlLgpJbmRl eDogc3ZnL2dyYXBoaWNzL1NWR1BhaW50U2VydmVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBzdmcvZ3Jh cGhpY3MvU1ZHUGFpbnRTZXJ2ZXIuY3BwCShyZXZpc2lvbiA0MDMxNCkKKysrIHN2Zy9ncmFwaGlj cy9TVkdQYWludFNlcnZlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM3LDYgKzM3LDEwIEBACiAj aW5jbHVkZSAiU1ZHU3R5bGVkRWxlbWVudC5oIgogI2luY2x1ZGUgIlNWR1VSSVJlZmVyZW5jZS5o IgogCisjaWYgUExBVEZPUk0oU0tJQSkKKyNpbmNsdWRlICJQbGF0Zm9ybUNvbnRleHRTa2lhLmgi CisjZW5kaWYKKwogbmFtZXNwYWNlIFdlYkNvcmUgewogCiBTVkdQYWludFNlcnZlcjo6U1ZHUGFp bnRTZXJ2ZXIoKQpAQCAtMTc5LDkgKzE4Myw5IEBAIHZvaWQgU1ZHUGFpbnRTZXJ2ZXI6OnJlbmRl clBhdGgoR3JhcGhpY3MKICAgICAgICAgY29udGV4dC0+c3Ryb2tlUGF0aCgpOwogfQogCi12b2lk IFNWR1BhaW50U2VydmVyOjp0ZWFyZG93bihHcmFwaGljc0NvbnRleHQqJiwgY29uc3QgUmVuZGVy T2JqZWN0KiwgU1ZHUGFpbnRUYXJnZXRUeXBlLCBib29sKSBjb25zdAotewogI2lmIFBMQVRGT1JN KFNLSUEpCit2b2lkIFNWR1BhaW50U2VydmVyOjp0ZWFyZG93bihHcmFwaGljc0NvbnRleHQqJiBj b250ZXh0LCBjb25zdCBSZW5kZXJPYmplY3QqLCBTVkdQYWludFRhcmdldFR5cGUsIGJvb2wpIGNv bnN0Cit7CiAgICAgLy8gRklYTUU6IE1vdmUgdGhpcyBpbnRvIHRoZSBHcmFwaGljc0NvbnRleHQK ICAgICAvLyBXZWJLaXQgaW1wbGljaXRseSBleHBlY3RzIHVzIHRvIHJlc2V0IHRoZSBwYXRoLgog ICAgIC8vIEZvciBleGFtcGxlIGluIGZpbGxBbmRTdHJva2VQYXRoKCkgb2YgUmVuZGVyUGF0aC5j cHAgdGhlIHBhdGggaXMgCkBAIC0xOTAsOCArMTk0LDExIEBAIHZvaWQgU1ZHUGFpbnRTZXJ2ZXI6 OnRlYXJkb3duKEdyYXBoaWNzQ28KICAgICBjb250ZXh0LT5iZWdpblBhdGgoKTsKICAgICBjb250 ZXh0LT5wbGF0Zm9ybUNvbnRleHQoKS0+c2V0R3JhZGllbnQoMCk7CiAgICAgY29udGV4dC0+cGxh dGZvcm1Db250ZXh0KCktPnNldFBhdHRlcm4oMCk7Ci0jZW5kaWYKIH0KKyNlbHNlCit2b2lkIFNW R1BhaW50U2VydmVyOjp0ZWFyZG93bihHcmFwaGljc0NvbnRleHQqJiwgY29uc3QgUmVuZGVyT2Jq ZWN0KiwgU1ZHUGFpbnRUYXJnZXRUeXBlLCBib29sKSBjb25zdAoreworI2VuZGlmCiAKIERhc2hB cnJheSBkYXNoQXJyYXlGcm9tUmVuZGVyaW5nU3R5bGUoY29uc3QgUmVuZGVyU3R5bGUqIHN0eWxl KQogewo= 27167 2009-01-29 15:35:47 -0800 2009-01-29 16:32:03 -0800 v3 patch svg_3.diff text/plain 1946 fishd SW5kZXg6IENoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBDaGFuZ2VMb2cJKHJldmlzaW9uIDQwMzc4 KQorKysgQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTMgQEAKKzIwMDktMDEt MjkgIERhcmluIEZpc2hlciAgPGRhcmluQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjM2MjcKKyAgICAgICAgRml4IHRoZSBQTEFURk9STShTS0lBKSBidWls ZC4KKworICAgICAgICAqIHN2Zy9ncmFwaGljcy9TVkdQYWludFNlcnZlci5jcHA6CisgICAgICAg IChXZWJDb3JlOjpTVkdQYWludFNlcnZlcjo6dGVhcmRvd24pOgorCiAyMDA5LTAxLTI5ICBEYXZp ZCBIeWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KIAogICAgICAgICBNb3ZlIHRoZSBsaW5lIGJveCBs aXN0IG1lbWJlciBvdXQgb2YgUmVuZGVyRmxvdyBhbmQgZG93biBpbnRvIFJlbmRlckJsb2NrIGFu ZCBSZW5kZXJJbmxpbmUuICBFbGltaW5hdGUgUmVuZGVyRmxvdyBmcm9tIHRoZSB0cmVlLgpJbmRl eDogc3ZnL2dyYXBoaWNzL1NWR1BhaW50U2VydmVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBzdmcvZ3Jh cGhpY3MvU1ZHUGFpbnRTZXJ2ZXIuY3BwCShyZXZpc2lvbiA0MDMxNCkKKysrIHN2Zy9ncmFwaGlj cy9TVkdQYWludFNlcnZlci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM3LDYgKzM3LDEwIEBACiAj aW5jbHVkZSAiU1ZHU3R5bGVkRWxlbWVudC5oIgogI2luY2x1ZGUgIlNWR1VSSVJlZmVyZW5jZS5o IgogCisjaWYgUExBVEZPUk0oU0tJQSkKKyNpbmNsdWRlICJQbGF0Zm9ybUNvbnRleHRTa2lhLmgi CisjZW5kaWYKKwogbmFtZXNwYWNlIFdlYkNvcmUgewogCiBTVkdQYWludFNlcnZlcjo6U1ZHUGFp bnRTZXJ2ZXIoKQpAQCAtMTc5LDkgKzE4Myw5IEBAIHZvaWQgU1ZHUGFpbnRTZXJ2ZXI6OnJlbmRl clBhdGgoR3JhcGhpY3MKICAgICAgICAgY29udGV4dC0+c3Ryb2tlUGF0aCgpOwogfQogCi12b2lk IFNWR1BhaW50U2VydmVyOjp0ZWFyZG93bihHcmFwaGljc0NvbnRleHQqJiwgY29uc3QgUmVuZGVy T2JqZWN0KiwgU1ZHUGFpbnRUYXJnZXRUeXBlLCBib29sKSBjb25zdAotewogI2lmIFBMQVRGT1JN KFNLSUEpCit2b2lkIFNWR1BhaW50U2VydmVyOjp0ZWFyZG93bihHcmFwaGljc0NvbnRleHQqJiBj b250ZXh0LCBjb25zdCBSZW5kZXJPYmplY3QqLCBTVkdQYWludFRhcmdldFR5cGUsIGJvb2wpIGNv bnN0Cit7CiAgICAgLy8gRklYTUU6IE1vdmUgdGhpcyBpbnRvIHRoZSBHcmFwaGljc0NvbnRleHQK ICAgICAvLyBXZWJLaXQgaW1wbGljaXRseSBleHBlY3RzIHVzIHRvIHJlc2V0IHRoZSBwYXRoLgog ICAgIC8vIEZvciBleGFtcGxlIGluIGZpbGxBbmRTdHJva2VQYXRoKCkgb2YgUmVuZGVyUGF0aC5j cHAgdGhlIHBhdGggaXMgCkBAIC0xOTAsOCArMTk0LDEyIEBAIHZvaWQgU1ZHUGFpbnRTZXJ2ZXI6 OnRlYXJkb3duKEdyYXBoaWNzQ28KICAgICBjb250ZXh0LT5iZWdpblBhdGgoKTsKICAgICBjb250 ZXh0LT5wbGF0Zm9ybUNvbnRleHQoKS0+c2V0R3JhZGllbnQoMCk7CiAgICAgY29udGV4dC0+cGxh dGZvcm1Db250ZXh0KCktPnNldFBhdHRlcm4oMCk7Ci0jZW5kaWYKIH0KKyNlbHNlCit2b2lkIFNW R1BhaW50U2VydmVyOjp0ZWFyZG93bihHcmFwaGljc0NvbnRleHQqJiwgY29uc3QgUmVuZGVyT2Jq ZWN0KiwgU1ZHUGFpbnRUYXJnZXRUeXBlLCBib29sKSBjb25zdAoreworfQorI2VuZGlmCiAKIERh c2hBcnJheSBkYXNoQXJyYXlGcm9tUmVuZGVyaW5nU3R5bGUoY29uc3QgUmVuZGVyU3R5bGUqIHN0 eWxlKQogewo=