236251 2022-02-07 12:09:49 -0800 [Xcode] Prevent install builds from using the default toolchain 2022-02-07 13:32:40 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED MOVED InRadar P2 Normal --- 1 emw emw ap webkit-bug-importer oldest_to_newest 1838287 0 emw 2022-02-07 12:09:49 -0800 [Xcode] Prevent install builds from using the default toolchain 1838291 1 451137 emw 2022-02-07 12:14:12 -0800 Created attachment 451137 Patch 1838292 2 webkit-bug-importer 2022-02-07 12:15:13 -0800 <rdar://problem/88587680> 1838294 3 451137 emw 2022-02-07 12:17:22 -0800 Comment on attachment 451137 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451137&action=review > Source/WTF/WTF.xcodeproj/project.pbxproj:1761 > + shellScript = "if [ $(basename \"$TOOLCHAIN_DIR\") == \"XcodeDefault.xctoolchain\" ]; then\necho \"error: Installed toolchain doesn't match requested one, failing the build early to prevent falling back to default toolchain\"\nexit 1\nfi\n"; this is: ``` if [ $(basename "$TOOLCHAIN_DIR") == "XcodeDefault.xctoolchain" ]; then echo "error: Installed toolchain doesn't match requested one, failing the build early to prevent falling back to default toolchain" exit 1 fi ``` 1838330 4 451137 ap 2022-02-07 13:32:29 -0800 Comment on attachment 451137 Patch Moving this elsewhere. 451137 2022-02-07 12:14:12 -0800 2022-02-07 13:32:29 -0800 Patch bug-236251-20220207121411.patch text/plain 3698 emw U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5MDIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDZkYmQwOWQ0N2NmY2Q5OWRlMjUyNmNj MzJkNWI3MzMwZTI5NWUyYjMuLjc2ZGFlM2RlNjdlMTBlNjlkZjQ2YjBkMzA2NTRmYzBiZjM3ZTE3 MGUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMjItMDItMDcgIEVsbGlvdHQgV2lsbGlhbXMgIDxl bXdAYXBwbGUuY29tPgorCisgICAgICAgIFtYY29kZV0gUHJldmVudCBpbnN0YWxsIGJ1aWxkcyBm cm9tIHVzaW5nIHRoZSBkZWZhdWx0IHRvb2xjaGFpbgorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM2MjUxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgQSBzZWxlY3RlZCAiWGNvZGVEZWZhdWx0LnhjdG9vbGNo YWluIiBpbiBwcm9kdWN0aW9uIGlzIHVzdWFsbHkgYSBmYWxsYmFjaywgbWVhbmluZyB0aGUKKyAg ICAgICAgX3JlYWxfIHRvb2xjaGFpbiBhc2tlZCBmb3Igd2FzIG5vdCBhdmFpbGFibGUgYW5kIHRo ZSBidWlsZCBlbnZyaW9ubWVudCBpcyBtaXNjb25maWd1cmVkLgorCisgICAgICAgIEltcGxlbWVu dGVkIGluIFdURiwgYnV0IGFwcGxpZXMgdG8gYWxsIHByb2plY3RzLgorCisgICAgICAgICogV1RG Lnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2o6IEFkZCBpbnN0YWxsLW9ubHkgc2NyaXB0IHBoYXNl LgorCiAyMDIyLTAyLTAyICBYYW4gTG9wZXogIDx4YW5AaWdhbGlhLmNvbT4KIAogICAgICAgICBb SlNDXSBSZW1vdmUgY29tcGlsZXIgd2FybmluZyBpbiBUcmFpbGluZ0FycmF5LmgKZGlmZiAtLWdp dCBhL1NvdXJjZS9XVEYvV1RGLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2ogYi9Tb3VyY2UvV1RG L1dURi54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qCmluZGV4IDkxZTc4MmEzNjZkYWUyMjA5NzYw YjdiOWI5YWQyMTI3M2RhOGU3ZWQuLjc4YjliOWNhMTJkYTVhODRmYzFlNDExNGE4MWRhYWFjMjll ODE4NDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvV1RGLnhjb2RlcHJvai9wcm9qZWN0LnBieHBy b2oKKysrIGIvU291cmNlL1dURi9XVEYueGNvZGVwcm9qL3Byb2plY3QucGJ4cHJvagpAQCAtMTY4 Miw2ICsxNjgyLDcgQEAKIAkJCWlzYSA9IFBCWE5hdGl2ZVRhcmdldDsKIAkJCWJ1aWxkQ29uZmln dXJhdGlvbkxpc3QgPSA1RDI0N0I2NjE0Njg5Qjg2MDBFNzhCNzYgLyogQnVpbGQgY29uZmlndXJh dGlvbiBsaXN0IGZvciBQQlhOYXRpdmVUYXJnZXQgIldURiIgKi87CiAJCQlidWlsZFBoYXNlcyA9 ICgKKwkJCQlEREU4NUU2MTI3QjE5QzVBMDAwMjVDQzkgLyogQ2hlY2sgc2VsZWN0ZWQgdG9vbGNo YWluIChpbnN0YWxsIGJ1aWxkcykgKi8sCiAJCQkJRERFOTkzMTYyNzhEMDhCOTAwRjYwRDI2IC8q IFByb2R1Y3QgRGVwZW5kZW5jaWVzICovLAogCQkJCTVEMjQ3QjVFMTQ2ODlCODYwMEU3OEI3NiAv KiBTb3VyY2VzICovLAogCQkJCTVEMjQ3QjVGMTQ2ODlCODYwMEU3OEI3NiAvKiBGcmFtZXdvcmtz ICovLApAQCAtMTc0MCw2ICsxNzQxLDI1IEBACiAJCQlzaGVsbFBhdGggPSAvYmluL3NoOwogCQkJ c2hlbGxTY3JpcHQgPSAiaWYgW1sgXCIke0RFUExPWU1FTlRfTE9DQVRJT059XCIgPT0gXCJOT1wi IF1dOyB0aGVuXG4gICAgUFJJVkFURV9IRUFERVJTX1BBVEg9XCIke1RBUkdFVF9CVUlMRF9ESVIl L30vJHtQUklWQVRFX0hFQURFUlNfRk9MREVSX1BBVEh9XCJcbiAgICBJQ1VfUFJJVkFURV9IRUFE RVJTX1BBVEg9XCIke1RBUkdFVF9CVUlMRF9ESVIlL30vJHtJQ1VfUFJJVkFURV9IRUFERVJTX0ZP TERFUl9QQVRIfVwiXG5lbHNlXG4gICAgUFJJVkFURV9IRUFERVJTX1BBVEg9XCIke0RTVFJPT1R9 LyR7UFJJVkFURV9IRUFERVJTX0ZPTERFUl9QQVRIfVwiXG4gICAgSUNVX1BSSVZBVEVfSEVBREVS U19QQVRIPVwiJHtEU1RST09UfS8ke0lDVV9QUklWQVRFX0hFQURFUlNfRk9MREVSX1BBVEh9XCJc bmZpO1xuXG5lY2hvIFwiJHtQUklWQVRFX0hFQURFUlNfUEFUSH1cIlxubWtkaXIgLXAgXCIke1BS SVZBVEVfSEVBREVSU19QQVRIfVwiXG5yc3luYyAtYXYgLS1uby1vd25lciAtLW5vLWdyb3VwIC0t cHJ1bmUtZW1wdHktZGlycyAtLWV4Y2x1ZGUgXCIuc3ZuXCIgLS1leGNsdWRlIFwidXNyXCIgLS1l eGNsdWRlIFwiRGVyaXZlZFNvdXJjZXNcIiAtLWluY2x1ZGUgXCIqL1wiIC0taW5jbHVkZSBcIiou aFwiIC0tZXhjbHVkZSBcIipcIiBcIiR7U1JDUk9PVH0vd3RmL1wiIFwiJHtQUklWQVRFX0hFQURF UlNfUEFUSH1cIlxuXG5yc3luYyAtYXYgLS1uby1vd25lciAtLW5vLWdyb3VwIC0tcHJ1bmUtZW1w dHktZGlycyAtLWV4Y2x1ZGUgXCIuc3ZuXCIgLS1leGNsdWRlIFwidXNyXCIgLS1leGNsdWRlIFwi RGVyaXZlZFNvdXJjZXNcIiAtLWluY2x1ZGUgXCIqL1wiIC0taW5jbHVkZSBcIioucmJcIiAtLWlu Y2x1ZGU9XCIqLyoueWFtbFwiIC0tZXhjbHVkZSBcIipcIiBcIiR7U1JDUk9PVH0vU2NyaXB0c1wi IFwiJHtQUklWQVRFX0hFQURFUlNfUEFUSH1cIlxuXG5pZiBbWyBcIiR7VVNFX0lOVEVSTkFMX1NE S31cIiAhPSBcIllFU1wiIF1dOyB0aGVuXG5ta2RpciAtcCBcIiR7SUNVX1BSSVZBVEVfSEVBREVS U19QQVRIfVwiXG5yc3luYyAtYXYgLS1uby1vd25lciAtLW5vLWdyb3VwIC0tcHJ1bmUtZW1wdHkt ZGlycyAtLWV4Y2x1ZGUgXCIuc3ZuXCIgLS1leGNsdWRlIFwidXNyXCIgLS1leGNsdWRlIFwiRGVy aXZlZFNvdXJjZXNcIiAtLWluY2x1ZGUgXCIqL1wiIC0taW5jbHVkZSBcIiouaFwiIC0tZXhjbHVk ZSBcIipcIiBcIiR7U1JDUk9PVH0vaWN1L1wiIFwiJHtJQ1VfUFJJVkFURV9IRUFERVJTX1BBVEh9 XCJcbmZpXG4iOwogCQl9OworCQlEREU4NUU2MTI3QjE5QzVBMDAwMjVDQzkgLyogQ2hlY2sgc2Vs ZWN0ZWQgdG9vbGNoYWluIChpbnN0YWxsIGJ1aWxkcykgKi8gPSB7CisJCQlpc2EgPSBQQlhTaGVs bFNjcmlwdEJ1aWxkUGhhc2U7CisJCQlhbHdheXNPdXRPZkRhdGUgPSAxOworCQkJYnVpbGRBY3Rp b25NYXNrID0gODsKKwkJCWZpbGVzID0gKAorCQkJKTsKKwkJCWlucHV0RmlsZUxpc3RQYXRocyA9 ICgKKwkJCSk7CisJCQlpbnB1dFBhdGhzID0gKAorCQkJKTsKKwkJCW5hbWUgPSAiQ2hlY2sgc2Vs ZWN0ZWQgdG9vbGNoYWluIChpbnN0YWxsIGJ1aWxkcykiOworCQkJb3V0cHV0RmlsZUxpc3RQYXRo cyA9ICgKKwkJCSk7CisJCQlvdXRwdXRQYXRocyA9ICgKKwkJCSk7CisJCQlydW5Pbmx5Rm9yRGVw bG95bWVudFBvc3Rwcm9jZXNzaW5nID0gMTsKKwkJCXNoZWxsUGF0aCA9IC9iaW4vc2g7CisJCQlz aGVsbFNjcmlwdCA9ICJpZiBbICQoYmFzZW5hbWUgXCIkVE9PTENIQUlOX0RJUlwiKSA9PSBcIlhj b2RlRGVmYXVsdC54Y3Rvb2xjaGFpblwiIF07IHRoZW5cbmVjaG8gXCJlcnJvcjogSW5zdGFsbGVk IHRvb2xjaGFpbiBkb2Vzbid0IG1hdGNoIHJlcXVlc3RlZCBvbmUsIGZhaWxpbmcgdGhlIGJ1aWxk IGVhcmx5IHRvIHByZXZlbnQgZmFsbGluZyBiYWNrIHRvIGRlZmF1bHQgdG9vbGNoYWluXCJcbmV4 aXQgMVxuZmlcbiI7CisJCX07CiAvKiBFbmQgUEJYU2hlbGxTY3JpcHRCdWlsZFBoYXNlIHNlY3Rp b24gKi8KIAogLyogQmVnaW4gUEJYU291cmNlc0J1aWxkUGhhc2Ugc2VjdGlvbiAqLwo=