236234 2022-02-07 06:55:27 -0800 [model] improve sizing on iOS 2022-02-07 11:44:01 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 236233 1 graouts graouts darin dino thorton webkit-bug-importer oldest_to_newest 1838118 0 graouts 2022-02-07 06:55:27 -0800 [model] improve sizing on iOS 1838119 1 webkit-bug-importer 2022-02-07 06:55:48 -0800 <rdar://problem/88569898> 1838126 2 451094 graouts 2022-02-07 07:20:47 -0800 Created attachment 451094 Patch 1838145 3 451094 dino 2022-02-07 07:48:29 -0800 Comment on attachment 451094 Patch Any way to test this? 1838157 4 graouts 2022-02-07 08:04:57 -0800 (In reply to Dean Jackson from comment #3) > Comment on attachment 451094 [details] > Patch > > Any way to test this? This sets the size in ways that are internal to ARQL, I don't think we can test this. 1838182 5 darin 2022-02-07 08:49:13 -0800 To state something we have learned over the years on the WebKit project: If we want to keep this working we have to figure out some way to regression test. Even if it involves thinking creatively and adding new test hooks of some kind. Otherwise it just breaks some day without anyone noticing. 1838189 6 graouts 2022-02-07 08:53:29 -0800 I'll engage with the right people internally to see how we could test this correctly. 1838216 7 graouts 2022-02-07 09:42:24 -0800 I think we might be able to cook something up with empty model resources and turning on debug colors on ASVInlinePreview instances which should allow us to have predictable renderings to test against. 1838265 8 ews-feeder 2022-02-07 11:43:57 -0800 Committed r289235 (246919@main): <https://commits.webkit.org/246919@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451094. 451094 2022-02-07 07:20:47 -0800 2022-02-07 11:43:59 -0800 Patch bug-236234-20220207162045.patch text/plain 3551 graouts U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5MjAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9Q QUwvQ2hhbmdlTG9nIGIvU291cmNlL1dlYkNvcmUvUEFML0NoYW5nZUxvZwppbmRleCBkNTQwMjQy NDc0MDRmNDQwZWZkMjU3MDFkOWFjODFmZjdlMTAxYTY4Li5jNzg1Nzc5OTM1YTBkZjkwNjVkYzRm OTgyNzUxNDZlY2QyN2U2YjIzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QQUwvQ2hhbmdl TG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAor MjAyMi0wMi0wNyAgQW50b2luZSBRdWludCAgPGdyYW91dHNAd2Via2l0Lm9yZz4KKworICAgICAg ICBbbW9kZWxdIGltcHJvdmUgc2l6aW5nIG9uIGlPUworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM2MjM0CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84 ODU2OTg5OD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBBZGQgbmV3bHktdXNlZCAtW0FTVklubGluZVByZXZpZXcgc2V0RnJhbWVXaXRoaW5GZW5jZWRU cmFuc2FjdGlvbjpdIFNQSSBvbiBpT1MuCisKKyAgICAgICAgKiBwYWwvc3BpL2lvcy9TeXN0ZW1Q cmV2aWV3U1BJLmg6CisKIDIwMjItMDItMDcgIEFudG9pbmUgUXVpbnQgIDxncmFvdXRzQHdlYmtp dC5vcmc+CiAKICAgICAgICAgW21vZGVsXSBpbXByb3ZlIHNpemluZyBvbiBtYWNPUwpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpp bmRleCA5YTEyN2IxZDU3OTg5NDAwMDQ0ZWYzOGY1Y2ZkYTUxNTdhMDRiNWY3Li43YWEyY2JlNTQ1 Yjg2M2UwMGE2OWQ0NGVkYmI0MGU5NzVkMzE4ZGFiIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBA CisyMDIyLTAyLTA3ICBBbnRvaW5lIFF1aW50ICA8Z3Jhb3V0c0B3ZWJraXQub3JnPgorCisgICAg ICAgIFttb2RlbF0gaW1wcm92ZSBzaXppbmcgb24gaU9TCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzYyMzQKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVt Lzg4NTY5ODk4PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIFdlIG11c3QgaW5zdGFsbCB0aGUgZmVuY2UgYW5kIGludmFsaWRhdGUgaXQgb24gdGhlIG1h aW4gcXVldWUgYW5kIGNhbGwKKyAgICAgICAgLVtBU1ZJbmxpbmVQcmV2aWV3IHNldEZyYW1lV2l0 aGluRmVuY2VkVHJhbnNhY3Rpb246XSB0byBjb21wbGV0ZSB0aGUKKyAgICAgICAgcmVzaXppbmcg cHJvY2VzcyBvbiBpT1MuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvaW9zL1dLTW9kZWxWaWV3Lm1t OgorICAgICAgICAoLVtXS01vZGVsVmlldyB1cGRhdGVCb3VuZHNdKToKKwogMjAyMi0wMi0wNyAg QW50b2luZSBRdWludCAgPGdyYW91dHNAd2Via2l0Lm9yZz4KIAogICAgICAgICBbbW9kZWxdIGlt cHJvdmUgc2l6aW5nIG9uIG1hY09TCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFs L3NwaS9pb3MvU3lzdGVtUHJldmlld1NQSS5oIGIvU291cmNlL1dlYkNvcmUvUEFML3BhbC9zcGkv aW9zL1N5c3RlbVByZXZpZXdTUEkuaAppbmRleCA3Mzk1ZTUwZGQwZjBkMzM4ZmYzZWYzMjI1YjEw YWY4MDJlZTEyZmYxLi4zMTI4OWE0YjBlYTgxNzBmMTUxNDVhNzBlOGYzNjU1NjE1ZWE3NjI1IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QQUwvcGFsL3NwaS9pb3MvU3lzdGVtUHJldmlld1NQ SS5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL1BBTC9wYWwvc3BpL2lvcy9TeXN0ZW1QcmV2aWV3U1BJ LmgKQEAgLTk3LDYgKzk3LDcgQEAgTlNfQVNTVU1FX05PTk5VTExfQkVHSU4KIC0gKHZvaWQpc2V0 dXBSZW1vdGVDb25uZWN0aW9uV2l0aENvbXBsZXRpb25IYW5kbGVyOih2b2lkICheKShOU0Vycm9y ICogX051bGxhYmxlIGVycm9yKSloYW5kbGVyOwogLSAodm9pZClwcmVwYXJlUHJldmlld09mRmls ZUF0VVJMOihOU1VSTCAqKXVybCBjb21wbGV0aW9uSGFuZGxlcjoodm9pZCAoXikoTlNFcnJvciAq IF9OdWxsYWJsZSBlcnJvcikpaGFuZGxlcjsKIC0gKHZvaWQpdXBkYXRlRnJhbWU6KENHUmVjdClu ZXdGcmFtZSBjb21wbGV0aW9uSGFuZGxlcjoodm9pZCAoXikoQ0FGZW5jZUhhbmRsZSAqIF9OdWxs YWJsZSBmZW5jZUhhbmRsZSwgTlNFcnJvciAqIF9OdWxsYWJsZSBlcnJvcikpaGFuZGxlcjsKKy0g KHZvaWQpc2V0RnJhbWVXaXRoaW5GZW5jZWRUcmFuc2FjdGlvbjooQ0dSZWN0KWZyYW1lOwogLSAo dm9pZCljcmVhdGVGdWxsc2NyZWVuSW5zdGFuY2VXaXRoSW5pdGlhbEZyYW1lOihDR1JlY3QpaW5p dGlhbEZyYW1lIHByZXZpZXdPcHRpb25zOihOU0RpY3Rpb25hcnkgKilwcmV2aWV3T3B0aW9ucyBj b21wbGV0aW9uSGFuZGxlcjoodm9pZCAoXikoVUlWaWV3Q29udHJvbGxlciAqcmVtb3RlVmlld0Nv bnRyb2xsZXIsIENBRmVuY2VIYW5kbGUgKiBfTnVsbGFibGUgZmVuY2VIYW5kbGUsIE5TRXJyb3Ig KiBfTnVsbGFibGUgZXJyb3IpKWhhbmRsZXI7CiAtICh2b2lkKW9ic2VydmVEaXNtaXNzRnVsbHNj cmVlbldpdGhDb21wbGV0aW9uSGFuZGxlcjoodm9pZCAoXikoQ0FGZW5jZUhhbmRsZSAqIF9OdWxs YWJsZSBmZW5jZUhhbmRsZSwgTlNEaWN0aW9uYXJ5ICogX05vbm51bGwgcGF5bG9hZCwgTlNFcnJv ciAqIF9OdWxsYWJsZSBlcnJvcikpaGFuZGxlcjsKIC0gKHZvaWQpdG91Y2hlc0JlZ2FuOihOU1Nl dDxVSVRvdWNoICo+ICopdG91Y2hlcyB3aXRoRXZlbnQ6KG51bGxhYmxlIFVJRXZlbnQgKilldmVu dDsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS01vZGVsVmlldy5t bSBiL1NvdXJjZS9XZWJLaXQvVUlQcm9jZXNzL2lvcy9XS01vZGVsVmlldy5tbQppbmRleCAwNWE4 MTMxYjNhZTM3ZWU1NWVhYzlkYzVkOTQ0N2QyNzAwNTcxOTY2Li4yYzdjODhkNTJhMTI4MDRiNTAx YTgyNmMzZjY3NTViOGU1OWNmNmE5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1VJUHJvY2Vz cy9pb3MvV0tNb2RlbFZpZXcubW0KKysrIGIvU291cmNlL1dlYktpdC9VSVByb2Nlc3MvaW9zL1dL TW9kZWxWaWV3Lm1tCkBAIC0xNTcsOCArMTU3LDExIEBAIC0gKHZvaWQpdXBkYXRlQm91bmRzCiAg ICAgICAgICAgICByZXR1cm47CiAgICAgICAgIH0KIAotICAgICAgICBbc2VsZi5sYXllci5jb250 ZXh0IGFkZEZlbmNlOmZlbmNlSGFuZGxlXTsKLSAgICAgICAgW2ZlbmNlSGFuZGxlIGludmFsaWRh dGVdOworICAgICAgICBkaXNwYXRjaF9hc3luYyhkaXNwYXRjaF9nZXRfbWFpbl9xdWV1ZSgpLCBe eworICAgICAgICAgICAgW3NlbGYubGF5ZXIuY29udGV4dCBhZGRGZW5jZTpmZW5jZUhhbmRsZV07 CisgICAgICAgICAgICBbX3ByZXZpZXcgc2V0RnJhbWVXaXRoaW5GZW5jZWRUcmFuc2FjdGlvbjpi b3VuZHNdOworICAgICAgICAgICAgW2ZlbmNlSGFuZGxlIGludmFsaWRhdGVdOworICAgICAgICB9 KTsKICAgICB9XTsKIH0KIAo=