236228 2022-02-07 04:30:41 -0800 Fix some compilation warnings coming from unhandled execution paths for unexpected enum values 2022-02-07 07:32:17 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mrobinson mrobinson darin eric.carlson esprehn+autocc ews-watchlist glenn gyuyoung.kim hta jer.noble macpherson menard philipj sergio tommyw webkit-bug-importer oldest_to_newest 1838065 0 mrobinson 2022-02-07 04:30:41 -0800 These missing checks lead to many compilation warnings during the build of the GTK port. 1838066 1 451079 mrobinson 2022-02-07 04:35:20 -0800 Created attachment 451079 Patch 1838132 2 ews-feeder 2022-02-07 07:31:38 -0800 Committed r289219 (246904@main): <https://commits.webkit.org/246904@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451079. 1838133 3 webkit-bug-importer 2022-02-07 07:32:17 -0800 <rdar://problem/88571064> 451079 2022-02-07 04:35:20 -0800 2022-02-07 07:31:41 -0800 Patch bug-236228-20220207133519.patch text/plain 6115 mrobinson U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5MjA1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMzUyMmRhMmQ4ZmYyNWJk NmZiY2Y0NjNkN2M0OGFjYTJmYzRiZjM3Ni4uMjg0ZTczODZkZmY2ZmYyZDM4YWRhOThlOGQ5ZTQ0 ZTMxMzc1MDVhMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI3IEBACisyMDIyLTAyLTA3ICBNYXJ0 aW4gUm9iaW5zb24gIDxtcm9iaW5zb25Ad2Via2l0Lm9yZz4KKworICAgICAgICBGaXggc29tZSBj b21waWxhdGlvbiB3YXJuaW5ncyBjb21pbmcgZnJvbSB1bmhhbmRsZWQgZXhlY3V0aW9uIHBhdGhz IGZvciB1bmV4cGVjdGVkIGVudW0gdmFsdWVzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMzYyMjgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBObyBuZXcgdGVzdHMuIFRoaXMgc2hvdWxkIG5vdCBjaGFuZ2Ug YmVoYXZpb3IuCisKKyAgICAgICAgKiBhbmltYXRpb24vQ29tcG9zaXRlT3BlcmF0aW9uT3JBdXRv Lmg6CisgICAgICAgIChXZWJDb3JlOjp0b0NvbXBvc2l0ZU9wZXJhdGlvbk9yQXV0byk6CisgICAg ICAgICogYmluZGluZ3MvanMvSlNDU1NTdHlsZVZhbHVlQ3VzdG9tLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6OnRvSlNOZXdseUNyZWF0ZWQpOgorICAgICAgICAqIGJpbmRpbmdzL2pzL0pTQ1NTVHJh bnNmb3JtQ29tcG9uZW50Q3VzdG9tLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnRvSlNOZXdseUNy ZWF0ZWQpOgorICAgICAgICAqIGNzcy9DU1NDb21wdXRlZFN0eWxlRGVjbGFyYXRpb24uY3BwOgor ICAgICAgICAoV2ViQ29yZTo6dmFsdWVGb3JBbmltYXRpb25Db21wb3NpdGlvbik6CisgICAgICAg ICogY3NzL0NTU1VuaXRzLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnVuaXRDYXRlZ29yeSk6Cisg ICAgICAgIChXZWJDb3JlOjpjYW5vbmljYWxVbml0VHlwZUZvckNhdGVnb3J5KToKKyAgICAgICAg KiBwbGF0Zm9ybS9tZWRpYXN0cmVhbS9saWJ3ZWJydGMvTGliV2ViUlRDUHJvdmlkZXIuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6TGliV2ViUlRDUHJvdmlkZXI6OnJlY2VpdmVyQ2FwYWJpbGl0aWVz KToKKyAgICAgICAgKFdlYkNvcmU6OkxpYldlYlJUQ1Byb3ZpZGVyOjpzZW5kZXJDYXBhYmlsaXRp ZXMpOgorCiAyMDIyLTAyLTA3ICBOaWtvbGFzIFppbW1lcm1hbm4gIDxuemltbWVybWFubkBpZ2Fs aWEuY29tPgogCiAgICAgICAgIFtMQlNFXSBTdXBwcmVzcyBub24tZm9yZWdyb3VuZCBwYWludCBw aGFzZXMgZm9yIFNWRyBzaGFwZXMgJiBpbWFnZXMKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2FuaW1hdGlvbi9Db21wb3NpdGVPcGVyYXRpb25PckF1dG8uaCBiL1NvdXJjZS9XZWJDb3JlL2Fu aW1hdGlvbi9Db21wb3NpdGVPcGVyYXRpb25PckF1dG8uaAppbmRleCBjOTM5M2ViMjdhNTBjOWE4 MGFiY2EwOTY2MzIzM2UyMzVmMDU2NDYzLi43MzIzOWJjNTkzMWZjZDJkOTgzOGFmOTI1MmRhMGQx NzFhYmFmMDIwIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hbmltYXRpb24vQ29tcG9zaXRl T3BlcmF0aW9uT3JBdXRvLmgKKysrIGIvU291cmNlL1dlYkNvcmUvYW5pbWF0aW9uL0NvbXBvc2l0 ZU9wZXJhdGlvbk9yQXV0by5oCkBAIC00MSw2ICs0MSw4IEBAIGNvbnN0ZXhwciBDb21wb3NpdGVP cGVyYXRpb25PckF1dG8gdG9Db21wb3NpdGVPcGVyYXRpb25PckF1dG8oQ29tcG9zaXRlT3BlcmF0 aW9uCiAgICAgY2FzZSBDb21wb3NpdGVPcGVyYXRpb246OkFjY3VtdWxhdGU6CiAgICAgICAgIHJl dHVybiBDb21wb3NpdGVPcGVyYXRpb25PckF1dG86OkFjY3VtdWxhdGU7CiAgICAgfQorICAgIEFT U0VSVF9OT1RfUkVBQ0hFRCgpOworICAgIHJldHVybiBDb21wb3NpdGVPcGVyYXRpb25PckF1dG86 OkF1dG87CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL2JpbmRpbmdzL2pzL0pTQ1NTU3R5bGVWYWx1ZUN1c3RvbS5jcHAgYi9Tb3VyY2UvV2Vi Q29yZS9iaW5kaW5ncy9qcy9KU0NTU1N0eWxlVmFsdWVDdXN0b20uY3BwCmluZGV4IDM4MzdlODkz YzNiN2UxNDk2OTY3ZjU0NmU5YjgzYjQ3YTkyYTg2MGYuLjBhYTY4ODQxZGVhNjJmNDEyNTM4NTIx N2UwNGMyYmQxOWRkZDFmZGQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pz L0pTQ1NTU3R5bGVWYWx1ZUN1c3RvbS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv anMvSlNDU1NTdHlsZVZhbHVlQ3VzdG9tLmNwcApAQCAtNTgsNiArNTgsOSBAQCBKU1ZhbHVlIHRv SlNOZXdseUNyZWF0ZWQoSlNHbG9iYWxPYmplY3QqLCBKU0RPTUdsb2JhbE9iamVjdCogZ2xvYmFs T2JqZWN0LCBSZWY8QwogICAgIGNhc2UgQ1NTU3R5bGVWYWx1ZVR5cGU6OkNTU1N0eWxlVmFsdWU6 CiAgICAgICAgIHJldHVybiBjcmVhdGVXcmFwcGVyPENTU1N0eWxlVmFsdWU+KGdsb2JhbE9iamVj dCwgV1RGTW92ZSh2YWx1ZSkpOwogICAgIH0KKworICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwor ICAgIHJldHVybiBjcmVhdGVXcmFwcGVyPENTU1N0eWxlVmFsdWU+KGdsb2JhbE9iamVjdCwgV1RG TW92ZSh2YWx1ZSkpOwogfQogCiBKU1ZhbHVlIHRvSlMoSlNHbG9iYWxPYmplY3QqIGxleGljYWxH bG9iYWxPYmplY3QsIEpTRE9NR2xvYmFsT2JqZWN0KiBnbG9iYWxPYmplY3QsIENTU1N0eWxlVmFs dWUmIG9iamVjdCkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL0pTQ1NT VHJhbnNmb3JtQ29tcG9uZW50Q3VzdG9tLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pz L0pTQ1NTVHJhbnNmb3JtQ29tcG9uZW50Q3VzdG9tLmNwcAppbmRleCBlMGIxYjkzMjMxN2NkOTc0 MGZlMjllZDViNWZkNGI2OTZhM2RkMTQxLi45OWQ2YTE1Y2IzYzA2MGQ0NzgyYWFlZmQ4MDdmZDJl NWI1N2M2NzRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9iaW5kaW5ncy9qcy9KU0NTU1Ry YW5zZm9ybUNvbXBvbmVudEN1c3RvbS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3Mv anMvSlNDU1NUcmFuc2Zvcm1Db21wb25lbnRDdXN0b20uY3BwCkBAIC02Myw2ICs2Myw4IEBAIEpT VmFsdWUgdG9KU05ld2x5Q3JlYXRlZChKU0dsb2JhbE9iamVjdCosIEpTRE9NR2xvYmFsT2JqZWN0 KiBnbG9iYWxPYmplY3QsIFJlZjxDCiAgICAgY2FzZSBDU1NUcmFuc2Zvcm1UeXBlOjpUcmFuc2xh dGU6CiAgICAgICAgIHJldHVybiBjcmVhdGVXcmFwcGVyPENTU1RyYW5zbGF0ZT4oZ2xvYmFsT2Jq ZWN0LCBXVEZNb3ZlKHZhbHVlKSk7CiAgICAgfQorICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgpOwor ICAgIHJldHVybiBjcmVhdGVXcmFwcGVyPENTU1RyYW5zZm9ybUNvbXBvbmVudD4oZ2xvYmFsT2Jq ZWN0LCBXVEZNb3ZlKHZhbHVlKSk7CiB9CiAKIEpTVmFsdWUgdG9KUyhKU0dsb2JhbE9iamVjdCog bGV4aWNhbEdsb2JhbE9iamVjdCwgSlNET01HbG9iYWxPYmplY3QqIGdsb2JhbE9iamVjdCwgQ1NT VHJhbnNmb3JtQ29tcG9uZW50JiBvYmplY3QpCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9j c3MvQ1NTQ29tcHV0ZWRTdHlsZURlY2xhcmF0aW9uLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9D U1NDb21wdXRlZFN0eWxlRGVjbGFyYXRpb24uY3BwCmluZGV4IDY5MmQ4NDY4MzMzNjk2YzQ1OGFi MTM1NzJhNTVkMmU1NDFhODQwMzkuLjUyODE3YmE4NWI2OWU1NGYyM2FhZDM2ZDEzMGU3OWNjNGFk OTE1YWYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NDb21wdXRlZFN0eWxlRGVj bGFyYXRpb24uY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NDb21wdXRlZFN0eWxlRGVj bGFyYXRpb24uY3BwCkBAIC0xMzg4LDYgKzEzODgsNyBAQCBzdGF0aWMgUmVmPENTU1ByaW1pdGl2 ZVZhbHVlPiB2YWx1ZUZvckFuaW1hdGlvbkNvbXBvc2l0aW9uKENvbXBvc2l0ZU9wZXJhdGlvbiBv cAogICAgIGNhc2UgQ29tcG9zaXRlT3BlcmF0aW9uOjpSZXBsYWNlOgogICAgICAgICByZXR1cm4g Q1NTVmFsdWVQb29sOjpzaW5nbGV0b24oKS5jcmVhdGVJZGVudGlmaWVyVmFsdWUoQ1NTVmFsdWVS ZXBsYWNlKTsKICAgICB9CisgICAgUkVMRUFTRV9BU1NFUlRfTk9UX1JFQUNIRUQoKTsKIH0KIAog c3RhdGljIFJlZjxDU1NQcmltaXRpdmVWYWx1ZT4gdmFsdWVGb3JBbmltYXRpb25QbGF5U3RhdGUo QW5pbWF0aW9uUGxheVN0YXRlIHBsYXlTdGF0ZSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L2Nzcy9DU1NVbml0cy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9jc3MvQ1NTVW5pdHMuY3BwCmluZGV4 IDdlNDJlZGE0ODE3ZWNjM2RhZDVkYmM0NTYwZjA0NGFiMDM0ZDRhOWQuLjJhOWYwNDhiZTU2MzE5 YjNlZjY4ZTZjNjQ2NzFhNmQwOTRhYWVhMWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2Nz cy9DU1NVbml0cy5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1VuaXRzLmNwcApAQCAt MTEzLDYgKzExMyw4IEBAIENTU1VuaXRDYXRlZ29yeSB1bml0Q2F0ZWdvcnkoQ1NTVW5pdFR5cGUg dHlwZSkKICAgICBjYXNlIENTU1VuaXRUeXBlOjpDdXN0b21JZGVudDoKICAgICAgICAgcmV0dXJu IENTU1VuaXRDYXRlZ29yeTo6T3RoZXI7CiAgICAgfQorICAgIEFTU0VSVF9OT1RfUkVBQ0hFRCgp OworICAgIHJldHVybiBDU1NVbml0Q2F0ZWdvcnk6Ok90aGVyOwogfQogCiBDU1NVbml0VHlwZSBj YW5vbmljYWxVbml0VHlwZUZvckNhdGVnb3J5KENTU1VuaXRDYXRlZ29yeSBjYXRlZ29yeSkKQEAg LTEzNSw2ICsxMzcsOCBAQCBDU1NVbml0VHlwZSBjYW5vbmljYWxVbml0VHlwZUZvckNhdGVnb3J5 KENTU1VuaXRDYXRlZ29yeSBjYXRlZ29yeSkKICAgICBjYXNlIENTU1VuaXRDYXRlZ29yeTo6T3Ro ZXI6CiAgICAgICAgIHJldHVybiBDU1NVbml0VHlwZTo6Q1NTX1VOS05PV047CiAgICAgfQorICAg IEFTU0VSVF9OT1RfUkVBQ0hFRCgpOworICAgIHJldHVybiBDU1NVbml0VHlwZTo6Q1NTX1VOS05P V047CiB9CiAKIENTU1VuaXRUeXBlIGNhbm9uaWNhbFVuaXRUeXBlKENTU1VuaXRUeXBlIHVuaXRU eXBlKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vbGli d2VicnRjL0xpYldlYlJUQ1Byb3ZpZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21l ZGlhc3RyZWFtL2xpYndlYnJ0Yy9MaWJXZWJSVENQcm92aWRlci5jcHAKaW5kZXggM2IxMDcwNzZm ZThkMjk4YWRhNzdkZWI0NjEwOTY2MjEwYTZiZjU4OC4uZjIyZTcyMTEyYTIyNzVkMDAyZWNmYWJk MzdmNTlkODVmZGFmMTU1NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVk aWFzdHJlYW0vbGlid2VicnRjL0xpYldlYlJUQ1Byb3ZpZGVyLmNwcAorKysgYi9Tb3VyY2UvV2Vi Q29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9saWJ3ZWJydGMvTGliV2ViUlRDUHJvdmlkZXIuY3Bw CkBAIC00OTIsNiArNDkyLDkgQEAgc3RkOjpvcHRpb25hbDxSVENSdHBDYXBhYmlsaXRpZXM+IExp YldlYlJUQ1Byb3ZpZGVyOjpyZWNlaXZlckNhcGFiaWxpdGllcyhjb25zdAogICAgICAgICBBU1NF UlRfTk9UX1JFQUNIRUQoKTsKICAgICAgICAgcmV0dXJuIHsgfTsKICAgICB9CisKKyAgICBBU1NF UlRfTk9UX1JFQUNIRUQoKTsKKyAgICByZXR1cm4geyB9OwogfQogCiBzdGQ6Om9wdGlvbmFsPFJU Q1J0cENhcGFiaWxpdGllcz4mIExpYldlYlJUQ1Byb3ZpZGVyOjphdWRpb0RlY29kaW5nQ2FwYWJp bGl0aWVzKCkKQEAgLTUzMCw2ICs1MzMsOCBAQCBzdGQ6Om9wdGlvbmFsPFJUQ1J0cENhcGFiaWxp dGllcz4gTGliV2ViUlRDUHJvdmlkZXI6OnNlbmRlckNhcGFiaWxpdGllcyhjb25zdCBTdAogICAg ICAgICBBU1NFUlRfTk9UX1JFQUNIRUQoKTsKICAgICAgICAgcmV0dXJuIHsgfTsKICAgICB9Cisg ICAgQVNTRVJUX05PVF9SRUFDSEVEKCk7CisgICAgcmV0dXJuIHsgfTsKIH0KIAogc3RkOjpvcHRp b25hbDxSVENSdHBDYXBhYmlsaXRpZXM+JiBMaWJXZWJSVENQcm92aWRlcjo6YXVkaW9FbmNvZGlu Z0NhcGFiaWxpdGllcygpCg==