236217 2022-02-06 22:46:17 -0800 REGRESSION(r195447): [GTK] document.activeElement not set on mouse click 2026-03-17 05:25:51 -0700 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=309478 P2 Normal --- 1 dpa-webkit webkit-unassigned bugs-noreply cdumez cgarcia changseok esprehn+autocc ews-watchlist gyuyoung.kim mcatanzaro oldest_to_newest 1838015 0 dpa-webkit 2022-02-06 22:46:17 -0800 In Firefox 96 and Chromium 96, when I call document.activeElement within a mouse-click handler, it points to the element, which got clicked. In Epiphany 41.3/WebGitGTK 2.34.4 and MiniBrowser/WebKitGTK 2.34.4 document.activeElement points to the <body> element in the mouse-click handler. In all browsers, when I use TAB to select an element and then press enter, document.activeElement points to that element. Sample: ``` <!DOCTYPE html> <html> <style> a:focus-visible, a:focus { outline: dashed 4px } </style> <body> <a href='#' onclick='console.log(document.activeElement)'>If this is clicked with the mouse, once the document is loaded, in Epiphany the console will emit <body></body>, instead of the <a> element. In all other browsers, or when the element is focused with the keyboard/TAB, console will print the <a> element.</a> <p>See also <a href='https://gitlab.gnome.org/GNOME/epiphany/-/issues/1695'> https://gitlab.gnome.org/GNOME/epiphany/-/issues/1695</a></p>. </body></hmtl> ``` See also https://gitlab.gnome.org/GNOME/epiphany/-/issues/1695 . 1838101 1 mcatanzaro 2022-02-07 06:25:18 -0800 This seems like the sort of thing that could potentially cause a *lot* of web compat issues. I wonder how Safari behaves. 1840318 2 cgarcia 2022-02-11 06:08:53 -0800 I think this only happens with links because we don't focus links on click. 1840670 3 cgarcia 2022-02-12 03:00:32 -0800 This behavior is desired for apple ports, but for GTK it regressed in r195447. I've checked chromium and firefox and they both set the focus on links when clicking, so I think we can restore the behavior for GTK (and WPE). 1840680 4 451783 cgarcia 2022-02-12 05:34:27 -0800 Created attachment 451783 Patch 1840681 5 dpa-webkit 2022-02-12 05:47:24 -0800 > This behavior is desired for apple ports, Does this mean, that on purpose document.activeElement in Safari with mouse-click works in a different way, compared to other browsers? May I ask what is the background for this deviation? I wanted to write code using document.activeElement. Eventually I achieved the same functionality without using document.activeElement. This distinction, made on purpose, shall be documented with the rationale behind it, e.g. at https://github.com/mdn/browser-compat-data/issues/14866 . 1840691 6 451783 mcatanzaro 2022-02-12 07:22:53 -0800 Comment on attachment 451783 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451783&action=review Need to look at: imported/blink/fast/events/click-focus-keydown-no-ring.html > LayoutTests/fast/events/click-focus-anchor.html:7 > <p>This test ensures that we can click to focus an a element. Please fix preexisting typo: "focus an element" 1840692 7 mcatanzaro 2022-02-12 07:24:13 -0800 (In reply to Дилян Палаузов from comment #5) > May I ask what is the background for this deviation? That's probably just how links behave on macOS? It's normal for UI elements to behave differently on macOS vs. Windows. WebKitGTK generally aims to match Safari with respect to web platform behavior, but in regards to UI concerns like "what happens on mouse click," we tend to more often match Windows or GTK behavior. 1840705 8 dpa-webkit 2022-02-12 09:28:47 -0800 >>This test ensures that we can click to focus an a element. > Please fix preexisting typo: "focus an element" I thought initially also, that this is a typo. But the a means anchor. So the above says: This test ensures that we can click to focus an anchor element. 1841158 9 cgarcia 2022-02-14 00:39:36 -0800 (In reply to Дилян Палаузов from comment #5) > > This behavior is desired for apple ports, > Does this mean, that on purpose document.activeElement in Safari with > mouse-click works in a different way, compared to other browsers? > > May I ask what is the background for this deviation? See bug #18425 > I wanted to write code using document.activeElement. Eventually I achieved > the same functionality without using document.activeElement. This > distinction, made on purpose, shall be documented with the rationale behind > it, e.g. at https://github.com/mdn/browser-compat-data/issues/14866 . 1841168 10 cgarcia 2022-02-14 02:00:43 -0800 (In reply to Michael Catanzaro from comment #6) > Comment on attachment 451783 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=451783&action=review > > Need to look at: imported/blink/fast/events/click-focus-keydown-no-ring.html I think this is chromium specific behavior, at least it's not consistent with firefox. I don't see why not drawing the focus ring when pressing a key while a link is focused. > > LayoutTests/fast/events/click-focus-anchor.html:7 > > <p>This test ensures that we can click to focus an a element. > > Please fix preexisting typo: "focus an element" Confusing but not a typo. 1841171 11 451875 cgarcia 2022-02-14 02:20:42 -0800 Created attachment 451875 Patch 1841239 12 451875 mcatanzaro 2022-02-14 06:50:31 -0800 Comment on attachment 451875 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451875&action=review > Source/WebCore/html/HTMLAnchorElement.cpp:105 > +#if !(PLATFORM(GTK) || PLATFORM(WPE)) I would guard this with #if PLATFORM(COCOA) instead, since I suspect other non-Apple ports want our behavior. 1841602 13 cgarcia 2022-02-15 00:32:53 -0800 (In reply to Michael Catanzaro from comment #12) > Comment on attachment 451875 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=451875&action=review > > > Source/WebCore/html/HTMLAnchorElement.cpp:105 > > +#if !(PLATFORM(GTK) || PLATFORM(WPE)) > > I would guard this with #if PLATFORM(COCOA) instead, since I suspect other > non-Apple ports want our behavior. I prefer not to change the behavior of other ports, this was always specific to GTK, EFL and Qt, but not win. 1841603 14 cgarcia 2022-02-15 00:34:35 -0800 Committed r289792 (247257@trunk): <https://commits.webkit.org/247257@trunk> 451783 2022-02-12 05:34:27 -0800 2022-02-14 02:20:42 -0800 Patch wcore-focus-link-on-click.diff text/plain 4564 cgarcia ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA1NmJjMDg3ZmI4OTguLjJjMjY5ZmYyMjg4OSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBA CisyMDIyLTAyLTEyICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4K KworICAgICAgICBSRUdSRVNTSU9OKHIxOTU0NDcpOiBbR1RLXSBkb2N1bWVudC5hY3RpdmVFbGVt ZW50IG5vdCBzZXQgb24gbW91c2UgY2xpY2sKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIzNjIxNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogZmFzdC9ldmVudHMvY2xpY2stZm9jdXMtYW5jaG9yLWV4cGVj dGVkLnR4dDoKKyAgICAgICAgKiBmYXN0L2V2ZW50cy9jbGljay1mb2N1cy1hbmNob3IuaHRtbDoK KyAgICAgICAgKiBwbGF0Zm9ybS9nbGliL2Zhc3QvZXZlbnRzL2NsaWNrLWZvY3VzLWFuY2hvci1l eHBlY3RlZC50eHQ6IENvcGllZCBmcm9tIExheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2NsaWNrLWZv Y3VzLWFuY2hvci1leHBlY3RlZC50eHQuCisKIDIwMjItMDItMTEgIEFsYW4gQnVqdGFzICA8emFs YW5AYXBwbGUuY29tPgogCiAgICAgICAgIGBjb250YWluOmNvbnRlbnRgIGJyZWFrcyBmdWxsc2Ny ZWVuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9jbGljay1mb2N1cy1hbmNo b3ItZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvY2xpY2stZm9jdXMtYW5j aG9yLWV4cGVjdGVkLnR4dAppbmRleCA1MzliZGVhMGUzODEuLmQ2NzVlY2I4MjZlNCAxMDA2NDQK LS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvY2xpY2stZm9jdXMtYW5jaG9yLWV4cGVjdGVk LnR4dAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9jbGljay1mb2N1cy1hbmNob3ItZXhw ZWN0ZWQudHh0CkBAIC0xLDYgKzEsNiBAQAogVGhpcyB0ZXN0IGVuc3VyZXMgdGhhdCB3ZSBjYW4g Y2xpY2sgdG8gZm9jdXMgYW4gYSBlbGVtZW50LiBDbGljayBvbiB0aGUgZWxlbWVudCBiZWxvdy4K IAotVGhlIGV4cGVjdGVkIHJlc3VsdCBpcyBwbGF0Zm9ybSBzcGVjaWZpYy4gR1RLLCBRVCBhbmQg RUZMIGFsbG93cyBhbGwgbGlua3MgdG8gYmUgbW91c2UgZm9jdXNhYmxlLgorVGhlIGV4cGVjdGVk IHJlc3VsdCBpcyBwbGF0Zm9ybSBzcGVjaWZpYy4gR1RLIGFuZCBXUEUgYWxsb3cgYWxsIGxpbmtz IHRvIGJlIG1vdXNlIGZvY3VzYWJsZS4KIAogUmVzdWx0CiAKZGlmZiAtLWdpdCBhL0xheW91dFRl c3RzL2Zhc3QvZXZlbnRzL2NsaWNrLWZvY3VzLWFuY2hvci5odG1sIGIvTGF5b3V0VGVzdHMvZmFz dC9ldmVudHMvY2xpY2stZm9jdXMtYW5jaG9yLmh0bWwKaW5kZXggNDA2NDVjMTZhNjhjLi42ZGU5 ODY0MzhiZjIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2NsaWNrLWZvY3Vz LWFuY2hvci5odG1sCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2NsaWNrLWZvY3VzLWFu Y2hvci5odG1sCkBAIC03LDEzICs3LDEzIEBACiA8cD5UaGlzIHRlc3QgZW5zdXJlcyB0aGF0IHdl IGNhbiBjbGljayB0byBmb2N1cyBhbiBhIGVsZW1lbnQuCiBDbGljayBvbiB0aGUgZWxlbWVudCBi ZWxvdy4KIAotPHA+VGhlIGV4cGVjdGVkIHJlc3VsdCBpcyBwbGF0Zm9ybSBzcGVjaWZpYy4gR1RL LCBRVCBhbmQgRUZMIGFsbG93cyBhbGwgbGlua3MgdG8gYmUKKzxwPlRoZSBleHBlY3RlZCByZXN1 bHQgaXMgcGxhdGZvcm0gc3BlY2lmaWMuIEdUSyBhbmQgV1BFIGFsbG93IGFsbCBsaW5rcyB0byBi ZQogbW91c2UgZm9jdXNhYmxlLgogCiA8ZGl2IGlkPXRlc3QtY29udGFpbmVyPgogPHA+PGEgaWQ9 YTEgdGFiaW5kZXg9MCB0aXRsZT0iZm9jdXNhYmxlIj5BbmNob3Igd2l0aCB0YWIgaW5kZXg8L2E+ CiA8cD48YSBpZD1hMiB0aXRsZT0ibm90IGZvY3VzYWJsZSI+QW5jaG9yIHdpdGhvdXQgdGFiIGlu ZGV4PC9hPgotPHA+PGEgaWQ9YTMgaHJlZj0iIyIgdGl0bGU9ImZvY3VzYWJsZSBvbiBHVEssIFFU IGFuZCBFRkwiPkxpbmsgd2l0aG91dCB0YWIgaW5kZXg8L2E+Cis8cD48YSBpZD1hMyBocmVmPSIj IiB0aXRsZT0iZm9jdXNhYmxlIG9uIEdUSyBhbmQgV1BFIj5MaW5rIHdpdGhvdXQgdGFiIGluZGV4 PC9hPgogPHA+PGEgaWQ9YTQgaHJlZj0iIyIgdGFiaW5kZXg9MCB0aXRsZT0iZm9jdXNhYmxlIj5M aW5rIHdpdGggdGFiIGluZGV4PC9hPgogPHA+PGEgaWQ9YTUgaHJlZj0iIyIgY29udGVudEVkaXRh YmxlIHRpdGxlPSJmb2N1c2FibGUiPkxpbmsgd2l0aCBjb250ZW50RWRpdGFibGU8L2E+CiA8cCBj b250ZW50RWRpdGFibGU+PGEgaWQ9YTYgaHJlZj0iIyIgZm9jdXNhYmxlPSJub3QgZm9jdXNhYmxl Ij5MaW5rIGluc2lkZSBjb250ZW50RWRpdGFibGU8L2E+CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9nbGliL2Zhc3QvZXZlbnRzL2NsaWNrLWZvY3VzLWFuY2hvci1leHBlY3RlZC50 eHQgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9nbGliL2Zhc3QvZXZlbnRzL2NsaWNrLWZvY3VzLWFu Y2hvci1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAw Li42Yjc3NTdlNzA3ZTAKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9n bGliL2Zhc3QvZXZlbnRzL2NsaWNrLWZvY3VzLWFuY2hvci1leHBlY3RlZC50eHQKQEAgLTAsMCAr MSwxMSBAQAorVGhpcyB0ZXN0IGVuc3VyZXMgdGhhdCB3ZSBjYW4gY2xpY2sgdG8gZm9jdXMgYW4g YSBlbGVtZW50LiBDbGljayBvbiB0aGUgZWxlbWVudCBiZWxvdy4KKworVGhlIGV4cGVjdGVkIHJl c3VsdCBpcyBwbGF0Zm9ybSBzcGVjaWZpYy4gR1RLIGFuZCBXUEUgYWxsb3cgYWxsIGxpbmtzIHRv IGJlIG1vdXNlIGZvY3VzYWJsZS4KKworUmVzdWx0CisKKworYTEgcmVjZWl2ZWQgZm9jdXMgKGZv Y3VzYWJsZSkKK2EzIHJlY2VpdmVkIGZvY3VzIChmb2N1c2FibGUgb24gR1RLIGFuZCBXUEUpCith NCByZWNlaXZlZCBmb2N1cyAoZm9jdXNhYmxlKQorYTUgcmVjZWl2ZWQgZm9jdXMgKGZvY3VzYWJs ZSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3Jl L0NoYW5nZUxvZwppbmRleCA1Mzg1OTdhODJiZmIuLjA4N2JkNWQzOWYxYSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE2IEBACisyMDIyLTAyLTEyICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJj aWFAaWdhbGlhLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OKHIxOTU0NDcpOiBbR1RLXSBkb2N1 bWVudC5hY3RpdmVFbGVtZW50IG5vdCBzZXQgb24gbW91c2UgY2xpY2sKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNjIxNworCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJyaW5nIGJhY2sgdGhlIGJlaGF2aW9y IGJlZm9yZSByMTk1NDQ3IGFuZCBmb2N1cyB0aGUgbGlua3Mgb24gY2xpY2sgd2hpY2ggaXMgY29u c2lzdGVudCB3aXRoIG90aGVyIGJyb3dzZXIgaW4KKyAgICAgICAgTGludXggYW5kIGVuc3VyZXMg YWN0aXZlIGVsZW1lbnQgaXMgdGhlIGV4cGVjdGVkIG9uZSBvbiBhIGNsaWNrIGV2ZW50IGxpc3Rl bmVyLgorCisgICAgICAgICogaHRtbC9IVE1MQW5jaG9yRWxlbWVudC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpIVE1MQW5jaG9yRWxlbWVudDo6aXNNb3VzZUZvY3VzYWJsZSBjb25zdCk6CisKIDIw MjItMDItMTEgIEFsYW4gQnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIGBjb250 YWluOmNvbnRlbnRgIGJyZWFrcyBmdWxsc2NyZWVuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29y ZS9odG1sL0hUTUxBbmNob3JFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEFu Y2hvckVsZW1lbnQuY3BwCmluZGV4IGQ5MjQzOTEwNGQwYi4uYzMwZGM2ZjdhOGJhIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxBbmNob3JFbGVtZW50LmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9odG1sL0hUTUxBbmNob3JFbGVtZW50LmNwcApAQCAtMTAyLDkgKzEwMiwxMSBA QCBib29sIEhUTUxBbmNob3JFbGVtZW50OjpzdXBwb3J0c0ZvY3VzKCkgY29uc3QKIAogYm9vbCBI VE1MQW5jaG9yRWxlbWVudDo6aXNNb3VzZUZvY3VzYWJsZSgpIGNvbnN0CiB7CisjaWYgIShQTEFU Rk9STShHVEspIHx8IFBMQVRGT1JNKFdQRSkpCiAgICAgLy8gT25seSBhbGxvdyBsaW5rcyB3aXRo IHRhYkluZGV4IG9yIGNvbnRlbnRFZGl0YWJsZSB0byBiZSBtb3VzZSBmb2N1c2FibGUuCiAgICAg aWYgKGlzTGluaygpKQogICAgICAgICByZXR1cm4gSFRNTEVsZW1lbnQ6OnN1cHBvcnRzRm9jdXMo KTsKKyNlbmRpZgogCiAgICAgcmV0dXJuIEhUTUxFbGVtZW50Ojppc01vdXNlRm9jdXNhYmxlKCk7 CiB9Cg== 451875 2022-02-14 02:20:42 -0800 2022-02-14 06:50:31 -0800 Patch wk-link-active-element.diff text/plain 5575 cgarcia ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA1NmJjMDg3ZmI4OTguLjVlZTNiYTliY2IzOSAxMDA2NDQKLS0tIGEvTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBA CisyMDIyLTAyLTE0ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4K KworICAgICAgICBSRUdSRVNTSU9OKHIxOTU0NDcpOiBbR1RLXSBkb2N1bWVudC5hY3RpdmVFbGVt ZW50IG5vdCBzZXQgb24gbW91c2UgY2xpY2sKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIzNjIxNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgICogZmFzdC9ldmVudHMvY2xpY2stZm9jdXMtYW5jaG9yLWV4cGVj dGVkLnR4dDoKKyAgICAgICAgKiBmYXN0L2V2ZW50cy9jbGljay1mb2N1cy1hbmNob3IuaHRtbDoK KyAgICAgICAgKiBwbGF0Zm9ybS9nbGliL1Rlc3RFeHBlY3RhdGlvbnM6IE1hcmsgaW1wb3J0ZWQv YmxpbmsvZmFzdC9ldmVudHMvY2xpY2stZm9jdXMta2V5ZG93bi1uby1yaW5nLmh0bWwgYXMgZmFp bHVyZS4KKyAgICAgICAgKiBwbGF0Zm9ybS9nbGliL2Zhc3QvZXZlbnRzL2NsaWNrLWZvY3VzLWFu Y2hvci1leHBlY3RlZC50eHQ6IENvcGllZCBmcm9tIExheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2Ns aWNrLWZvY3VzLWFuY2hvci1leHBlY3RlZC50eHQuCisKIDIwMjItMDItMTEgIEFsYW4gQnVqdGFz ICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIGBjb250YWluOmNvbnRlbnRgIGJyZWFrcyBm dWxsc2NyZWVuCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9jbGljay1mb2N1 cy1hbmNob3ItZXhwZWN0ZWQudHh0IGIvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvY2xpY2stZm9j dXMtYW5jaG9yLWV4cGVjdGVkLnR4dAppbmRleCA1MzliZGVhMGUzODEuLmQ2NzVlY2I4MjZlNCAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvY2xpY2stZm9jdXMtYW5jaG9yLWV4 cGVjdGVkLnR4dAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy9jbGljay1mb2N1cy1hbmNo b3ItZXhwZWN0ZWQudHh0CkBAIC0xLDYgKzEsNiBAQAogVGhpcyB0ZXN0IGVuc3VyZXMgdGhhdCB3 ZSBjYW4gY2xpY2sgdG8gZm9jdXMgYW4gYSBlbGVtZW50LiBDbGljayBvbiB0aGUgZWxlbWVudCBi ZWxvdy4KIAotVGhlIGV4cGVjdGVkIHJlc3VsdCBpcyBwbGF0Zm9ybSBzcGVjaWZpYy4gR1RLLCBR VCBhbmQgRUZMIGFsbG93cyBhbGwgbGlua3MgdG8gYmUgbW91c2UgZm9jdXNhYmxlLgorVGhlIGV4 cGVjdGVkIHJlc3VsdCBpcyBwbGF0Zm9ybSBzcGVjaWZpYy4gR1RLIGFuZCBXUEUgYWxsb3cgYWxs IGxpbmtzIHRvIGJlIG1vdXNlIGZvY3VzYWJsZS4KIAogUmVzdWx0CiAKZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2Zhc3QvZXZlbnRzL2NsaWNrLWZvY3VzLWFuY2hvci5odG1sIGIvTGF5b3V0VGVz dHMvZmFzdC9ldmVudHMvY2xpY2stZm9jdXMtYW5jaG9yLmh0bWwKaW5kZXggNDA2NDVjMTZhNjhj Li42ZGU5ODY0MzhiZjIgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2NsaWNr LWZvY3VzLWFuY2hvci5odG1sCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvZXZlbnRzL2NsaWNrLWZv Y3VzLWFuY2hvci5odG1sCkBAIC03LDEzICs3LDEzIEBACiA8cD5UaGlzIHRlc3QgZW5zdXJlcyB0 aGF0IHdlIGNhbiBjbGljayB0byBmb2N1cyBhbiBhIGVsZW1lbnQuCiBDbGljayBvbiB0aGUgZWxl bWVudCBiZWxvdy4KIAotPHA+VGhlIGV4cGVjdGVkIHJlc3VsdCBpcyBwbGF0Zm9ybSBzcGVjaWZp Yy4gR1RLLCBRVCBhbmQgRUZMIGFsbG93cyBhbGwgbGlua3MgdG8gYmUKKzxwPlRoZSBleHBlY3Rl ZCByZXN1bHQgaXMgcGxhdGZvcm0gc3BlY2lmaWMuIEdUSyBhbmQgV1BFIGFsbG93IGFsbCBsaW5r cyB0byBiZQogbW91c2UgZm9jdXNhYmxlLgogCiA8ZGl2IGlkPXRlc3QtY29udGFpbmVyPgogPHA+ PGEgaWQ9YTEgdGFiaW5kZXg9MCB0aXRsZT0iZm9jdXNhYmxlIj5BbmNob3Igd2l0aCB0YWIgaW5k ZXg8L2E+CiA8cD48YSBpZD1hMiB0aXRsZT0ibm90IGZvY3VzYWJsZSI+QW5jaG9yIHdpdGhvdXQg dGFiIGluZGV4PC9hPgotPHA+PGEgaWQ9YTMgaHJlZj0iIyIgdGl0bGU9ImZvY3VzYWJsZSBvbiBH VEssIFFUIGFuZCBFRkwiPkxpbmsgd2l0aG91dCB0YWIgaW5kZXg8L2E+Cis8cD48YSBpZD1hMyBo cmVmPSIjIiB0aXRsZT0iZm9jdXNhYmxlIG9uIEdUSyBhbmQgV1BFIj5MaW5rIHdpdGhvdXQgdGFi IGluZGV4PC9hPgogPHA+PGEgaWQ9YTQgaHJlZj0iIyIgdGFiaW5kZXg9MCB0aXRsZT0iZm9jdXNh YmxlIj5MaW5rIHdpdGggdGFiIGluZGV4PC9hPgogPHA+PGEgaWQ9YTUgaHJlZj0iIyIgY29udGVu dEVkaXRhYmxlIHRpdGxlPSJmb2N1c2FibGUiPkxpbmsgd2l0aCBjb250ZW50RWRpdGFibGU8L2E+ CiA8cCBjb250ZW50RWRpdGFibGU+PGEgaWQ9YTYgaHJlZj0iIyIgZm9jdXNhYmxlPSJub3QgZm9j dXNhYmxlIj5MaW5rIGluc2lkZSBjb250ZW50RWRpdGFibGU8L2E+CmRpZmYgLS1naXQgYS9MYXlv dXRUZXN0cy9wbGF0Zm9ybS9nbGliL1Rlc3RFeHBlY3RhdGlvbnMgYi9MYXlvdXRUZXN0cy9wbGF0 Zm9ybS9nbGliL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggNzQ2NTQzY2JiOTMyLi5hOTQwYjRiZjZi NTUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2dsaWIvVGVzdEV4cGVjdGF0aW9u cworKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9nbGliL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTcy Myw2ICs3MjMsOSBAQCB3ZWJraXQub3JnL2IvMjE4OTMxIGZhc3QvZXZlbnRzL3doZWVsL3doZWVs LWV2ZW50LWxpc3RlbmVycy1vbi13aW5kb3ctbWFkZS1wYXNzaQogd2Via2l0Lm9yZy9iLzIxODkz MSBmYXN0L2V2ZW50cy93aGVlbC93aGVlbC1ldmVudC1pbi1wYXNzaXZlLXJlZ2lvbi1ub24tY2Fu Y2VsYWJsZS5odG1sIFsgVGltZW91dCBdCiB3ZWJraXQub3JnL2IvMjE4OTMxIGZhc3QvZXZlbnRz L3doZWVsL3doZWVsLWV2ZW50cy1iZWNvbWUtbm9uLWNhbmNlbGFibGUuaHRtbCBbIFRpbWVvdXQg XQogCisjIFdlIGRyYXcgdGhlIGZvY3VzIHJpbmcgb2YgZm9jdXNlZCBsaW5rcyBvbiBrZXlkb3du IGV2ZW50LgoraW1wb3J0ZWQvYmxpbmsvZmFzdC9ldmVudHMvY2xpY2stZm9jdXMta2V5ZG93bi1u by1yaW5nLmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIF0KKwogIy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8KICMgRW5kIG9mIEV2ZW50cy1yZWxhdGVkIGJ1Z3MKICMvLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8vLy8v Ly8vLy8vLy8vLy8vLy8vLy8vCmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9nbGli L2Zhc3QvZXZlbnRzL2NsaWNrLWZvY3VzLWFuY2hvci1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0 cy9wbGF0Zm9ybS9nbGliL2Zhc3QvZXZlbnRzL2NsaWNrLWZvY3VzLWFuY2hvci1leHBlY3RlZC50 eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwLi42Yjc3NTdlNzA3ZTAK LS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9wbGF0Zm9ybS9nbGliL2Zhc3QvZXZlbnRz L2NsaWNrLWZvY3VzLWFuY2hvci1leHBlY3RlZC50eHQKQEAgLTAsMCArMSwxMSBAQAorVGhpcyB0 ZXN0IGVuc3VyZXMgdGhhdCB3ZSBjYW4gY2xpY2sgdG8gZm9jdXMgYW4gYSBlbGVtZW50LiBDbGlj ayBvbiB0aGUgZWxlbWVudCBiZWxvdy4KKworVGhlIGV4cGVjdGVkIHJlc3VsdCBpcyBwbGF0Zm9y bSBzcGVjaWZpYy4gR1RLIGFuZCBXUEUgYWxsb3cgYWxsIGxpbmtzIHRvIGJlIG1vdXNlIGZvY3Vz YWJsZS4KKworUmVzdWx0CisKKworYTEgcmVjZWl2ZWQgZm9jdXMgKGZvY3VzYWJsZSkKK2EzIHJl Y2VpdmVkIGZvY3VzIChmb2N1c2FibGUgb24gR1RLIGFuZCBXUEUpCithNCByZWNlaXZlZCBmb2N1 cyAoZm9jdXNhYmxlKQorYTUgcmVjZWl2ZWQgZm9jdXMgKGZvY3VzYWJsZSkKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRl eCA1Mzg1OTdhODJiZmIuLjkwYjMxMzY5ZjIyZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv Q2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBA CisyMDIyLTAyLTE0ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4K KworICAgICAgICBSRUdSRVNTSU9OKHIxOTU0NDcpOiBbR1RLXSBkb2N1bWVudC5hY3RpdmVFbGVt ZW50IG5vdCBzZXQgb24gbW91c2UgY2xpY2sKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTIzNjIxNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEJyaW5nIGJhY2sgdGhlIGJlaGF2aW9yIGJlZm9yZSByMTk1NDQ3 IGFuZCBmb2N1cyB0aGUgbGlua3Mgb24gY2xpY2sgd2hpY2ggaXMgY29uc2lzdGVudCB3aXRoIG90 aGVyIGJyb3dzZXIgaW4KKyAgICAgICAgTGludXggYW5kIGVuc3VyZXMgYWN0aXZlIGVsZW1lbnQg aXMgdGhlIGV4cGVjdGVkIG9uZSBvbiBhIGNsaWNrIGV2ZW50IGxpc3RlbmVyLgorCisgICAgICAg ICogaHRtbC9IVE1MQW5jaG9yRWxlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpIVE1MQW5j aG9yRWxlbWVudDo6aXNNb3VzZUZvY3VzYWJsZSBjb25zdCk6CisKIDIwMjItMDItMTEgIEFsYW4g QnVqdGFzICA8emFsYW5AYXBwbGUuY29tPgogCiAgICAgICAgIGBjb250YWluOmNvbnRlbnRgIGJy ZWFrcyBmdWxsc2NyZWVuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9odG1sL0hUTUxBbmNo b3JFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2h0bWwvSFRNTEFuY2hvckVsZW1lbnQuY3Bw CmluZGV4IGQ5MjQzOTEwNGQwYi4uYzMwZGM2ZjdhOGJhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi Q29yZS9odG1sL0hUTUxBbmNob3JFbGVtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9odG1s L0hUTUxBbmNob3JFbGVtZW50LmNwcApAQCAtMTAyLDkgKzEwMiwxMSBAQCBib29sIEhUTUxBbmNo b3JFbGVtZW50OjpzdXBwb3J0c0ZvY3VzKCkgY29uc3QKIAogYm9vbCBIVE1MQW5jaG9yRWxlbWVu dDo6aXNNb3VzZUZvY3VzYWJsZSgpIGNvbnN0CiB7CisjaWYgIShQTEFURk9STShHVEspIHx8IFBM QVRGT1JNKFdQRSkpCiAgICAgLy8gT25seSBhbGxvdyBsaW5rcyB3aXRoIHRhYkluZGV4IG9yIGNv bnRlbnRFZGl0YWJsZSB0byBiZSBtb3VzZSBmb2N1c2FibGUuCiAgICAgaWYgKGlzTGluaygpKQog ICAgICAgICByZXR1cm4gSFRNTEVsZW1lbnQ6OnN1cHBvcnRzRm9jdXMoKTsKKyNlbmRpZgogCiAg ICAgcmV0dXJuIEhUTUxFbGVtZW50Ojppc01vdXNlRm9jdXNhYmxlKCk7CiB9Cg==