23621 2009-01-29 09:10:06 -0800 [GTK] Fix scrollbars mis-positioning. 2009-02-06 17:06:55 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 xan.lopez webkit-unassigned oldest_to_newest 107529 0 xan.lopez 2009-01-29 09:10:06 -0800 Patch attached. 107530 1 27149 xan.lopez 2009-01-29 09:11:57 -0800 Created attachment 27149 Fix scrollbars mispositioning. 108265 2 27313 xan.lopez 2009-02-04 07:47:40 -0800 Created attachment 27313 Second try 108297 3 zecke 2009-02-04 10:36:35 -0800 Alternatively you can remove the entire if () {} and always set the value. Currently we would call gtk_adjustment_changed twice... 108300 4 xan.lopez 2009-02-04 10:55:14 -0800 (In reply to comment #3) > Alternatively you can remove the entire if () {} and always set the value. > Currently we would call gtk_adjustment_changed twice... > It's not the same function. One is gtk_adjustment_changed, and the other gtk_adjustment_VALUE_changed. The first is used when the adj parameters change, the second when the actual value changes. 108782 5 zecke 2009-02-06 17:06:55 -0800 M WebCore/ChangeLog M WebCore/platform/gtk/ScrollViewGtk.cpp r40742 = 1d0eb8fee689dbb9d11e2d5d68b75546957549f1 (git-svn) 27149 2009-01-29 09:11:57 -0800 2009-02-04 07:49:06 -0800 Fix scrollbars mispositioning. 0001-2009-01-29-Xan-Lopez-xan-gnome.org.patch text/plain 2355 xan.lopez RnJvbSAzZGE2OGYxZjg3MzcxNjUzZWIyZjFjZWI3OTVjMGMzYTEyNjUxODQxIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhhbkBnbm9tZS5vcmc+CkRhdGU6IFRodSwg MjkgSmFuIDIwMDkgMTk6MDk6MTUgKzAyMDAKU3ViamVjdDogW1BBVENIXSAyMDA5LTAxLTI5ICBY YW4gTG9wZXogIDx4YW5AZ25vbWUub3JnPgoKICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KCiAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIz NjIxCgogICAgICAgIERvIG5vdCBtYW51YWxseSB1cGRhdGUgdGhlIHNjcm9sbGJhcnMnIHBvc2l0 aW9uLCB0aGlzIHNlZW1zIHRvIGJlCiAgICAgICAgZG9uZSBpbiB0aGUgcGxhdGZyb20tbmV1dHJh bCBtZXRob2QgdGhhdCB3ZSBjYWxsLgoKICAgICAgICBGaXhlcyBtaXMtcG9zaXRpb25pbmcgb2Yg c2Nyb2xsYmFycyB3aGVuIG9wZW5pbmcgbmV3IHBhZ2VzLgoKICAgICAgICAqIFdlYkNvcmVTdXBw b3J0L0ZyYW1lTG9hZGVyQ2xpZW50R3RrLmNwcDoKICAgICAgICAoV2ViS2l0OjpGcmFtZUxvYWRl ckNsaWVudDo6dHJhbnNpdGlvblRvQ29tbWl0dGVkRm9yTmV3UGFnZSk6Ci0tLQogV2ViS2l0L2d0 ay9DaGFuZ2VMb2cgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgfCAgIDE0ICsrKysrKysr KysrKysrCiBXZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50R3RrLmNw cCB8ICAgIDcgLS0tLS0tLQogMiBmaWxlcyBjaGFuZ2VkLCAxNCBpbnNlcnRpb25zKCspLCA3IGRl bGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0 ay9DaGFuZ2VMb2cKaW5kZXggYzIwNWNkZC4uYzIzMTU5MyAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0 ay9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAor MjAwOS0wMS0yOSAgWGFuIExvcGV6ICA8eGFuQGdub21lLm9yZz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjM2MjEKKworICAgICAgICBEbyBub3QgbWFudWFsbHkgdXBkYXRlIHRo ZSBzY3JvbGxiYXJzJyBwb3NpdGlvbiwgdGhpcyBzZWVtcyB0byBiZQorICAgICAgICBkb25lIGlu IHRoZSBwbGF0ZnJvbS1uZXV0cmFsIG1ldGhvZCB0aGF0IHdlIGNhbGwuCisKKyAgICAgICAgRml4 ZXMgbWlzLXBvc2l0aW9uaW5nIG9mIHNjcm9sbGJhcnMgd2hlbiBvcGVuaW5nIG5ldyBwYWdlcy4K KworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50R3RrLmNwcDoKKyAg ICAgICAgKFdlYktpdDo6RnJhbWVMb2FkZXJDbGllbnQ6OnRyYW5zaXRpb25Ub0NvbW1pdHRlZEZv ck5ld1BhZ2UpOgorCiAyMDA5LTAxLTI3ICBCcmFkeSBFaWRzb24gIDxiZWlkc29uQGFwcGxlLmNv bT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYW4gQmVybnN0ZWluCmRpZmYgLS1naXQgYS9XZWJL aXQvZ3RrL1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50R3RrLmNwcCBiL1dlYktpdC9n dGsvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRHdGsuY3BwCmluZGV4IDMzZDBmYmIu LjFkNjk1YzMgMTAwNjQ0Ci0tLSBhL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2Fk ZXJDbGllbnRHdGsuY3BwCisrKyBiL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2Fk ZXJDbGllbnRHdGsuY3BwCkBAIC04NjEsMTMgKzg2MSw2IEBAIHZvaWQgRnJhbWVMb2FkZXJDbGll bnQ6OnRyYW5zaXRpb25Ub0NvbW1pdHRlZEZvck5ld1BhZ2UoKQogICAgIEFTU0VSVChmcmFtZSk7 CiAKICAgICBXZWJDb3JlOjpGcmFtZUxvYWRlckNsaWVudDo6dHJhbnNpdGlvblRvQ29tbWl0dGVk Rm9yTmV3UGFnZShmcmFtZSwgc2l6ZSwgYmFja2dyb3VuZENvbG9yLCB0cmFuc3BhcmVudCwgSW50 U2l6ZSgpLCBmYWxzZSk7Ci0KLSAgICAvLyBXZSBuZWVkIHRvIGRvIGZ1cnRoZXIgbWFuaXB1bGF0 aW9uIG9uIHRoZSBGcmFtZVZpZXcgaWYgaXQgd2FzIHRoZSBtYWluRnJhbWUKLSAgICBpZiAoZnJh bWUgIT0gZnJhbWUtPnBhZ2UoKS0+bWFpbkZyYW1lKCkpCi0gICAgICAgIHJldHVybjsKLQotICAg IFdlYktpdFdlYlZpZXdQcml2YXRlKiBwcml2ID0gV0VCS0lUX1dFQl9WSUVXX0dFVF9QUklWQVRF KGNvbnRhaW5pbmdXaW5kb3cpOwotICAgIGZyYW1lLT52aWV3KCktPnNldEd0a0FkanVzdG1lbnRz KHByaXYtPmhvcml6b250YWxBZGp1c3RtZW50LCBwcml2LT52ZXJ0aWNhbEFkanVzdG1lbnQpOwog fQogCiB9Ci0tIAoxLjYuMQoK 27313 2009-02-04 07:47:40 -0800 2009-02-04 10:34:43 -0800 Second try 0001-2009-02-04-Xan-Lopez-xan-gnome.org.patch text/plain 3255 xan.lopez RnJvbSA0MGQ1OTlmZDExZWRjN2Y2ODVjYTZkZjRjZTExYTU1ZTliNzcxYTBiIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBYYW4gTG9wZXogPHhhbkBnbm9tZS5vcmc+CkRhdGU6IFdlZCwg NCBGZWIgMjAwOSAxNzoyMjo1NiArMDIwMApTdWJqZWN0OiBbUEFUQ0hdIDIwMDktMDItMDQgIFhh biBMb3BleiAgPHhhbkBnbm9tZS5vcmc+CgogICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgoKICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM2 MjEKCiAgICAgICAgRG8gbm90IHVzZSBtX3Njcm9sbE9mZnNldCB0byBjaGVjayBpZiB3ZSBhcmUg c2V0dGluZyB0aGUgc2FtZQogICAgICAgIHZhbHVlIHRoYW4gd2UgYWxyZWFkeSBoYXZlLgoKICAg ICAgICBtX3Njcm9sbE9mZnNldCBzdGFydHMgYXQgMCBmb3IgU2Nyb2xsVmlldywgc28gd2hlbiBv cGVuaW5nIGEgbmV3CiAgICAgICAgcGFnZSBhbmQgc2Nyb2xsaW5nIHRvIDAgKHRoZSB1c3VhbCBj YXNlKSB0aGUgY2hlY2sgd2lsbCBmYWlsIGFuZAogICAgICAgIHdlIHdvbid0IHVwZGF0ZSB0aGUg YWRqdXN0bWVudCB2YWx1ZSwgcmVzdWx0aW5nIGluIGEgcG9zc2libHkKICAgICAgICBtaXNwb3Np dGlvbmVkIHNjcm9sbGJhci4gVXNlIHRoZSBhZGp1c3RtZW50IHZhbHVlIGRpcmVjdGx5CiAgICAg ICAgaW5zdGVhZCwgd2hpY2ggaXMgd2hhdCB3ZSBhcmUgdXBkYXRpbmcgYW55d2F5LgoKICAgICAg ICAqIHBsYXRmb3JtL2d0ay9TY3JvbGxWaWV3R3RrLmNwcDoKICAgICAgICAoV2ViQ29yZTo6U2Ny b2xsVmlldzo6cGxhdGZvcm1IYW5kbGVIb3Jpem9udGFsQWRqdXN0bWVudCk6CiAgICAgICAgKFdl YkNvcmU6OlNjcm9sbFZpZXc6OnBsYXRmb3JtSGFuZGxlVmVydGljYWxBZGp1c3RtZW50KToKLS0t CiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICB8ICAgMTkgKysrKysrKysr KysrKysrKysrKwogV2ViQ29yZS9wbGF0Zm9ybS9ndGsvU2Nyb2xsVmlld0d0ay5jcHAgfCAgICA0 ICsrLS0KIDIgZmlsZXMgY2hhbmdlZCwgMjEgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkK CmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4 IGQxOGMzM2YuLmMyYmFhOTMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dl YkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjIgQEAKKzIwMDktMDItMDQgIFhhbiBMb3BleiAg PHhhbkBnbm9tZS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNjIxCisK KyAgICAgICAgRG8gbm90IHVzZSBtX3Njcm9sbE9mZnNldCB0byBjaGVjayBpZiB3ZSBhcmUgc2V0 dGluZyB0aGUgc2FtZQorICAgICAgICB2YWx1ZSB0aGFuIHdlIGFscmVhZHkgaGF2ZS4KKworICAg ICAgICBtX3Njcm9sbE9mZnNldCBzdGFydHMgYXQgMCBmb3IgU2Nyb2xsVmlldywgc28gd2hlbiBv cGVuaW5nIGEgbmV3CisgICAgICAgIHBhZ2UgYW5kIHNjcm9sbGluZyB0byAwICh0aGUgdXN1YWwg Y2FzZSkgdGhlIGNoZWNrIHdpbGwgZmFpbCBhbmQKKyAgICAgICAgd2Ugd29uJ3QgdXBkYXRlIHRo ZSBhZGp1c3RtZW50IHZhbHVlLCByZXN1bHRpbmcgaW4gYSBwb3NzaWJseQorICAgICAgICBtaXNw b3NpdGlvbmVkIHNjcm9sbGJhci4gVXNlIHRoZSBhZGp1c3RtZW50IHZhbHVlIGRpcmVjdGx5Cisg ICAgICAgIGluc3RlYWQsIHdoaWNoIGlzIHdoYXQgd2UgYXJlIHVwZGF0aW5nIGFueXdheS4KKwor ICAgICAgICAqIHBsYXRmb3JtL2d0ay9TY3JvbGxWaWV3R3RrLmNwcDoKKyAgICAgICAgKFdlYkNv cmU6OlNjcm9sbFZpZXc6OnBsYXRmb3JtSGFuZGxlSG9yaXpvbnRhbEFkanVzdG1lbnQpOgorICAg ICAgICAoV2ViQ29yZTo6U2Nyb2xsVmlldzo6cGxhdGZvcm1IYW5kbGVWZXJ0aWNhbEFkanVzdG1l bnQpOgorCiAyMDA5LTAyLTA0ICBTaW1vbiBIYXVzbWFubiAgPHNpbW9uLmhhdXNtYW5uQG5va2lh LmNvbT4KIAogICAgICAgICBVbnJldmlld2VkIFF0IGJ1aWxkIGZpeC4KZGlmZiAtLWdpdCBhL1dl YkNvcmUvcGxhdGZvcm0vZ3RrL1Njcm9sbFZpZXdHdGsuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9n dGsvU2Nyb2xsVmlld0d0ay5jcHAKaW5kZXggZTEzMTZlZS4uYjNiNmRkOSAxMDA2NDQKLS0tIGEv V2ViQ29yZS9wbGF0Zm9ybS9ndGsvU2Nyb2xsVmlld0d0ay5jcHAKKysrIGIvV2ViQ29yZS9wbGF0 Zm9ybS9ndGsvU2Nyb2xsVmlld0d0ay5jcHAKQEAgLTE1NCw3ICsxNTQsNyBAQCBib29sIFNjcm9s bFZpZXc6OnBsYXRmb3JtSGFuZGxlSG9yaXpvbnRhbEFkanVzdG1lbnQoY29uc3QgSW50U2l6ZSYg c2Nyb2xsKQogICAgICAgICBtX2hvcml6b250YWxBZGp1c3RtZW50LT51cHBlciA9IGNvbnRlbnRz V2lkdGgoKTsKICAgICAgICAgZ3RrX2FkanVzdG1lbnRfY2hhbmdlZChtX2hvcml6b250YWxBZGp1 c3RtZW50KTsKIAotICAgICAgICBpZiAobV9zY3JvbGxPZmZzZXQud2lkdGgoKSAhPSBzY3JvbGwu d2lkdGgoKSkgeworICAgICAgICBpZiAobV9ob3Jpem9udGFsQWRqdXN0bWVudC0+dmFsdWUgIT0g c2Nyb2xsLndpZHRoKCkpIHsKICAgICAgICAgICAgIG1faG9yaXpvbnRhbEFkanVzdG1lbnQtPnZh bHVlID0gc2Nyb2xsLndpZHRoKCk7CiAgICAgICAgICAgICBndGtfYWRqdXN0bWVudF92YWx1ZV9j aGFuZ2VkKG1faG9yaXpvbnRhbEFkanVzdG1lbnQpOwogICAgICAgICB9CkBAIC0xNzMsNyArMTcz LDcgQEAgYm9vbCBTY3JvbGxWaWV3OjpwbGF0Zm9ybUhhbmRsZVZlcnRpY2FsQWRqdXN0bWVudChj b25zdCBJbnRTaXplJiBzY3JvbGwpCiAgICAgICAgIG1fdmVydGljYWxBZGp1c3RtZW50LT51cHBl ciA9IGNvbnRlbnRzSGVpZ2h0KCk7CiAgICAgICAgIGd0a19hZGp1c3RtZW50X2NoYW5nZWQobV92 ZXJ0aWNhbEFkanVzdG1lbnQpOwogCi0gICAgICAgIGlmIChtX3Njcm9sbE9mZnNldC5oZWlnaHQo KSAhPSBzY3JvbGwuaGVpZ2h0KCkpIHsKKyAgICAgICAgaWYgKG1fdmVydGljYWxBZGp1c3RtZW50 LT52YWx1ZSAhPSBzY3JvbGwuaGVpZ2h0KCkpIHsKICAgICAgICAgICAgIG1fdmVydGljYWxBZGp1 c3RtZW50LT52YWx1ZSA9IHNjcm9sbC5oZWlnaHQoKTsKICAgICAgICAgICAgIGd0a19hZGp1c3Rt ZW50X3ZhbHVlX2NoYW5nZWQobV92ZXJ0aWNhbEFkanVzdG1lbnQpOwogICAgICAgICB9Ci0tIAox LjYuMQoK