236208 2022-02-06 14:16:51 -0800 [GTK] D-Bus crash atk-bridge 2022-02-15 06:07:59 -0800 1 1 1 Unclassified WebKit WebKitGTK Other Unspecified Linux RESOLVED FIXED P2 Normal --- 1 kailueke webkit-unassigned aboxhall andresg_22 aperez apinheiro bugs-noreply cfleizach cgarcia dmazzoni ews-watchlist jcraig jdiggs kailueke mcatanzaro samuel_white oldest_to_newest 1837946 0 kailueke 2022-02-06 14:16:51 -0800 It can happen at any time but after it happend it is likely to happen directly again a few seconds after app startup that it crashes with the following error printed on the console: ``` (WebKitWebProcess:2): dbind-WARNING **: 22:39:12.184: AT-SPI: Error retrieving accessibility bus address: org.freedesktop.DBus.Error.ServiceUnknown: org.freedesktop.DBus.Error.ServiceUnknown dbus[10454]: arguments to dbus_message_new_method_call() were incorrect, assertion "destination == NULL || _dbus_check_is_valid_bus_name (destination)" failed in file ../../../dbus/dbus-message.c line 1364. This is normally a bug in some application using the D-Bus library. D-Bus not built with -rdynamic so unable to print a backtrace (WebKitWebProcess:2): WPE-FDO-ERROR **: 22:39:16.262: Failed to bind wpe_bridge ``` Originally reported in https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=995420 and in https://gitlab.gnome.org/GNOME/epiphany/-/issues/1694 - maybe this even needs to go to the atk lib. Here is the full backtrace: https://paste.debian.net/1229712 1841637 1 cgarcia 2022-02-15 02:40:04 -0800 It seems that for some reason we can end up with an empty string as plug ID and ATK doesn't handle it right. We can validate the plug id returned by ATK and not call BindAccessibilityTree if it's not valid. 1841639 2 452008 cgarcia 2022-02-15 02:45:29 -0800 Created attachment 452008 Patch 1841653 3 452008 aperez 2022-02-15 04:16:09 -0800 Comment on attachment 452008 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=452008&action=review > Source/WebCore/ChangeLog:8 > + When a root is unregitered, check first if the registration is still pending to just complete and remove it. Typo: s/unregitered/unregistered/ 1841670 4 cgarcia 2022-02-15 06:07:59 -0800 Committed r289804 (247269@trunk): <https://commits.webkit.org/247269@trunk> 452008 2022-02-15 02:45:29 -0800 2022-02-15 04:16:09 -0800 Patch wcore-at-crash.diff text/plain 4610 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAxNDhkYzYwN2Y0MzMuLjUzYzM0ZTgwNWU3ZCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE1IEBACisyMDIyLTAyLTE1ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFA aWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBELUJ1cyBjcmFzaCBhdGstYnJpZGdlCisgICAg ICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzYyMDgKKworICAg ICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXaGVuIGEgcm9vdCBp cyB1bnJlZ2l0ZXJlZCwgY2hlY2sgZmlyc3QgaWYgdGhlIHJlZ2lzdHJhdGlvbiBpcyBzdGlsbCBw ZW5kaW5nIHRvIGp1c3QgY29tcGxldGUgYW5kIHJlbW92ZSBpdC4KKworICAgICAgICAqIGFjY2Vz c2liaWxpdHkvYXRzcGkvQWNjZXNzaWJpbGl0eUF0c3BpLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkFjY2Vzc2liaWxpdHlBdHNwaTo6dW5yZWdpc3RlclJvb3QpOgorCiAyMDIyLTAyLTE1ICBDYXJs b3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBSRUdSRVNT SU9OKHIxOTU0NDcpOiBbR1RLXSBkb2N1bWVudC5hY3RpdmVFbGVtZW50IG5vdCBzZXQgb24gbW91 c2UgY2xpY2sKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvYXRzcGkv QWNjZXNzaWJpbGl0eUF0c3BpLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvYXRz cGkvQWNjZXNzaWJpbGl0eUF0c3BpLmNwcAppbmRleCBjOTkzOTVhZTBlMmIuLjFhNWZmMWEzNzYx MSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9hdHNwaS9BY2Nlc3Np YmlsaXR5QXRzcGkuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvYXRzcGkv QWNjZXNzaWJpbGl0eUF0c3BpLmNwcApAQCAtMzAzLDYgKzMwMywxNSBAQCB2b2lkIEFjY2Vzc2li aWxpdHlBdHNwaTo6cmVnaXN0ZXJSb290KEFjY2Vzc2liaWxpdHlSb290QXRzcGkmIHJvb3RPYmpl Y3QsIFZlY3RvcgogCiB2b2lkIEFjY2Vzc2liaWxpdHlBdHNwaTo6dW5yZWdpc3RlclJvb3QoQWNj ZXNzaWJpbGl0eVJvb3RBdHNwaSYgcm9vdE9iamVjdCkKIHsKKyAgICBmb3IgKHVuc2lnbmVkIGkg PSAwOyBpIDwgbV9wZW5kaW5nUm9vdFJlZ2lzdHJhdGlvbnMuc2l6ZSgpOyArK2kpIHsKKyAgICAg ICAgYXV0byYgcGVuZGluZ1Jvb3RSZWdpc3RyYXRpb24gPSBtX3BlbmRpbmdSb290UmVnaXN0cmF0 aW9uc1tpXTsKKyAgICAgICAgaWYgKHBlbmRpbmdSb290UmVnaXN0cmF0aW9uLnJvb3QucHRyKCkg PT0gJnJvb3RPYmplY3QpIHsKKyAgICAgICAgICAgIHBlbmRpbmdSb290UmVnaXN0cmF0aW9uLmNv bXBsZXRpb25IYW5kbGVyKHsgfSk7CisgICAgICAgICAgICBtX3BlbmRpbmdSb290UmVnaXN0cmF0 aW9ucy5yZW1vdmUoaSk7CisgICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0KKyAgICB9CisK ICAgICBpZiAoIW1fY29ubmVjdGlvbikKICAgICAgICAgcmV0dXJuOwogCmRpZmYgLS1naXQgYS9T b3VyY2UvV2ViS2l0L0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGJk ZjI4ZGM5NjIxNy4uOWFlY2QwYmY3OTE0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L0NoYW5n ZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIy LTAyLTE1ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKworICAg ICAgICBbR1RLXSBELUJ1cyBjcmFzaCBhdGstYnJpZGdlCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzYyMDgKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBJdCBzZWVtcyB0aGF0IGZvciBzb21lIHJlYXNvbiB3 ZSBtaWdodCBlbmQgdXAgd2l0aCBhbiBlbXB0eSBzdHJpbmcgYXMgcGx1ZyBJRCB3aGljaCBBVEsg ZG9lc24ndCBoYW5kbGUgcmlnaHQuIFdlCisgICAgICAgIHNob3VsZCBub3Qgc2VuZCB0aGUgQmlu ZEFjY2Vzc2liaWxpdHlUcmVlIG1lc3NhZ2UgaWYgdGhlIHBsdWcgSUQgaXMgbm90IHZhbGlkLiBJ biB0aGUgY2FzZSBvZiBBVFNQSSB3ZSBjYW4ganVzdAorICAgICAgICBjaGVjayBpdCdzIG5vdCBl bXB0eSwgc2luY2Ugd2Uga25vdyB3ZSBhbHdheXMgYnVpbGQgYSB2YWxpZCBJRCB3aGVuIHdlIGhh dmUgYSBjb25uZWN0aW9uLiBJbiB0aGUgY2FzZSBvZiBBVEsgd2UKKyAgICAgICAgc2hvdWxkIGNo ZWNrIGl0J3MgYSB2YWxpZCB1bmlxdWUgbmFtZSBhbmQgb2JqZWN0IHBhdGguCisKKyAgICAgICAg KiBXZWJQcm9jZXNzL1dlYlBhZ2UvZ3RrL1dlYlBhZ2VHdGsuY3BwOgorICAgICAgICAoV2ViS2l0 OjpXZWJQYWdlOjpwbGF0Zm9ybUluaXRpYWxpemUpOgorCiAyMDIyLTAyLTE0ICBLaW1tbyBLaW5u dW5lbiAgPGtraW5udW5lbkBhcHBsZS5jb20+CiAKICAgICAgICAgRXh0ZW5zaW9uc0dMIGlzIG5v dCB1c2VmdWwgY2xhc3MsIGl0IHNob3VsZCBiZSByZW1vdmVkCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViS2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9ndGsvV2ViUGFnZUd0ay5jcHAgYi9Tb3VyY2UvV2Vi S2l0L1dlYlByb2Nlc3MvV2ViUGFnZS9ndGsvV2ViUGFnZUd0ay5jcHAKaW5kZXggMWJkZDVkZGY3 MmFiLi42NjFhN2NlN2U1ZjYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9X ZWJQYWdlL2d0ay9XZWJQYWdlR3RrLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0L1dlYlByb2Nlc3Mv V2ViUGFnZS9ndGsvV2ViUGFnZUd0ay5jcHAKQEAgLTY0LDkgKzY0LDI4IEBAIHZvaWQgV2ViUGFn ZTo6cGxhdGZvcm1Jbml0aWFsaXplKGNvbnN0IFdlYlBhZ2VDcmVhdGlvblBhcmFtZXRlcnMmKQog ICAgIC8vIHByb2Nlc3MgdG8gY29ubmVjdCB0aGUgdHdvIHdvcmxkcyB0aHJvdWdoIHRoZSBhY2Nl c3NpYmlsaXR5CiAgICAgLy8gb2JqZWN0IHRoZXJlIHNwZWNpZmljYWxseSBwbGFjZWQgZm9yIHRo YXQgcHVycG9zZSAodGhlIHNvY2tldCkuCiAjaWYgVVNFKEFUSykKKyAgICBhdXRvIGlzVmFsaWRQ bHVnSUQgPSBbXShjb25zdCBjaGFyKiBwbHVnSUQpIC0+IGJvb2wgeworICAgICAgICBpZiAoIXBs dWdJRCB8fCBwbHVnSURbMF0gIT0gJzonKQorICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworCisg ICAgICAgIGF1dG8qIHAgPSBnX3N0cnJzdHIocGx1Z0lELCAiOiIpOworICAgICAgICBpZiAoIXAp CisgICAgICAgICAgICByZXR1cm4gZmFsc2U7CisKKyAgICAgICAgaWYgKCFnX3ZhcmlhbnRfaXNf b2JqZWN0X3BhdGgocCArIDEpKQorICAgICAgICAgICAgcmV0dXJuIGZhbHNlOworCisgICAgICAg IEdVbmlxdWVQdHI8Y2hhcj4gbmFtZShnX3N0cm5kdXAocGx1Z0lELCBwIC0gcGx1Z0lEKSk7Cisg ICAgICAgIGlmICghZ19kYnVzX2lzX3VuaXF1ZV9uYW1lKG5hbWUuZ2V0KCkpKQorICAgICAgICAg ICAgcmV0dXJuIGZhbHNlOworCisgICAgICAgIHJldHVybiB0cnVlOworICAgIH07CisKICAgICBt X2FjY2Vzc2liaWxpdHlPYmplY3QgPSBhZG9wdEdSZWYod2Via2l0V2ViUGFnZUFjY2Vzc2liaWxp dHlPYmplY3ROZXcodGhpcykpOwogICAgIEdVbmlxdWVQdHI8Z2NoYXI+IHBsdWdJRChhdGtfcGx1 Z19nZXRfaWQoQVRLX1BMVUcobV9hY2Nlc3NpYmlsaXR5T2JqZWN0LmdldCgpKSkpOwotICAgIHNl bmQoTWVzc2FnZXM6OldlYlBhZ2VQcm94eTo6QmluZEFjY2Vzc2liaWxpdHlUcmVlKFN0cmluZyhw bHVnSUQuZ2V0KCkpKSk7CisgICAgaWYgKGlzVmFsaWRQbHVnSUQocGx1Z0lELmdldCgpKSkKKyAg ICAgICAgc2VuZChNZXNzYWdlczo6V2ViUGFnZVByb3h5OjpCaW5kQWNjZXNzaWJpbGl0eVRyZWUo U3RyaW5nKHBsdWdJRC5nZXQoKSkpKTsKICNlbGlmIFVTRShBVFNQSSkKICNpZiBVU0UoR1RLNCkK ICAgICAvLyBGSVhNRTogd2UgbmVlZCBhIHdheSB0byBjb25uZWN0IERPTSBhbmQgYXBwIGExMXkg dHJlZSBpbiBHVEs0LgpAQCAtNzQsNyArOTMsOCBAQCB2b2lkIFdlYlBhZ2U6OnBsYXRmb3JtSW5p dGlhbGl6ZShjb25zdCBXZWJQYWdlQ3JlYXRpb25QYXJhbWV0ZXJzJikKICAgICBpZiAoYXV0byog cGFnZSA9IGNvcmVQYWdlKCkpIHsKICAgICAgICAgbV9hY2Nlc3NpYmlsaXR5Um9vdE9iamVjdCA9 IEFjY2Vzc2liaWxpdHlSb290QXRzcGk6OmNyZWF0ZSgqcGFnZSk7CiAgICAgICAgIG1fYWNjZXNz aWJpbGl0eVJvb3RPYmplY3QtPnJlZ2lzdGVyT2JqZWN0KFsmXShjb25zdCBTdHJpbmcmIHBsdWdJ RCkgewotICAgICAgICAgICAgc2VuZChNZXNzYWdlczo6V2ViUGFnZVByb3h5OjpCaW5kQWNjZXNz aWJpbGl0eVRyZWUocGx1Z0lEKSk7CisgICAgICAgICAgICBpZiAoIXBsdWdJRC5pc0VtcHR5KCkp CisgICAgICAgICAgICAgICAgc2VuZChNZXNzYWdlczo6V2ViUGFnZVByb3h5OjpCaW5kQWNjZXNz aWJpbGl0eVRyZWUocGx1Z0lEKSk7CiAgICAgICAgIH0pOwogICAgIH0KICNlbmRpZgo=