23619 2009-01-29 03:24:56 -0800 ASSERT(!error.isNull()) in DocumentLoader::mainReceivedError() when an SVG image load is cancelled 2009-01-29 13:55:37 -0800 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 ap ap oldest_to_newest 107506 0 ap 2009-01-29 03:24:56 -0800 I'm seeing a random assertion failure when running layout tests due to a recently added assertion: void DocumentLoader::mainReceivedError(const ResourceError& error, bool isComplete) { ASSERT(!error.isNull()); ... The problem is that EmptyFrameLoaderClient always creates null errors. 107508 1 27145 ap 2009-01-29 04:02:36 -0800 Created attachment 27145 proposed patch 107577 2 27145 zimmermann 2009-01-29 13:55:04 -0800 Comment on attachment 27145 proposed patch Looks sane, if the ChangeLog gets fixed, r=me. 107578 3 ap 2009-01-29 13:55:37 -0800 Committed revision 40374. 27145 2009-01-29 04:02:36 -0800 2009-01-29 13:55:04 -0800 proposed patch EmptyClients.txt text/plain 3753 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MDM1OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMzggQEAKKzIwMDktMDEtMjkgIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJr aXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzYxOQorICAgICAgICBB U1NFUlQoIWVycm9yLmlzTnVsbCgpKSBpbiBEb2N1bWVudExvYWRlcjo6bWFpblJlY2VpdmVkRXJy b3IoKSB3aGVuIGFuIFNWRyBpbWFnZSBsb2FkCisgICAgICAgIGlzIGNhbmNlbGxlZAorCisgICAg ICAgIENvdmVyZWQgYnkgZXhpc3RpbmcgdGVzdHMgKGFzIGEgcmFuZG9tIGNyYXNoKS4KKworICAg ICAgICAqIGxvYWRlci9FbXB0eUNsaWVudHMuaDoKKyAgICAgICAgKFdlYkNvcmU6OkVtcHR5RnJh bWVMb2FkZXJDbGllbnQ6OmNhbmNlbGxlZEVycm9yKToKKyAgICAgICAgKFdlYkNvcmU6OkVtcHR5 RnJhbWVMb2FkZXJDbGllbnQ6OmJsb2NrZWRFcnJvcik6CisgICAgICAgIChXZWJDb3JlOjpFbXB0 eUZyYW1lTG9hZGVyQ2xpZW50OjpjYW5ub3RTaG93VVJMRXJyb3IpOgorICAgICAgICAoV2ViQ29y ZTo6RW1wdHlGcmFtZUxvYWRlckNsaWVudDo6aW50ZXJydXB0Rm9yUG9saWN5Q2hhbmdlRXJyb3Ip OgorICAgICAgICAoV2ViQ29yZTo6RW1wdHlGcmFtZUxvYWRlckNsaWVudDo6Y2Fubm90U2hvd01J TUVUeXBlRXJyb3IpOgorICAgICAgICAoV2ViQ29yZTo6RW1wdHlGcmFtZUxvYWRlckNsaWVudDo6 ZmlsZURvZXNOb3RFeGlzdEVycm9yKToKKyAgICAgICAgKFdlYkNvcmU6OkVtcHR5RnJhbWVMb2Fk ZXJDbGllbnQ6OnBsdWdpbldpbGxIYW5kbGVMb2FkRXJyb3IpOgorICAgICAgICBDcmVhdGUgbm9u LW51bGwgZXJyb3JzLgorCisyMDA5LTAxLTI5ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAd2Vi a2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBXQVJOSU5HOiBOTyBURVNUIENBU0VTIEFEREVEIE9SIENIQU5HRUQKKworICAgICAgICAqIGxv YWRlci9FbXB0eUNsaWVudHMuaDoKKyAgICAgICAgKFdlYkNvcmU6OkVtcHR5RnJhbWVMb2FkZXJD bGllbnQ6OmNhbmNlbGxlZEVycm9yKToKKyAgICAgICAgKFdlYkNvcmU6OkVtcHR5RnJhbWVMb2Fk ZXJDbGllbnQ6OmJsb2NrZWRFcnJvcik6CisgICAgICAgIChXZWJDb3JlOjpFbXB0eUZyYW1lTG9h ZGVyQ2xpZW50OjpjYW5ub3RTaG93VVJMRXJyb3IpOgorICAgICAgICAoV2ViQ29yZTo6RW1wdHlG cmFtZUxvYWRlckNsaWVudDo6aW50ZXJydXB0Rm9yUG9saWN5Q2hhbmdlRXJyb3IpOgorICAgICAg ICAoV2ViQ29yZTo6RW1wdHlGcmFtZUxvYWRlckNsaWVudDo6Y2Fubm90U2hvd01JTUVUeXBlRXJy b3IpOgorICAgICAgICAoV2ViQ29yZTo6RW1wdHlGcmFtZUxvYWRlckNsaWVudDo6ZmlsZURvZXNO b3RFeGlzdEVycm9yKToKKyAgICAgICAgKFdlYkNvcmU6OkVtcHR5RnJhbWVMb2FkZXJDbGllbnQ6 OnBsdWdpbldpbGxIYW5kbGVMb2FkRXJyb3IpOgorCiAyMDA5LTAxLTI5ICBBbGV4ZXkgUHJvc2t1 cnlha292ICA8YXBAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZWxlYXNlIGJ1aWxkIGZpeC4KSW5k ZXg6IFdlYkNvcmUvbG9hZGVyL0VtcHR5Q2xpZW50cy5oCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUv bG9hZGVyL0VtcHR5Q2xpZW50cy5oCShyZXZpc2lvbiA0MDM1MykKKysrIFdlYkNvcmUvbG9hZGVy L0VtcHR5Q2xpZW50cy5oCSh3b3JraW5nIGNvcHkpCkBAIC0yMTEsMTQgKzIxMSwxNCBAQCBwdWJs aWM6CiAgICAgdmlydHVhbCB2b2lkIGNvbW1pdHRlZExvYWQoRG9jdW1lbnRMb2FkZXIqLCBjb25z dCBjaGFyKiwgaW50KSB7IH0KICAgICB2aXJ0dWFsIHZvaWQgZmluaXNoZWRMb2FkaW5nKERvY3Vt ZW50TG9hZGVyKikgeyB9CiAKLSAgICB2aXJ0dWFsIFJlc291cmNlRXJyb3IgY2FuY2VsbGVkRXJy b3IoY29uc3QgUmVzb3VyY2VSZXF1ZXN0JikgeyByZXR1cm4gUmVzb3VyY2VFcnJvcigpOyB9Ci0g ICAgdmlydHVhbCBSZXNvdXJjZUVycm9yIGJsb2NrZWRFcnJvcihjb25zdCBSZXNvdXJjZVJlcXVl c3QmKSB7IHJldHVybiBSZXNvdXJjZUVycm9yKCk7IH0KLSAgICB2aXJ0dWFsIFJlc291cmNlRXJy b3IgY2Fubm90U2hvd1VSTEVycm9yKGNvbnN0IFJlc291cmNlUmVxdWVzdCYpIHsgcmV0dXJuIFJl c291cmNlRXJyb3IoKTsgfQotICAgIHZpcnR1YWwgUmVzb3VyY2VFcnJvciBpbnRlcnJ1cHRGb3JQ b2xpY3lDaGFuZ2VFcnJvcihjb25zdCBSZXNvdXJjZVJlcXVlc3QmKSB7IHJldHVybiBSZXNvdXJj ZUVycm9yKCk7IH0KLQotICAgIHZpcnR1YWwgUmVzb3VyY2VFcnJvciBjYW5ub3RTaG93TUlNRVR5 cGVFcnJvcihjb25zdCBSZXNvdXJjZVJlc3BvbnNlJikgeyByZXR1cm4gUmVzb3VyY2VFcnJvcigp OyB9Ci0gICAgdmlydHVhbCBSZXNvdXJjZUVycm9yIGZpbGVEb2VzTm90RXhpc3RFcnJvcihjb25z dCBSZXNvdXJjZVJlc3BvbnNlJikgeyByZXR1cm4gUmVzb3VyY2VFcnJvcigpOyB9Ci0gICAgdmly dHVhbCBSZXNvdXJjZUVycm9yIHBsdWdpbldpbGxIYW5kbGVMb2FkRXJyb3IoY29uc3QgUmVzb3Vy Y2VSZXNwb25zZSYpIHsgcmV0dXJuIFJlc291cmNlRXJyb3IoKTsgfQorICAgIHZpcnR1YWwgUmVz b3VyY2VFcnJvciBjYW5jZWxsZWRFcnJvcihjb25zdCBSZXNvdXJjZVJlcXVlc3QmKSB7IFJlc291 cmNlRXJyb3IgZXJyb3IoIiIsIDAsICIiLCAiIik7IGVycm9yLnNldElzQ2FuY2VsbGF0aW9uKHRy dWUpOyByZXR1cm4gZXJyb3I7IH0KKyAgICB2aXJ0dWFsIFJlc291cmNlRXJyb3IgYmxvY2tlZEVy cm9yKGNvbnN0IFJlc291cmNlUmVxdWVzdCYpIHsgcmV0dXJuIFJlc291cmNlRXJyb3IoIiIsIDAs ICIiLCAiIik7IH0KKyAgICB2aXJ0dWFsIFJlc291cmNlRXJyb3IgY2Fubm90U2hvd1VSTEVycm9y KGNvbnN0IFJlc291cmNlUmVxdWVzdCYpIHsgcmV0dXJuIFJlc291cmNlRXJyb3IoIiIsIDAsICIi LCAiIik7IH0KKyAgICB2aXJ0dWFsIFJlc291cmNlRXJyb3IgaW50ZXJydXB0Rm9yUG9saWN5Q2hh bmdlRXJyb3IoY29uc3QgUmVzb3VyY2VSZXF1ZXN0JikgeyByZXR1cm4gUmVzb3VyY2VFcnJvcigi IiwgMCwgIiIsICIiKTsgfQorCisgICAgdmlydHVhbCBSZXNvdXJjZUVycm9yIGNhbm5vdFNob3dN SU1FVHlwZUVycm9yKGNvbnN0IFJlc291cmNlUmVzcG9uc2UmKSB7IHJldHVybiBSZXNvdXJjZUVy cm9yKCIiLCAwLCAiIiwgIiIpOyB9CisgICAgdmlydHVhbCBSZXNvdXJjZUVycm9yIGZpbGVEb2Vz Tm90RXhpc3RFcnJvcihjb25zdCBSZXNvdXJjZVJlc3BvbnNlJikgeyByZXR1cm4gUmVzb3VyY2VF cnJvcigiIiwgMCwgIiIsICIiKTsgfQorICAgIHZpcnR1YWwgUmVzb3VyY2VFcnJvciBwbHVnaW5X aWxsSGFuZGxlTG9hZEVycm9yKGNvbnN0IFJlc291cmNlUmVzcG9uc2UmKSB7IHJldHVybiBSZXNv dXJjZUVycm9yKCIiLCAwLCAiIiwgIiIpOyB9CiAKICAgICB2aXJ0dWFsIGJvb2wgc2hvdWxkRmFs bEJhY2soY29uc3QgUmVzb3VyY2VFcnJvciYpIHsgcmV0dXJuIGZhbHNlOyB9CiAK