236181 2022-02-05 12:39:09 -0800 [WTF] Fix clang tidy bugprone-move-forwarding-reference static analyzer warnings in CompletionHandler.h 2022-02-10 12:37:53 -0800 1 1 1 Unclassified WebKit Web Template Framework Other Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=229114 https://bugs.webkit.org/show_bug.cgi?id=236202 https://bugs.webkit.org/show_bug.cgi?id=236459 InRadar P2 Normal --- 1 ddkilzer ddkilzer benjamin cdumez cmarcelo darin ews-watchlist webkit-bug-importer ysuzuki oldest_to_newest 1837779 0 ddkilzer 2022-02-05 12:39:09 -0800 Fix clang tidy bugprone-move-forwarding-reference static analyzer warnings in CompletionHandler.h. Found by clang static analyzer. 1837780 1 webkit-bug-importer 2022-02-05 12:39:25 -0800 <rdar://problem/88529996> 1837781 2 450995 ddkilzer 2022-02-05 12:40:17 -0800 Created attachment 450995 Patch v1 1837782 3 450996 ddkilzer 2022-02-05 13:04:17 -0800 Created attachment 450996 Patch v2 1837783 4 ddkilzer 2022-02-05 13:05:02 -0800 (In reply to David Kilzer (:ddkilzer) from comment #2) > Created attachment 450995 [details] > Patch v1 Oops. Changed std::forward() to std::forward<CallableType>(). 1837795 5 450996 ddkilzer 2022-02-05 15:05:27 -0800 Comment on attachment 450996 Patch v2 Marking xq+ since enough builds and tests have run to show this didn't cause a regression. 1837803 6 ews-feeder 2022-02-05 15:40:14 -0800 Committed r289162 (246858@main): <https://commits.webkit.org/246858@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450996. 1837841 7 450996 ysuzuki 2022-02-05 20:16:10 -0800 Comment on attachment 450996 Patch v2 r=me, yes, it can be a lref or rref (b/c CallableType is template type of this function), thus we should use std::forward. 1837842 8 ysuzuki 2022-02-05 20:16:32 -0800 Ah, oops it was already landed. 450995 2022-02-05 12:40:17 -0800 2022-02-05 12:54:16 -0800 Patch v1 bug-236181-20220205124015.patch text/plain 2095 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4NDY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDU5N2NlODJiMGYwNDYwNzliZGUzMTFj MTNjMDg2M2E0MTJiZmY2OGUuLmEzZTg4ZDU5M2NhMGI4MGU4NjY0ZDM2Mzg5MTM0NzgyZmRhNTJh MzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjItMDItMDUgIERhdmlkIEtpbHplciAgPGRka2ls emVyQGFwcGxlLmNvbT4KKworICAgICAgICBbV1RGXSBGaXggY2xhbmcgdGlkeSBidWdwcm9uZS1t b3ZlLWZvcndhcmRpbmctcmVmZXJlbmNlIHN0YXRpYyBhbmFseXplciB3YXJuaW5ncyBpbiBDb21w bGV0aW9uSGFuZGxlci5oCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8yMzYxODE+Cisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS84ODUyOTk5Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9Db21wbGV0aW9uSGFuZGxlci5oOgorICAg ICAgICAoV1RGOjpDb21wbGV0aW9uSGFuZGxlcjxPdXQpOgorICAgICAgICAoV1RGOjpDb21wbGV0 aW9uSGFuZGxlcldpdGhGaW5hbGl6ZXI8T3V0KToKKyAgICAgICAgLSBSZXBsYWNlIFdURk1vdmUo KSB3aXRoIHN0ZDo6Zm9yd2FyZDw+KCkuCisKIDIwMjItMDEtMjQgIE1pY2hhZWwgQ2F0YW56YXJv ICA8bWNhdGFuemFyb0Bnbm9tZS5vcmc+CiAKICAgICAgICAgQnVpbGQgZmFpbHVyZSB3aXRoIEdD QyAxMjogbm8gbWF0Y2hpbmcgZnVuY3Rpb24gZm9yIGNhbGwgdG8gJ2VuZChMQ2hhciBbN10pJwpk aWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvQ29tcGxldGlvbkhhbmRsZXIuaCBiL1NvdXJjZS9X VEYvd3RmL0NvbXBsZXRpb25IYW5kbGVyLmgKaW5kZXggNWJjNTUxNzhhMGNmMjNlMWEyZTUwMWVl MDBmOWJiNTkzOWQ5YjVmZS4uNzQzZDk3ZDRiZmQ0MzQwNDU5MjRjODkyNjU3YmFlZWM0MDM2OWY3 YSAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvQ29tcGxldGlvbkhhbmRsZXIuaAorKysgYi9T b3VyY2UvV1RGL3d0Zi9Db21wbGV0aW9uSGFuZGxlci5oCkBAIC00Myw3ICs0Myw3IEBAIHB1Ymxp YzoKIAogICAgIHRlbXBsYXRlPHR5cGVuYW1lIENhbGxhYmxlVHlwZSwgY2xhc3MgPSB0eXBlbmFt ZSBzdGQ6OmVuYWJsZV9pZjxzdGQ6OmlzX3J2YWx1ZV9yZWZlcmVuY2U8Q2FsbGFibGVUeXBlJiY+ Ojp2YWx1ZT46OnR5cGU+CiAgICAgQ29tcGxldGlvbkhhbmRsZXIoQ2FsbGFibGVUeXBlJiYgY2Fs bGFibGUsIENvbXBsZXRpb25IYW5kbGVyQ2FsbFRocmVhZCBjYWxsVGhyZWFkID0gQ29tcGxldGlv bkhhbmRsZXJDYWxsVGhyZWFkOjpDb25zdHJ1Y3Rpb25UaHJlYWQpCi0gICAgICAgIDogbV9mdW5j dGlvbihXVEZNb3ZlKGNhbGxhYmxlKSkKKyAgICAgICAgOiBtX2Z1bmN0aW9uKHN0ZDo6Zm9yd2Fy ZChjYWxsYWJsZSkpCiAjaWYgQVNTRVJUX0VOQUJMRUQKICAgICAgICAgLCBtX3Nob3VsZEJlQ2Fs bGVkT25NYWluVGhyZWFkKGNhbGxUaHJlYWQgPT0gQ29tcGxldGlvbkhhbmRsZXJDYWxsVGhyZWFk OjpNYWluVGhyZWFkIHx8IGlzTWFpblRocmVhZCgpKQogI2VuZGlmCkBAIC04NSw3ICs4NSw3IEBA IGNsYXNzIENvbXBsZXRpb25IYW5kbGVyV2l0aEZpbmFsaXplcjxPdXQoSW4uLi4pPiB7CiBwdWJs aWM6CiAgICAgdGVtcGxhdGU8dHlwZW5hbWUgQ2FsbGFibGVUeXBlLCBjbGFzcyA9IHR5cGVuYW1l IHN0ZDo6ZW5hYmxlX2lmPHN0ZDo6aXNfcnZhbHVlX3JlZmVyZW5jZTxDYWxsYWJsZVR5cGUmJj46 OnZhbHVlPjo6dHlwZT4KICAgICBDb21wbGV0aW9uSGFuZGxlcldpdGhGaW5hbGl6ZXIoQ2FsbGFi bGVUeXBlJiYgY2FsbGFibGUsIEZ1bmN0aW9uPHZvaWQoRnVuY3Rpb248T3V0KEluLi4uKT4mKT4m JiBmaW5hbGl6ZXIpCi0gICAgICAgIDogbV9mdW5jdGlvbihXVEZNb3ZlKGNhbGxhYmxlKSkKKyAg ICAgICAgOiBtX2Z1bmN0aW9uKHN0ZDo6Zm9yd2FyZChjYWxsYWJsZSkpCiAgICAgICAgICwgbV9m aW5hbGl6ZXIoV1RGTW92ZShmaW5hbGl6ZXIpKQogICAgIHsKICAgICB9Cg== 450996 2022-02-05 13:04:17 -0800 2022-02-05 20:16:10 -0800 Patch v2 bug-236181-20220205130414.patch text/plain 2123 ddkilzer U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4NDY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDU5N2NlODJiMGYwNDYwNzliZGUzMTFj MTNjMDg2M2E0MTJiZmY2OGUuLmEzZTg4ZDU5M2NhMGI4MGU4NjY0ZDM2Mzg5MTM0NzgyZmRhNTJh MzkgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMjItMDItMDUgIERhdmlkIEtpbHplciAgPGRka2ls emVyQGFwcGxlLmNvbT4KKworICAgICAgICBbV1RGXSBGaXggY2xhbmcgdGlkeSBidWdwcm9uZS1t b3ZlLWZvcndhcmRpbmctcmVmZXJlbmNlIHN0YXRpYyBhbmFseXplciB3YXJuaW5ncyBpbiBDb21w bGV0aW9uSGFuZGxlci5oCisgICAgICAgIDxodHRwczovL3dlYmtpdC5vcmcvYi8yMzYxODE+Cisg ICAgICAgIDxyZGFyOi8vcHJvYmxlbS84ODUyOTk5Nj4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIHd0Zi9Db21wbGV0aW9uSGFuZGxlci5oOgorICAg ICAgICAoV1RGOjpDb21wbGV0aW9uSGFuZGxlcjxPdXQpOgorICAgICAgICAoV1RGOjpDb21wbGV0 aW9uSGFuZGxlcldpdGhGaW5hbGl6ZXI8T3V0KToKKyAgICAgICAgLSBSZXBsYWNlIFdURk1vdmUo KSB3aXRoIHN0ZDo6Zm9yd2FyZDw+KCkuCisKIDIwMjItMDEtMjQgIE1pY2hhZWwgQ2F0YW56YXJv ICA8bWNhdGFuemFyb0Bnbm9tZS5vcmc+CiAKICAgICAgICAgQnVpbGQgZmFpbHVyZSB3aXRoIEdD QyAxMjogbm8gbWF0Y2hpbmcgZnVuY3Rpb24gZm9yIGNhbGwgdG8gJ2VuZChMQ2hhciBbN10pJwpk aWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvQ29tcGxldGlvbkhhbmRsZXIuaCBiL1NvdXJjZS9X VEYvd3RmL0NvbXBsZXRpb25IYW5kbGVyLmgKaW5kZXggNWJjNTUxNzhhMGNmMjNlMWEyZTUwMWVl MDBmOWJiNTkzOWQ5YjVmZS4uNjljYjQ0YTdmZGFkMDE3YTI1NDAyODA1OWE3MjNmYmVlMDE5NmRk NiAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYvQ29tcGxldGlvbkhhbmRsZXIuaAorKysgYi9T b3VyY2UvV1RGL3d0Zi9Db21wbGV0aW9uSGFuZGxlci5oCkBAIC00Myw3ICs0Myw3IEBAIHB1Ymxp YzoKIAogICAgIHRlbXBsYXRlPHR5cGVuYW1lIENhbGxhYmxlVHlwZSwgY2xhc3MgPSB0eXBlbmFt ZSBzdGQ6OmVuYWJsZV9pZjxzdGQ6OmlzX3J2YWx1ZV9yZWZlcmVuY2U8Q2FsbGFibGVUeXBlJiY+ Ojp2YWx1ZT46OnR5cGU+CiAgICAgQ29tcGxldGlvbkhhbmRsZXIoQ2FsbGFibGVUeXBlJiYgY2Fs bGFibGUsIENvbXBsZXRpb25IYW5kbGVyQ2FsbFRocmVhZCBjYWxsVGhyZWFkID0gQ29tcGxldGlv bkhhbmRsZXJDYWxsVGhyZWFkOjpDb25zdHJ1Y3Rpb25UaHJlYWQpCi0gICAgICAgIDogbV9mdW5j dGlvbihXVEZNb3ZlKGNhbGxhYmxlKSkKKyAgICAgICAgOiBtX2Z1bmN0aW9uKHN0ZDo6Zm9yd2Fy ZDxDYWxsYWJsZVR5cGU+KGNhbGxhYmxlKSkKICNpZiBBU1NFUlRfRU5BQkxFRAogICAgICAgICAs IG1fc2hvdWxkQmVDYWxsZWRPbk1haW5UaHJlYWQoY2FsbFRocmVhZCA9PSBDb21wbGV0aW9uSGFu ZGxlckNhbGxUaHJlYWQ6Ok1haW5UaHJlYWQgfHwgaXNNYWluVGhyZWFkKCkpCiAjZW5kaWYKQEAg LTg1LDcgKzg1LDcgQEAgY2xhc3MgQ29tcGxldGlvbkhhbmRsZXJXaXRoRmluYWxpemVyPE91dChJ bi4uLik+IHsKIHB1YmxpYzoKICAgICB0ZW1wbGF0ZTx0eXBlbmFtZSBDYWxsYWJsZVR5cGUsIGNs YXNzID0gdHlwZW5hbWUgc3RkOjplbmFibGVfaWY8c3RkOjppc19ydmFsdWVfcmVmZXJlbmNlPENh bGxhYmxlVHlwZSYmPjo6dmFsdWU+Ojp0eXBlPgogICAgIENvbXBsZXRpb25IYW5kbGVyV2l0aEZp bmFsaXplcihDYWxsYWJsZVR5cGUmJiBjYWxsYWJsZSwgRnVuY3Rpb248dm9pZChGdW5jdGlvbjxP dXQoSW4uLi4pPiYpPiYmIGZpbmFsaXplcikKLSAgICAgICAgOiBtX2Z1bmN0aW9uKFdURk1vdmUo Y2FsbGFibGUpKQorICAgICAgICA6IG1fZnVuY3Rpb24oc3RkOjpmb3J3YXJkPENhbGxhYmxlVHlw ZT4oY2FsbGFibGUpKQogICAgICAgICAsIG1fZmluYWxpemVyKFdURk1vdmUoZmluYWxpemVyKSkK ICAgICB7CiAgICAgfQo=