236164 2022-02-04 15:55:12 -0800 [libpas] allocation failure crash should be PAS_NEVER_INLINE 2022-02-04 16:52:16 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 ysuzuki ysuzuki saam webkit-bug-importer oldest_to_newest 1837624 0 ysuzuki 2022-02-04 15:55:12 -0800 [libpas] allocation failure crash should be NEVER_INLINED 1837625 1 450946 ysuzuki 2022-02-04 15:56:23 -0800 Created attachment 450946 Patch 1837626 2 450946 ysuzuki 2022-02-04 15:57:18 -0800 Comment on attachment 450946 Patch Oops, I'll a bit fix it. 1837634 3 450947 ysuzuki 2022-02-04 16:17:24 -0800 Created attachment 450947 Patch 1837637 4 450947 saam 2022-02-04 16:19:59 -0800 Comment on attachment 450947 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450947&action=review > Source/bmalloc/libpas/src/libpas/pas_utils.c:60 > + pas_panic("allocation did fail because of out-of-memory\n"); do we want to make sure this call gets inlined? 1837638 5 450947 ysuzuki 2022-02-04 16:21:53 -0800 Comment on attachment 450947 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450947&action=review >> Source/bmalloc/libpas/src/libpas/pas_utils.c:60 >> + pas_panic("allocation did fail because of out-of-memory\n"); > > do we want to make sure this call gets inlined? Discussed with Saam. I'll change it to __builtin_trap to make pas_panic_on_out_of_memory_error top signature. 1837656 6 ysuzuki 2022-02-04 16:50:17 -0800 OK we ensured it is built, landing. 1837658 7 ysuzuki 2022-02-04 16:51:59 -0800 Committed r289144 (246840@trunk): <https://commits.webkit.org/246840@trunk> 1837659 8 webkit-bug-importer 2022-02-04 16:52:16 -0800 <rdar://problem/88514835> 450946 2022-02-04 15:56:23 -0800 2022-02-04 16:21:47 -0800 Patch bug-236164-20220204155623.patch text/plain 1710 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5MTQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9D aGFuZ2VMb2cgYi9Tb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cKaW5kZXggNmM0MDYzYmQ1OTY2YzA0 YWVjYjJjMTBlMDZkMWM2MzFiZTU2ZmFjYS4uOTcxNGJmZTZiOGQ5YzA4MjI5NzkwMTY5ZTg1NjBk NGY5NTFiYzQyZiAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9ibWFsbG9jL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDIyLTAyLTA0ICBZdXN1 a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CisKKyAgICAgICAgW2xpYnBhc10gYWxsb2Nh dGlvbiBmYWlsdXJlIGNyYXNoIHNob3VsZCBiZSBQQVNfTkVWRVJfSU5MSU5FCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzYxNjQKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGFsbG93cyB1cyB0byBh bm5vdGF0ZSBjcmFzaCB0cmFjZSB3aXRoIGEgY2xlYXIgc2lnbmF0dXJlIHdoaWNoIGluZGljYXRl cyBhIE9PTSBjcmFzaC4KKyAgICAgICAgV2UgYWxzbyByZW5hbWUgcGFzX2FsbG9jYXRpb25fcmVz dWx0X2NyYXNoX29uX2Vycm9yIHRvIHBhc19hbGxvY2F0aW9uX3Jlc3VsdF9jcmFzaF9vbl9vb21f ZXJyb3IuCisKKyAgICAgICAgKiBsaWJwYXMvc3JjL2xpYnBhcy9wYXNfYWxsb2NhdGlvbl9yZXN1 bHQuaDoKKyAgICAgICAgKHBhc19hbGxvY2F0aW9uX3Jlc3VsdF9jcmFzaF9vbl9vb21fZXJyb3Ip OgorICAgICAgICAocGFzX2FsbG9jYXRpb25fcmVzdWx0X2NyYXNoX29uX2Vycm9yKTogRGVsZXRl ZC4KKwogMjAyMi0wMi0wMyAgTWlraGFpbCBSLiBHYWRlbGhhICA8bWlraGFpbEBpZ2FsaWEuY29t PgogCiAgICAgICAgIEZpeCBCU0QgY29tcGlsYXRpb24gYWZ0ZXIgcjI4OTA1NgpkaWZmIC0tZ2l0 IGEvU291cmNlL2JtYWxsb2MvbGlicGFzL3NyYy9saWJwYXMvcGFzX2FsbG9jYXRpb25fcmVzdWx0 LmggYi9Tb3VyY2UvYm1hbGxvYy9saWJwYXMvc3JjL2xpYnBhcy9wYXNfYWxsb2NhdGlvbl9yZXN1 bHQuaAppbmRleCA1NjdkM2NjYjYxZGY0MmFjODA5MzY0MjE1YWJiN2VhMWY2ZDNiMjc5Li42NTg5 MGZiNDI5NTU3YTE3MGI1MjNiYmNjOTYzMWY1M2RlODFkMzdiIDEwMDY0NAotLS0gYS9Tb3VyY2Uv Ym1hbGxvYy9saWJwYXMvc3JjL2xpYnBhcy9wYXNfYWxsb2NhdGlvbl9yZXN1bHQuaAorKysgYi9T b3VyY2UvYm1hbGxvYy9saWJwYXMvc3JjL2xpYnBhcy9wYXNfYWxsb2NhdGlvbl9yZXN1bHQuaApA QCAtOTksOCArOTksOCBAQCBwYXNfYWxsb2NhdGlvbl9yZXN1bHRfc2V0X2Vycm5vKHBhc19hbGxv Y2F0aW9uX3Jlc3VsdCByZXN1bHQpCiAgICAgcmV0dXJuIHJlc3VsdDsKIH0KIAotc3RhdGljIFBB U19BTFdBWVNfSU5MSU5FIHBhc19hbGxvY2F0aW9uX3Jlc3VsdAotcGFzX2FsbG9jYXRpb25fcmVz dWx0X2NyYXNoX29uX2Vycm9yKHBhc19hbGxvY2F0aW9uX3Jlc3VsdCByZXN1bHQpCitzdGF0aWMg UEFTX05FVkVSX0lOTElORSBwYXNfYWxsb2NhdGlvbl9yZXN1bHQKK3Bhc19hbGxvY2F0aW9uX3Jl c3VsdF9jcmFzaF9vbl9vb21fZXJyb3IocGFzX2FsbG9jYXRpb25fcmVzdWx0IHJlc3VsdCkKIHsK ICAgICBQQVNfQVNTRVJUKHJlc3VsdC5kaWRfc3VjY2VlZCk7CiAgICAgcmV0dXJuIHJlc3VsdDsK 450947 2022-02-04 16:17:24 -0800 2022-02-04 16:19:17 -0800 Patch bug-236164-20220204161724.patch text/plain 3211 ysuzuki U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5MTQwCmRpZmYgLS1naXQgYS9Tb3VyY2UvYm1hbGxvYy9D aGFuZ2VMb2cgYi9Tb3VyY2UvYm1hbGxvYy9DaGFuZ2VMb2cKaW5kZXggNmM0MDYzYmQ1OTY2YzA0 YWVjYjJjMTBlMDZkMWM2MzFiZTU2ZmFjYS4uZjg5OGViNzY4NTA4NGVkMThjODIyYWMwYjBlMWFm OWYwNTZjZTY2YSAxMDA2NDQKLS0tIGEvU291cmNlL2JtYWxsb2MvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9ibWFsbG9jL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIyLTAyLTA0ICBZdXN1 a2UgU3V6dWtpICA8eXN1enVraUBhcHBsZS5jb20+CisKKyAgICAgICAgW2xpYnBhc10gYWxsb2Nh dGlvbiBmYWlsdXJlIGNyYXNoIHNob3VsZCBiZSBQQVNfTkVWRVJfSU5MSU5FCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzYxNjQKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBpbnRyb2R1Y2UgcGFzX2Fs bG9jYXRpb25fcmVzdWx0X2NyYXNoX29uX2Vycm9yIGZ1bmN0aW9uIHdoaWNoIGNhbiBsZWF2ZSBP T00gY3Jhc2gKKyAgICAgICAgaW5mb3JtYXRpb24gaW4gdGhlIGNyYXNoIGxvZy4gVG8ga2VlcCB0 aGlzIG5vbi1pbmxpbmVkLCB3ZSBhbm5vdGF0ZSBpdCBQQVNfTkVWRVJfSU5MSU5FLgorCisgICAg ICAgICogbGlicGFzL3NyYy9saWJwYXMvcGFzX2FsbG9jYXRpb25fcmVzdWx0Lmg6CisgICAgICAg IChwYXNfYWxsb2NhdGlvbl9yZXN1bHRfY3Jhc2hfb25fZXJyb3IpOgorICAgICAgICAqIGxpYnBh cy9zcmMvbGlicGFzL3Bhc191dGlscy5jOgorICAgICAgICAocGFzX3BhbmljX29uX291dF9vZl9t ZW1vcnlfZXJyb3IpOgorICAgICAgICAqIGxpYnBhcy9zcmMvbGlicGFzL3Bhc191dGlscy5oOgor CiAyMDIyLTAyLTAzICBNaWtoYWlsIFIuIEdhZGVsaGEgIDxtaWtoYWlsQGlnYWxpYS5jb20+CiAK ICAgICAgICAgRml4IEJTRCBjb21waWxhdGlvbiBhZnRlciByMjg5MDU2CmRpZmYgLS1naXQgYS9T b3VyY2UvYm1hbGxvYy9saWJwYXMvc3JjL2xpYnBhcy9wYXNfYWxsb2NhdGlvbl9yZXN1bHQuaCBi L1NvdXJjZS9ibWFsbG9jL2xpYnBhcy9zcmMvbGlicGFzL3Bhc19hbGxvY2F0aW9uX3Jlc3VsdC5o CmluZGV4IDU2N2QzY2NiNjFkZjQyYWM4MDkzNjQyMTVhYmI3ZWExZjZkM2IyNzkuLmM3YTg5N2Nl Y2E1NDU5OGMyZjg4OTE4OGI2ZmRlMzQ0M2IzMGQ3MGEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9ibWFs bG9jL2xpYnBhcy9zcmMvbGlicGFzL3Bhc19hbGxvY2F0aW9uX3Jlc3VsdC5oCisrKyBiL1NvdXJj ZS9ibWFsbG9jL2xpYnBhcy9zcmMvbGlicGFzL3Bhc19hbGxvY2F0aW9uX3Jlc3VsdC5oCkBAIC0x MDIsNyArMTAyLDggQEAgcGFzX2FsbG9jYXRpb25fcmVzdWx0X3NldF9lcnJubyhwYXNfYWxsb2Nh dGlvbl9yZXN1bHQgcmVzdWx0KQogc3RhdGljIFBBU19BTFdBWVNfSU5MSU5FIHBhc19hbGxvY2F0 aW9uX3Jlc3VsdAogcGFzX2FsbG9jYXRpb25fcmVzdWx0X2NyYXNoX29uX2Vycm9yKHBhc19hbGxv Y2F0aW9uX3Jlc3VsdCByZXN1bHQpCiB7Ci0gICAgUEFTX0FTU0VSVChyZXN1bHQuZGlkX3N1Y2Nl ZWQpOworICAgIGlmIChQQVNfVU5MSUtFTFkoIXJlc3VsdC5kaWRfc3VjY2VlZCkpCisgICAgICAg IHBhc19wYW5pY19vbl9vdXRfb2ZfbWVtb3J5X2Vycm9yKCk7CiAgICAgcmV0dXJuIHJlc3VsdDsK IH0KIApkaWZmIC0tZ2l0IGEvU291cmNlL2JtYWxsb2MvbGlicGFzL3NyYy9saWJwYXMvcGFzX3V0 aWxzLmMgYi9Tb3VyY2UvYm1hbGxvYy9saWJwYXMvc3JjL2xpYnBhcy9wYXNfdXRpbHMuYwppbmRl eCBkMDk1ZDZjMjgzNWE3NTkxMmI2NmJhN2Y5NzNlNzhkZjI4MDJhODY1Li5lYzRlYTFhOGM3ZWQz YTk0ZDllOWVkOWIzZjJmNzI4NWU1NjMzZDAyIDEwMDY0NAotLS0gYS9Tb3VyY2UvYm1hbGxvYy9s aWJwYXMvc3JjL2xpYnBhcy9wYXNfdXRpbHMuYworKysgYi9Tb3VyY2UvYm1hbGxvYy9saWJwYXMv c3JjL2xpYnBhcy9wYXNfdXRpbHMuYwpAQCAtNTUsNiArNTUsMTEgQEAgdm9pZCBwYXNfYXNzZXJ0 aW9uX2ZhaWxlZChjb25zdCBjaGFyKiBmaWxlbmFtZSwgaW50IGxpbmUsIGNvbnN0IGNoYXIqIGZ1 bmN0aW9uLAogfQogI2VuZGlmIC8qIFBBU19FTkFCTEVfVEVTVElORyAqLwogCit2b2lkIHBhc19w YW5pY19vbl9vdXRfb2ZfbWVtb3J5X2Vycm9yKCkKK3sKKyAgICBwYXNfcGFuaWMoImFsbG9jYXRp b24gZGlkIGZhaWwgYmVjYXVzZSBvZiBvdXQtb2YtbWVtb3J5XG4iKTsKK30KKwogc3RhdGljIHZv aWQgKCpkZWFsbG9jYXRpb25fZGlkX2ZhaWxfY2FsbGJhY2spKGNvbnN0IGNoYXIqIHJlYXNvbiwg dm9pZCogYmVnaW4pOwogCiBQQVNfTk9fUkVUVVJOIFBBU19ORVZFUl9JTkxJTkUgdm9pZCBwYXNf ZGVhbGxvY2F0aW9uX2RpZF9mYWlsKGNvbnN0IGNoYXIgKnJlYXNvbiwgdWludHB0cl90IGJlZ2lu KQpkaWZmIC0tZ2l0IGEvU291cmNlL2JtYWxsb2MvbGlicGFzL3NyYy9saWJwYXMvcGFzX3V0aWxz LmggYi9Tb3VyY2UvYm1hbGxvYy9saWJwYXMvc3JjL2xpYnBhcy9wYXNfdXRpbHMuaAppbmRleCAz NTUxN2Y4MmMzYTlmMWY1NTVlY2ZmMWNjZjcyYjZhN2RmODBjZjkxLi45OGJhNzJlYWYzNmY5OTE0 Mjg1NWRkN2U3MzUzOTIwY2MzNDgzY2NhIDEwMDY0NAotLS0gYS9Tb3VyY2UvYm1hbGxvYy9saWJw YXMvc3JjL2xpYnBhcy9wYXNfdXRpbHMuaAorKysgYi9Tb3VyY2UvYm1hbGxvYy9saWJwYXMvc3Jj L2xpYnBhcy9wYXNfdXRpbHMuaApAQCAtMTYwLDYgKzE2MCw4IEBAIFBBU19CRUdJTl9FWFRFUk5f QzsKIC8qIE5PVEU6IHBhbmljIGZvcm1hdCBzdHJpbmcgbXVzdCBoYXZlIFxuIGF0IHRoZSBlbmQu ICovCiBQQVNfQVBJIFBBU19OT19SRVRVUk4gdm9pZCBwYXNfcGFuaWMoY29uc3QgY2hhciogZm9y bWF0LCAuLi4pIFBBU19GT1JNQVRfUFJJTlRGKDEsIDIpOwogCitQQVNfQVBJIFBBU19ORVZFUl9J TkxJTkUgUEFTX05PX1JFVFVSTiB2b2lkIHBhc19wYW5pY19vbl9vdXRfb2ZfbWVtb3J5X2Vycm9y KHZvaWQpOworCiAjZGVmaW5lIHBhc19zZXRfZGVhbGxvY2F0aW9uX2RpZF9mYWlsX2NhbGxiYWNr IF9fcGFzX3NldF9kZWFsbG9jYXRpb25fZGlkX2ZhaWxfY2FsbGJhY2sKICNkZWZpbmUgcGFzX3Nl dF9yZWFsbG9jYXRpb25fZGlkX2ZhaWxfY2FsbGJhY2sgX19wYXNfc2V0X3JlYWxsb2NhdGlvbl9k aWRfZmFpbF9jYWxsYmFjawogCg==