23615 2009-01-29 00:53:43 -0800 Try to make layout test timeout-release-on-close.html reliable 2009-01-30 09:07:19 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 dimich dimich ap oldest_to_newest 107484 0 dimich 2009-01-29 00:53:43 -0800 This test sometimes fails on buildbots. I could not reproduce the failure, but looking at other similar tests (Layout/fast/dom/gc-10.html) I think the following can improve it: - Use threshold when comparing the number of objects to account for objects that can be allocated by the running script itself. - Increase the number of allocated objects that should be released to make test less sensitive to other allocations. - Add debug output in case test fails to investigate further. Patch is coming. 107486 1 27140 dimich 2009-01-29 01:07:51 -0800 Created attachment 27140 Proposed patch 107487 2 27140 ap 2009-01-29 01:21:20 -0800 Comment on attachment 27140 Proposed patch r=me 107705 3 fishd 2009-01-30 09:07:19 -0800 http://trac.webkit.org/changeset/40405 27140 2009-01-29 01:07:51 -0800 2009-01-29 01:21:20 -0800 Proposed patch ltest.txt text/plain 4693 dimich SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDQwMzU3KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMDktMDEtMjkgIERtaXRyeSBUaXRvdiAgPGRp bWljaEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNjE1 CisgICAgICAgIFRyeSB0byBtYWtlIHRoaXMgdGVzdCByZWxpYWJsZSBvbiBidWlsZGJvdHMuCisK KyAgICAgICAgKiBmYXN0L2RvbS9XaW5kb3cvcmVzb3VyY2VzL2xvbmdfdGltZW91dC5odG1sOgor ICAgICAgICBBbGxvY2F0ZSBtb3JlIG9iamVjdHMgdG8gbWFrZSBkZXRlY3Rpb24gbW9yZSByZWxp YWJsZS4KKworICAgICAgICAqIGZhc3QvZG9tL1dpbmRvdy90aW1lb3V0LXJlbGVhc2VkLW9uLWNs b3NlLmh0bWw6CisgICAgICAgIFVzZSB0aHJlc2hvbGQgdG8gYWNjb3VudCBmb3Igb2JqZWN0cyBh bGxvY2F0ZWQgYnkgdGhlIHJ1bm5pbmcgc2NyaXB0cy4KKyAgICAgICAgQWRkIGRlYnVnIG91dHB1 dCBpbiBjYXNlIG9mIGZhaWx1cmUgdG8gaGVscCB1bmRlcnN0YW5kIHBvc3NpYmxlIGZhaWx1cmVz LgorCiAyMDA5LTAxLTI5ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAd2Via2l0Lm9yZz4KIAog ICAgICAgICBSZXZpZXdlZCBieSBBbmRlcnMgQ2FybHNzb24uCkluZGV4OiBMYXlvdXRUZXN0cy9m YXN0L2RvbS9XaW5kb3cvdGltZW91dC1yZWxlYXNlZC1vbi1jbG9zZS5odG1sCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL1dpbmRvdy90aW1lb3V0LXJlbGVhc2VkLW9uLWNsb3Nl Lmh0bWwJKHJldmlzaW9uIDQwMzQ1KQorKysgTGF5b3V0VGVzdHMvZmFzdC9kb20vV2luZG93L3Rp bWVvdXQtcmVsZWFzZWQtb24tY2xvc2UuaHRtbAkod29ya2luZyBjb3B5KQpAQCAtMSwzMSArMSw0 OSBAQAogPHNjcmlwdD4KLXZhciBvYmplY3RDb3VudEJlZm9yZTsKLQogLy8gVGhlIHRlc3Qgd29y a3MgYnkgZmlyc3QgbmF2aWdhdGluZyBpZnJhbWUgdG8gYSBwYWdlIHRoYXQgYWxsb2NhdGVzIGEg bG90IG9mIEpTIG9iamVjdHMKIC8vIGFuZCB0aGVuIGNyZWF0ZXMgYSBsb25nIHRpbWVvdXQuIFRo ZW4gaWZyYW1lIGlzIG5hdmlnYXRlZCB0byBhYm91dDpibGFuayBhbmQgdGhlIG51bWJlciBvZiBK UwogLy8gb2JqZWN0cyBpcyB2ZXJpZmllZCAtIHRoZXJlIHNob3VsZCBiZSBhIHNpZ25pZmljYW50 IGRyb3AgaW4gdGhlaXIgbnVtYmVyLgotZnVuY3Rpb24gc3RhcnQoKQoteworCit2YXIgb2JqZWN0 Q291bnRCZWZvcmU7CitmdW5jdGlvbiBzdGFydCgpIHsKICAgICBpZiAod2luZG93LmxheW91dFRl c3RDb250cm9sbGVyICYmIHdpbmRvdy5HQ0NvbnRyb2xsZXIpIHsKICAgICAgICAgbGF5b3V0VGVz dENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOwogICAgICAgICBsYXlvdXRUZXN0Q29udHJvbGxlci53 YWl0VW50aWxEb25lKCk7CiAgICAgICAgIHdpbmRvdy5HQ0NvbnRyb2xsZXIuY29sbGVjdCgpOwog ICAgICAgICBvYmplY3RDb3VudEJlZm9yZSA9IHdpbmRvdy5HQ0NvbnRyb2xsZXIuZ2V0SlNPYmpl Y3RDb3VudCgpOwotICAgICAgICBpZnJhbWVFbGVtZW50ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5 SWQoImlmcmFtZSIpOwotICAgICAgICBpZnJhbWVFbGVtZW50LnNldEF0dHJpYnV0ZSgib25sb2Fk IiwgInZlcmlmeSgpIik7Ci0gICAgICAgIGlmcmFtZUVsZW1lbnQuc3JjID0gImFib3V0OmJsYW5r IjsKKyAgICAgICAgdmFyIGlmcmFtZUVsZW1lbnQgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgi aWZyYW1lIik7CisgICAgICAgIGlmcmFtZUVsZW1lbnQuc2V0QXR0cmlidXRlKCJvbmxvYWQiLCAi bG9hZEJsYW5rKCkiKTsKKyAgICAgICAgaWZyYW1lRWxlbWVudC5zcmMgPSAicmVzb3VyY2VzL2xv bmdfdGltZW91dC5odG1sIjsKICAgICB9CiB9CiAKK3ZhciBvYmplY3RDb3VudEFmdGVyTG9hZDsK K2Z1bmN0aW9uIGxvYWRCbGFuaygpIHsKKyAgICB3aW5kb3cuR0NDb250cm9sbGVyLmNvbGxlY3Qo KTsKKyAgICBvYmplY3RDb3VudEFmdGVyTG9hZCA9IHdpbmRvdy5HQ0NvbnRyb2xsZXIuZ2V0SlNP YmplY3RDb3VudCgpOworICAgIHZhciBpZnJhbWVFbGVtZW50ID0gZG9jdW1lbnQuZ2V0RWxlbWVu dEJ5SWQoImlmcmFtZSIpOworICAgIGlmcmFtZUVsZW1lbnQuc2V0QXR0cmlidXRlKCJvbmxvYWQi LCAidmVyaWZ5KCkiKTsKKyAgICBpZnJhbWVFbGVtZW50LnNyYyA9ICJhYm91dDpibGFuayI7Cit9 CisKIGZ1bmN0aW9uIHZlcmlmeSgpCiB7CisJdmFyIGFsbG9jYXRlZE9iamVjdHMgPSAxMDAwOyAv LyBOdW1iZXIgb2YgYWxsb2NhdGVkIG9iamVjdHMgaW4gInJlc291cmNlcy9sb25nX3RpbWVvdXQu aHRtbCIuCisJdmFyIHRocmVzaG9sZCA9IGFsbG9jYXRlZE9iamVjdHMgLyAyOworCiAgICAgd2lu ZG93LkdDQ29udHJvbGxlci5jb2xsZWN0KCk7Ci0gICAgdmFyIGNvbGxlY3RlZE9iamVjdHNDb3Vu dCA9IG9iamVjdENvdW50QmVmb3JlIC0gd2luZG93LkdDQ29udHJvbGxlci5nZXRKU09iamVjdENv dW50KCk7Ci0gICAgLy8gbG9uZ190aW1lb3V0Lmh0bWwgYWxsb2NhdGVzIDEwMCBKUyBzdHJpbmdz LiBUaGV5IHNob3VsZCBiZSBnb25lLgotICAgIGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJyZXN1 bHQiKS5pbm5lclRleHQgPSAoY29sbGVjdGVkT2JqZWN0c0NvdW50ID49IDEwMCA/ICJQQVNTIiA6 ICJGQUlMIik7CisgICAgdmFyIG9iamVjdENvdW50QWZ0ZXIgPSB3aW5kb3cuR0NDb250cm9sbGVy LmdldEpTT2JqZWN0Q291bnQoKTsKKyAgICAvLyBTb21lIG51bWJlciBvZiBvYmplY3RzIGlzIHN0 aWxsIG5vdCByZWxlYXNlZCAocG9zc2libHkgcmVsYXRlZCB0byBleGVjdXRpb24gb2YgdGhpcyBz Y3JpcHQpLgorICAgIC8vIFVzZSBhIHRocmVzaG9sZCB3aGljaCBpcyBsZXNzIHRoZW4gdGhlIG51 bWViciBvZiBhbGxvY2F0ZWQgb2JqZWN0cyBpbiAicmVzb3VyY2VzL2xvbmdfdGltZW91dC5odG1s IiB0byBhY2NvdW50IGZvciB0aGlzLgorICAgIHZhciBzdWNjZXNzID0gKG9iamVjdENvdW50QWZ0 ZXIgLSBvYmplY3RDb3VudEJlZm9yZSkgPCB0aHJlc2hvbGQ7CisgICAgZG9jdW1lbnQuZ2V0RWxl bWVudEJ5SWQoInJlc3VsdCIpLmlubmVyVGV4dCA9IChzdWNjZXNzID8gIlBBU1MiIDogIkZBSUwi ICsKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAiLCBiZWZvcmU6ICIgKyAgb2JqZWN0Q291bnRCZWZvcmUgKworICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICIsIGFmdGVyIGxvYWQ6ICIgKyBvYmplY3RDb3VudEFmdGVyTG9hZCArCisgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIiwgYWZ0ZXI6ICIgKyBvYmplY3RDb3VudEFmdGVyKTsKICAgICBsYXlvdXRUZXN0 Q29udHJvbGxlci5ub3RpZnlEb25lKCk7CiB9CiA8L3NjcmlwdD4KKzxib2R5IG9ubG9hZD0ic3Rh cnQoKSI+CiA8cD5UaGlzIHRlc3QgdmVyaWZpZXMgdGhhdCBhbiBhY3RpdmUgdGltZW91dCB0aGF0 IGRpZG4ndCB5ZXQgZmlyZSBkb2VzIG5vdCBwcmV2ZW50IGEgRG9jdW1lbnQgZnJvbSByZWxlYXNp bmcgKGJ1ZyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjI3MTApLiBU ZXN0IGNhbiBvbmx5IHJ1biBpbiBEdW1wUmVuZGVyVHJlZSBzaW5jZSBpdCBuZWVkcyBHQ0NvbnRy b2xsZXIuIFRlc3QgaXMgc3VjY2Vzc2Z1bCBpZiBpdCBwcmludHMgJ1BBU1MnLjwvcD4KIDxkaXYg aWQ9InJlc3VsdCI+PC9kaXY+Ci08aWZyYW1lIG9ubG9hZD0ic3RhcnQoKSIgaWQ9ImlmcmFtZSIg c3JjPSJyZXNvdXJjZXMvbG9uZ190aW1lb3V0Lmh0bWwiPjwvaWZyYW1lPgorPGlmcmFtZSBpZD0i aWZyYW1lIj48L2lmcmFtZT4KKzwvYm9keT4KXCBObyBuZXdsaW5lIGF0IGVuZCBvZiBmaWxlCklu ZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2RvbS9XaW5kb3cvcmVzb3VyY2VzL2xvbmdfdGltZW91dC5o dG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2Zhc3QvZG9tL1dpbmRvdy9yZXNvdXJjZXMv bG9uZ190aW1lb3V0Lmh0bWwJKHJldmlzaW9uIDQwMzQ1KQorKysgTGF5b3V0VGVzdHMvZmFzdC9k b20vV2luZG93L3Jlc291cmNlcy9sb25nX3RpbWVvdXQuaHRtbAkod29ya2luZyBjb3B5KQpAQCAt MSw2ICsxLDYgQEAKIDxzY3JpcHQ+CiB3aW5kb3cuc3R1ZmYgPSBuZXcgQXJyYXk7Ci1mb3IgKGkg PSAwOyBpIDwgMTAwOyArK2kpCitmb3IgKGkgPSAwOyBpIDwgMTAwMDsgKytpKQogICB3aW5kb3cu c3R1ZmYucHVzaChuZXcgU3RyaW5nKCJhYmMiKSk7CiAKIHdpbmRvdy5zZXRUaW1lb3V0KGZ1bmN0 aW9uKCkgeyB9LCAxMDAwMCk7Cg==