236133 2022-02-04 03:04:35 -0800 [GTK][WPE] Use a Vector when defining the EGLImage attributes in the createImage 2022-02-04 05:53:49 -0800 1 1 1 Unclassified WebKit ANGLE WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 alex alex andresg_22 clord cmarcelo dino ews-watchlist kbr kkinnunen kondapallykalyan luiz webkit-bug-importer zdobersek oldest_to_newest 1837319 0 alex 2022-02-04 03:04:35 -0800 This was a pending improvement in the method we use to pass the attributes to the createImage method. 1837320 1 webkit-bug-importer 2022-02-04 03:04:48 -0800 <rdar://problem/88481431> 1837321 2 450882 alex 2022-02-04 03:09:51 -0800 Created attachment 450882 Patch 1837331 3 ews-feeder 2022-02-04 05:53:47 -0800 Committed r289109 (246806@main): <https://commits.webkit.org/246806@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450882. 450882 2022-02-04 03:09:51 -0800 2022-02-04 05:53:48 -0800 Patch bug-236133-20220204120949.patch text/plain 5450 alex U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5MTA3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGQ3ODQxMTQyMmM1NDFi NGViODc1OTVhMzUwMjNjY2E1MmQ1MTZlZi4uOGMyYzk5MDNlNjg5YzU1ZWVmMjIzYmY5N2E3ZDg5 OTI2NjQwMzg3YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDIyLTAyLTA0ICBBbGVq YW5kcm8gRy4gQ2FzdHJvICA8YWxleEBpZ2FsaWEuY29tPgorCisgICAgICAgIFtHVEtdW1dQRV0g VXNlIGEgVmVjdG9yIHdoZW4gZGVmaW5pbmcgdGhlIEVHTEltYWdlIGF0dHJpYnV0ZXMgaW4gdGhl IGNyZWF0ZUltYWdlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMzYxMzMKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBObyBuZXcgdGVzdHMsIG5vIGNoYW5nZSBpbiBiZWhhdmlvdXIKKworICAgICAgICAqIHBs YXRmb3JtL2dyYXBoaWNzL2VnbC9HTENvbnRleHRFR0wuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 R0xDb250ZXh0RUdMOjpjcmVhdGVJbWFnZSBjb25zdCk6IFJlcGxhY2UgdGhlIHBhcmFtZXRlcgor ICAgICAgICBvZiBjcmVhdGVJbWFnZSB3aXRoIGEgVmVjdG9yLCBhbmQgdXNlIG1hcCB0byB0cmFu c2Zvcm0gaW4gY2FzZSB3ZQorICAgICAgICBoYXZlIHRvIHVzZSB0aGUgZXh0ZW5zaW9uIGZ1bmN0 aW9uLgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2VnbC9HTENvbnRleHRFR0wuaDogRGl0 dG8uCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJQbGF0 Zm9ybUxheWVyQnVmZmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlRleHR1cmVNYXBwZXJQbGF0 Zm9ybUxheWVyQnVmZmVyOjpUZXh0dXJlTWFwcGVyUGxhdGZvcm1MYXllckJ1ZmZlcik6CisgICAg ICAgIEZpeCBhIHdhcm5pbmcgY2F1c2VkIGJ5IHRoZSBvcmRlciBvZiB0aGUgcGFyYW1ldGVyIGlu aXRpYWxpemF0aW9uLgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJl TWFwcGVyUGxhdGZvcm1MYXllckRtYWJ1Zi5jcHA6CisgICAgICAgIChXZWJDb3JlOjpUZXh0dXJl TWFwcGVyUGxhdGZvcm1MYXllckRtYWJ1Zjo6dmFsaWRhdGVUZXh0dXJlKToKKyAgICAgICAgUmVw bGFjZSB0aGUgQyBhcnJheSB3aXRoIGEgVmVjdG9yIG9iamVjdC4KKwogMjAyMi0wMi0wNCAgUGFi bG8gU2FhdmVkcmEgIDxwc2FhdmVkcmFAaWdhbGlhLmNvbT4KIAogICAgICAgICBGaXggZm9yIG5v bi11bmlmaWVkIGJ1aWxkcyBhZnRlciByMjg2ODIxICgyNDUwNTZAbWFpbikKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2VnbC9HTENvbnRleHRFR0wuY3BwIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZWdsL0dMQ29udGV4dEVHTC5jcHAKaW5k ZXggYTQ1YmE2OGIyN2JjMTlhMDNkMDI0MGY4ZTUxMDkwOGI3MWIzNjQ0Yi4uM2FjZWUwZjY1NWRj Y2M4MmJmMjczMTMwMzQ0ZjhkMDE0MzcyZTc4MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvZWdsL0dMQ29udGV4dEVHTC5jcHAKKysrIGIvU291cmNlL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvZWdsL0dMQ29udGV4dEVHTC5jcHAKQEAgLTM5OSwxOCArMzk5 LDE1IEBAIEdMQ29udGV4dEVHTDo6fkdMQ29udGV4dEVHTCgpCiAjZW5kaWYKIH0KIAotRUdMSW1h Z2UgR0xDb250ZXh0RUdMOjpjcmVhdGVJbWFnZShFR0xlbnVtIHRhcmdldCwgRUdMQ2xpZW50QnVm ZmVyIGNsaWVudEJ1ZmZlciwgY29uc3QgRUdMQXR0cmliKiBhdHRyaWJMaXN0KSBjb25zdAorRUdM SW1hZ2UgR0xDb250ZXh0RUdMOjpjcmVhdGVJbWFnZShFR0xlbnVtIHRhcmdldCwgRUdMQ2xpZW50 QnVmZmVyIGNsaWVudEJ1ZmZlciwgY29uc3QgVmVjdG9yPEVHTEF0dHJpYj4mIGF0dHJpYkxpc3Qp IGNvbnN0CiB7CiAgICAgaWYgKG1fZWdsQ3JlYXRlSW1hZ2UpCi0gICAgICAgIHJldHVybiBtX2Vn bENyZWF0ZUltYWdlKG1fZGlzcGxheS5lZ2xEaXNwbGF5KCksIGF0dHJpYkxpc3QgPyBFR0xfTk9f Q09OVEVYVCA6IG1fY29udGV4dCwgdGFyZ2V0LCBjbGllbnRCdWZmZXIsIGF0dHJpYkxpc3QpOwor ICAgICAgICByZXR1cm4gbV9lZ2xDcmVhdGVJbWFnZShtX2Rpc3BsYXkuZWdsRGlzcGxheSgpLCAh YXR0cmliTGlzdC5pc0VtcHR5KCkgPyBFR0xfTk9fQ09OVEVYVCA6IG1fY29udGV4dCwgdGFyZ2V0 LCBjbGllbnRCdWZmZXIsIGF0dHJpYkxpc3QuZGF0YSgpKTsKICAgICBpZiAobV9lZ2xDcmVhdGVJ bWFnZUtIUikgewotICAgICAgICBWZWN0b3I8RUdMaW50PiBpbnRBdHRyaWJMaXN0OwotICAgICAg ICBmb3IgKGludCBpID0gMDsgYXR0cmliTGlzdFtpXSAhPSBFR0xfTk9ORTsgaSArPSAyKSB7Ci0g ICAgICAgICAgICBpbnRBdHRyaWJMaXN0LmFwcGVuZChhdHRyaWJMaXN0W2ldKTsKLSAgICAgICAg ICAgIGludEF0dHJpYkxpc3QuYXBwZW5kKGF0dHJpYkxpc3RbaSsxXSk7Ci0gICAgICAgIH0KLSAg ICAgICAgaW50QXR0cmliTGlzdC5hcHBlbmQoRUdMX05PTkUpOwotICAgICAgICByZXR1cm4gbV9l Z2xDcmVhdGVJbWFnZUtIUihtX2Rpc3BsYXkuZWdsRGlzcGxheSgpLCBhdHRyaWJMaXN0ID8gRUdM X05PX0NPTlRFWFQgOiBtX2NvbnRleHQsIHRhcmdldCwgY2xpZW50QnVmZmVyLCBpbnRBdHRyaWJM aXN0LmRhdGEoKSk7CisgICAgICAgIGF1dG8gaW50QXR0cmliTGlzdCA9IGF0dHJpYkxpc3QubWFw PFZlY3RvcjxFR0xpbnQ+PihbXSAoRUdMQXR0cmliIHZhbHVlKSB7CisgICAgICAgICAgICByZXR1 cm4gdmFsdWU7CisgICAgICAgIH0pOworICAgICAgICByZXR1cm4gbV9lZ2xDcmVhdGVJbWFnZUtI UihtX2Rpc3BsYXkuZWdsRGlzcGxheSgpLCAhYXR0cmliTGlzdC5pc0VtcHR5KCkgPyBFR0xfTk9f Q09OVEVYVCA6IG1fY29udGV4dCwgdGFyZ2V0LCBjbGllbnRCdWZmZXIsIGludEF0dHJpYkxpc3Qu ZGF0YSgpKTsKICAgICB9CiAgICAgcmV0dXJuIEVHTF9OT19JTUFHRTsKIH0KZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2VnbC9HTENvbnRleHRFR0wuaCBiL1Nv dXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2VnbC9HTENvbnRleHRFR0wuaAppbmRleCBm NWYzODk1NjBhMGEwMDI2M2Q3YjA3OTlhMDIxYTZlMjgwY2MwNTFhLi4zYzNhM2Q3ZjA1NzczYWRl YzBjNmNkODcxZWZiYTRkNmRiMzVjNjQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0 Zm9ybS9ncmFwaGljcy9lZ2wvR0xDb250ZXh0RUdMLmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvZWdsL0dMQ29udGV4dEVHTC5oCkBAIC03Myw3ICs3Myw3IEBAIHB1Ymxp YzoKICAgICBzdGF0aWMgY29uc3QgY2hhciogbGFzdEVycm9yU3RyaW5nKCk7CiAKICAgICBFR0xD b25maWcgY29uZmlnKCkgY29uc3QgeyByZXR1cm4gbV9jb25maWc7IH0KLSAgICBFR0xJbWFnZSBj cmVhdGVJbWFnZShFR0xlbnVtIHRhcmdldCwgRUdMQ2xpZW50QnVmZmVyLCBjb25zdCBFR0xBdHRy aWIqKSBjb25zdDsKKyAgICBFR0xJbWFnZSBjcmVhdGVJbWFnZShFR0xlbnVtIHRhcmdldCwgRUdM Q2xpZW50QnVmZmVyLCBjb25zdCBWZWN0b3I8RUdMQXR0cmliPiYpIGNvbnN0OwogICAgIGJvb2wg ZGVzdHJveUltYWdlKEVHTEltYWdlKSBjb25zdDsKIAogICAgIHZpcnR1YWwgfkdMQ29udGV4dEVH TCgpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFw L1RleHR1cmVNYXBwZXJQbGF0Zm9ybUxheWVyQnVmZmVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Bs YXRmb3JtL2dyYXBoaWNzL3RleG1hcC9UZXh0dXJlTWFwcGVyUGxhdGZvcm1MYXllckJ1ZmZlci5j cHAKaW5kZXggYmQ1ZWRiOTY0Y2M4OTU2MTU2ZTBmMGFlNjQyYWM3MzY1YjQ2MmNiMi4uNTBiMGI3 NTRhM2IyZmQ2MDdiZDEwNTdiNTEwMzgxZTI0YjI4N2I0YyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJQbGF0Zm9ybUxheWVy QnVmZmVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAv VGV4dHVyZU1hcHBlclBsYXRmb3JtTGF5ZXJCdWZmZXIuY3BwCkBAIC0zNCw4ICszNCw4IEBACiBu YW1lc3BhY2UgV2ViQ29yZSB7CiAKIFRleHR1cmVNYXBwZXJQbGF0Zm9ybUxheWVyQnVmZmVyOjpU ZXh0dXJlTWFwcGVyUGxhdGZvcm1MYXllckJ1ZmZlcihSZWZQdHI8Qml0bWFwVGV4dHVyZT4mJiB0 ZXh0dXJlLCBUZXh0dXJlTWFwcGVyR0w6OkZsYWdzIGZsYWdzKQotICAgIDogbV90ZXh0dXJlKFdU Rk1vdmUodGV4dHVyZSkpCi0gICAgLCBtX3ZhcmlhbnQoUkdCVGV4dHVyZSB7IDAgfSkKKyAgICA6 IG1fdmFyaWFudChSR0JUZXh0dXJlIHsgMCB9KQorICAgICwgbV90ZXh0dXJlKFdURk1vdmUodGV4 dHVyZSkpCiAgICAgLCBtX2V4dHJhRmxhZ3MoZmxhZ3MpCiAgICAgLCBtX2hhc01hbmFnZWRUZXh0 dXJlKHRydWUpCiB7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy90ZXhtYXAvVGV4dHVyZU1hcHBlclBsYXRmb3JtTGF5ZXJEbWFidWYuY3BwIGIvU291cmNlL1dl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvdGV4bWFwL1RleHR1cmVNYXBwZXJQbGF0Zm9ybUxheWVy RG1hYnVmLmNwcAppbmRleCBjMDhjNDhjNTc2ZGNmZDlhNWU4YmU1ZmQ5MjJiZGVjMzBjN2ZhM2Mx Li5lMzVhNjU0NmU1NzFkNThmNGE1YTllN2Q1ZWE3MjZhMmRlN2FiZTA4IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy90ZXhtYXAvVGV4dHVyZU1hcHBlclBsYXRm b3JtTGF5ZXJEbWFidWYuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L3RleG1hcC9UZXh0dXJlTWFwcGVyUGxhdGZvcm1MYXllckRtYWJ1Zi5jcHAKQEAgLTg5LDcgKzg5 LDcgQEAgdm9pZCBUZXh0dXJlTWFwcGVyUGxhdGZvcm1MYXllckRtYWJ1Zjo6dmFsaWRhdGVUZXh0 dXJlKCkKICAgICBjb250ZXh0LT5tYWtlQ29udGV4dEN1cnJlbnQoKTsKIAogICAgIGF1dG8gc2l6 ZSA9IFRleHR1cmVNYXBwZXJQbGF0Zm9ybUxheWVyQnVmZmVyOjpzaXplKCk7Ci0gICAgRUdMQXR0 cmliIGltYWdlQXR0cmlidXRlc1tdID0geworICAgIFZlY3RvcjxFR0xBdHRyaWI+IGltYWdlQXR0 cmlidXRlcyB7CiAgICAgICAgIEVHTF9XSURUSCwgc2l6ZS53aWR0aCgpLAogICAgICAgICBFR0xf SEVJR0hULCBzaXplLmhlaWdodCgpLAogICAgICAgICBFR0xfTElOVVhfRFJNX0ZPVVJDQ19FWFQs IHN0YXRpY19jYXN0PEVHTEF0dHJpYj4obV9mb3JtYXQpLAo=