236129 2022-02-04 00:07:02 -0800 Fix for non-unified builds after r286821 (245056@main) 2022-02-04 00:17:15 -0800 1 1 1 Unclassified WebKit WebCore Misc. WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 psaavedra psaavedra webkit-bug-importer oldest_to_newest 1837291 0 psaavedra 2022-02-04 00:07:02 -0800 SSIA Error: In file included from /home/bot/workspace/sources/wpewebkit/Source/WebCore/workers/shared/SharedWorkerScriptLoader.cpp:27: /home/bot/workspace/sources/wpewebkit/Source/WebCore/workers/shared/SharedWorkerScriptLoader.h:51:5: error: 'SharedWorkerScriptLoaderIdentifier' does not name a type; did you mean 'SharedWorkerScriptLoader'? 51 | SharedWorkerScriptLoaderIdentifier identifier() const { return m_identifier; } | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | SharedWorkerScriptLoader /home/bot/workspace/sources/wpewebkit/Source/WebCore/workers/shared/SharedWorkerScriptLoader.h:60:11: error: 'SharedWorkerScriptLoaderIdentifier' does not name a type; did you mean 'SharedWorkerScriptLoader'? 60 | const SharedWorkerScriptLoaderIdentifier m_identifier; | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | SharedWorkerScriptLoader /home/bot/workspace/sources/wpewebkit/Source/WebCore/workers/shared/SharedWorkerScriptLoader.cpp: In constructor 'WebCore::SharedWorkerScriptLoader::SharedWorkerScriptLoader(const WTF::URL&, WebCore::SharedWorker&, WebCore::TransferredMessagePort&&, WebCore::WorkerOptions&&)': /home/bot/workspace/sources/wpewebkit/Source/WebCore/workers/shared/SharedWorkerScriptLoader.cpp:39:7: error: class 'WebCore::SharedWorkerScriptLoader' does not have any field named 'm_identifier' 39 | : m_identifier(SharedWorkerScriptLoaderIdentifier::generate()) | ^~~~~~~~~~~~ 1837292 1 450879 psaavedra 2022-02-04 00:09:42 -0800 Created attachment 450879 patch 1837293 2 ews-feeder 2022-02-04 00:10:23 -0800 psaavedra@igalia.com does not have reviewer permissions according to https://raw.githubusercontent.com/WebKit/WebKit/main/metadata/contributors.json. Rejecting attachment 450879 from commit queue. 1837294 3 psaavedra 2022-02-04 00:14:18 -0800 Committed r289107 (246804@trunk): <https://commits.webkit.org/246804@trunk> 1837295 4 webkit-bug-importer 2022-02-04 00:15:18 -0800 <rdar://problem/88477288> 1837296 5 psaavedra 2022-02-04 00:17:15 -0800 Just for reference, landed as unreviewed patch for the sake of simplicity . 450879 2022-02-04 00:09:42 -0800 2022-02-04 00:15:06 -0800 patch bug-236129-20220204090940.patch text/plain 1293 psaavedra U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5MTA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggOWEyNGNkNDRlNzIyYzBk MTdkZGU2OGRkNjY2ZGZkZTNkMDUwYTM2YS4uZGQ3ODQxMTQyMmM1NDFiNGViODc1OTVhMzUwMjNj Y2E1MmQ1MTZlZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDIyLTAyLTA0ICBQYWJs byBTYWF2ZWRyYSAgPHBzYWF2ZWRyYUBpZ2FsaWEuY29tPgorCisgICAgICAgIEZpeCBmb3Igbm9u LXVuaWZpZWQgYnVpbGRzIGFmdGVyIHIyODY4MjEgKDI0NTA1NkBtYWluKQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM2MTI5CisKKyAgICAgICAgVW5y ZXZpZXdlZCwgZml4ZXMgbWlzc2luZyBoZWFkZXIuCisKKyAgICAgICAgKiB3b3JrZXJzL3NoYXJl ZC9TaGFyZWRXb3JrZXJTY3JpcHRMb2FkZXIuaDoKKwogMjAyMi0wMi0wMyAgQ2hyaXMgTG9yZCAg PGNsb3JkQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS11bV1BFXSBVc2UgZG1hYnVmIHdoZW4g cG9zc2libGUgdG8gdHJhbnNmZXIgQU5HTEUgcmVuZGVyaW5nIHRvIHRoZSBjb21wb3NpdG9yCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS93b3JrZXJzL3NoYXJlZC9TaGFyZWRXb3JrZXJTY3Jp cHRMb2FkZXIuaCBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvc2hhcmVkL1NoYXJlZFdvcmtlclNj cmlwdExvYWRlci5oCmluZGV4IGFiMzA5YTFjZWZiNjc1NGYzMWJjYWJiNWY4YjA3YTRiYzYwYmFh MzguLmFlNWIzYmI5ZWM1MjA3NDUzM2VmZDg0MDkyY2VlYTk5OWYyMDE3OTkgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvc2hhcmVkL1NoYXJlZFdvcmtlclNjcmlwdExvYWRlci5o CisrKyBiL1NvdXJjZS9XZWJDb3JlL3dvcmtlcnMvc2hhcmVkL1NoYXJlZFdvcmtlclNjcmlwdExv YWRlci5oCkBAIC0yOSw2ICsyOSw3IEBACiAjaW5jbHVkZSAiTWVzc2FnZVBvcnRJZGVudGlmaWVy LmgiCiAjaW5jbHVkZSAiUmVzb3VyY2VMb2FkZXJJZGVudGlmaWVyLmgiCiAjaW5jbHVkZSAiUmVz b3VyY2VSZXNwb25zZS5oIgorI2luY2x1ZGUgIlNoYXJlZFdvcmtlck1hbmFnZXIuaCIKICNpbmNs dWRlICJXb3JrZXJPcHRpb25zLmgiCiAjaW5jbHVkZSAiV29ya2VyU2NyaXB0TG9hZGVyQ2xpZW50 LmgiCiAjaW5jbHVkZSA8d3RmL09iamVjdElkZW50aWZpZXIuaD4K