236112 2022-02-03 17:53:54 -0800 Add pen type for HitTestRequest. 2022-02-03 19:16:18 -0800 1 1 1 Unclassified WebKit New Bugs WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 megan_gardner megan_gardner changseok esprehn+autocc ews-watchlist glenn kondapallykalyan pdr thorton webkit-bug-importer oldest_to_newest 1837188 0 megan_gardner 2022-02-03 17:53:54 -0800 Add pen type for HitTestRequest. 1837189 1 450842 megan_gardner 2022-02-03 17:54:46 -0800 Created attachment 450842 Patch 1837190 2 450842 thorton 2022-02-03 17:55:14 -0800 Comment on attachment 450842 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450842&action=review > Source/WebCore/rendering/HitTestRequest.h:52 > + PenEvent = 1 << 15, Not sure why you're re-using a bit. 1837191 3 450842 thorton 2022-02-03 17:56:27 -0800 Comment on attachment 450842 Patch Also, not sure this should be landed separate from code that propagates it from the event, since as it stands this is untestable and zero-impact. 1837192 4 450843 megan_gardner 2022-02-03 17:57:17 -0800 Created attachment 450843 Patch 1837212 5 450849 megan_gardner 2022-02-03 18:33:16 -0800 Created attachment 450849 Patch for landing 1837222 6 ews-feeder 2022-02-03 19:15:04 -0800 Committed r289102 (246799@main): <https://commits.webkit.org/246799@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450849. 1837223 7 webkit-bug-importer 2022-02-03 19:16:18 -0800 <rdar://problem/88469338> 450842 2022-02-03 17:54:46 -0800 2022-02-03 17:57:15 -0800 Patch bug-236112-20220203175445.patch text/plain 2278 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5MDkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmI0OWVmZWUxMzcwMTJh NGVkODE1NzZmYmZhOWNiNmI2ODUzOTZlNy4uOGRjNGFhYzg4N2YwODI1ZjA0NjIxNzk0MDQ4YjRl MTI1NDllMjY2NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIyLTAyLTAzICBNZWdh biBHYXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIHBlbiB0 eXBlIGZvciBIaXRUZXN0UmVxdWVzdC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIzNjExMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogcmVuZGVyaW5nL0hpdFRlc3RSZXF1ZXN0Lmg6CisgICAgICAgIChX ZWJDb3JlOjpIaXRUZXN0UmVxdWVzdDo6bW91c2VFdmVudCBjb25zdCk6CisgICAgICAgIChXZWJD b3JlOjpIaXRUZXN0UmVxdWVzdDo6cGVuRXZlbnQgY29uc3QpOgorCiAyMDIyLTAyLTAzICBNaWNo YWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYktpdCBwcm9qZWN0 cyBoYXZlIGluY29ycmVjdCBpbnN0YWxsIG5hbWUgZm9yIHRoZSBmcmFtZXdvcmtzIGZvciBDYXRh bHlzdCBidWlsZHMgd2l0aCB0aGUgc3lzdGVtIGNvbnRlbnQgcGF0aApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0hpdFRlc3RSZXF1ZXN0LmggYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvSGl0VGVzdFJlcXVlc3QuaAppbmRleCBhM2JmMjA1YzBkNDE1YWZhNjZmMGIzYjk1 MjgyMDQ2ZmU2ODUzMmM4Li43NjkwMTE0OTlhMDE0YzliYjAyOGNkMTQ2ZjBlMWUyZWRjMDViYWM1 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvSGl0VGVzdFJlcXVlc3QuaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvSGl0VGVzdFJlcXVlc3QuaApAQCAtNDksNiAr NDksNyBAQCBwdWJsaWM6CiAgICAgICAgIENvbGxlY3RNdWx0aXBsZUVsZW1lbnRzID0gMSA8PCAx NSwKICAgICAgICAgLy8gV2hlbiB1c2luZyBsaXN0LWJhc2VkIHRlc3RpbmcsIGNvbnRpbnVlIGhp dCB0ZXN0aW5nIGV2ZW4gYWZ0ZXIgYSBoaXQgaGFzIGJlZW4gZm91bmQuCiAgICAgICAgIEluY2x1 ZGVBbGxFbGVtZW50c1VuZGVyUG9pbnQgPSAxIDw8IDE2LAorICAgICAgICBQZW5FdmVudCA9IDEg PDwgMTUsCiAgICAgfTsKIAogICAgIEhpdFRlc3RSZXF1ZXN0KE9wdGlvblNldDxUeXBlPiB0eXBl ID0geyBUeXBlOjpSZWFkT25seSwgVHlwZTo6QWN0aXZlLCBUeXBlOjpEaXNhbGxvd1VzZXJBZ2Vu dFNoYWRvd0NvbnRlbnQgfSkKQEAgLTY2LDcgKzY3LDggQEAgcHVibGljOgogICAgIGJvb2wgaWdu b3JlQ2xpcHBpbmcoKSBjb25zdCB7IHJldHVybiBtX3R5cGUuY29udGFpbnMoVHlwZTo6SWdub3Jl Q2xpcHBpbmcpOyB9CiAgICAgYm9vbCBzdmdDbGlwQ29udGVudCgpIGNvbnN0IHsgcmV0dXJuIG1f dHlwZS5jb250YWlucyhUeXBlOjpTVkdDbGlwQ29udGVudCk7IH0KICAgICBib29sIHRvdWNoRXZl bnQoKSBjb25zdCB7IHJldHVybiBtX3R5cGUuY29udGFpbnMoVHlwZTo6VG91Y2hFdmVudCk7IH0K LSAgICBib29sIG1vdXNlRXZlbnQoKSBjb25zdCB7IHJldHVybiAhdG91Y2hFdmVudCgpOyB9Cisg ICAgYm9vbCBtb3VzZUV2ZW50KCkgY29uc3QgeyByZXR1cm4gIXRvdWNoRXZlbnQoKSAmJiAhcGVu RXZlbnQoKTsgfQorICAgIGJvb2wgcGVuRXZlbnQoKSBjb25zdCB7IHJldHVybiBtX3R5cGUuY29u dGFpbnMoVHlwZTo6UGVuRXZlbnQpOyB9CiAgICAgYm9vbCBkaXNhbGxvd3NVc2VyQWdlbnRTaGFk b3dDb250ZW50KCkgY29uc3QgeyByZXR1cm4gbV90eXBlLmNvbnRhaW5zKFR5cGU6OkRpc2FsbG93 VXNlckFnZW50U2hhZG93Q29udGVudCk7IH0KICAgICBib29sIGRpc2FsbG93c1VzZXJBZ2VudFNo YWRvd0NvbnRlbnRFeGNlcHRGb3JJbWFnZU92ZXJsYXlzKCkgY29uc3QgeyByZXR1cm4gbV90eXBl LmNvbnRhaW5zKFR5cGU6OkRpc2FsbG93VXNlckFnZW50U2hhZG93Q29udGVudEV4Y2VwdEZvcklt YWdlT3ZlcmxheXMpOyB9CiAgICAgYm9vbCBhbGxvd3NGcmFtZVNjcm9sbGJhcnMoKSBjb25zdCB7 IHJldHVybiBtX3R5cGUuY29udGFpbnMoVHlwZTo6QWxsb3dGcmFtZVNjcm9sbGJhcnMpOyB9Cg== 450843 2022-02-03 17:57:17 -0800 2022-02-03 18:33:13 -0800 Patch bug-236112-20220203175716.patch text/plain 2278 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5MDkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmI0OWVmZWUxMzcwMTJh NGVkODE1NzZmYmZhOWNiNmI2ODUzOTZlNy4uOGRjNGFhYzg4N2YwODI1ZjA0NjIxNzk0MDQ4YjRl MTI1NDllMjY2NCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIyLTAyLTAzICBNZWdh biBHYXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIHBlbiB0 eXBlIGZvciBIaXRUZXN0UmVxdWVzdC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIzNjExMgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgICogcmVuZGVyaW5nL0hpdFRlc3RSZXF1ZXN0Lmg6CisgICAgICAgIChX ZWJDb3JlOjpIaXRUZXN0UmVxdWVzdDo6bW91c2VFdmVudCBjb25zdCk6CisgICAgICAgIChXZWJD b3JlOjpIaXRUZXN0UmVxdWVzdDo6cGVuRXZlbnQgY29uc3QpOgorCiAyMDIyLTAyLTAzICBNaWNo YWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgogCiAgICAgICAgIFdlYktpdCBwcm9qZWN0 cyBoYXZlIGluY29ycmVjdCBpbnN0YWxsIG5hbWUgZm9yIHRoZSBmcmFtZXdvcmtzIGZvciBDYXRh bHlzdCBidWlsZHMgd2l0aCB0aGUgc3lzdGVtIGNvbnRlbnQgcGF0aApkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL0hpdFRlc3RSZXF1ZXN0LmggYi9Tb3VyY2UvV2ViQ29yZS9y ZW5kZXJpbmcvSGl0VGVzdFJlcXVlc3QuaAppbmRleCBhM2JmMjA1YzBkNDE1YWZhNjZmMGIzYjk1 MjgyMDQ2ZmU2ODUzMmM4Li4zZGZkNmQzZmRkYjgyZjllZTVlMWJiMWJiY2E2MTJkNzY1MzBkODA1 IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvSGl0VGVzdFJlcXVlc3QuaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvSGl0VGVzdFJlcXVlc3QuaApAQCAtNDksNiAr NDksNyBAQCBwdWJsaWM6CiAgICAgICAgIENvbGxlY3RNdWx0aXBsZUVsZW1lbnRzID0gMSA8PCAx NSwKICAgICAgICAgLy8gV2hlbiB1c2luZyBsaXN0LWJhc2VkIHRlc3RpbmcsIGNvbnRpbnVlIGhp dCB0ZXN0aW5nIGV2ZW4gYWZ0ZXIgYSBoaXQgaGFzIGJlZW4gZm91bmQuCiAgICAgICAgIEluY2x1 ZGVBbGxFbGVtZW50c1VuZGVyUG9pbnQgPSAxIDw8IDE2LAorICAgICAgICBQZW5FdmVudCA9IDEg PDwgMTcsCiAgICAgfTsKIAogICAgIEhpdFRlc3RSZXF1ZXN0KE9wdGlvblNldDxUeXBlPiB0eXBl ID0geyBUeXBlOjpSZWFkT25seSwgVHlwZTo6QWN0aXZlLCBUeXBlOjpEaXNhbGxvd1VzZXJBZ2Vu dFNoYWRvd0NvbnRlbnQgfSkKQEAgLTY2LDcgKzY3LDggQEAgcHVibGljOgogICAgIGJvb2wgaWdu b3JlQ2xpcHBpbmcoKSBjb25zdCB7IHJldHVybiBtX3R5cGUuY29udGFpbnMoVHlwZTo6SWdub3Jl Q2xpcHBpbmcpOyB9CiAgICAgYm9vbCBzdmdDbGlwQ29udGVudCgpIGNvbnN0IHsgcmV0dXJuIG1f dHlwZS5jb250YWlucyhUeXBlOjpTVkdDbGlwQ29udGVudCk7IH0KICAgICBib29sIHRvdWNoRXZl bnQoKSBjb25zdCB7IHJldHVybiBtX3R5cGUuY29udGFpbnMoVHlwZTo6VG91Y2hFdmVudCk7IH0K LSAgICBib29sIG1vdXNlRXZlbnQoKSBjb25zdCB7IHJldHVybiAhdG91Y2hFdmVudCgpOyB9Cisg ICAgYm9vbCBtb3VzZUV2ZW50KCkgY29uc3QgeyByZXR1cm4gIXRvdWNoRXZlbnQoKSAmJiAhcGVu RXZlbnQoKTsgfQorICAgIGJvb2wgcGVuRXZlbnQoKSBjb25zdCB7IHJldHVybiBtX3R5cGUuY29u dGFpbnMoVHlwZTo6UGVuRXZlbnQpOyB9CiAgICAgYm9vbCBkaXNhbGxvd3NVc2VyQWdlbnRTaGFk b3dDb250ZW50KCkgY29uc3QgeyByZXR1cm4gbV90eXBlLmNvbnRhaW5zKFR5cGU6OkRpc2FsbG93 VXNlckFnZW50U2hhZG93Q29udGVudCk7IH0KICAgICBib29sIGRpc2FsbG93c1VzZXJBZ2VudFNo YWRvd0NvbnRlbnRFeGNlcHRGb3JJbWFnZU92ZXJsYXlzKCkgY29uc3QgeyByZXR1cm4gbV90eXBl LmNvbnRhaW5zKFR5cGU6OkRpc2FsbG93VXNlckFnZW50U2hhZG93Q29udGVudEV4Y2VwdEZvcklt YWdlT3ZlcmxheXMpOyB9CiAgICAgYm9vbCBhbGxvd3NGcmFtZVNjcm9sbGJhcnMoKSBjb25zdCB7 IHJldHVybiBtX3R5cGUuY29udGFpbnMoVHlwZTo6QWxsb3dGcmFtZVNjcm9sbGJhcnMpOyB9Cg== 450849 2022-02-03 18:33:16 -0800 2022-02-03 19:15:05 -0800 Patch for landing bug-236112-20220203183315.patch text/plain 2274 megan_gardner U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5MDkzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNmI0OWVmZWUxMzcwMTJh NGVkODE1NzZmYmZhOWNiNmI2ODUzOTZlNy4uNThhYTU2OTI0M2FiM2Q3ZjllOTdiY2YyZmI0NWY5 YjA3MjNmNjMxYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDIyLTAyLTAzICBNZWdh biBHYXJkbmVyICA8bWVnYW5fZ2FyZG5lckBhcHBsZS5jb20+CisKKyAgICAgICAgQWRkIHBlbiB0 eXBlIGZvciBIaXRUZXN0UmVxdWVzdC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTIzNjExMgorCisgICAgICAgIFJldmlld2VkIGJ5IFRpbSBIb3J0b24u CisKKyAgICAgICAgKiByZW5kZXJpbmcvSGl0VGVzdFJlcXVlc3QuaDoKKyAgICAgICAgKFdlYkNv cmU6OkhpdFRlc3RSZXF1ZXN0Ojptb3VzZUV2ZW50IGNvbnN0KToKKyAgICAgICAgKFdlYkNvcmU6 OkhpdFRlc3RSZXF1ZXN0OjpwZW5FdmVudCBjb25zdCk6CisKIDIwMjItMDItMDMgIE1pY2hhZWwg U2Fib2ZmICA8bXNhYm9mZkBhcHBsZS5jb20+CiAKICAgICAgICAgV2ViS2l0IHByb2plY3RzIGhh dmUgaW5jb3JyZWN0IGluc3RhbGwgbmFtZSBmb3IgdGhlIGZyYW1ld29ya3MgZm9yIENhdGFseXN0 IGJ1aWxkcyB3aXRoIHRoZSBzeXN0ZW0gY29udGVudCBwYXRoCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9yZW5kZXJpbmcvSGl0VGVzdFJlcXVlc3QuaCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRl cmluZy9IaXRUZXN0UmVxdWVzdC5oCmluZGV4IGEzYmYyMDVjMGQ0MTVhZmE2NmYwYjNiOTUyODIw NDZmZTY4NTMyYzguLjNkZmQ2ZDNmZGRiODJmOWVlNWUxYmIxYmJjYTYxMmQ3NjUzMGQ4MDUgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9IaXRUZXN0UmVxdWVzdC5oCisrKyBi L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9IaXRUZXN0UmVxdWVzdC5oCkBAIC00OSw2ICs0OSw3 IEBAIHB1YmxpYzoKICAgICAgICAgQ29sbGVjdE11bHRpcGxlRWxlbWVudHMgPSAxIDw8IDE1LAog ICAgICAgICAvLyBXaGVuIHVzaW5nIGxpc3QtYmFzZWQgdGVzdGluZywgY29udGludWUgaGl0IHRl c3RpbmcgZXZlbiBhZnRlciBhIGhpdCBoYXMgYmVlbiBmb3VuZC4KICAgICAgICAgSW5jbHVkZUFs bEVsZW1lbnRzVW5kZXJQb2ludCA9IDEgPDwgMTYsCisgICAgICAgIFBlbkV2ZW50ID0gMSA8PCAx NywKICAgICB9OwogCiAgICAgSGl0VGVzdFJlcXVlc3QoT3B0aW9uU2V0PFR5cGU+IHR5cGUgPSB7 IFR5cGU6OlJlYWRPbmx5LCBUeXBlOjpBY3RpdmUsIFR5cGU6OkRpc2FsbG93VXNlckFnZW50U2hh ZG93Q29udGVudCB9KQpAQCAtNjYsNyArNjcsOCBAQCBwdWJsaWM6CiAgICAgYm9vbCBpZ25vcmVD bGlwcGluZygpIGNvbnN0IHsgcmV0dXJuIG1fdHlwZS5jb250YWlucyhUeXBlOjpJZ25vcmVDbGlw cGluZyk7IH0KICAgICBib29sIHN2Z0NsaXBDb250ZW50KCkgY29uc3QgeyByZXR1cm4gbV90eXBl LmNvbnRhaW5zKFR5cGU6OlNWR0NsaXBDb250ZW50KTsgfQogICAgIGJvb2wgdG91Y2hFdmVudCgp IGNvbnN0IHsgcmV0dXJuIG1fdHlwZS5jb250YWlucyhUeXBlOjpUb3VjaEV2ZW50KTsgfQotICAg IGJvb2wgbW91c2VFdmVudCgpIGNvbnN0IHsgcmV0dXJuICF0b3VjaEV2ZW50KCk7IH0KKyAgICBi b29sIG1vdXNlRXZlbnQoKSBjb25zdCB7IHJldHVybiAhdG91Y2hFdmVudCgpICYmICFwZW5FdmVu dCgpOyB9CisgICAgYm9vbCBwZW5FdmVudCgpIGNvbnN0IHsgcmV0dXJuIG1fdHlwZS5jb250YWlu cyhUeXBlOjpQZW5FdmVudCk7IH0KICAgICBib29sIGRpc2FsbG93c1VzZXJBZ2VudFNoYWRvd0Nv bnRlbnQoKSBjb25zdCB7IHJldHVybiBtX3R5cGUuY29udGFpbnMoVHlwZTo6RGlzYWxsb3dVc2Vy QWdlbnRTaGFkb3dDb250ZW50KTsgfQogICAgIGJvb2wgZGlzYWxsb3dzVXNlckFnZW50U2hhZG93 Q29udGVudEV4Y2VwdEZvckltYWdlT3ZlcmxheXMoKSBjb25zdCB7IHJldHVybiBtX3R5cGUuY29u dGFpbnMoVHlwZTo6RGlzYWxsb3dVc2VyQWdlbnRTaGFkb3dDb250ZW50RXhjZXB0Rm9ySW1hZ2VP dmVybGF5cyk7IH0KICAgICBib29sIGFsbG93c0ZyYW1lU2Nyb2xsYmFycygpIGNvbnN0IHsgcmV0 dXJuIG1fdHlwZS5jb250YWlucyhUeXBlOjpBbGxvd0ZyYW1lU2Nyb2xsYmFycyk7IH0K