23609 2009-01-28 20:16:25 -0800 Do not append trailing slash to urls with no path for KURL::parse 2009-01-29 06:40:06 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Other All RESOLVED FIXED P2 Normal --- 1 manyoso webkit-unassigned ap darin staikos zimmermann oldest_to_newest 107451 0 manyoso 2009-01-28 20:16:25 -0800 The KURL class has recently been changed in revision r40242 to assert in the KURL single argument constructors when the string passed in does not match the result of the parse. The theory is that KURL::parse method should be idempotent. However, the KURL::parse method appends a trailing slash to a perfectly valid URL that has no path. This results in triggering the ASSERT in KURL ctor by passing in a string of "http://google.com" for instance. Looking at the history it seems KURL has been adding this trailing slash since WebKit was originally created from KHTML. With this history I am not sure the right thing to do is to remove this appending of the trailing slash, but if the assert is to stay then this is what is required. 107452 1 27136 manyoso 2009-01-28 20:17:30 -0800 Created attachment 27136 Do not append trailing slash in parse Remove the append of the trailing slash. 107453 2 manyoso 2009-01-28 20:19:54 -0800 The other option is to remove or edit the assert to take into account the trailing slash I suppose. 107461 3 ap 2009-01-28 22:40:38 -0800 Where is the single argument constructor called from? If it's called with a string that is not already an output of KURL::parse algorithm, then it is likely that an arbitrary string can be passed via this code path, so a two-argument constructor should be used. This assertion usually fires on seemingly innocuous things like this one, but uncovers real bugs at call sites nonetheless. 107462 4 27136 ap 2009-01-28 22:43:07 -0800 Comment on attachment 27136 Do not append trailing slash in parse Marking r- for now, because it's more likely to be a bug at call site. 107516 5 manyoso 2009-01-29 05:50:48 -0800 It is being called from KURLQt.cpp for the QUrl conversion constructor. Perhaps I should add a special new constructor to KURL for usage by PLATFORM(QT) that will forgo the parsing entirely since QUrl already accomplishes this? 107519 6 ap 2009-01-29 06:23:30 -0800 For posterity: as discussed on IRC, I think that if any constructor were to expect QUrl output to be properly encoded, then KURL::parse should be replaced with an appropriate QUrl method to avoid surprises during re-parsing. For now, it's probably best to just use two-argument KURL constructor with a null base. 107520 7 27148 manyoso 2009-01-29 06:24:52 -0800 Created attachment 27148 Makes KURLQt.cpp use two-arg ctor After discussion with ap it was determined that KURLQt should use the two-arg ctor for implicit conversion of QUrl to KURL. 107521 8 27148 ap 2009-01-29 06:26:49 -0800 Comment on attachment 27148 Makes KURLQt.cpp use two-arg ctor r=me 107522 9 manyoso 2009-01-29 06:40:06 -0800 Fixed with r40362. 27136 2009-01-28 20:17:30 -0800 2009-01-28 22:43:07 -0800 Do not append trailing slash in parse noappendslash.patch text/plain 1472 manyoso ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YTJhOTBmOC4uMWE3YjMzZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsNSArMSwxNyBAQAogMjAwOS0wMS0yOCAgQWRhbSBUcmVhdCAg PGFkYW0udHJlYXRAdG9yY2htb2JpbGUuY29tPgogCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFRoZSBLVVJMOjpwYXJzZSBtZXRob2QgaXMgaW50ZW5kZWQg dG8gYmUgaWRlbXBvdGVudCBhbmQgYXMgc3VjaCB3ZSBjYW4KKyAgICAgICAgbm90IGNvbnRpbnVl IHRvIGFkZCBhIHRyYWlsaW5nIHNsYXNoIHRvIGEgdXJsIHdpdGggbm8gcGF0aCBvdGhlcndpc2UK KyAgICAgICAgd2UgdHJpZ2dlciB0aGUgbmV3IGFzc2VydCBpbiBLVVJMIHNpbmdsZSBhcmd1bWVu dCBjb25zdHJ1Y3RvcnMgYnkgcGFzc2luZworICAgICAgICBodHRwOi8vd3d3Lmdvb2dsZS5jb20g Zm9yIGluc3RhbmNlLgorCisgICAgICAgICogcGxhdGZvcm0vS1VSTC5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpLVVJMOjpwYXJzZSk6CisKKzIwMDktMDEtMjggIEFkYW0gVHJlYXQgIDxhZGFtLnRy ZWF0QHRvcmNobW9iaWxlLmNvbT4KKwogICAgICAgICBSZXZpZXdlZCBieSBOaWtvbGFzIFppbW1l cm1hbm4gYW5kIEdlb3JnZSBTdGFpa29zLgogCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0yMzU1NwpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9L VVJMLmNwcCBiL1dlYkNvcmUvcGxhdGZvcm0vS1VSTC5jcHAKaW5kZXggNmZjYjliOS4uMjYyMDNh OCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9LVVJMLmNwcAorKysgYi9XZWJDb3JlL3Bs YXRmb3JtL0tVUkwuY3BwCkBAIC0xMjUxLDExICsxMjUxLDYgQEAgdm9pZCBLVVJMOjpwYXJzZShj b25zdCBjaGFyKiB1cmwsIGNvbnN0IFN0cmluZyogb3JpZ2luYWxTdHJpbmcpCiAgICAgfSBlbHNl CiAgICAgICAgIG1fdXNlclN0YXJ0ID0gbV91c2VyRW5kID0gbV9wYXNzd29yZEVuZCA9IG1faG9z dEVuZCA9IG1fcG9ydEVuZCA9IHAgLSBidWZmZXIuZGF0YSgpOwogCi0gICAgLy8gRm9yIGNhbm9u aWNhbGl6YXRpb24sIGVuc3VyZSB3ZSBoYXZlIGEgJy8nIGZvciBubyBwYXRoLgotICAgIC8vIE9u bHkgZG8gdGhpcyBmb3IgaHR0cCBhbmQgaHR0cHMuCi0gICAgaWYgKGlzSFRUUG9ySFRUUFMgJiYg cGF0aEVuZCAtIHBhdGhTdGFydCA9PSAwKQotICAgICAgICAqcCsrID0gJy8nOwotCiAgICAgLy8g YWRkIHBhdGgsIGVzY2FwaW5nIGJhZCBjaGFyYWN0ZXJzCiAgICAgaWYgKCFoaWVyYXJjaGljYWwg fHwgIWhhc1NsYXNoRG90T3JEb3REb3QodXJsKSkKICAgICAgICAgYXBwZW5kRXNjYXBpbmdCYWRD aGFycyhwLCB1cmwgKyBwYXRoU3RhcnQsIHBhdGhFbmQgLSBwYXRoU3RhcnQpOwo= 27148 2009-01-29 06:24:52 -0800 2009-01-29 06:26:49 -0800 Makes KURLQt.cpp use two-arg ctor kurlqurl-ctor.patch text/plain 1373 manyoso ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YTJhOTBmOC4uMDI2MGIxYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAwOS0wMS0yOSAgQWRhbSBUcmVhdCAg PGFkYW0udHJlYXRAdG9yY2htb2JpbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0yMzYwOQorICAgICAgICBVc2UgdGhlIHR3by1hcmcgY29uc3RydWN0b3IgZm9yIGltcGxp Y2l0IFFVcmwtPktVUkwgY29udmVyc2lvbiBhcyB0aGUKKyAgICAgICAgc2luZ2xlIGFyZ3VtZW50 IGN0b3JzIGFzc3VtZSB0aGF0IEtVUkw6OnBhcnNlIGhhcyBhbHJlYWR5IGJlZW4gY2FsbGVkCisg ICAgICAgIGFuZCBhc3NlcnQgaWYgdGhlIHBhcnNlIHJlc3VsdHMgaW4gYSBkaWZmZXJlbnQgc3Ry aW5nLiAgVGhpcyB3YXMgY2F1c2luZworICAgICAgICBhbiBhc3NlcnQgZm9yIFFVcmwncyB3aXRo IG5vIHBhdGggYW5kIHdpdGhvdXQgYSB0cmFpbGluZyBzbGFzaC4KKworICAgICAgICAqIHBsYXRm b3JtL3F0L0tVUkxRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpLVVJMOjpLVVJMKToKKwogMjAw OS0wMS0yOCAgQWRhbSBUcmVhdCAgPGFkYW0udHJlYXRAdG9yY2htb2JpbGUuY29tPgogCiAgICAg ICAgIFJldmlld2VkIGJ5IE5pa29sYXMgWmltbWVybWFubiBhbmQgR2VvcmdlIFN0YWlrb3MuCmRp ZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL3F0L0tVUkxRdC5jcHAgYi9XZWJDb3JlL3BsYXRm b3JtL3F0L0tVUkxRdC5jcHAKaW5kZXggY2RjNGY0OC4uMDc2M2ZlMCAxMDA2NDQKLS0tIGEvV2Vi Q29yZS9wbGF0Zm9ybS9xdC9LVVJMUXQuY3BwCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vcXQvS1VS TFF0LmNwcApAQCAtMjAsNiArMjAsNyBAQAogI2luY2x1ZGUgImNvbmZpZy5oIgogI2luY2x1ZGUg IktVUkwuaCIKICNpbmNsdWRlICJDU3RyaW5nLmgiCisjaW5jbHVkZSAiVGV4dEVuY29kaW5nLmgi CiAKICNpbmNsdWRlICJOb3RJbXBsZW1lbnRlZC5oIgogI2luY2x1ZGUgInF1cmwuaCIKQEAgLTM2 LDcgKzM3LDcgQEAgc3RhdGljIGlubGluZSBjaGFyIHRvSGV4KGNoYXIgYykKIAogS1VSTDo6S1VS TChjb25zdCBRVXJsJiB1cmwpCiB7Ci0gICAgKnRoaXMgPSBLVVJMKHVybC50b0VuY29kZWQoKS5j b25zdERhdGEoKSk7CisgICAgKnRoaXMgPSBLVVJMKEtVUkwoKSwgdXJsLnRvRW5jb2RlZCgpLmNv bnN0RGF0YSgpLCBVVEY4RW5jb2RpbmcoKSk7CiB9CiAKIEtVUkw6Om9wZXJhdG9yIFFVcmwoKSBj b25zdAo=