236067 2022-02-03 01:50:41 -0800 MediaSampleAVFObjC::createImageSample should take a presentationTime as parameter 2022-02-08 03:35:20 -0800 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf eric.carlson webkit-bug-importer youennf oldest_to_newest 1836823 0 youennf 2022-02-03 01:50:41 -0800 MediaSampleAVFObjC::createImageSample should take a presentationTime as parameter 1836824 1 450750 youennf 2022-02-03 01:53:07 -0800 Created attachment 450750 Patch 1838599 2 ews-feeder 2022-02-08 03:34:42 -0800 Committed r289362 (246950@main): <https://commits.webkit.org/246950@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450750. 1838600 3 webkit-bug-importer 2022-02-08 03:35:20 -0800 <rdar://problem/88621617> 450750 2022-02-03 01:53:07 -0800 2022-02-08 03:34:43 -0800 Patch bug-236067-20220203105306.patch text/plain 7245 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5MDM1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggY2ZhMGU0MjY0M2U2Y2Zm OGQxZTVmNWE3YzllOWMxNzM0ODg3ODRiZS4uZmUyYWM1M2NhZWVjOWNlMmY1NWJiMmM3NDIyYzhj ZjU1ODY4OGRmZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIyLTAyLTAzICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBNZWRpYVNhbXBsZUFWRk9i akM6OmNyZWF0ZUltYWdlU2FtcGxlIHNob3VsZCB0YWtlIGEgcHJlc2VudGF0aW9uVGltZSBhcyBw YXJhbWV0ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIzNjA2NworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEFkZCBhZGRpdGlvbmFsIHBhcmFtZXRlcnMgdG8gY3JlYXRlSW1hZ2VTYW1wbGUgdGhhdCB3aWxs IGJlIHVzZWQgYnkgV2ViS2l0LgorICAgICAgICBObyBjaGFuZ2Ugb2YgYmVoYXZpb3IuCisKKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVNhbXBsZUFW Rk9iakMuaDoKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhU2FtcGxlQVZGT2JqQzo6Y3JlYXRlSW1h Z2VTYW1wbGUpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpj L01lZGlhU2FtcGxlQVZGT2JqQy5tbToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhU2FtcGxlQVZG T2JqQzo6Y3JlYXRlSW1hZ2VTYW1wbGUpOgorCiAyMDIyLTAyLTAzICBZb3Vlbm4gRmFibGV0ICA8 eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZWFsdGltZUluY29taW5nVmlkZW9Tb3VyY2VD b2NvYSBzaG91bGQgbm90IG5lZWQgdG8gY3JlYXRlIElPU3VyZmFjZXMKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKaW5kZXggMGRi Y2NmMjU3NjQ1MmZkZmZjNjFlZWMzYzgwNGFjYWI5N2M1NTg1Ni4uYzgwNDI3NzEwM2NkYjRlN2M3 NmFlZTI1Nzc3MDQ5Y2Q2ZTk1NTNkNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdC9DaGFuZ2VM b2cKKysrIGIvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAyMi0w Mi0wMyAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CisKKyAgICAgICAgTWVkaWFT YW1wbGVBVkZPYmpDOjpjcmVhdGVJbWFnZVNhbXBsZSBzaG91bGQgdGFrZSBhIHByZXNlbnRhdGlv blRpbWUgYXMgcGFyYW1ldGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0yMzYwNjcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4K KworICAgICAgICAqIEdQVVByb2Nlc3Mvd2VicnRjL1JlbW90ZU1lZGlhUmVjb3JkZXIuY3BwOgor ICAgICAgICAoV2ViS2l0OjpSZW1vdGVNZWRpYVJlY29yZGVyOjp2aWRlb1NhbXBsZUF2YWlsYWJs ZSk6CisgICAgICAgICogR1BVUHJvY2Vzcy93ZWJydGMvUmVtb3RlU2FtcGxlQnVmZmVyRGlzcGxh eUxheWVyLmNwcDoKKyAgICAgICAgKFdlYktpdDo6UmVtb3RlU2FtcGxlQnVmZmVyRGlzcGxheUxh eWVyOjplbnF1ZXVlU2FtcGxlKToKKwogMjAyMi0wMi0wMyAgWW91ZW5uIEZhYmxldCAgPHlvdWVu bkBhcHBsZS5jb20+CiAKICAgICAgICAgU2FtcGxlQnVmZmVyRGlwbGF5TGF5ZXIgc2hvdWxkIG5v dCBuZWVkIHRvIGNyZWF0ZSBJT1N1cmZhY2VzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVNhbXBsZUFWRk9iakMuaCBi L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01lZGlh U2FtcGxlQVZGT2JqQy5oCmluZGV4IDkwMDdkY2NhOWRlZTEwZWViYzNiMzFkNjMzODA2MGQ3ZTky MzcwNTYuLjYzZGI5YzAwM2MwNTE5YzY2NTY2MTIxZTdjNmZiNTFkZjJmNzcxYzEgMTAwNjQ0Ci0t LSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2Zm91bmRhdGlvbi9vYmpjL01l ZGlhU2FtcGxlQVZGT2JqQy5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L2F2Zm91bmRhdGlvbi9vYmpjL01lZGlhU2FtcGxlQVZGT2JqQy5oCkBAIC00Miw3ICs0Miw3IEBA IHB1YmxpYzoKICAgICBzdGF0aWMgUmVmPE1lZGlhU2FtcGxlQVZGT2JqQz4gY3JlYXRlKENNU2Ft cGxlQnVmZmVyUmVmIHNhbXBsZSwgQXRvbVN0cmluZyB0cmFja0lEKSB7IHJldHVybiBhZG9wdFJl ZigqbmV3IE1lZGlhU2FtcGxlQVZGT2JqQyhzYW1wbGUsIHRyYWNrSUQpKTsgfQogICAgIHN0YXRp YyBSZWY8TWVkaWFTYW1wbGVBVkZPYmpDPiBjcmVhdGUoQ01TYW1wbGVCdWZmZXJSZWYgc2FtcGxl LCBWaWRlb1JvdGF0aW9uIHJvdGF0aW9uID0gVmlkZW9Sb3RhdGlvbjo6Tm9uZSwgYm9vbCBtaXJy b3JlZCA9IGZhbHNlKSB7IHJldHVybiBhZG9wdFJlZigqbmV3IE1lZGlhU2FtcGxlQVZGT2JqQyhz YW1wbGUsIHJvdGF0aW9uLCBtaXJyb3JlZCkpOyB9CiAgICAgc3RhdGljIFJlZlB0cjxNZWRpYVNh bXBsZUFWRk9iakM+IGNyZWF0ZUltYWdlU2FtcGxlKFBpeGVsQnVmZmVyJiYpOwotICAgIFdFQkNP UkVfRVhQT1JUIHN0YXRpYyBSZWZQdHI8TWVkaWFTYW1wbGVBVkZPYmpDPiBjcmVhdGVJbWFnZVNh bXBsZShSZXRhaW5QdHI8Q1ZQaXhlbEJ1ZmZlclJlZj4mJiwgVmlkZW9Sb3RhdGlvbiwgYm9vbCBt aXJyb3JlZCk7CisgICAgV0VCQ09SRV9FWFBPUlQgc3RhdGljIFJlZlB0cjxNZWRpYVNhbXBsZUFW Rk9iakM+IGNyZWF0ZUltYWdlU2FtcGxlKFJldGFpblB0cjxDVlBpeGVsQnVmZmVyUmVmPiYmLCBW aWRlb1JvdGF0aW9uLCBib29sIG1pcnJvcmVkLCBNZWRpYVRpbWUgcHJlc2VudGF0aW9uVGltZSA9 IHsgfSwgTWVkaWFUaW1lIGRlY29kaW5nVGltZSA9IHsgfSk7CiAKICAgICBXRUJDT1JFX0VYUE9S VCBzdGF0aWMgdm9pZCBzZXRBc0Rpc3BsYXlJbW1lZGlhdGVseShNZWRpYVNhbXBsZSYpOwogICAg IHN0YXRpYyBSZXRhaW5QdHI8Q01TYW1wbGVCdWZmZXJSZWY+IGNsb25lU2FtcGxlQnVmZmVyQW5k U2V0QXNEaXNwbGF5SW1tZWRpYXRlbHkoQ01TYW1wbGVCdWZmZXJSZWYpOwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3VuZGF0aW9uL29iamMvTWVkaWFT YW1wbGVBVkZPYmpDLm1tIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvYXZmb3Vu ZGF0aW9uL29iamMvTWVkaWFTYW1wbGVBVkZPYmpDLm1tCmluZGV4IDRhMGZhYzYxZWIxZWY2MDMz ZWQyOTc0MzVkYWE5MjZlOWVkZWFjZDcuLjJjZTZjZWRlYTU1ZGZlNDI5NTNjMmM5YmYyZjI2OWVh MTNjNDZjM2IgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2F2 Zm91bmRhdGlvbi9vYmpjL01lZGlhU2FtcGxlQVZGT2JqQy5tbQorKysgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9hdmZvdW5kYXRpb24vb2JqYy9NZWRpYVNhbXBsZUFWRk9iakMu bW0KQEAgLTk4LDcgKzk4LDcgQEAgUmVmUHRyPE1lZGlhU2FtcGxlQVZGT2JqQz4gTWVkaWFTYW1w bGVBVkZPYmpDOjpjcmVhdGVJbWFnZVNhbXBsZShQaXhlbEJ1ZmZlciYmIHAKICAgICByZXR1cm4g Y3JlYXRlSW1hZ2VTYW1wbGUoV1RGTW92ZShjdlBpeGVsQnVmZmVyKSwgVmlkZW9Sb3RhdGlvbjo6 Tm9uZSwgZmFsc2UpOwogfQogCi1SZWZQdHI8TWVkaWFTYW1wbGVBVkZPYmpDPiBNZWRpYVNhbXBs ZUFWRk9iakM6OmNyZWF0ZUltYWdlU2FtcGxlKFJldGFpblB0cjxDVlBpeGVsQnVmZmVyUmVmPiYm IHBpeGVsQnVmZmVyLCBWaWRlb1JvdGF0aW9uIHJvdGF0aW9uLCBib29sIG1pcnJvcmVkKQorUmVm UHRyPE1lZGlhU2FtcGxlQVZGT2JqQz4gTWVkaWFTYW1wbGVBVkZPYmpDOjpjcmVhdGVJbWFnZVNh bXBsZShSZXRhaW5QdHI8Q1ZQaXhlbEJ1ZmZlclJlZj4mJiBwaXhlbEJ1ZmZlciwgVmlkZW9Sb3Rh dGlvbiByb3RhdGlvbiwgYm9vbCBtaXJyb3JlZCwgTWVkaWFUaW1lIHByZXNlbnRhdGlvblRpbWUs IE1lZGlhVGltZSBkZWNvZGluZ1RpbWUpCiB7CiAgICAgQ01WaWRlb0Zvcm1hdERlc2NyaXB0aW9u UmVmIGZvcm1hdERlc2NyaXB0aW9uUmF3ID0gbnVsbHB0cjsKICAgICBhdXRvIHN0YXR1cyA9IFBB TDo6Q01WaWRlb0Zvcm1hdERlc2NyaXB0aW9uQ3JlYXRlRm9ySW1hZ2VCdWZmZXIoa0NGQWxsb2Nh dG9yRGVmYXVsdCwgcGl4ZWxCdWZmZXIuZ2V0KCksICZmb3JtYXREZXNjcmlwdGlvblJhdyk7CkBA IC0xMDgsNyArMTA4LDcgQEAgUmVmUHRyPE1lZGlhU2FtcGxlQVZGT2JqQz4gTWVkaWFTYW1wbGVB VkZPYmpDOjpjcmVhdGVJbWFnZVNhbXBsZShSZXRhaW5QdHI8Q1ZQaXgKICAgICB9CiAgICAgYXV0 byBmb3JtYXREZXNjcmlwdGlvbiA9IGFkb3B0Q0YoZm9ybWF0RGVzY3JpcHRpb25SYXcpOwogCi0g ICAgQ01TYW1wbGVUaW1pbmdJbmZvIHNhbXBsZVRpbWluZ0luZm9ybWF0aW9uID0geyBQQUw6OmtD TVRpbWVJbnZhbGlkLCBQQUw6OmtDTVRpbWVJbnZhbGlkLCBQQUw6OmtDTVRpbWVJbnZhbGlkIH07 CisgICAgQ01TYW1wbGVUaW1pbmdJbmZvIHNhbXBsZVRpbWluZ0luZm9ybWF0aW9uID0geyBQQUw6 OmtDTVRpbWVJbnZhbGlkLCBQQUw6OnRvQ01UaW1lKHByZXNlbnRhdGlvblRpbWUpLCBQQUw6OnRv Q01UaW1lKGRlY29kaW5nVGltZSkgfTsKICAgICBDTVNhbXBsZUJ1ZmZlclJlZiBzYW1wbGVCdWZm ZXJSYXcgPSBudWxscHRyOwogICAgIHN0YXR1cyA9IFBBTDo6Q01TYW1wbGVCdWZmZXJDcmVhdGVS ZWFkeVdpdGhJbWFnZUJ1ZmZlcihrQ0ZBbGxvY2F0b3JEZWZhdWx0LCBwaXhlbEJ1ZmZlci5nZXQo KSwgZm9ybWF0RGVzY3JpcHRpb24uZ2V0KCksICZzYW1wbGVUaW1pbmdJbmZvcm1hdGlvbiwgJnNh bXBsZUJ1ZmZlclJhdyk7CiAgICAgaWYgKHN0YXR1cyB8fCAhc2FtcGxlQnVmZmVyUmF3KSB7CmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0dQVVByb2Nlc3Mvd2VicnRjL1JlbW90ZU1lZGlhUmVj b3JkZXIuY3BwIGIvU291cmNlL1dlYktpdC9HUFVQcm9jZXNzL3dlYnJ0Yy9SZW1vdGVNZWRpYVJl Y29yZGVyLmNwcAppbmRleCBiNmM5MmJjZTFlNjFlOTU3MDVmNGFlNTc1NGE3Y2RiNDQzN2QzMmM4 Li4wNGI5YjdiYWM4NjkxY2RmNjIzYWZhZjUyY2Y3ODVkODZiZmE2Mjg2IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViS2l0L0dQVVByb2Nlc3Mvd2VicnRjL1JlbW90ZU1lZGlhUmVjb3JkZXIuY3BwCisr KyBiL1NvdXJjZS9XZWJLaXQvR1BVUHJvY2Vzcy93ZWJydGMvUmVtb3RlTWVkaWFSZWNvcmRlci5j cHAKQEAgLTk0LDggKzk0LDcgQEAgdm9pZCBSZW1vdGVNZWRpYVJlY29yZGVyOjp2aWRlb1NhbXBs ZUF2YWlsYWJsZShXZWJDb3JlOjpSZW1vdGVWaWRlb1NhbXBsZSYmIHJlbW8KICAgICAgICAgaWYg KCFwaXhlbEJ1ZmZlcikKICAgICAgICAgICAgIHJldHVybjsKIAotICAgICAgICBzYW1wbGUgPSBN ZWRpYVNhbXBsZUFWRk9iakM6OmNyZWF0ZUltYWdlU2FtcGxlKFdURk1vdmUocGl4ZWxCdWZmZXIp LCByZW1vdGVTYW1wbGUucm90YXRpb24oKSwgcmVtb3RlU2FtcGxlLm1pcnJvcmVkKCkpOwotICAg ICAgICBzYW1wbGUtPnNldFRpbWVzdGFtcHMocmVtb3RlU2FtcGxlLnRpbWUoKSwgTWVkaWFUaW1l IHsgfSk7CisgICAgICAgIHNhbXBsZSA9IE1lZGlhU2FtcGxlQVZGT2JqQzo6Y3JlYXRlSW1hZ2VT YW1wbGUoV1RGTW92ZShwaXhlbEJ1ZmZlciksIHJlbW90ZVNhbXBsZS5yb3RhdGlvbigpLCByZW1v dGVTYW1wbGUubWlycm9yZWQoKSwgcmVtb3RlU2FtcGxlLnRpbWUoKSk7CiAgICAgfSBlbHNlIHsK ICAgICAgICAgaWYgKCFtX2ltYWdlVHJhbnNmZXJTZXNzaW9uIHx8IG1faW1hZ2VUcmFuc2ZlclNl c3Npb24tPnBpeGVsRm9ybWF0KCkgIT0gcmVtb3RlU2FtcGxlLnZpZGVvRm9ybWF0KCkpCiAgICAg ICAgICAgICBtX2ltYWdlVHJhbnNmZXJTZXNzaW9uID0gSW1hZ2VUcmFuc2ZlclNlc3Npb25WVDo6 Y3JlYXRlKHJlbW90ZVNhbXBsZS52aWRlb0Zvcm1hdCgpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJLaXQvR1BVUHJvY2Vzcy93ZWJydGMvUmVtb3RlU2FtcGxlQnVmZmVyRGlzcGxheUxheWVyLmNw cCBiL1NvdXJjZS9XZWJLaXQvR1BVUHJvY2Vzcy93ZWJydGMvUmVtb3RlU2FtcGxlQnVmZmVyRGlz cGxheUxheWVyLmNwcAppbmRleCAyMTdkYjk3YTNjZTRjODMwMDQ4YWZhYzgyOGVmYmRiYmQ1MThl N2EwLi5hMTA4NDc1M2JlZjZlMzZhYTBiNmQ5OTdiZDA0MDliMTAyODcyNGFmIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViS2l0L0dQVVByb2Nlc3Mvd2VicnRjL1JlbW90ZVNhbXBsZUJ1ZmZlckRpc3Bs YXlMYXllci5jcHAKKysrIGIvU291cmNlL1dlYktpdC9HUFVQcm9jZXNzL3dlYnJ0Yy9SZW1vdGVT YW1wbGVCdWZmZXJEaXNwbGF5TGF5ZXIuY3BwCkBAIC0xMjEsOCArMTIxLDcgQEAgdm9pZCBSZW1v dGVTYW1wbGVCdWZmZXJEaXNwbGF5TGF5ZXI6OmVucXVldWVTYW1wbGUoUmVtb3RlVmlkZW9TYW1w bGUmJiByZW1vdGVTYW0KICAgICAgICAgaWYgKCFwaXhlbEJ1ZmZlcikKICAgICAgICAgICAgIHJl dHVybjsKIAotICAgICAgICBzYW1wbGUgPSBNZWRpYVNhbXBsZUFWRk9iakM6OmNyZWF0ZUltYWdl U2FtcGxlKFdURk1vdmUocGl4ZWxCdWZmZXIpLCByZW1vdGVTYW1wbGUucm90YXRpb24oKSwgcmVt b3RlU2FtcGxlLm1pcnJvcmVkKCkpOwotICAgICAgICBzYW1wbGUtPnNldFRpbWVzdGFtcHMocmVt b3RlU2FtcGxlLnRpbWUoKSwgTWVkaWFUaW1lIHsgfSk7CisgICAgICAgIHNhbXBsZSA9IE1lZGlh U2FtcGxlQVZGT2JqQzo6Y3JlYXRlSW1hZ2VTYW1wbGUoV1RGTW92ZShwaXhlbEJ1ZmZlciksIHJl bW90ZVNhbXBsZS5yb3RhdGlvbigpLCByZW1vdGVTYW1wbGUubWlycm9yZWQoKSwgcmVtb3RlU2Ft cGxlLnRpbWUoKSk7CiAgICAgfSBlbHNlIHsKICAgICAgICAgaWYgKCFtX2ltYWdlVHJhbnNmZXJT ZXNzaW9uIHx8IG1faW1hZ2VUcmFuc2ZlclNlc3Npb24tPnBpeGVsRm9ybWF0KCkgIT0gcmVtb3Rl U2FtcGxlLnZpZGVvRm9ybWF0KCkpCiAgICAgICAgICAgICBtX2ltYWdlVHJhbnNmZXJTZXNzaW9u ID0gSW1hZ2VUcmFuc2ZlclNlc3Npb25WVDo6Y3JlYXRlKHJlbW90ZVNhbXBsZS52aWRlb0Zvcm1h dCgpKTsK