236066 2022-02-03 01:40:11 -0800 Add SharedVideoFrameReader/SharedVideoFrameWriter logging for error cases 2022-05-05 08:46:29 -0700 1 1 1 Unclassified WebKit WebRTC WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 youennf youennf eric.carlson ews-watchlist glenn jer.noble philipj sergio webkit-bug-importer youennf oldest_to_newest 1836814 0 youennf 2022-02-03 01:40:11 -0800 Add SharedVideoFrameReader/SharedVideoFrameWriter logging for error cases 1836816 1 webkit-bug-importer 2022-02-03 01:40:37 -0800 <rdar://problem/88424960> 1866815 2 458869 youennf 2022-05-05 05:51:35 -0700 Created attachment 458869 Patch 1866838 3 ews-feeder 2022-05-05 08:16:46 -0700 Committed r293833 (250306@main): <https://commits.webkit.org/250306@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 458869. 458869 2022-05-05 05:51:35 -0700 2022-05-05 08:46:29 -0700 Patch bug-236066-20220505145134.patch text/plain 6951 youennf U3VidmVyc2lvbiBSZXZpc2lvbjogMjkzNzY3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMWZkOGI5MjQ0NDg3Y2M5 YzZmZjI2MDNiNzViMmM4YTFhMDcyMjgxMS4uZGI1YjkxNzY1N2I0ZWMwMjZkNTE5ZDFkNWY0NDBm NWJkZWI2MTU3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDIyLTA1LTA1ICBZb3Vl bm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KKworICAgICAgICBBZGQgU2hhcmVkVmlkZW9G cmFtZVJlYWRlci9TaGFyZWRWaWRlb0ZyYW1lV3JpdGVyIGxvZ2dpbmcgZm9yIGVycm9yIGNhc2Vz CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzYwNjYK KyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzg4NDI0OTYwPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIE5vIGNoYW5nZSBvZiBiZWhhdmlvci4KKworICAg ICAgICAqIHBsYXRmb3JtL2NvY29hL1NoYXJlZFZpZGVvRnJhbWVJbmZvLm1tOgorICAgICAgICAo V2ViQ29yZTo6U2hhcmVkVmlkZW9GcmFtZUluZm86OndyaXRlUGl4ZWxCdWZmZXIpOgorCiAyMDIy LTA1LTA1ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNvbT4KIAogICAgICAgICBSZW1v dmUgdXNhZ2Ugb2YgUGl4ZWxCdWZmZXJDb25mb3JtZXIgaW4gUmVhbHRpbWVPdXRnb2luZ1ZpZGVv U291cmNlQ29jb2EKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nIGIvU291cmNl L1dlYktpdC9DaGFuZ2VMb2cKaW5kZXggNThiNDBiN2EwNjQxMDFkMzBlNTRjYTI3YmU4NDU0MWVh ZDg5N2MxMi4uZjQyZjcxM2U1YTg0ZWE1NzE1ZGFjOTNmNWQyMjQ2ZDI1Njc3NWE0MyAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdC9DaGFuZ2VM b2cKQEAgLTEsMyArMSwxNiBAQAorMjAyMi0wNS0wNSAgWW91ZW5uIEZhYmxldCAgPHlvdWVubkBh cHBsZS5jb20+CisKKyAgICAgICAgQWRkIFNoYXJlZFZpZGVvRnJhbWVSZWFkZXIvU2hhcmVkVmlk ZW9GcmFtZVdyaXRlciBsb2dnaW5nIGZvciBlcnJvciBjYXNlcworICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM2MDY2CisgICAgICAgIDxyZGFyOi8vcHJv YmxlbS84ODQyNDk2MD4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICAqIFdlYlByb2Nlc3MvR1BVL3dlYnJ0Yy9TaGFyZWRWaWRlb0ZyYW1lLmNwcDoKKyAg ICAgICAgKFdlYktpdDo6U2hhcmVkVmlkZW9GcmFtZVdyaXRlcjo6cHJlcGFyZVdyaXRpbmcpOgor ICAgICAgICAoV2ViS2l0OjpTaGFyZWRWaWRlb0ZyYW1lUmVhZGVyOjpyZWFkQnVmZmVyRnJvbVNo YXJlZE1lbW9yeSk6CisgICAgICAgIChXZWJLaXQ6OlNoYXJlZFZpZGVvRnJhbWVSZWFkZXI6OnJl YWRCdWZmZXIpOgorCiAyMDIyLTA1LTA1ICBZb3Vlbm4gRmFibGV0ICA8eW91ZW5uQGFwcGxlLmNv bT4KIAogICAgICAgICBBbGxvdyBNZWRpYVBsYXllclByaXZhdGVNZWRpYVN0cmVhbUFWRk9iakMg dG8gYXZvaWQgcGl4ZWwgY29uZm9ybWVycyBpZiBJT1N1cmZhY2VzIGFyZSBub3QgYWxsb3dlZApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY29jb2EvU2hhcmVkVmlkZW9GcmFt ZUluZm8ubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jb2NvYS9TaGFyZWRWaWRlb0ZyYW1l SW5mby5tbQppbmRleCAwMTI2ZGJiYTE4NDVlNTIzNWI1ODMxMjBmMGYyMTQ0YTdiMzJjNjRhLi5l NmRkMGUxZDA1MjAwMjkzN2Y0ZmM1ODA2ZWZkMjBkZTFlZmU0N2RmIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9jb2NvYS9TaGFyZWRWaWRlb0ZyYW1lSW5mby5tbQorKysgYi9T b3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jb2NvYS9TaGFyZWRWaWRlb0ZyYW1lSW5mby5tbQpAQCAt MTc4LDggKzE3OCwxMCBAQCBSZXRhaW5QdHI8Q1ZQaXhlbEJ1ZmZlclJlZj4gU2hhcmVkVmlkZW9G cmFtZUluZm86OmNyZWF0ZVBpeGVsQnVmZmVyRnJvbU1lbW9yeShjbwogYm9vbCBTaGFyZWRWaWRl b0ZyYW1lSW5mbzo6d3JpdGVQaXhlbEJ1ZmZlcihDVlBpeGVsQnVmZmVyUmVmIHBpeGVsQnVmZmVy LCB1aW50OF90KiBkYXRhKQogewogICAgIGF1dG8gcmVzdWx0ID0gQ1ZQaXhlbEJ1ZmZlckxvY2tC YXNlQWRkcmVzcyhwaXhlbEJ1ZmZlciwga0NWUGl4ZWxCdWZmZXJMb2NrX1JlYWRPbmx5KTsKLSAg ICBpZiAocmVzdWx0ICE9IGtDVlJldHVyblN1Y2Nlc3MpCisgICAgaWYgKHJlc3VsdCAhPSBrQ1ZS ZXR1cm5TdWNjZXNzKSB7CisgICAgICAgIFJFTEVBU0VfTE9HX0VSUk9SKFdlYlJUQywgIlNoYXJl ZFZpZGVvRnJhbWVJbmZvOjp3cml0ZVBpeGVsQnVmZmVyIGxvY2sgZmFpbGVkIik7CiAgICAgICAg IHJldHVybiBmYWxzZTsKKyAgICB9CiAKICAgICBhdXRvIHNjb3BlID0gbWFrZVNjb3BlRXhpdChb JnBpeGVsQnVmZmVyXSB7CiAgICAgICAgIENWUGl4ZWxCdWZmZXJVbmxvY2tCYXNlQWRkcmVzcyhw aXhlbEJ1ZmZlciwga0NWUGl4ZWxCdWZmZXJMb2NrX1JlYWRPbmx5KTsKZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJLaXQvV2ViUHJvY2Vzcy9HUFUvd2VicnRjL1NoYXJlZFZpZGVvRnJhbWUuY3BwIGIv U291cmNlL1dlYktpdC9XZWJQcm9jZXNzL0dQVS93ZWJydGMvU2hhcmVkVmlkZW9GcmFtZS5jcHAK aW5kZXggMzliNzRiZjQ2ZGViZGE1ZGI2OWY2N2ZiMmJjNmE4ZGU4ZmQ0ZTljZi4uMjQwMWU1ODYw ZDI5OWViMDY2MGM4NGNlZjU1M2VjOTRmZjMyNmY2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktp dC9XZWJQcm9jZXNzL0dQVS93ZWJydGMvU2hhcmVkVmlkZW9GcmFtZS5jcHAKKysrIGIvU291cmNl L1dlYktpdC9XZWJQcm9jZXNzL0dQVS93ZWJydGMvU2hhcmVkVmlkZW9GcmFtZS5jcHAKQEAgLTc5 LDE2ICs3OSwyMiBAQCBib29sIFNoYXJlZFZpZGVvRnJhbWVXcml0ZXI6OmFsbG9jYXRlU3RvcmFn ZShzaXplX3Qgc2l6ZSwgY29uc3QgRnVuY3Rpb248dm9pZChjbwogCiBib29sIFNoYXJlZFZpZGVv RnJhbWVXcml0ZXI6OnByZXBhcmVXcml0aW5nKGNvbnN0IFNoYXJlZFZpZGVvRnJhbWVJbmZvJiBp bmZvLCBjb25zdCBGdW5jdGlvbjx2b2lkKElQQzo6U2VtYXBob3JlJik+JiBuZXdTZW1hcGhvcmVD YWxsYmFjaywgY29uc3QgRnVuY3Rpb248dm9pZChjb25zdCBTaGFyZWRNZW1vcnk6OklQQ0hhbmRs ZSYpPiYgbmV3TWVtb3J5Q2FsbGJhY2spCiB7Ci0gICAgaWYgKCFpbmZvLmlzUmVhZFdyaXRlU3Vw cG9ydGVkKCkpCisgICAgaWYgKCFpbmZvLmlzUmVhZFdyaXRlU3VwcG9ydGVkKCkpIHsKKyAgICAg ICAgUkVMRUFTRV9MT0dfRVJST1IoV2ViUlRDLCAiU2hhcmVkVmlkZW9GcmFtZVdyaXRlcjo6cHJl cGFyZVdyaXRpbmcgbm90IHN1cHBvcnRlZCIpOwogICAgICAgICByZXR1cm4gZmFsc2U7CisgICAg fQogCi0gICAgaWYgKCF3YWl0KG5ld1NlbWFwaG9yZUNhbGxiYWNrKSkKKyAgICBpZiAoIXdhaXQo bmV3U2VtYXBob3JlQ2FsbGJhY2spKSB7CisgICAgICAgIFJFTEVBU0VfTE9HX0VSUk9SKFdlYlJU QywgIlNoYXJlZFZpZGVvRnJhbWVSZWFkZXI6OndyaXRlQnVmZmVyIHdhaXQgZmFpbGVkIik7CiAg ICAgICAgIHJldHVybiBmYWxzZTsKKyAgICB9CiAKICAgICBzaXplX3Qgc2l6ZSA9IGluZm8uc3Rv cmFnZVNpemUoKTsKICAgICBpZiAoIW1fc3RvcmFnZSB8fCBtX3N0b3JhZ2UtPnNpemUoKSA8IHNp emUpIHsKLSAgICAgICAgaWYgKCFhbGxvY2F0ZVN0b3JhZ2Uoc2l6ZSwgbmV3TWVtb3J5Q2FsbGJh Y2spKQorICAgICAgICBpZiAoIWFsbG9jYXRlU3RvcmFnZShzaXplLCBuZXdNZW1vcnlDYWxsYmFj aykpIHsKKyAgICAgICAgICAgIFJFTEVBU0VfTE9HX0VSUk9SKFdlYlJUQywgIlNoYXJlZFZpZGVv RnJhbWVSZWFkZXI6OndyaXRlQnVmZmVyIGFsbG9jYXRpb24gZmFpbGVkIik7CiAgICAgICAgICAg ICByZXR1cm4gZmFsc2U7CisgICAgICAgIH0KICAgICB9CiAgICAgcmV0dXJuIHRydWU7CiB9CkBA IC0xNzQsOCArMTgwLDEwIEBAIFNoYXJlZFZpZGVvRnJhbWVSZWFkZXI6OlNoYXJlZFZpZGVvRnJh bWVSZWFkZXIoKSA9IGRlZmF1bHQ7CiAKIFJldGFpblB0cjxDVlBpeGVsQnVmZmVyUmVmPiBTaGFy ZWRWaWRlb0ZyYW1lUmVhZGVyOjpyZWFkQnVmZmVyRnJvbVNoYXJlZE1lbW9yeSgpCiB7Ci0gICAg aWYgKCFtX3N0b3JhZ2UpCisgICAgaWYgKCFtX3N0b3JhZ2UpIHsKKyAgICAgICAgUkVMRUFTRV9M T0dfRVJST1IoV2ViUlRDLCAiU2hhcmVkVmlkZW9GcmFtZVJlYWRlcjo6cmVhZEJ1ZmZlckZyb21T aGFyZWRNZW1vcnkgbm8gc3RvcmFnZSIpOwogICAgICAgICByZXR1cm4geyB9OworICAgIH0KIAog ICAgIGF1dG8gc2NvcGUgPSBtYWtlU2NvcGVFeGl0KFsmXSB7CiAgICAgICAgIG1fc2VtYXBob3Jl LnNpZ25hbCgpOwpAQCAtMTgzLDE0ICsxOTEsMjAgQEAgUmV0YWluUHRyPENWUGl4ZWxCdWZmZXJS ZWY+IFNoYXJlZFZpZGVvRnJhbWVSZWFkZXI6OnJlYWRCdWZmZXJGcm9tU2hhcmVkTWVtb3J5KCkK IAogICAgIGF1dG8qIGRhdGEgPSBzdGF0aWNfY2FzdDxjb25zdCB1aW50OF90Kj4obV9zdG9yYWdl LT5kYXRhKCkpOwogICAgIGF1dG8gaW5mbyA9IFNoYXJlZFZpZGVvRnJhbWVJbmZvOjpkZWNvZGUo eyBkYXRhLCBtX3N0b3JhZ2UtPnNpemUoKSB9KTsKLSAgICBpZiAoIWluZm8pCisgICAgaWYgKCFp bmZvKSB7CisgICAgICAgIFJFTEVBU0VfTE9HX0VSUk9SKFdlYlJUQywgIlNoYXJlZFZpZGVvRnJh bWVSZWFkZXI6OnJlYWRCdWZmZXJGcm9tU2hhcmVkTWVtb3J5IGRlY29kaW5nIGZhaWxlZCIpOwog ICAgICAgICByZXR1cm4geyB9OworICAgIH0KIAotICAgIGlmICghaW5mby0+aXNSZWFkV3JpdGVT dXBwb3J0ZWQoKSkKKyAgICBpZiAoIWluZm8tPmlzUmVhZFdyaXRlU3VwcG9ydGVkKCkpIHsKKyAg ICAgICAgUkVMRUFTRV9MT0dfRVJST1IoV2ViUlRDLCAiU2hhcmVkVmlkZW9GcmFtZVJlYWRlcjo6 cmVhZEJ1ZmZlckZyb21TaGFyZWRNZW1vcnkgbm90IHN1cHBvcnRlZCIpOwogICAgICAgICByZXR1 cm4geyB9OworICAgIH0KIAotICAgIGlmIChtX3N0b3JhZ2UtPnNpemUoKSA8IGluZm8tPnN0b3Jh Z2VTaXplKCkpCisgICAgaWYgKG1fc3RvcmFnZS0+c2l6ZSgpIDwgaW5mby0+c3RvcmFnZVNpemUo KSkgeworICAgICAgICBSRUxFQVNFX0xPR19FUlJPUihXZWJSVEMsICJTaGFyZWRWaWRlb0ZyYW1l UmVhZGVyOjpyZWFkQnVmZmVyRnJvbVNoYXJlZE1lbW9yeSBzdG9yYWdlIHNpemUgbWlzbWF0Y2gi KTsKICAgICAgICAgcmV0dXJuIHsgfTsKKyAgICB9CiAKICAgICBhdXRvIHJlc3VsdCA9IGluZm8t PmNyZWF0ZVBpeGVsQnVmZmVyRnJvbU1lbW9yeShkYXRhICsgU2hhcmVkVmlkZW9GcmFtZUluZm9F bmNvZGluZ0xlbmd0aCwgcGl4ZWxCdWZmZXJQb29sKCppbmZvKSk7CiAgICAgaWYgKHJlc3VsdCAm JiBtX3Jlc291cmNlT3duZXIgJiYgbV91c2VJT1N1cmZhY2VCdWZmZXJQb29sID09IFVzZUlPU3Vy ZmFjZUJ1ZmZlclBvb2w6OlllcykKQEAgLTIwMywxOCArMjE3LDI1IEBAIFJldGFpblB0cjxDVlBp eGVsQnVmZmVyUmVmPiBTaGFyZWRWaWRlb0ZyYW1lUmVhZGVyOjpyZWFkQnVmZmVyKFNoYXJlZFZp ZGVvRnJhbWU6CiAgICAgcmV0dXJuIHN3aXRjaE9uKFdURk1vdmUoYnVmZmVyKSwKICAgICBbdGhp c10oUmVtb3RlVmlkZW9GcmFtZVJlYWRSZWZlcmVuY2UmJiByZWZlcmVuY2UpIC0+IFJldGFpblB0 cjxDVlBpeGVsQnVmZmVyUmVmPiB7CiAgICAgICAgIEFTU0VSVChtX29iamVjdEhlYXApOwotICAg ICAgICBpZiAoIW1fb2JqZWN0SGVhcCkKKyAgICAgICAgaWYgKCFtX29iamVjdEhlYXApIHsKKyAg ICAgICAgICAgIFJFTEVBU0VfTE9HX0VSUk9SKFdlYlJUQywgIlNoYXJlZFZpZGVvRnJhbWVSZWFk ZXI6OnJlYWRCdWZmZXIgbm8gb2JqZWN0IGhlYXAiKTsKICAgICAgICAgICAgIHJldHVybiBudWxs cHRyOworICAgICAgICB9CiAKICAgICAgICAgYXV0byBzYW1wbGUgPSBtX29iamVjdEhlYXAtPmdl dChXVEZNb3ZlKHJlZmVyZW5jZSkpOwotICAgICAgICBpZiAoIXNhbXBsZSkKKyAgICAgICAgaWYg KCFzYW1wbGUpIHsKKyAgICAgICAgICAgIFJFTEVBU0VfTE9HX0VSUk9SKFdlYlJUQywgIlNoYXJl ZFZpZGVvRnJhbWVSZWFkZXI6OnJlYWRCdWZmZXIgbm8gc2FtcGxlIik7CiAgICAgICAgICAgICBy ZXR1cm4gbnVsbHB0cjsKKyAgICAgICAgfQorCiAgICAgICAgIEFTU0VSVChzYW1wbGUtPnBpeGVs QnVmZmVyKCkpOwogICAgICAgICByZXR1cm4gc2FtcGxlLT5waXhlbEJ1ZmZlcigpOwogICAgIH0g LCBbXShNYWNoU2VuZFJpZ2h0JiYgc2VuZFJpZ2h0KSAtPiBSZXRhaW5QdHI8Q1ZQaXhlbEJ1ZmZl clJlZj4gewogICAgICAgICBhdXRvIHN1cmZhY2UgPSBXZWJDb3JlOjpJT1N1cmZhY2U6OmNyZWF0 ZUZyb21TZW5kUmlnaHQoV1RGTW92ZShzZW5kUmlnaHQpLCBEZXN0aW5hdGlvbkNvbG9yU3BhY2U6 OlNSR0IoKSk7Ci0gICAgICAgIGlmICghc3VyZmFjZSkKKyAgICAgICAgaWYgKCFzdXJmYWNlKSB7 CisgICAgICAgICAgICBSRUxFQVNFX0xPR19FUlJPUihXZWJSVEMsICJTaGFyZWRWaWRlb0ZyYW1l UmVhZGVyOjpyZWFkQnVmZmVyIG5vIHN1cmZhY2UiKTsKICAgICAgICAgICAgIHJldHVybiBudWxs cHRyOworICAgICAgICB9CiAgICAgICAgIHJldHVybiBXZWJDb3JlOjpjcmVhdGVDVlBpeGVsQnVm ZmVyKHN1cmZhY2UtPnN1cmZhY2UoKSkudmFsdWVfb3IobnVsbHB0cik7CiAgICAgfSwgW3RoaXNd KHN0ZDo6bnVsbHB0cl90IHJlcHJlc2VudGF0aW9uKSAtPiBSZXRhaW5QdHI8Q1ZQaXhlbEJ1ZmZl clJlZj4gewogICAgICAgICByZXR1cm4gcmVhZEJ1ZmZlckZyb21TaGFyZWRNZW1vcnkoKTsK