236043 2022-02-02 15:39:06 -0800 REGRESSION(r288878) webkitpy.layout_tests.controllers.layout_test_finder_legacy_unittest.LayoutTestFinderTests tests are failing with Windows Python 2022-02-06 20:43:14 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=235370 InRadar P2 Normal --- 236149 1 fujii fujii commit-queue darin ews-watchlist glenn gsnedders jbedard webkit-bug-importer oldest_to_newest 1836669 0 fujii 2022-02-02 15:39:06 -0800 REGRESSION(r288878) webkitpy.layout_tests.controllers.layout_test_finder_legacy_unittest.LayoutTestFinderTests tests are failing with Windows Python Since r288878 (Bug 235370) WinCairo buildbot is using Windows Python. https://build.webkit.org/#/builders/60/builds/4301 [496/1640] webkitpy.layout_tests.controllers.layout_test_finder_legacy_unittest.LayoutTestFinderTests.test_find_all_no_paths [497/1640] webkitpy.layout_tests.controllers.layout_test_finder_legacy_unittest.LayoutTestFinderTests.test_find_all_no_paths passed [497/1640] webkitpy.layout_tests.controllers.layout_test_finder_legacy_unittest.LayoutTestFinderTests.test_find_directory [498/1640] webkitpy.layout_tests.controllers.layout_test_finder_legacy_unittest.LayoutTestFinderTests.test_find_directory failed: Traceback (most recent call last): File "C:\BW\wincairo-wkl-release-tests\build\Tools\Scripts\webkitpy\layout_tests\controllers\layout_test_finder_legacy_unittest.py", line 263, in test_find_directory self.assertEqual(tests, ['websocket/tests/passes/text.html']) AssertionError: Lists differ: ['\\test.checkout\\LayoutTests\\websocket\\tests\\passes\\text.html'] != ['websocket/tests/passes/text.html'] First differing element 0: '\\test.checkout\\LayoutTests\\websocket\\tests\\passes\\text.html' 'websocket/tests/passes/text.html' - ['\\test.checkout\\LayoutTests\\websocket\\tests\\passes\\text.html'] + ['websocket/tests/passes/text.html'] [498/1640] webkitpy.layout_tests.controllers.layout_test_finder_legacy_unittest.LayoutTestFinderTests.test_find_directory_includes_platform_specific [499/1640] webkitpy.layout_tests.controllers.layout_test_finder_legacy_unittest.LayoutTestFinderTests.test_find_directory_includes_platform_specific failed: Traceback (most recent call last): File "C:\BW\wincairo-wkl-release-tests\build\Tools\Scripts\webkitpy\layout_tests\controllers\layout_test_finder_legacy_unittest.py", line 173, in test_find_directory_includes_platform_specific self.assertEqual( AssertionError: Lists differ: ['\\test.checkout\\LayoutTests\\http\\tests[142 chars]tml'] != ['http/tests/passes/image.html', 'http/test[87 chars]tml'] First differing element 0: '\\test.checkout\\LayoutTests\\http\\tests\\passes\\image.html' 'http/tests/passes/image.html' Second list contains 1 additional elements. First extra element 3: 'platform/test-mac-leopard/http/test.html' - ['\\test.checkout\\LayoutTests\\http\\tests\\passes\\image.html', - '\\test.checkout\\LayoutTests\\http\\tests\\passes\\text.html', - '\\test.checkout\\LayoutTests\\http\\tests\\ssl\\text.html'] + ['http/tests/passes/image.html', + 'http/tests/passes/text.html', + 'http/tests/ssl/text.html', + 'platform/test-mac-leopard/http/test.html'] [499/1640] webkitpy.layout_tests.controllers.layout_test_finder_legacy_unittest.LayoutTestFinderTests.test_find_directory_multiple_times 1836690 1 450715 fujii 2022-02-02 16:14:53 -0800 Created attachment 450715 Patch 1836995 2 gsnedders 2022-02-03 10:24:39 -0800 Ah, gah, sorry about this regression! I'd actually realised I was breaking the tests in this way and had worked around it locally (essentially by maintaining the existing semantics of always running the tests under an emulated UNIX-like filesystem), but clearly I uploaded an outdated patch. This is, however, undoubtedly better, given you're fixing the actual reason for the failure! 1837040 3 450715 fujii 2022-02-03 11:53:25 -0800 Comment on attachment 450715 Patch Thank you for the review. 1837048 4 ews-feeder 2022-02-03 12:16:27 -0800 Committed r289067 (246774@main): <https://commits.webkit.org/246774@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450715. 1837049 5 webkit-bug-importer 2022-02-03 12:17:18 -0800 <rdar://problem/88449289> 1837534 6 commit-queue 2022-02-04 11:44:22 -0800 Re-opened since this is blocked by bug 236149 1837974 7 451058 fujii 2022-02-06 18:18:59 -0800 Created attachment 451058 Patch 1837995 8 ews-feeder 2022-02-06 20:43:12 -0800 Committed r289197 (246883@main): <https://commits.webkit.org/246883@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451058. 450715 2022-02-02 16:14:53 -0800 2022-02-06 18:18:49 -0800 Patch bug-236043-20220203091451.patch text/plain 1854 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4OTkyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggMDU5OTMwMGM1MGUwNmFhMjA3NzAxY2U1ZTJkMzg4OWZm MGYyMTg4ZC4uMTY0MGJmYmNjZTRjNWI0MzM4MmYzNDdhNDQzMWE5MTdlY2I2NTFlNiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0 IEBACisyMDIyLTAyLTAyICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29t PgorCisgICAgICAgIFJFR1JFU1NJT04ocjI4ODg3OCkgd2Via2l0cHkubGF5b3V0X3Rlc3RzLmNv bnRyb2xsZXJzLmxheW91dF90ZXN0X2ZpbmRlcl9sZWdhY3lfdW5pdHRlc3QuTGF5b3V0VGVzdEZp bmRlclRlc3RzIHRlc3RzIGFyZSBmYWlsaW5nIHdpdGggV2luZG93cyBQeXRob24KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNjA0MworCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRw eS9wb3J0L2Jhc2UucHk6CisgICAgICAgIChQb3J0LnJlbGF0aXZlX3Rlc3RfZmlsZW5hbWUpOiBO b3JtYWxpemUgZmlsZW5hbWUgd2l0aAorICAgICAgICBURVNUX1BBVEhfU0VQQVJBVE9SIGJlZm9y ZSBjb21wYXJpbmcgd2l0aCBsYXlvdXRfdGVzdHNfZGlyKCkuCisKIDIwMjItMDItMDIgIFNhaWQg QWJvdS1IYWxsYXdhICA8c2FpZEBhcHBsZS5jb20+CiAKICAgICAgICAgW0dQVSBQcm9jZXNzXSBS ZW1vdmUgRGlzcGxheUxpc3Q6OlJlcGxheWVyOjpEZWxlZ2F0ZSBhbmQgRGlzcGxheUxpc3Q6OlJl Y29yZGVySW1wbDo6RGVsZWdhdGUKZGlmZiAtLWdpdCBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv cG9ydC9iYXNlLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2Jhc2UucHkKaW5kZXgg NmM1Y2MzNTcyZjI3NTdlNzBhNDA4ZDc1ZjdhOTlmNTMwMjA4ZTAxYy4uMmExMmEwOWMyYjU5ZWUz ZGMyNGNiODEzNWMxMmFiNmI0NGFlYTY0NyAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS9wb3J0L2Jhc2UucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2Jhc2Uu cHkKQEAgLTcxOCw4ICs3MTgsNyBAQCBjbGFzcyBQb3J0KG9iamVjdCk6CiAgICAgZGVmIHJlbGF0 aXZlX3Rlc3RfZmlsZW5hbWUoc2VsZiwgZmlsZW5hbWUpOgogICAgICAgICAiIiJSZXR1cm5zIGEg dGVzdF9uYW1lIGEgcmVsYXRpdmUgdW5peC1zdHlsZSBwYXRoIGZvciBhIGZpbGVuYW1lIHVuZGVy IHRoZSBMYXlvdXRUZXN0cwogICAgICAgICBkaXJlY3RvcnkuIFBvcnRzIG1heSBsZWdpdGltYXRl bHkgcmV0dXJuIGFic3BhdGhzIGhlcmUgaWYgbm8gcmVscGF0aCBtYWtlcyBzZW5zZS4iIiIKLSAg ICAgICAgIyBQb3J0cyB0aGF0IHJ1biBvbiB3aW5kb3dzIG5lZWQgdG8gb3ZlcnJpZGUgdGhpcyBt ZXRob2QgdG8gZGVhbCB3aXRoCi0gICAgICAgICMgZmlsZW5hbWVzIHdpdGggYmFja3NsYXNoZXMg aW4gdGhlbS4KKyAgICAgICAgZmlsZW5hbWUgPSBmaWxlbmFtZS5yZXBsYWNlKHNlbGYuaG9zdC5m aWxlc3lzdGVtLnNlcCwgc2VsZi5URVNUX1BBVEhfU0VQQVJBVE9SKQogICAgICAgICBpZiBmaWxl bmFtZS5zdGFydHN3aXRoKHNlbGYubGF5b3V0X3Rlc3RzX2RpcigpKToKICAgICAgICAgICAgIHJl dHVybiBzZWxmLmhvc3QuZmlsZXN5c3RlbS5yZWxwYXRoKGZpbGVuYW1lLCBzZWxmLmxheW91dF90 ZXN0c19kaXIoKSkucmVwbGFjZShzZWxmLmhvc3QuZmlsZXN5c3RlbS5zZXAsIHNlbGYuVEVTVF9Q QVRIX1NFUEFSQVRPUikKICAgICAgICAgZWxzZToK 451058 2022-02-06 18:18:59 -0800 2022-02-06 20:43:13 -0800 Patch bug-236043-20220207111858.patch text/plain 1857 fujii U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5MTg5CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggNGVmOGI0ZDc5NTBkNTYyOGFmYjJiZDRiOTE3NTc2MTU0 NDVjZjQzMS4uZjI3ZjUxMjJiMjgxNDMxNTQ5NWMwYjI5NzE4MzE3NTZiZjI5MjUxMSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDIyLTAyLTA2ICBGdWppaSBIaXJvbm9yaSAgPEhpcm9ub3JpLkZ1amlpQHNvbnkuY29t PgorCisgICAgICAgIFJFR1JFU1NJT04ocjI4ODg3OCkgd2Via2l0cHkubGF5b3V0X3Rlc3RzLmNv bnRyb2xsZXJzLmxheW91dF90ZXN0X2ZpbmRlcl9sZWdhY3lfdW5pdHRlc3QuTGF5b3V0VGVzdEZp bmRlclRlc3RzIHRlc3RzIGFyZSBmYWlsaW5nIHdpdGggV2luZG93cyBQeXRob24KKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNjA0MworICAgICAgICA8 cmRhcjovL3Byb2JsZW0vODg0NDkyODk+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgU2luY2UgcjI4ODg3OCBzdGFydGVkIHRvIHVzZSBweWZha2Vmcywg UG9ydC5yZWxhdGl2ZV90ZXN0X2ZpbGVuYW1lCisgICAgICAgIGRpZG4ndCB3b3JrIGFzIGV4cGVj dGVkIGluIHVuaXQgdGVzdHMgd2l0aCBXaW5kb3dzIFB5dGhvbiBiZWNhdXNlCisgICAgICAgIFRl c3RQb3J0LmxheW91dF90ZXN0c19kaXIgcmV0dXJuZWQgVW5peC1zdHlsZSBwYXRoIHdoaWxlIHRo ZSBwYXRoCisgICAgICAgIG5hbWUgb2YgbGF5b3V0IHRlc3QgaXMgV2luZG93cy1zdHlsZSBwYXRo LgorCisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9wb3J0L3Rlc3QucHk6IFVzZSBhYnNwYXRo IHRvIGNvbnZlcnQgVW5peC1zdHlsZQorICAgICAgICBwYXRoIHRvIFdpbmRvd3Mtc3R5bGUgZm9y IFdpbmRvd3MgUHl0aG9uLgorCiAyMDIyLTAyLTA2ICBZdXN1a2UgU3V6dWtpICA8eXN1enVraUBh cHBsZS5jb20+CiAKICAgICAgICAgW1dURl0gTWFrZSBCaXRtYXAgY29uc3RleHByIGZyaWVuZGx5 CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvdGVzdC5weSBiL1Rvb2xz L1NjcmlwdHMvd2Via2l0cHkvcG9ydC90ZXN0LnB5CmluZGV4IDkwOGZmY2Q2OTFkMmUwZGM3MTYz MjYzZjRjNDMxNzZlYjYzZTNlMzAuLmExYjhmNmNlMjE3Nzc2NzNkNTRkYjEzMzk1NWVmZmE5MGNj Zjg2NzEgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC90ZXN0LnB5Cisr KyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC90ZXN0LnB5CkBAIC00NDEsMTAgKzQ0MSwx MCBAQCBjbGFzcyBUZXN0UG9ydChQb3J0KToKICAgICAgICAgcmV0dXJuIEltYWdlRGlmZlJlc3Vs dChwYXNzZWQ9VHJ1ZSwgZGlmZl9pbWFnZT1Ob25lLCBkaWZmZXJlbmNlPTAsIHRvbGVyYW5jZT10 b2xlcmFuY2Ugb3IgMCwgZnV6enlfZGF0YT17J21heF9kaWZmZXJlbmNlJzogMCwgJ3RvdGFsX3Bp eGVscyc6IDB9KQogCiAgICAgZGVmIGxheW91dF90ZXN0c19kaXIoc2VsZik6Ci0gICAgICAgIHJl dHVybiBMQVlPVVRfVEVTVF9ESVIKKyAgICAgICAgcmV0dXJuIHNlbGYuX2ZpbGVzeXN0ZW0uYWJz cGF0aChMQVlPVVRfVEVTVF9ESVIpCiAKICAgICBkZWYgcGVyZl90ZXN0c19kaXIoc2VsZik6Ci0g ICAgICAgIHJldHVybiBQRVJGX1RFU1RfRElSCisgICAgICAgIHJldHVybiBzZWxmLl9maWxlc3lz dGVtLmFic3BhdGgoUEVSRl9URVNUX0RJUikKIAogICAgIGRlZiB3ZWJraXRfYmFzZShzZWxmKToK ICAgICAgICAgcmV0dXJuICcvdGVzdC5jaGVja291dCcK