23602 2009-01-28 14:26:44 -0800 add another piece (left out earlier) in platform/graphics/chromium 2009-02-04 15:23:24 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Enhancement --- 1 jshin jshin dglazkov oldest_to_newest 107404 0 jshin 2009-01-28 14:26:44 -0800 This is what's left out in the patch for bug 23340 (I should have made certain that this was landed as a part of the patch, but due to a 'bad timing', this piece missed the train). This patch is for non-BMP characters in Chromium-Win. 107410 1 27125 jshin 2009-01-28 14:45:07 -0800 Created attachment 27125 patch Recap from ChangeLog (FYI): This comes from Chromium patch (http://codereview.chromium.org/17624). Add m_disableFontFallback to UniscriberHelper class and set it to true when filling up glyph pages for non-BMP code points. When it's set true, UniscriberHelper does not do its own font fallback. Neither does it do glyph placement. Font fallback will be taken care of in the simple script font path and glyph placement is not necessary for simple scripts. Layout test is missing at the moment due to the lack of freely distributable font covering a non-BMP code page. A test page is available at http://i18nl10n.com/webkit/nonbmp2.html As for the layout test, I plan to make a simple TTF with 'ugly' glyphs covering a small number of non-BMP characters. 108177 2 27125 eric 2009-02-03 14:57:14 -0800 Comment on attachment 27125 patch This looks fine. I'll land after fixing the spacing on one indent. 108343 3 eric 2009-02-04 15:16:50 -0800 Sigh. It looks like this patch file was modified after it was created. :( That's bad, cause it means it won't apply. I fixed up the ChangeLog section of the patch to apply, looks like a line was removed from the ChangeLog portion of the patchfile instead of removing the line first from the ChangeLog and regenerating the patch file. 108345 4 eric 2009-02-04 15:23:24 -0800 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp M WebCore/platform/graphics/chromium/UniscribeHelper.cpp M WebCore/platform/graphics/chromium/UniscribeHelper.h Committed r40635 Thanks! 27125 2009-01-28 14:45:07 -0800 2009-02-03 14:57:14 -0800 patch 23602.patch.1 text/plain 5565 jshin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MDMyNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMzIgQEAKKzIwMDktMDEtMjggIEp1bmdzaGlrIFNoaW4gPGpzaGluQGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBU aGlzIGNvbWVzIGZyb20gQ2hyb21pdW0gcGF0Y2ggKGh0dHA6Ly9jb2RlcmV2aWV3LmNocm9taXVt Lm9yZy8xNzYyNCkuCisKKyAgICAgICAgQWRkIG1fZGlzYWJsZUZvbnRGYWxsYmFjayB0byBVbmlz Y3JpYmVySGVscGVyIGNsYXNzIGFuZCBzZXQgaXQKKyAgICAgICAgdG8gdHJ1ZSB3aGVuIGZpbGxp bmcgdXAgZ2x5cGggcGFnZXMgZm9yIG5vbi1CTVAgY29kZSBwb2ludHMuCisgICAgICAgIFdoZW4g aXQncyBzZXQgdHJ1ZSwgVW5pc2NyaWJlckhlbHBlciBkb2VzIG5vdCBkbyBpdHMgb3duIGZvbnQK KyAgICAgICAgZmFsbGJhY2suIE5laXRoZXIgZG9lcyBpdCBkbyBnbHlwaCBwbGFjZW1lbnQuIEZv bnQgZmFsbGJhY2sKKyAgICAgICAgd2lsbCBiZSB0YWtlbiBjYXJlIG9mIGluIHRoZSBzaW1wbGUg c2NyaXB0IGZvbnQgcGF0aCBhbmQgZ2x5cGgKKyAgICAgICAgcGxhY2VtZW50IGlzIG5vdCBuZWNl c3NhcnkgZm9yIHNpbXBsZSBzY3JpcHRzLgorCisgICAgICAgIExheW91dCB0ZXN0IGlzIG1pc3Np bmcgYXQgdGhlIG1vbWVudCBkdWUgdG8gdGhlIGxhY2sgb2YgZnJlZWx5CisgICAgICAgIGRpc3Ry aWJ1dGFibGUgZm9udCBjb3ZlcmluZyBhIG5vbi1CTVAgY29kZSBwYWdlLiBBIHRlc3QgcGFnZQor ICAgICAgICBpcyBhdmFpbGFibGUgYXQgaHR0cDovL2kxOG5sMTBuLmNvbS93ZWJraXQvbm9uYm1w Mi5odG1sCisKKyAgICAgICAgU2VlIGFsc28gaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIzNjAyCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9H bHlwaFBhZ2VUcmVlTm9kZUNocm9taXVtV2luLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmZpbGxO b25CTVBHbHlwaHMpOgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2Nocm9taXVtL1VuaXNj cmliZUhlbHBlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpVbmlzY3JpYmVIZWxwZXI6OlVuaXNj cmliZUhlbHBlcik6CisgICAgICAgIChXZWJDb3JlOjpVbmlzY3JpYmVIZWxwZXI6OnNoYXBlKToK KyAgICAgICAgKFdlYkNvcmU6OlVuaXNjcmliZUhlbHBlcjo6ZmlsbFNoYXBlcyk6CisgICAgICAg ICogcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vVW5pc2NyaWJlSGVscGVyLmg6CisgICAgICAg IChXZWJDb3JlOjpVbmlzY3JpYmVIZWxwZXI6OnNldERpc2FibGVGb250RmFsbGJhY2spOgorCiAy MDA5LTAxLTI4ICBEYXZpZCBIeWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KIAogICAgICAgICBNb3Zl IGNyZWF0ZUlubGluZUJveCBvdXQgb2YgUmVuZGVyRmxvdyBhbmQgZG93biBpbnRvIFJlbmRlcklu bGluZSBhbmQgUmVuZGVyQmxvY2suCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2No cm9taXVtL0dseXBoUGFnZVRyZWVOb2RlQ2hyb21pdW1XaW4uY3BwCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vR2x5cGhQYWdlVHJlZU5vZGVDaHJvbWl1 bVdpbi5jcHAJKHJldmlzaW9uIDQwMzE2KQorKysgV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9j aHJvbWl1bS9HbHlwaFBhZ2VUcmVlTm9kZUNocm9taXVtV2luLmNwcAkod29ya2luZyBjb3B5KQpA QCAtMjA1LDYgKzIwNSw3IEBAIHN0YXRpYyBib29sIGZpbGxOb25CTVBHbHlwaHModW5zaWduZWQg b2YKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZvbnREYXRhLT5tX2ZvbnQuc2Ny aXB0Q2FjaGUoKSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGZvbnREYXRhLT5t X2ZvbnQuc2NyaXB0Rm9udFByb3BlcnRpZXMoKSk7CiAgICAgc3RhdGUuc2V0SW5oaWJpdExpZ2F0 ZSh0cnVlKTsKKyAgICBzdGF0ZS5zZXREaXNhYmxlRm9udEZhbGxiYWNrKHRydWUpOwogICAgIHN0 YXRlLmluaXQoKTsKIAogICAgIGZvciAodW5zaWduZWQgaSA9IDA7IGkgPCBsZW5ndGg7IGkrKykg ewpJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJvbWl1bS9VbmlzY3JpYmVIZWxw ZXIuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0v VW5pc2NyaWJlSGVscGVyLmNwcAkocmV2aXNpb24gNDAzMTYpCisrKyBXZWJDb3JlL3BsYXRmb3Jt L2dyYXBoaWNzL2Nocm9taXVtL1VuaXNjcmliZUhlbHBlci5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTExMiw2ICsxMTIsOCBAQCBVbmlzY3JpYmVIZWxwZXI6OlVuaXNjcmliZUhlbHBlcihjb25zdCBV CiAgICAgLCBtX3NwYWNlV2lkdGgoMCkKICAgICAsIG1fd29yZFNwYWNpbmcoMCkKICAgICAsIG1f YXNjZW50KDApCisgICAgLCBtX2Rpc2FibGVGb250RmFsbGJhY2soZmFsc2UpCisKIHsKICAgICBt X2xvZ2ZvbnQubGZGYWNlTmFtZVswXSA9IDA7CiB9CkBAIC01MjcsNyArNTI5LDEwIEBAIGJvb2wg VW5pc2NyaWJlSGVscGVyOjpzaGFwZShjb25zdCBVQ2hhcioKICAgICBIREMgdGVtcERDID0gMDsK ICAgICBIR0RJT0JKIG9sZEZvbnQgPSAwOwogICAgIEhSRVNVTFQgaHI7Ci0gICAgYm9vbCBsYXN0 RmFsbGJhY2tUcmllZCA9IGZhbHNlOworICAgIC8vIFdoZW4gdXNlZCB0byBmaWxsIHVwIGdseXBo IHBhZ2VzIGZvciBzaW1wbGUgc2NyaXB0cyBpbiBub24tQk1QLAorICAgIC8vIHdlIGRvbid0IHdh bnQgYW55IGZvbnQgZmFsbGJhY2sgaW4gdGhpcyBjbGFzcy4gVGhlIHNpbXBsZSBzY3JpcHQKKyAg ICAvLyBmb250IHBhdGggY2FuIHRha2UgY2FyZSBvZiBmb250IGZhbGxiYWNrLgorICAgIGJvb2wg bGFzdEZhbGxiYWNrVHJpZWQgPSBtX2Rpc2FibGVGb250RmFsbGJhY2s7CiAgICAgYm9vbCByZXN1 bHQ7CiAKICAgICBpbnQgZ2VuZXJhdGVkR2x5cGhzID0gMDsKQEAgLTU4Nyw3ICs1OTIsOCBAQCBi b29sIFVuaXNjcmliZUhlbHBlcjo6c2hhcGUoY29uc3QgVUNoYXIqCiAgICAgICAgICAgICB0ZW1w REMgPSAwOwogICAgICAgICB9CiAKLSAgICAgICAgaWYgKG5leHRXaW5Gb250RGF0YSgmaGZvbnQs ICZzY3JpcHRDYWNoZSwgJmZvbnRQcm9wZXJ0aWVzLCAmYXNjZW50KSkgeworICAgICAgICBpZiAo IW1fZGlzYWJsZUZvbnRGYWxsYmFjayAmJgorICAgICAgICAgICAgbmV4dFdpbkZvbnREYXRhKCZo Zm9udCwgJnNjcmlwdENhY2hlLCAmZm9udFByb3BlcnRpZXMsICZhc2NlbnQpKSB7CiAgICAgICAg ICAgICAvLyBUaGUgcHJpbWFyeSBmb250IGRvZXMgbm90IHN1cHBvcnQgdGhpcyBydW4uIFRyeSBu ZXh0IGZvbnQuCiAgICAgICAgICAgICAvLyBJbiBjYXNlIG9mIHdlYiBwYWdlIHJlbmRlcmluZywg dGhleSBjb21lIGZyb20gZm9udHMgc3BlY2lmaWVkIGluCiAgICAgICAgICAgICAvLyBDU1Mgc3R5 bGVzaGVldHMuCkBAIC03MDIsNiArNzA4LDEzIEBAIHZvaWQgVW5pc2NyaWJlSGVscGVyOjpmaWxs U2hhcGVzKCkKICAgICAgICAgaWYgKCFzaGFwZSgmbV9pbnB1dFtzdGFydEl0ZW1dLCBpdGVtTGVu Z3RoLCBudW1HbHlwaHMsIG1fcnVuc1tpXSwgc2hhcGluZykpCiAgICAgICAgICAgICBjb250aW51 ZTsKIAorICAgICAgICAvLyBBdCB0aGUgbW9tZW50LCB0aGUgb25seSB0aW1lIG1fZGlzYWJsZUZv bnRGYWxsYmFjayBpcyBzZXQgaXMKKyAgICAgICAgLy8gd2hlbiB3ZSBsb29rIHVwIGdseXBoIGlu ZGljZXMgZm9yIG5vbi1CTVAgY29kZSByYW5nZXMuIFNvLAorICAgICAgICAvLyB3ZSBjYW4gc2tp cCB0aGUgZ2x5cGggcGxhY2VtZW50LiBXaGVuIHRoYXQgYmVjb21lcyBub3QgdGhlIGNhc2UKKyAg ICAgICAgLy8gYW55IG1vcmUsIHdlIGhhdmUgdG8gYWRkIGEgbmV3IGZsYWcgdG8gY29udHJvbCBn bHlwaCBwbGFjZW1lbnQuCisgICAgICAgIGlmIChtX2Rpc2FibGVGb250RmFsbGJhY2spCisgICAg ICAgICAgY29udGludWU7CisKICAgICAgICAgLy8gQ29tcHV0ZSBwbGFjZW1lbnRzLiBOb3RlIHRo YXQgb2Zmc2V0cyBpcyBkb2N1bWVudGVkIGluY29ycmVjdGx5CiAgICAgICAgIC8vIGFuZCBpcyBh Y3R1YWxseSBhbiBhcnJheS4KIApJbmRleDogV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9jaHJv bWl1bS9VbmlzY3JpYmVIZWxwZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2Nocm9taXVtL1VuaXNjcmliZUhlbHBlci5oCShyZXZpc2lvbiA0MDMxNikKKysrIFdl YkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvY2hyb21pdW0vVW5pc2NyaWJlSGVscGVyLmgJKHdvcmtp bmcgY29weSkKQEAgLTE0NSw2ICsxNDUsMTYgQEAgcHVibGljOgogICAgICAgICBtX2FzY2VudCA9 IGFzY2VudDsKICAgICB9CiAKKyAgICAvLyBXaGVuIHNldCB0byB0cnVlLCB0aGlzIGNsYXNzIGlz IHVzZWQgb25seSB0byBsb29rIHVwIGdseXBoCisgICAgLy8gaW5kaWNlcyBmb3IgYSByYW5nZSBv ZiBVbmljb2RlIGNoYXJhY3RlcnMgd2l0aG91dCBnbHlwaCBwbGFjZW1lbnQuCisgICAgLy8gQnkg ZGVmYXVsdCwgaXQncyBmYWxzZS4gVGhpcyBzaG91bGQgYmUgc2V0IHRvIHRydWUgd2hlbiB0aGlz CisgICAgLy8gY2xhc3MgaXMgdXNlZCBmb3IgZ2x5cGggaW5kZXggbG9vay11cCBmb3Igbm9uLUJN UCBjaGFyYWN0ZXJzCisgICAgLy8gaW4gR2x5cGhQYWdlTm9kZUNocm9taXVtV2luLmNwcC4KKyAg ICB2b2lkIHNldERpc2FibGVGb250RmFsbGJhY2soYm9vbCBkaXNhYmxlRm9udEZhbGxiYWNrKQor ICAgIHsKKyAgICAgICAgbV9kaXNhYmxlRm9udEZhbGxiYWNrID0gdHJ1ZTsKKyAgICB9CisKICAg ICAvLyBZb3UgbXVzdCBjYWxsIHRoaXMgYWZ0ZXIgc2V0dGluZyBhbnkgb3B0aW9ucyBidXQgYmVm b3JlIGRvaW5nIGFueQogICAgIC8vIG90aGVyIGNhbGxzIGxpa2UgYXNraW5nIGZvciB3aWR0aHMg b3IgZHJhd2luZy4KICAgICB2b2lkIGluaXQoKQpAQCAtMzc4LDYgKzM4OCw3IEBAIHByaXZhdGU6 CiAgICAgaW50IG1fbGV0dGVyU3BhY2luZzsKICAgICBpbnQgbV9zcGFjZVdpZHRoOwogICAgIGlu dCBtX3dvcmRTcGFjaW5nOworICAgIGJvb2wgbV9kaXNhYmxlRm9udEZhbGxiYWNrOwogCiAgICAg Ly8gVW5pc2NyaWJlIGJyZWFrcyB0aGUgdGV4dCBpbnRvIFJ1bnMuIFRoZXNlIGFyZSBvbmUgbGVu Z3RoIG9mIHRleHQgdGhhdCBpcwogICAgIC8vIGluIG9uZSBzY3JpcHQgYW5kIG9uZSBkaXJlY3Rp b24uIFRoaXMgYXJyYXkgaXMgaW4gcmVhZGluZyBvcmRlci4K