236014 2022-02-02 06:42:36 -0800 [JSC] Remove compiler warning in TrailingArray.h 2022-02-02 13:40:17 -0800 1 1 1 Unclassified WebKit JavaScriptCore WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 xan.lopez webkit-unassigned benjamin cdumez cmarcelo ews-watchlist webkit-bug-importer xan.lopez ysuzuki oldest_to_newest 1836422 0 xan.lopez 2022-02-02 06:42:36 -0800 std::distance returns 'int' here, and we are comparing it with an unsigned int size. I believe we just care about the absolute value in the comparison, so use std::abs. Warning: WTF/Headers/wtf/TrailingArray.h: In instantiation of 'WTF::TrailingArray<Derived, T>::TrailingArray(unsigned int, InputIterator, InputIterator) [with InputIterator = const JSC::RegisterAtOffset*; Derived = WTF::EmbeddedFixedVector<JSC::RegisterAtOffset>; T = JSC::RegisterAtOffset]': WTF/Headers/wtf/EmbeddedFixedVector.h:99:33: required from 'WTF::EmbeddedFixedVector<T>::EmbeddedFixedVector(unsigned int, InputIterator, InputIterator) [with InputIterator = const JSC::RegisterAtOffset*; T = JSC::RegisterAtOffset]' WTF/Headers/wtf/EmbeddedFixedVector.h:52:29: required from 'static WTF::UniqueRef<WTF::EmbeddedFixedVector<T> > WTF::EmbeddedFixedVector<T>::create(InputIterator, InputIterator) [with InputIterator = const JSC::RegisterAtOffset*; T = JSC::RegisterAtOffset]' WTF/Headers/wtf/EmbeddedFixedVector.h:72:22: required from 'WTF::UniqueRef<WTF::EmbeddedFixedVector<T> > WTF::EmbeddedFixedVector<T>::clone() const [with T = JSC::RegisterAtOffset]' WTF/Headers/wtf/FixedVector.h:43:61: required from 'WTF::FixedVector< <template-parameter-1-1> >::FixedVector(const WTF::FixedVector< <template-parameter-1-1> >&) [with T = JSC::RegisterAtOffset]' WTF/Headers/wtf/FixedVector.h:59:21: required from 'WTF::FixedVector< <template-parameter-1-1> >& WTF::FixedVector< <template-parameter-1-1> >::operator=(const WTF::FixedVector< <template-parameter-1-1> >&) [with T = JSC::RegisterAtOffset]' ../../Source/JavaScriptCore/jit/RegisterAtOffsetList.h:37:7: required from here WTF/Headers/wtf/TrailingArray.h:69:43: warning: comparison of integer expressions of different signedness: 'std::iterator_traits<const JSC::RegisterAtOffset*>::difference_type' {aka 'int'} and 'unsigned int' [-Wsign-compare] 69 | ASSERT(std::distance(first, last) == size); WTF/Headers/wtf/Assertions.h:356:11: note: in definition of macro 'ASSERT' 356 | if (!(assertion)) { \ 1836423 1 450642 xan.lopez 2022-02-02 06:44:51 -0800 Created attachment 450642 v1 Remove compiler warning. 1836536 2 450642 ysuzuki 2022-02-02 11:04:04 -0800 Comment on attachment 450642 v1 View in context: https://bugs.webkit.org/attachment.cgi?id=450642&action=review > Source/WTF/wtf/TrailingArray.h:69 > + ASSERT(std::abs(std::distance(first, last)) == size); I think `static_cast<size_t>(std::distance(first, last))` is better. 1836548 3 450678 xan.lopez 2022-02-02 11:29:04 -0800 Created attachment 450678 v2 Fix compiler warning with static_cast 1836618 4 ews-feeder 2022-02-02 13:39:15 -0800 Committed r288993 (246712@main): <https://commits.webkit.org/246712@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450678. 1836619 5 webkit-bug-importer 2022-02-02 13:40:17 -0800 <rdar://problem/88399028> 450642 2022-02-02 06:44:51 -0800 2022-02-02 11:29:04 -0800 v1 0001-JSC-Remove-compiler-warning-in-TrailingArray.h.patch text/plain 1767 xan.lopez RnJvbSA1ZmRhYjViMDlhOTE4NTQxZDUwOTdlYzcwNDVmNDBhYTczNTY3MjFkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/WGFuPTIwTD1DMz1CM3Blej89IDx4YW5AaWdh bGlhLmNvbT4KRGF0ZTogV2VkLCAyIEZlYiAyMDIyIDE1OjQzOjQzICswMTAwClN1YmplY3Q6IFtQ QVRDSF0gW0pTQ10gUmVtb3ZlIGNvbXBpbGVyIHdhcm5pbmcgaW4gVHJhaWxpbmdBcnJheS5oCiBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM2MDE0CgpSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KCiogd3RmL1RyYWlsaW5nQXJyYXkuaDoKKFdURjo6VHJhaWxpbmdB cnJheTo6VHJhaWxpbmdBcnJheSk6IHVzZSBzdGQ6OmFicyB0byBjb21wYXJlIHRoZQphYnNvbHV0 ZSB2YWx1ZSBvZiB0aGUgZGlzdGFuY2Ugd2l0aCB0aGUgJ3Vuc2lnbmVkIGludCcgc2l6ZS4KLS0t CiBTb3VyY2UvV1RGL0NoYW5nZUxvZyAgICAgICAgICAgfCAxMSArKysrKysrKysrKwogU291cmNl L1dURi93dGYvVHJhaWxpbmdBcnJheS5oIHwgIDIgKy0KIDIgZmlsZXMgY2hhbmdlZCwgMTIgaW5z ZXJ0aW9ucygrKSwgMSBkZWxldGlvbigtKQoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdl TG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKaW5kZXggM2U0YmFlNTJkNTNiLi5iNTdiYjZhMWIz ODggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjItMDItMDIgIFhhbiBMb3BleiAgPHhhbkBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtKU0NdIFJlbW92ZSBjb21waWxlciB3YXJuaW5nIGluIFRyYWls aW5nQXJyYXkuaAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjM2MDE0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAg ICAgKiB3dGYvVHJhaWxpbmdBcnJheS5oOgorICAgICAgICAoV1RGOjpUcmFpbGluZ0FycmF5OjpU cmFpbGluZ0FycmF5KTogdXNlIHN0ZDo6YWJzIHRvIGNvbXBhcmUgdGhlCisgICAgICAgIGFic29s dXRlIHZhbHVlIG9mIHRoZSBkaXN0YW5jZSB3aXRoIHRoZSAndW5zaWduZWQgaW50JyBzaXplLgor CiAyMDIyLTAxLTI4ICBDaHJpcyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CiAKICAgICAgICAg QVNTRVJUSU9OIEZBSUxFRDogbV9wcm9jZXNzQ2FsbGJhY2sgaW4gV2ViQ29yZTo6QXVkaW9Xb3Jr bGV0UHJvY2Vzc29yOjpwcm9jZXNzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9UcmFpbGlu Z0FycmF5LmggYi9Tb3VyY2UvV1RGL3d0Zi9UcmFpbGluZ0FycmF5LmgKaW5kZXggNzVjMjZlNzZm ZDkxLi4zMmJlMDQ0NTM2NzYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1RyYWlsaW5nQXJy YXkuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9UcmFpbGluZ0FycmF5LmgKQEAgLTY2LDcgKzY2LDcg QEAgcHVibGljOgogICAgICAgICA6IG1fc2l6ZShzaXplKQogICAgIHsKICAgICAgICAgc3RhdGlj X2Fzc2VydChzdGQ6OmlzX2ZpbmFsX3Y8RGVyaXZlZD4pOwotICAgICAgICBBU1NFUlQoc3RkOjpk aXN0YW5jZShmaXJzdCwgbGFzdCkgPT0gc2l6ZSk7CisgICAgICAgIEFTU0VSVChzdGQ6OmFicyhz dGQ6OmRpc3RhbmNlKGZpcnN0LCBsYXN0KSkgPT0gc2l6ZSk7CiAgICAgICAgIHN0ZDo6dW5pbml0 aWFsaXplZF9jb3B5KGZpcnN0LCBsYXN0LCBiZWdpbigpKTsKICAgICB9CiAKLS0gCjIuMzQuMQoK 450678 2022-02-02 11:29:04 -0800 2022-02-02 13:39:18 -0800 v2 0001-JSC-Remove-compiler-warning-in-TrailingArray.h.patch text/plain 1860 xan.lopez RnJvbSBlNTQwZjZjNzk2MDM0NmU3NWQ0NGFlOWIwODFkNjJiZWY2ZTQ4OGJmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiA9P1VURi04P3E/WGFuPTIwTD1DMz1CM3Blej89IDx4YW5AaWdh bGlhLmNvbT4KRGF0ZTogV2VkLCAyIEZlYiAyMDIyIDE1OjQzOjQzICswMTAwClN1YmplY3Q6IFtQ QVRDSF0gW0pTQ10gUmVtb3ZlIGNvbXBpbGVyIHdhcm5pbmcgaW4gVHJhaWxpbmdBcnJheS5oCiBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM2MDE0CgpSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KCiogd3RmL1RyYWlsaW5nQXJyYXkuaDoKKFdURjo6VHJhaWxpbmdB cnJheTo6VHJhaWxpbmdBcnJheSk6IGNhc3QgdGhlIHN0ZDo6ZGlzdGFuY2UgcmVzdWx0CnRvIHNp emVfdCwgd2Ugd2FudCB0byBjb21wYXJlIHRoZSBhYnNvbHV0ZSB2YWx1ZSBvZiB0aGUgZGlzdGFu Y2UKd2l0aCB0aGUgJ3Vuc2lnbmVkIGludCcgc2l6ZS4KLS0tCiBTb3VyY2UvV1RGL0NoYW5nZUxv ZyAgICAgICAgICAgfCAxMiArKysrKysrKysrKysKIFNvdXJjZS9XVEYvd3RmL1RyYWlsaW5nQXJy YXkuaCB8ICAyICstCiAyIGZpbGVzIGNoYW5nZWQsIDEzIGluc2VydGlvbnMoKyksIDEgZGVsZXRp b24oLSkKCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5nZUxvZyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCmluZGV4IDNlNGJhZTUyZDUzYi4uNzMxZTkxMDYyZjllIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV1RGL0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV1RGL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDIyLTAyLTAyICBYYW4gTG9wZXogIDx4YW5AaWdhbGlhLmNvbT4KKworICAgICAgICBb SlNDXSBSZW1vdmUgY29tcGlsZXIgd2FybmluZyBpbiBUcmFpbGluZ0FycmF5LmgKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNjAxNAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogd3RmL1RyYWlsaW5nQXJy YXkuaDoKKyAgICAgICAgKFdURjo6VHJhaWxpbmdBcnJheTo6VHJhaWxpbmdBcnJheSk6IGNhc3Qg dGhlIHN0ZDo6ZGlzdGFuY2UgcmVzdWx0CisgICAgICAgIHRvIHNpemVfdCwgd2Ugd2FudCB0byBj b21wYXJlIHRoZSBhYnNvbHV0ZSB2YWx1ZSBvZiB0aGUgZGlzdGFuY2UKKyAgICAgICAgd2l0aCB0 aGUgJ3Vuc2lnbmVkIGludCcgc2l6ZS4KKwogMjAyMi0wMS0yOCAgQ2hyaXMgRHVtZXogIDxjZHVt ZXpAYXBwbGUuY29tPgogCiAgICAgICAgIEFTU0VSVElPTiBGQUlMRUQ6IG1fcHJvY2Vzc0NhbGxi YWNrIGluIFdlYkNvcmU6OkF1ZGlvV29ya2xldFByb2Nlc3Nvcjo6cHJvY2VzcwpkaWZmIC0tZ2l0 IGEvU291cmNlL1dURi93dGYvVHJhaWxpbmdBcnJheS5oIGIvU291cmNlL1dURi93dGYvVHJhaWxp bmdBcnJheS5oCmluZGV4IDc1YzI2ZTc2ZmQ5MS4uZjJiYTllZjhkN2JjIDEwMDY0NAotLS0gYS9T b3VyY2UvV1RGL3d0Zi9UcmFpbGluZ0FycmF5LmgKKysrIGIvU291cmNlL1dURi93dGYvVHJhaWxp bmdBcnJheS5oCkBAIC02Niw3ICs2Niw3IEBAIHB1YmxpYzoKICAgICAgICAgOiBtX3NpemUoc2l6 ZSkKICAgICB7CiAgICAgICAgIHN0YXRpY19hc3NlcnQoc3RkOjppc19maW5hbF92PERlcml2ZWQ+ KTsKLSAgICAgICAgQVNTRVJUKHN0ZDo6ZGlzdGFuY2UoZmlyc3QsIGxhc3QpID09IHNpemUpOwor ICAgICAgICBBU1NFUlQoc3RhdGljX2Nhc3Q8c2l6ZV90PihzdGQ6OmRpc3RhbmNlKGZpcnN0LCBs YXN0KSkgPT0gc2l6ZSk7CiAgICAgICAgIHN0ZDo6dW5pbml0aWFsaXplZF9jb3B5KGZpcnN0LCBs YXN0LCBiZWdpbigpKTsKICAgICB9CiAKLS0gCjIuMzQuMQoK