236008 2022-02-02 01:27:45 -0800 Enable overflow:clip feature 2022-02-04 12:46:52 -0800 1 1 1 Unclassified WebKit CSS WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 198230 1 rbuis rbuis crzwdjk simon.fraser webkit-bug-importer oldest_to_newest 1836378 0 rbuis 2022-02-02 01:27:45 -0800 Enable overflow:clip feature. 1836379 1 450626 rbuis 2022-02-02 01:29:00 -0800 Created attachment 450626 Patch 1836495 2 webkit-bug-importer 2022-02-02 10:05:12 -0800 <rdar://problem/88387256> 1836508 3 crzwdjk 2022-02-02 10:22:35 -0800 Would it make sense to also unskip the tests still marked as skips and tagged with bug 198230? I.e. webkit.org/b/198230 imported/w3c/web-platform-tests/css/css-overflow/clip-003.html [ Skip ] webkit.org/b/198230 imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-intersection-observer.html [ Skip ] webkit.org/b/198230 imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-invalidation.html [ Skip ] webkit.org/b/198230 imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-001.html [ Skip ] webkit.org/b/198230 imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-002.html [ Skip ] webkit.org/b/198230 imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-003.html [ Skip ] webkit.org/b/198230 imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-004.html [ Skip ] webkit.org/b/198230 imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-005.html [ Skip ] webkit.org/b/198230 imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-006.html [ Skip ] webkit.org/b/198230 imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-007.html [ Skip ] 1836550 4 ews-feeder 2022-02-02 11:31:18 -0800 Committed r288973 (246702@main): <https://commits.webkit.org/246702@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450626. 1836632 5 rbuis 2022-02-02 14:07:24 -0800 (In reply to Arcady Goldmints-Orlov from comment #3) > Would it make sense to also unskip the tests still marked as skips and > tagged with bug 198230? I.e. > > webkit.org/b/198230 > imported/w3c/web-platform-tests/css/css-overflow/clip-003.html [ Skip ] > webkit.org/b/198230 > imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin- > intersection-observer.html [ Skip ] > webkit.org/b/198230 > imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin- > invalidation.html [ Skip ] > webkit.org/b/198230 > imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-001. > html [ Skip ] > webkit.org/b/198230 > imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-002. > html [ Skip ] > webkit.org/b/198230 > imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-003. > html [ Skip ] > webkit.org/b/198230 > imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-004. > html [ Skip ] > webkit.org/b/198230 > imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-005. > html [ Skip ] > webkit.org/b/198230 > imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-006. > html [ Skip ] > webkit.org/b/198230 > imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-007. > html [ Skip ] I think that is independent of this bug. i.e. they should pass (or not) independent of setting on by default (or not), as the tests should be run with experimental flags enabled. 1836869 6 rbuis 2022-02-03 04:31:39 -0800 (In reply to Arcady Goldmints-Orlov from comment #3) > Would it make sense to also unskip the tests still marked as skips and > tagged with bug 198230? I.e. > > webkit.org/b/198230 > imported/w3c/web-platform-tests/css/css-overflow/clip-003.html [ Skip ] > webkit.org/b/198230 > imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin- > intersection-observer.html [ Skip ] > webkit.org/b/198230 > imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin- > invalidation.html [ Skip ] > webkit.org/b/198230 > imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-001. > html [ Skip ] > webkit.org/b/198230 > imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-002. > html [ Skip ] > webkit.org/b/198230 > imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-003. > html [ Skip ] > webkit.org/b/198230 > imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-004. > html [ Skip ] > webkit.org/b/198230 > imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-005. > html [ Skip ] > webkit.org/b/198230 > imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-006. > html [ Skip ] > webkit.org/b/198230 > imported/w3c/web-platform-tests/css/css-overflow/overflow-clip-margin-007. > html [ Skip ] Now that I look closer, we do not support the overflow-clip-margin property so most of these should not pass. If clip-003.html passes then I am in favour of not skipping it. In general I think we may not be aggressive enough regarding enabling tests, many times I see "unexpected pass" locally. 1836960 7 simon.fraser 2022-02-03 09:07:55 -0800 Do we have a bug to implement overflow-clip-margin? 1837563 8 rbuis 2022-02-04 12:46:52 -0800 (In reply to Simon Fraser (smfr) from comment #7) > Do we have a bug to implement overflow-clip-margin? I could not find anything relevant, so I created https://bugs.webkit.org/show_bug.cgi?id=236153. 450626 2022-02-02 01:29:00 -0800 2022-02-02 11:31:20 -0800 Patch bug-236008-20220202092858.patch text/plain 1418 rbuis U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4OTQ1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDM1MWZkMTVlYzk1MTA3ZGExZjU1NTY5 OWE3ZDdhMGZmZWIyYzQ3NjkuLjU4ZDBhZDUxZTlkMWRlODM4OGY5YTU1MmMyZmFlM2E0NDk4N2Vk YzQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMjItMDItMDIgIFJvYiBCdWlzICA8cmJ1aXNAaWdh bGlhLmNvbT4KKworICAgICAgICBFbmFibGUgb3ZlcmZsb3c6Y2xpcCBmZWF0dXJlCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzYwMDgKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBFbmFibGUgb3ZlcmZsb3c6 Y2xpcCBmZWF0dXJlLgorCisgICAgICAgICogU2NyaXB0cy9QcmVmZXJlbmNlcy9XZWJQcmVmZXJl bmNlc0V4cGVyaW1lbnRhbC55YW1sOgorCiAyMDIyLTAyLTAxICBXZW5zb24gSHNpZWggIDx3ZW5z b25faHNpZWhAYXBwbGUuY29tPgogCiAgICAgICAgIFRoZSBkZWZhdWx0IHZhbHVlcyBmb3IgYSBj b3VwbGUgb2YgTGl2ZSBUZXh0LXJlbGF0ZWQgZmVhdHVyZXMgc2hvdWxkIHJlc3BlY3Qgc3lzdGVt IGZlYXR1cmUgZmxhZ3MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvU2NyaXB0cy9QcmVmZXJlbmNl cy9XZWJQcmVmZXJlbmNlc0V4cGVyaW1lbnRhbC55YW1sIGIvU291cmNlL1dURi9TY3JpcHRzL1By ZWZlcmVuY2VzL1dlYlByZWZlcmVuY2VzRXhwZXJpbWVudGFsLnlhbWwKaW5kZXggM2VmZjFjZjNj NmI2YmEyNjE3Mjc5MzkxNTNmNjExNjhmODdlZWE5Zi4uNWI0ZDNiNjI1NzE3NTMyNTU0ZjNhZDcy YTRkYjQ1YTY5ZWNhODVlNiAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9TY3JpcHRzL1ByZWZlcmVu Y2VzL1dlYlByZWZlcmVuY2VzRXhwZXJpbWVudGFsLnlhbWwKKysrIGIvU291cmNlL1dURi9TY3Jp cHRzL1ByZWZlcmVuY2VzL1dlYlByZWZlcmVuY2VzRXhwZXJpbWVudGFsLnlhbWwKQEAgLTk2Miwx MSArOTYyLDExIEBAIE92ZXJmbG93Q2xpcEVuYWJsZWQ6CiAgIGh1bWFuUmVhZGFibGVEZXNjcmlw dGlvbjogIkVuYWJsZSBDU1Mgb3ZlcmZsb3c6IGNsaXAgc3VwcG9ydCIKICAgZGVmYXVsdFZhbHVl OgogICAgIFdlYktpdExlZ2FjeToKLSAgICAgIGRlZmF1bHQ6IGZhbHNlCisgICAgICBkZWZhdWx0 OiB0cnVlCiAgICAgV2ViS2l0OgotICAgICAgZGVmYXVsdDogZmFsc2UKKyAgICAgIGRlZmF1bHQ6 IHRydWUKICAgICBXZWJDb3JlOgotICAgICAgZGVmYXVsdDogZmFsc2UKKyAgICAgIGRlZmF1bHQ6 IHRydWUKIAogT3ZlcnNjcm9sbEJlaGF2aW9yRW5hYmxlZDoKICAgdHlwZTogYm9vbAo=