23600 2009-01-28 13:49:50 -0800 Selection.collapse does not work as expected on empty text nodes 2022-12-17 22:05:29 -0800 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) Mac OS X 10.5 RESOLVED DUPLICATE 216325 P2 Normal --- 15256 23601 1 eric webkit-unassigned ahmad.saleem792 ap darin jparent justin.garcia ojan rniwa oldest_to_newest 107389 0 eric 2009-01-28 13:49:50 -0800 Ojan and I were trying to use comparePoint in a test case. It didn't work like we thought it would. After some investigation, it just seems our ranges are borked. This is probably a dupe of the "VisualPosiition shouldn't be used as much as they are" bug. Test case: <html> <body> <div id='log'></div> <script> function debug(str) { var logger = document.getElementById('log'); logger.appendChild(document.createTextNode(str)); logger.appendChild(document.createElement('br')); } var div = document.createElement('div'); document.body.appendChild(div); var textNode = document.createTextNode(""); div.appendChild(textNode); var sel = window.getSelection(); sel.collapse(textNode, 0); var range = sel.getRangeAt(0); debug("comparing point with <text>, offset 0:"); var result = range.comparePoint(textNode, 0); if (result == 0) { debug("PASSED: result = 0"); } else { debug("FAILED: result = " + result + " expected 0"); } debug("range:"); debug("startContainer: " + range.startContainer); debug("startOffset: " + range.startOffset); debug("endContainer: " + range.endContainer); debug("endOffset: " + range.endOffset); debug("selection:"); debug("anchorNode: " + sel.anchorNode); debug("anchorOffset: " + sel.anchorOffset); debug("focusNode: " + sel.focusNode); debug("focusOffset: " + sel.focusOffset); </script> </body> </html> 107390 1 27121 eric 2009-01-28 13:50:08 -0800 Created attachment 27121 test case 107391 2 eric 2009-01-28 13:54:29 -0800 Ok, turns out there are at least two bugs at play. Repurposing this one to cover "Range.collapse does not work as expected on empty text nodes", and will file a separate bug with slightly modified test case showing more clearly that getRangeAt(0) is mutating the Range in a bad bad way. 107418 3 justin.garcia 2009-01-28 15:16:13 -0800 (In reply to comment #2) > Ok, turns out there are at least two bugs at play. Repurposing this one to > cover "Range.collapse does not work as expected on empty text nodes Looks like you're using Selection.collapse not Range.collapse. 113960 4 eric 2009-03-16 17:44:58 -0700 I think this in the end is just another dupe of bug 15256. 1920110 5 ahmad.saleem792 2022-12-16 16:14:26 -0800 Using attached test case: *** Safari Technology Preview 160 *** comparing point with <text>, offset 0: FAILED: result = 1 expected 0 range: startContainer: [object HTMLBodyElement] startOffset: 0 endContainer: [object HTMLBodyElement] endOffset: 0 selection: anchorNode: [object HTMLBodyElement] anchorOffset: 0 focusNode: [object HTMLBodyElement] focusOffset: 0 *** Chrome Canary 110 & Firefox Nightly 110 *** comparing point with <text>, offset 0: PASSED: result = 0 range: startContainer: [object Text] startOffset: 0 endContainer: [object Text] endOffset: 0 selection: anchorNode: [object Text] anchorOffset: 0 focusNode: [object Text] focusOffset: 0 ____ Just wanted to share updated test result. Thanks! 1920309 6 darin 2022-12-17 19:20:58 -0800 Probably fixed by the live range selection work that Ryosuke is doing. 1920320 7 rniwa 2022-12-17 22:05:15 -0800 Indeed, this test case passes once live range selection is enabled. 1920321 8 rniwa 2022-12-17 22:05:29 -0800 *** This bug has been marked as a duplicate of bug 216325 *** 27121 2009-01-28 13:50:08 -0800 2009-01-28 13:50:08 -0800 test case testrange.html text/html 1090 eric PGh0bWw+Cjxib2R5PgogICAgPGRpdiBpZD0nbG9nJz48L2Rpdj4KPHNjcmlwdD4KZnVuY3Rpb24g ZGVidWcoc3RyKSB7CiAgICB2YXIgbG9nZ2VyID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoJ2xv ZycpOwogICAgbG9nZ2VyLmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZVRleHROb2RlKHN0cikp OwogICAgbG9nZ2VyLmFwcGVuZENoaWxkKGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ2JyJykpOwp9 CnZhciBkaXYgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdkaXYnKTsKZG9jdW1lbnQuYm9keS5h cHBlbmRDaGlsZChkaXYpOwp2YXIgdGV4dE5vZGUgPSBkb2N1bWVudC5jcmVhdGVUZXh0Tm9kZSgi Iik7CmRpdi5hcHBlbmRDaGlsZCh0ZXh0Tm9kZSk7Cgp2YXIgc2VsID0gd2luZG93LmdldFNlbGVj dGlvbigpOwpzZWwuY29sbGFwc2UodGV4dE5vZGUsIDApOwp2YXIgcmFuZ2UgPSBzZWwuZ2V0UmFu Z2VBdCgwKTsKCmRlYnVnKCJjb21wYXJpbmcgcG9pbnQgd2l0aCA8dGV4dD4sIG9mZnNldCAwOiIp Owp2YXIgcmVzdWx0ID0gcmFuZ2UuY29tcGFyZVBvaW50KHRleHROb2RlLCAwKTsKaWYgKHJlc3Vs dCA9PSAwKSB7CiAgICBkZWJ1ZygiUEFTU0VEOiByZXN1bHQgPSAwIik7Cn0gZWxzZSB7CiAgICBk ZWJ1ZygiRkFJTEVEOiByZXN1bHQgPSAiICsgcmVzdWx0ICsgIiBleHBlY3RlZCAwIik7Cn0KCmRl YnVnKCJyYW5nZToiKTsKZGVidWcoInN0YXJ0Q29udGFpbmVyOiAiICsgcmFuZ2Uuc3RhcnRDb250 YWluZXIpOwpkZWJ1Zygic3RhcnRPZmZzZXQ6ICIgKyByYW5nZS5zdGFydE9mZnNldCk7CmRlYnVn KCJlbmRDb250YWluZXI6ICIgKyByYW5nZS5lbmRDb250YWluZXIpOwpkZWJ1ZygiZW5kT2Zmc2V0 OiAiICsgcmFuZ2UuZW5kT2Zmc2V0KTsKCmRlYnVnKCJzZWxlY3Rpb246Iik7CmRlYnVnKCJhbmNo b3JOb2RlOiAiICsgc2VsLmFuY2hvck5vZGUpOwpkZWJ1ZygiYW5jaG9yT2Zmc2V0OiAiICsgc2Vs LmFuY2hvck9mZnNldCk7CmRlYnVnKCJmb2N1c05vZGU6ICIgKyBzZWwuZm9jdXNOb2RlKTsKZGVi dWcoImZvY3VzT2Zmc2V0OiAiICsgc2VsLmZvY3VzT2Zmc2V0KTsKPC9zY3JpcHQ+CjwvYm9keT4K PC9odG1sPg==