235997 2022-02-01 19:38:32 -0800 AX: Display startObject and anchorObject objectID when logging AccessibilitySearchCriteria from AXLogger 2022-02-02 08:44:30 -0800 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 tyler_w tyler_w aboxhall andresg_22 apinheiro cfleizach dmazzoni ews-watchlist jcraig jdiggs samuel_white webkit-bug-importer oldest_to_newest 1836300 0 tyler_w 2022-02-01 19:38:32 -0800 Currently, we only log the startObject and anchorObject address: (SearchCriteria 0x2a7d13a80 (anchorObject 0x315ba9980) (startObject 0x0) It would be nice to also their objectIDs so we can correlate them with other logs. 1836301 1 webkit-bug-importer 2022-02-01 19:38:44 -0800 <rdar://problem/88360864> 1836303 2 450603 tyler_w 2022-02-01 19:41:38 -0800 Created attachment 450603 Patch 1836440 3 ews-feeder 2022-02-02 08:44:27 -0800 Committed r288953 (246682@main): <https://commits.webkit.org/246682@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450603. 450603 2022-02-01 19:41:38 -0800 2022-02-02 08:44:29 -0800 Patch bug-235997-20220201214137.patch text/plain 2264 tyler_w U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4ODYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDAxODc5MzBiOGEyN2M4 YTE3ODEwMjU5YTNmNjZjMmNkNTVjNjg3My4uZjI5YTIyNjc4ZmNiZjQ3N2E2ZWRkYzgwODUwNWIy MGY3NGMzNjYwMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIyLTAyLTAxICBUeWxl ciBXaWxjb2NrICA8dHlsZXJfd0BhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IERpc3BsYXkgc3Rh cnRPYmplY3QgYW5kIGFuY2hvck9iamVjdCBvYmplY3RJRCB3aGVuIGxvZ2dpbmcgQWNjZXNzaWJp bGl0eVNlYXJjaENyaXRlcmlhIGZyb20gQVhMb2dnZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNTk5NworCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIFdpdGggdGhpcyBwYXRjaCwgbG9nZ2luZyBBY2Nlc3Np YmlsaXR5U2VhcmNoQ3JpdGVyaWEgd2lsbCBsb29rIGxpa2U6CisKKyAgICAgICAgKFNlYXJjaENy aXRlcmlhIDB4MmE3ZDEzYTgwCisgICAgICAgICAgKGFuY2hvck9iamVjdCAweDMxNWJhOTk4MCwg SUQgNDkyKQorICAgICAgICAgIChzdGFydE9iamVjdCAweDAsIElEIDApCisgICAgICAgICAgLi4u dHJ1bmNhdGVkLi4uCisKKyAgICAgICAgVGhpcyB3aWxsIGhlbHAgdXMgY29ycmVsYXRlIHRoZSBJ RHMgb2YgYW5jaG9yT2JqZWN0IGFuZCBzdGFydE9iamVjdCB3aXRoIG90aGVyCisgICAgICAgIGxv ZyBzdGF0ZW1lbnRzLgorCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9BWExvZ2dlci5jcHA6Cisg ICAgICAgIChXZWJDb3JlOjpvcGVyYXRvcjw8KToKKwogMjAyMi0wMS0zMSAgQW5kcmVzIEdvbnph bGV6ICA8YW5kcmVzZ18yMkBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIHRvIEFYTG9nZ2VyIHRo ZSBhYmlsaXR5IHRvIGxvZyBvbmx5IGZyb20gdGhlIHNwZWNpZmllZCB0aHJlYWQuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FYTG9nZ2VyLmNwcCBiL1NvdXJjZS9X ZWJDb3JlL2FjY2Vzc2liaWxpdHkvQVhMb2dnZXIuY3BwCmluZGV4IGY0MDQwMWU4ZDlhZDM3MTM3 MDNkN2Q0OThmY2EyODFjYzZmMGNmNzkuLjQzZTA2OWI3MzA3MGQwZDFmNzEzY2YyODQ2MjA2MDM1 ZTlmNjMwMTUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQVhMb2dn ZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQVhMb2dnZXIuY3BwCkBA IC0zMjgsOSArMzI4LDE1IEBAIFRleHRTdHJlYW0mIG9wZXJhdG9yPDwoVGV4dFN0cmVhbSYgc3Ry ZWFtLCBBY2Nlc3NpYmlsaXR5U2VhcmNoS2V5IHNlYXJjaEtleSkKIFRleHRTdHJlYW0mIG9wZXJh dG9yPDwoVGV4dFN0cmVhbSYgc3RyZWFtLCBjb25zdCBBY2Nlc3NpYmlsaXR5U2VhcmNoQ3JpdGVy aWEmIGNyaXRlcmlhKQogewogICAgIFRleHRTdHJlYW06Okdyb3VwU2NvcGUgZ3JvdXBTY29wZShz dHJlYW0pOworICAgIGF1dG8gc3RyZWFtQ3JpdGVyaWFPYmplY3QgPSBbJnN0cmVhbV0gKFN0cmlu ZyBvYmplY3RMYWJlbCwgYXV0byogYXhPYmplY3QpIHsKKyAgICAgICAgc3RyZWFtLnN0YXJ0R3Jv dXAoKTsKKyAgICAgICAgc3RyZWFtIDw8IG9iamVjdExhYmVsIDw8ICIgIiA8PCBheE9iamVjdCA8 PCAiLCBJRCAiIDw8IChheE9iamVjdCA/IGF4T2JqZWN0LT5vYmplY3RJRCgpIDogQVhJRCgpKTsK KyAgICAgICAgc3RyZWFtLmVuZEdyb3VwKCk7CisgICAgfTsKKwogICAgIHN0cmVhbSA8PCAiU2Vh cmNoQ3JpdGVyaWEgIiA8PCAmY3JpdGVyaWE7Ci0gICAgc3RyZWFtLmR1bXBQcm9wZXJ0eSgiYW5j aG9yT2JqZWN0IiwgY3JpdGVyaWEuYW5jaG9yT2JqZWN0KTsKLSAgICBzdHJlYW0uZHVtcFByb3Bl cnR5KCJzdGFydE9iamVjdCIsIGNyaXRlcmlhLnN0YXJ0T2JqZWN0KTsKKyAgICBzdHJlYW1Dcml0 ZXJpYU9iamVjdCgiYW5jaG9yT2JqZWN0IiwgY3JpdGVyaWEuYW5jaG9yT2JqZWN0KTsKKyAgICBz dHJlYW1Dcml0ZXJpYU9iamVjdCgic3RhcnRPYmplY3QiLCBjcml0ZXJpYS5zdGFydE9iamVjdCk7 CiAgICAgc3RyZWFtLmR1bXBQcm9wZXJ0eSgic2VhcmNoRGlyZWN0aW9uIiwgY3JpdGVyaWEuc2Vh cmNoRGlyZWN0aW9uKTsKIAogICAgIHN0cmVhbS5uZXh0TGluZSgpOwo=