235980 2022-02-01 15:10:32 -0800 The default values for a couple of Live Text-related features should respect system feature flags 2022-02-01 18:03:20 -0800 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 235991 1 wenson_hsieh wenson_hsieh akeerthi bdakin hi megan_gardner thorton webkit-bug-importer oldest_to_newest 1836178 0 wenson_hsieh 2022-02-01 15:10:32 -0800 rdar://88349726 1836184 1 450579 wenson_hsieh 2022-02-01 15:22:27 -0800 Created attachment 450579 Patch 1836277 2 ews-feeder 2022-02-01 18:03:16 -0800 Committed r288934 (246664@main): <https://commits.webkit.org/246664@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450579. 450579 2022-02-01 15:22:27 -0800 2022-02-01 18:03:18 -0800 Patch bug-235980-20220201152226.patch text/plain 7355 wenson_hsieh U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4OTAyCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGZmZTZjY2NjYzQ3OTc2MjhhOTNhZGVm ZTFhZWMxYjZjOTQ4Y2M1NTAuLjBjOTM4MWFhNTc5Y2IzZmMzYzc4MDk0NWM1MTNjZTlmYzc5MWY2 ZjIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMjItMDItMDEgIFdlbnNvbiBIc2llaCAgPHdlbnNv bl9oc2llaEBhcHBsZS5jb20+CisKKyAgICAgICAgVGhlIGRlZmF1bHQgdmFsdWVzIGZvciBhIGNv dXBsZSBvZiBMaXZlIFRleHQtcmVsYXRlZCBmZWF0dXJlcyBzaG91bGQgcmVzcGVjdCBzeXN0ZW0g ZmVhdHVyZSBmbGFncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjM1OTgwCisgICAgICAgIHJkYXI6Ly84ODM0OTcyNgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIG5ldyBmZWF0dXJlIGZsYWcsIGFu ZCBhZGQgZGVmYXVsdCB2YWx1ZXMgZm9yIGJvdGggZmVhdHVyZXMuIFNlZSBXZWJLaXQvQ2hhbmdl TG9nIGZvciBtb3JlIGRldGFpbHMuCisKKyAgICAgICAgKiBTY3JpcHRzL1ByZWZlcmVuY2VzL1dl YlByZWZlcmVuY2VzSW50ZXJuYWwueWFtbDoKKwogMjAyMi0wMi0wMSAgQmVuIE5oYW0gIDxuaGFt QGFwcGxlLmNvbT4KIAogICAgICAgICBJbXBvcnQgQVBTQ29ubmVjdGlvbi1yZWxhdGVkIFNQSQpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0L0NoYW5n ZUxvZwppbmRleCBlODlhMWNjMWNlYzUyMDI2MzcyNGJmNTg5ZGY4YTQxMzE3OWE1MWM2Li5lNTMx NTdiMzczNjk5Nzk2ZjdmNGFkMzUyODU1MWEzZjMwNDliOGJiIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0L0NoYW5nZUxvZworKysgYi9Tb3VyY2UvV2ViS2l0L0NoYW5nZUxvZwpAQCAtMSwzICsx LDI4IEBACisyMDIyLTAyLTAxICBXZW5zb24gSHNpZWggIDx3ZW5zb25faHNpZWhAYXBwbGUuY29t PgorCisgICAgICAgIFRoZSBkZWZhdWx0IHZhbHVlcyBmb3IgYSBjb3VwbGUgb2YgTGl2ZSBUZXh0 LXJlbGF0ZWQgZmVhdHVyZXMgc2hvdWxkIHJlc3BlY3Qgc3lzdGVtIGZlYXR1cmUgZmxhZ3MKKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNTk4MAorICAg ICAgICByZGFyOi8vODgzNDk3MjYKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBTcGxpdCB0aGUgZXh0YW50IGBUZXh0UmVjb2duaXRpb25FbmhhbmNlbWVu dHNgIGZlYXR1cmUgZmxhZyBpbnRvIHR3byBmbGFnczogb25lIHRvIGNvbnRyb2wgZW5hYmxlbWVu dCBvZiB0aGUKKyAgICAgICAgImltYWdlIGFuYWx5c2lzIHF1ZXVlIiwgYW5kIGFub3RoZXIgdG8g Y29udHJvbCBMaXZlIFRleHQgYmVoYXZpb3JzIChzdGlsbCByZWZlcnJlZCB0byBhcyAidGV4dCBy ZWNvZ25pdGlvbgorICAgICAgICBlbmhhbmNlbWVudHMiKS4gQWRkIFdlYktpdEFkZGl0aW9ucyBp bnRlZ3JhdGlvbiBwb2ludHMgdG8gYWxsb3cgdGhlIGRlZmF1bHQgdmFsdWVzIGZvciB0aGVzZSB0 d28gZmxhZ3MgdG8gcmVhZAorICAgICAgICBmcm9tIHN5c3RlbSBmZWF0dXJlIGZsYWdzLgorCisg ICAgICAgICogUGxhdGZvcm0vY29jb2EvVGV4dFJlY29nbml0aW9uVXRpbGl0aWVzLmg6CisgICAg ICAgICogUGxhdGZvcm0vY29jb2EvVGV4dFJlY29nbml0aW9uVXRpbGl0aWVzLm1tOgorICAgICAg ICAoV2ViS2l0Ojp0ZXh0UmVjb2duaXRpb25FbmhhbmNlbWVudHNTeXN0ZW1GZWF0dXJlRW5hYmxl ZCk6CisgICAgICAgIChXZWJLaXQ6OmltYWdlQW5hbHlzaXNRdWV1ZVN5c3RlbUZlYXR1cmVFbmFi bGVkKToKKyAgICAgICAgKFdlYktpdDo6aXNMaXZlVGV4dEF2YWlsYWJsZUFuZEVuYWJsZWQpOgor ICAgICAgICAoV2ViS2l0Ojppc0xpdmVUZXh0RW5hYmxlZCk6IERlbGV0ZWQuCisgICAgICAgIChX ZWJLaXQ6OnJlcXVlc3RJbWFnZUFuYWx5c2lzV2l0aElkZW50aWZpZXIpOiBEZWxldGVkLgorICAg ICAgICAqIFNoYXJlZC9Db2NvYS9XZWJQcmVmZXJlbmNlc0RlZmF1bHRWYWx1ZXNDb2NvYS5tbToK KyAgICAgICAgKFdlYktpdDo6ZGVmYXVsdFRleHRSZWNvZ25pdGlvbkVuaGFuY2VtZW50c0VuYWJs ZWQpOgorICAgICAgICAoV2ViS2l0OjpkZWZhdWx0SW1hZ2VBbmFseXNpc1F1ZXVlRW5hYmxlZCk6 CisgICAgICAgICogU2hhcmVkL1dlYlByZWZlcmVuY2VzRGVmYXVsdFZhbHVlcy5oOgorCiAyMDIy LTAyLTAxICBCZW4gTmhhbSAgPG5oYW1AYXBwbGUuY29tPgogCiAgICAgICAgIEltcG9ydCBBUFND b25uZWN0aW9uLXJlbGF0ZWQgU1BJCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL1NjcmlwdHMvUHJl ZmVyZW5jZXMvV2ViUHJlZmVyZW5jZXNJbnRlcm5hbC55YW1sIGIvU291cmNlL1dURi9TY3JpcHRz L1ByZWZlcmVuY2VzL1dlYlByZWZlcmVuY2VzSW50ZXJuYWwueWFtbAppbmRleCBkNWFmMTgxNzk1 OGJmNjZiYThiN2VkNGM4MWNhZjkwMzBiMWQ2ODk5Li4yMWRiZTFjYjQ5ZTcyYjI2YzI3M2NmMjM5 YzJlYTkwZDBjOGQxNjA3IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL1NjcmlwdHMvUHJlZmVyZW5j ZXMvV2ViUHJlZmVyZW5jZXNJbnRlcm5hbC55YW1sCisrKyBiL1NvdXJjZS9XVEYvU2NyaXB0cy9Q cmVmZXJlbmNlcy9XZWJQcmVmZXJlbmNlc0ludGVybmFsLnlhbWwKQEAgLTM1OCw2ICszNTgsMjAg QEAgSVBDVGVzdGluZ0FQSUVuYWJsZWQ6CiAgICAgV2ViS2l0OgogICAgICAgZGVmYXVsdDogZmFs c2UKIAorSW1hZ2VBbmFseXNpc1F1ZXVlRW5hYmxlZDoKKyAgdHlwZTogYm9vbAorICBodW1hblJl YWRhYmxlTmFtZTogIkltYWdlIGFuYWx5c2lzIHF1ZXVlIgorICBodW1hblJlYWRhYmxlRGVzY3Jp cHRpb246ICJFbmFibGUgaW1hZ2UgYW5hbHlzaXMgcXVldWUiCisgIGNvbmRpdGlvbjogRU5BQkxF KElNQUdFX0FOQUxZU0lTKQorICBleHBvc2VkOiBbIFdlYktpdCBdCisgIGRlZmF1bHRWYWx1ZToK KyAgICBXZWJDb3JlOgorICAgICAgZGVmYXVsdDogZmFsc2UKKyAgICBXZWJLaXRMZWdhY3k6Cisg ICAgICBkZWZhdWx0OiBmYWxzZQorICAgIFdlYktpdDoKKyAgICAgIGRlZmF1bHQ6IGRlZmF1bHRJ bWFnZUFuYWx5c2lzUXVldWVFbmFibGVkKCkKKwogSW5wdXRUeXBlQ29sb3JFbmFibGVkOgogICB0 eXBlOiBib29sCiAgIGh1bWFuUmVhZGFibGVOYW1lOiAiQ29sb3IgSW5wdXRzIgpAQCAtODI1LDcg KzgzOSw3IEBAIFRleHRSZWNvZ25pdGlvbkVuaGFuY2VtZW50c0VuYWJsZWQ6CiAgICAgV2ViS2l0 TGVnYWN5OgogICAgICAgZGVmYXVsdDogZmFsc2UKICAgICBXZWJLaXQ6Ci0gICAgICBkZWZhdWx0 OiBmYWxzZQorICAgICAgZGVmYXVsdDogZGVmYXVsdFRleHRSZWNvZ25pdGlvbkVuaGFuY2VtZW50 c0VuYWJsZWQoKQogCiAjIEZJWE1FOiBJcyB0aGlzIGltcGxlbWVudGVkIGZvciBXZWJLaXRMZWdh Y3k/IElmIG5vdCwgdGhpcyBzaG91bGQgYmUgZXhjbHVkZWQgZnJvbSBXZWJLaXRMZWdhY3kgZW50 aXJlbHkuCiBVbmRvTWFuYWdlckFQSUVuYWJsZWQ6CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0 L1BsYXRmb3JtL2NvY29hL1RleHRSZWNvZ25pdGlvblV0aWxpdGllcy5oIGIvU291cmNlL1dlYktp dC9QbGF0Zm9ybS9jb2NvYS9UZXh0UmVjb2duaXRpb25VdGlsaXRpZXMuaAppbmRleCA4YzEwODc4 MTc0ZDBmZjNmNWJkZDgwM2IyNGVjZmFlZmI1ZmRlODhhLi40MzM1MTc4ZDFjNjU3MzBhNTMzMDgy YmNiODhhNDE5MTgwYzE5YWFjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1BsYXRmb3JtL2Nv Y29hL1RleHRSZWNvZ25pdGlvblV0aWxpdGllcy5oCisrKyBiL1NvdXJjZS9XZWJLaXQvUGxhdGZv cm0vY29jb2EvVGV4dFJlY29nbml0aW9uVXRpbGl0aWVzLmgKQEAgLTM4LDYgKzM4LDkgQEAgc3Ry dWN0IFRleHRSZWNvZ25pdGlvblJlc3VsdDsKIG5hbWVzcGFjZSBXZWJLaXQgewogCiBib29sIGlz TGl2ZVRleHRBdmFpbGFibGVBbmRFbmFibGVkKCk7Citib29sIHRleHRSZWNvZ25pdGlvbkVuaGFu Y2VtZW50c1N5c3RlbUZlYXR1cmVFbmFibGVkKCk7Citib29sIGltYWdlQW5hbHlzaXNRdWV1ZVN5 c3RlbUZlYXR1cmVFbmFibGVkKCk7CisKIFdlYkNvcmU6OlRleHRSZWNvZ25pdGlvblJlc3VsdCBt YWtlVGV4dFJlY29nbml0aW9uUmVzdWx0KFZLSW1hZ2VBbmFseXNpcyAqKTsKIAogLy8gRklYTUU6 IFJlcGxhY2UgdGhlIHJldHVybiB0eXBlcyBvZiB0aGVzZSBoZWxwZXIgZnVuY3Rpb25zIHdpdGgg VktDSW1hZ2VBbmFseXplciBhbmQgVktDSW1hZ2VBbmFseXplclJlcXVlc3QsIHJlc3BlY3RpdmVs eS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQvUGxhdGZvcm0vY29jb2EvVGV4dFJlY29nbml0 aW9uVXRpbGl0aWVzLm1tIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9jb2NvYS9UZXh0UmVjb2du aXRpb25VdGlsaXRpZXMubW0KaW5kZXggZTBkY2YyOTI1YTUzMGYyNWUyN2Y3OWJlYWJhNDljZmU0 NjViNGFlOS4uMjBiYTYwYzQ0NGZkYzMyMzRmMzg5NDdlMzY2ODQxNzg2YmNkMThkMiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9jb2NvYS9UZXh0UmVjb2duaXRpb25VdGlsaXRp ZXMubW0KKysrIGIvU291cmNlL1dlYktpdC9QbGF0Zm9ybS9jb2NvYS9UZXh0UmVjb2duaXRpb25V dGlsaXRpZXMubW0KQEAgLTEzOSwyNSArMTM5LDI5IEBAIFRleHRSZWNvZ25pdGlvblJlc3VsdCBt YWtlVGV4dFJlY29nbml0aW9uUmVzdWx0KFZLSW1hZ2VBbmFseXNpcyAqYW5hbHlzaXMpCiAjaW5j bHVkZSA8V2ViS2l0QWRkaXRpb25zL1RleHRSZWNvZ25pdGlvblV0aWxpdGllc0FkZGl0aW9ucy5t bT4KICNlbHNlCiAKLXN0YXRpYyBib29sIGlzTGl2ZVRleHRFbmFibGVkKCkKK2Jvb2wgdGV4dFJl Y29nbml0aW9uRW5oYW5jZW1lbnRzU3lzdGVtRmVhdHVyZUVuYWJsZWQoKQogeworI2lmIEVOQUJM RShJTUFHRV9BTkFMWVNJU19FTkhBTkNFTUVOVFMpCiAgICAgcmV0dXJuIHRydWU7CisjZWxzZQor ICAgIHJldHVybiBmYWxzZTsKKyNlbmRpZgogfQogCi0jaWYgRU5BQkxFKElNQUdFX0FOQUxZU0lT X0VOSEFOQ0VNRU5UUykKLQotdm9pZCByZXF1ZXN0SW1hZ2VBbmFseXNpc1dpdGhJZGVudGlmaWVy KFZLSW1hZ2VBbmFseXplciAqLCBjb25zdCBTdHJpbmcmLCBDR0ltYWdlUmVmLCBDb21wbGV0aW9u SGFuZGxlcjx2b2lkKFRleHRSZWNvZ25pdGlvblJlc3VsdCYmKT4mJiBjb21wbGV0aW9uKQorYm9v bCBpbWFnZUFuYWx5c2lzUXVldWVTeXN0ZW1GZWF0dXJlRW5hYmxlZCgpCiB7Ci0gICAgY29tcGxl dGlvbih7IH0pOworI2lmIEVOQUJMRShJTUFHRV9BTkFMWVNJU19FTkhBTkNFTUVOVFMpCisgICAg cmV0dXJuIHRydWU7CisjZWxzZQorICAgIHJldHVybiBmYWxzZTsKKyNlbmRpZgogfQogCi0jZW5k aWYgLy8gRU5BQkxFKElNQUdFX0FOQUxZU0lTX0VOSEFOQ0VNRU5UUykKLQogI2VuZGlmCiAKIGJv b2wgaXNMaXZlVGV4dEF2YWlsYWJsZUFuZEVuYWJsZWQoKQogewotICAgIHJldHVybiBQQUw6Omlz VmlzaW9uS2l0Q29yZUZyYW1ld29ya0F2YWlsYWJsZSgpICYmIGlzTGl2ZVRleHRFbmFibGVkKCk7 CisgICAgcmV0dXJuIFBBTDo6aXNWaXNpb25LaXRDb3JlRnJhbWV3b3JrQXZhaWxhYmxlKCk7CiB9 CiAKIH0gLy8gbmFtZXNwYWNlIFdlYktpdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdC9TaGFy ZWQvQ29jb2EvV2ViUHJlZmVyZW5jZXNEZWZhdWx0VmFsdWVzQ29jb2EubW0gYi9Tb3VyY2UvV2Vi S2l0L1NoYXJlZC9Db2NvYS9XZWJQcmVmZXJlbmNlc0RlZmF1bHRWYWx1ZXNDb2NvYS5tbQppbmRl eCBmZWVlMDk4ODc0OTcyMmQ3ZGMzMjllMTk5ODZmMDM5ZDJjNmFhNjQyLi42OTk1ZDIyMTJhOGUw MThhYmY3MmRkMTA2NDE1ZDk0NzZhNWQzODliIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1No YXJlZC9Db2NvYS9XZWJQcmVmZXJlbmNlc0RlZmF1bHRWYWx1ZXNDb2NvYS5tbQorKysgYi9Tb3Vy Y2UvV2ViS2l0L1NoYXJlZC9Db2NvYS9XZWJQcmVmZXJlbmNlc0RlZmF1bHRWYWx1ZXNDb2NvYS5t bQpAQCAtMjgsOCArMjgsOCBAQAogCiAjaWYgUExBVEZPUk0oQ09DT0EpCiAKKyNpbXBvcnQgIlRl eHRSZWNvZ25pdGlvblV0aWxpdGllcy5oIgogI2ltcG9ydCA8Rm91bmRhdGlvbi9OU0J1bmRsZS5o PgotCiAjaW1wb3J0IDxwYWwvc3BpL2NvY29hL0ZlYXR1cmVGbGFnc1NQSS5oPgogI2ltcG9ydCA8 d3RmL1JldGFpblB0ci5oPgogI2ltcG9ydCA8d3RmL2NvY29hL1J1bnRpbWVBcHBsaWNhdGlvbkNo ZWNrc0NvY29hLmg+CkBAIC03Miw2ICs3MiwyMCBAQCBib29sIGRlZmF1bHRTY3JvbGxBbmltYXRv ckVuYWJsZWQoKQogfQogI2VuZGlmCiAKKyNpZiBFTkFCTEUoSU1BR0VfQU5BTFlTSVMpCisKK2Jv b2wgZGVmYXVsdFRleHRSZWNvZ25pdGlvbkVuaGFuY2VtZW50c0VuYWJsZWQoKQoreworICAgIHJl dHVybiB0ZXh0UmVjb2duaXRpb25FbmhhbmNlbWVudHNTeXN0ZW1GZWF0dXJlRW5hYmxlZCgpOwor fQorCitib29sIGRlZmF1bHRJbWFnZUFuYWx5c2lzUXVldWVFbmFibGVkKCkKK3sKKyAgICByZXR1 cm4gaW1hZ2VBbmFseXNpc1F1ZXVlU3lzdGVtRmVhdHVyZUVuYWJsZWQoKTsKK30KKworI2VuZGlm IC8vIEVOQUJMRShJTUFHRV9BTkFMWVNJUykKKwogfSAvLyBuYW1lc3BhY2UgV2ViS2l0CiAKLSNl bmRpZgorI2VuZGlmIC8vIFBMQVRGT1JNKENPQ09BKQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktp dC9TaGFyZWQvV2ViUHJlZmVyZW5jZXNEZWZhdWx0VmFsdWVzLmggYi9Tb3VyY2UvV2ViS2l0L1No YXJlZC9XZWJQcmVmZXJlbmNlc0RlZmF1bHRWYWx1ZXMuaAppbmRleCAxZjU4MmUzZmU2Y2MzMjQ4 MGI3MzkzNjJiMzdjZDdmOTdmNzQ5ODU0Li44ZGM4ZDIxOTBjODc3NWZiMmVmMmMwMWM3MWQxZjE3 ODY0YzNlNjJhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJQcmVmZXJlbmNl c0RlZmF1bHRWYWx1ZXMuaAorKysgYi9Tb3VyY2UvV2ViS2l0L1NoYXJlZC9XZWJQcmVmZXJlbmNl c0RlZmF1bHRWYWx1ZXMuaApAQCAtMTE1LDQgKzExNSw5IEBAIGJvb2wgZGVmYXVsdE1lZGlhU2Vz c2lvbkNvb3JkaW5hdG9yRW5hYmxlZCgpOwogYm9vbCBkZWZhdWx0U2NyZWVuQ2FwdHVyZUtpdEVu YWJsZWQoKTsKICNlbmRpZgogCisjaWYgRU5BQkxFKElNQUdFX0FOQUxZU0lTKQorYm9vbCBkZWZh dWx0VGV4dFJlY29nbml0aW9uRW5oYW5jZW1lbnRzRW5hYmxlZCgpOworYm9vbCBkZWZhdWx0SW1h Z2VBbmFseXNpc1F1ZXVlRW5hYmxlZCgpOworI2VuZGlmCisKIH0gLy8gbmFtZXNwYWNlIFdlYktp dAo=