23598 2009-01-28 12:58:03 -0800 wml/WMLTableElement.cpp has non-ASCII characters in comment and can't be compiled on CJK Windows 2009-01-29 16:45:40 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Trivial --- 1 jshin jshin ap darin oldest_to_newest 107377 0 jshin 2009-01-28 12:58:03 -0800 WebCore/wml/WMLTableElement.cpp has non-ASCII characters (0 enclosed by smart-quotes) in UTF-8 and leads to a compilation error (warning treated as an error) on CJK Windows (where 3-byte sequences for smart quotes cannot be interpreted as valid in the default system codepage). Either we have to replace them with ASCII double-quotes or add 'BOM' character represented in UTF-8 at the beginning of a file. I propose the former is better because on other platforms/compiler/build tools, 'BOM' in UTF-8 might be problematic. 107381 1 27119 jshin 2009-01-28 13:14:18 -0800 Created attachment 27119 patch Applying this patch is a step forward, but there are other header files (in Quicktime SDK and in WebKitLibraries/win/include) with the same issue leading to a compilation error on CJK Windows. For Quicktime SDK, I filed a bug report at bugreport.apple.com a while ago. 107382 2 jshin 2009-01-28 13:17:28 -0800 Other files in WebKitLibraries/win/include with the issue are CMTypes.h and CMApplication.h Perhaps, we have to add a note to the Windows build page about the issue (do not set the Windows system code page to one of CJK codepages to build webkit on Windows) until all of them are cleaned up. 107385 3 27119 ap 2009-01-28 13:38:14 -0800 Comment on attachment 27119 patch r=me 107623 4 fishd 2009-01-29 16:45:40 -0800 http://trac.webkit.org/changeset/40387 27119 2009-01-28 13:14:18 -0800 2009-01-28 13:38:14 -0800 patch 23598.patch.1 text/plain 1460 jshin SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MDMyNCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDktMDEtMjggIEp1bmdzaGlrIFNoaW4gIDxqc2hpbkBjaHJvbWl1 bS5vcmc+CisKKyAgICAgICAgUmVwbGFjZSBzbWFydC1xdW90ZXMgaW4gVVRGLTggd2l0aCBBU0NJ SSBkb3VibGUtcXVvdGVzIHRvIGF2b2lkCisgICAgICAgIHRoZSBjb21waWxhdGlvbiBlcnJvciBv biBDSksgV2luZG93cworCisgICAgICAgIGh0dHA6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTIzNTk4CisKKyAgICAgICAgKiB3bWwvV01MVGFibGVFbGVtZW50LmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OldNTFRhYmxlRWxlbWVudDo6cGFyc2VNYXBwZWRBdHRyaWJ1dGUpOgorCiAy MDA5LTAxLTI4ICBEYXZpZCBIeWF0dCAgPGh5YXR0QGFwcGxlLmNvbT4KIAogICAgICAgICBNb3Zl IGNhbGNNYXJnaW5zIGZyb20gUmVuZGVyRmxvdyB0byBSZW5kZXJJbmxpbmUsIHNpbmNlIGl0IHdh cyBvbmx5IGV2ZXIgY2FsbGVkIG9uIFJlbmRlcklubGluZXMuCkluZGV4OiBXZWJDb3JlL3dtbC9X TUxUYWJsZUVsZW1lbnQuY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvd21sL1dNTFRhYmxlRWxl bWVudC5jcHAJKHJldmlzaW9uIDQwMTM0KQorKysgV2ViQ29yZS93bWwvV01MVGFibGVFbGVtZW50 LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNjYsNyArNjYsNyBAQCB2b2lkIFdNTFRhYmxlRWxlbWVu dDo6cGFyc2VNYXBwZWRBdHRyaWJ1CiAKICAgICAgICAgLy8gU3BlYzogVGhpcyByZXF1aXJlZCBh dHRyaWJ1dGUgc3BlY2lmaWVzIHRoZSBudW1iZXIgb2YgY29sdW1ucyBmb3IgdGhlIHRhYmxlLgog ICAgICAgICAvLyBUaGUgdXNlciBhZ2VudCBtdXN0IGNyZWF0ZSBhIHRhYmxlIHdpdGggZXhhY3Rs eSB0aGUgbnVtYmVyIG9mIGNvbHVtbnMgc3BlY2lmaWVkCi0gICAgICAgIC8vIGJ5IHRoZSBhdHRy aWJ1dGUgdmFsdWUuIEl0IGlzIGFuIGVycm9yIHRvIHNwZWNpZnkgYSB2YWx1ZSBvZiB6ZXJvICji gJww4oCdKS4KKyAgICAgICAgLy8gYnkgdGhlIGF0dHJpYnV0ZSB2YWx1ZS4gSXQgaXMgYW4gZXJy b3IgdG8gc3BlY2lmeSBhIHZhbHVlIG9mIHplcm8gKCIwIikKICAgICAgICAgaWYgKCFtX2NvbHVt bnMgfHwgIWlzTnVtYmVyKQogICAgICAgICAgICAgcmVwb3J0V01MRXJyb3IoZG9jdW1lbnQoKSwg V01MRXJyb3JJbnZhbGlkQ29sdW1uc051bWJlckluVGFibGUpOwogICAgIH0gZWxzZSBpZiAoYXR0 ci0+bmFtZSgpID09IEhUTUxOYW1lczo6YWxpZ25BdHRyKQo=