235979 2022-02-01 15:03:33 -0800 [CMake] Use ld.lld by default for development builds where available 2022-02-11 07:29:07 -0800 1 1 1 Unclassified WebKit CMake WebKit Local Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=236362 https://bugs.webkit.org/show_bug.cgi?id=236506 P2 Normal --- 235476 235975 1 aperez aperez annulen aperez bugs-noreply cgarcia darin don.olmstead ews-watchlist gyuyoung.kim mcatanzaro mrobinson pgriffis ross.kirsling ryuan.choi sergio oldest_to_newest 1836172 0 aperez 2022-02-01 15:03:33 -0800 One of the reasons to use ld.gold for development builds before trying to not detect it (as per bug #235975) was that it is faster than the traditional GNU linker, ld.bfd — and shorter build times are always welcome by developers. While unfortunately ld.gold is essentially unmaintained, we can still try to use ld.lld when present. Not only it has matured plenty to be a drop-in replacement, it is well maintained and even faster than ld.gold As ld.lld is already part of the Flatpak SDK, the only thing missing is to try to make CMake builds use it by default. Currently it is picked if the LTO_MODE option is set: # Use ld.lld when building with LTO CMAKE_DEPENDENT_OPTION(USE_LD_LLD "Use LLD linker" ON "LTO_MODE;NOT USE_LD_GOLD;NOT WIN32" OFF) 1839602 1 aperez 2022-02-10 04:37:10 -0800 For the record, I did some numbers while checking the Mold linker, you can read here: https://bugs.webkit.org/show_bug.cgi?id=236362#c7 The TL;DR is that LLD is about 4.00x faster than the BFD linker, and even slightly faster (1.12x) than Gold. 1839633 2 451527 aperez 2022-02-10 07:10:32 -0800 Created attachment 451527 Patch 1839668 3 451527 mcatanzaro 2022-02-10 08:09:19 -0800 Comment on attachment 451527 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=451527&action=review > Source/cmake/OptionsCommon.cmake:30 > + if (CMAKE_BUILD_TYPE STREQUAL Debug) What makes debug builds special? I guess you cannot enable it for RelWithDebInfo builds because it doesn't support LTO and that would risk trouble with distro builds... but this still seems weird to distinguish between RelWithDebInfo and Debug like this. Maybe it would make more sense to check for DEVELOPER_MODE instead? 1839821 4 aperez 2022-02-10 11:05:02 -0800 (In reply to Michael Catanzaro from comment #3) > Comment on attachment 451527 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=451527&action=review > > > Source/cmake/OptionsCommon.cmake:30 > > + if (CMAKE_BUILD_TYPE STREQUAL Debug) > > What makes debug builds special? I guess you cannot enable it for > RelWithDebInfo builds because it doesn't support LTO and that would risk > trouble with distro builds... but this still seems weird to distinguish > between RelWithDebInfo and Debug like this. Maybe it would make more sense > to check for DEVELOPER_MODE instead? The LLD linker can do LTO just fine, I routinely do Clang+LLD builds here. I was trying to think of speeding up the workflow of developers working on WebKit because every minute counts there, but a few minutes more in a build for distro package don't matter as much. You are right and indeed checking for DEVELOPER_MODE makes more sense for what I am trying to do here — a developer using “build-webkit --release” will also want a faster edit-compile-test cycle! 1839836 5 mcatanzaro 2022-02-10 11:18:11 -0800 (In reply to Adrian Perez from comment #4) > The LLD linker can do LTO just fine, I routinely do Clang+LLD builds here. Sorry, I confused it with mold. So many linkers. 1839837 6 451527 mcatanzaro 2022-02-10 11:18:35 -0800 Comment on attachment 451527 Patch Seems we agree to check DEVELOPER_MODE instead. 1839840 7 451582 aperez 2022-02-10 11:26:22 -0800 Created attachment 451582 Patch v2 1840263 8 ews-feeder 2022-02-11 01:18:09 -0800 Committed r289611 (247124@main): <https://commits.webkit.org/247124@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 451582. 451527 2022-02-10 07:10:32 -0800 2022-02-10 11:26:17 -0800 Patch bug-235979-20220210171031.patch text/plain 2232 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5NTMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0NvbW1vbi5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCmluZGV4 IDZhOGFmM2NhODhlNGU5OTE0MDZiNzRiMWEzNTZiYTYyOTI1NDIxNGUuLmZhZTc2ZWI0NGViZWI3 ZDY3OTM0ZjExZDM1NzI1ZjgzZWE4MWM0ZWMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRp b25zQ29tbW9uLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCkBA IC0yMSwxOCArMjEsMjMgQEAgaWYgKFdURl9DUFVfQVJNKQogICAgIENIRUNLX0NYWF9TT1VSQ0Vf Q09NUElMRVMoIiR7QVJNX1RIVU1CMl9URVNUX1NPVVJDRX0iIEFSTV9USFVNQjJfREVURUNURUQp CiBlbmRpZiAoKQogCi0jIFVzZSBsZC5sbGQgd2hlbiBidWlsZGluZyB3aXRoIExUTworIyBVc2Ug bGQubGxkIHdoZW4gYnVpbGRpbmcgd2l0aCBMVE8sIG9yIGZvciBkZWJ1ZyBidWlsZHMsIGlmIGF2 YWlsYWJsZS4KIENNQUtFX0RFUEVOREVOVF9PUFRJT04oVVNFX0xEX0xMRCAiVXNlIExMRCBsaW5r ZXIiIE9OCiAgICAgICAgICAgICAgICAgICAgICAgICJMVE9fTU9ERTtOT1QgV0lOMzIiIE9GRikK LWlmIChVU0VfTERfTExEKQotICAgIGV4ZWN1dGVfcHJvY2VzcyhDT01NQU5EICR7Q01BS0VfQ19D T01QSUxFUn0gLWZ1c2UtbGQ9bGxkIC1XbCwtLXZlcnNpb24gRVJST1JfUVVJRVQgT1VUUFVUX1ZB UklBQkxFIExEX1ZFUlNJT04pCi0gICAgaWYgKCIke0xEX1ZFUlNJT059IiBNQVRDSEVTICJMTEQi KQotICAgICAgICBzdHJpbmcoQVBQRU5EIENNQUtFX0VYRV9MSU5LRVJfRkxBR1MgIiAtZnVzZS1s ZD1sbGQiKQotICAgICAgICBzdHJpbmcoQVBQRU5EIENNQUtFX1NIQVJFRF9MSU5LRVJfRkxBR1Mg IiAtZnVzZS1sZD1sbGQiKQotICAgICAgICBzdHJpbmcoQVBQRU5EIENNQUtFX01PRFVMRV9MSU5L RVJfRkxBR1MgIiAtZnVzZS1sZD1sbGQiKQotICAgIGVsc2UgKCkKLSAgICAgICAgc2V0KFVTRV9M RF9MTEQgT0ZGKQorCitleGVjdXRlX3Byb2Nlc3MoQ09NTUFORCAke0NNQUtFX0NfQ09NUElMRVJ9 IC1mdXNlLWxkPWxsZCAtV2wsLS12ZXJzaW9uIEVSUk9SX1FVSUVUIE9VVFBVVF9WQVJJQUJMRSBM RF9MTERfVkVSU0lPTikKK2lmIChMRF9MTERfVkVSU0lPTiBNQVRDSEVTICJeTExEICIpCisgICAg aWYgKENNQUtFX0JVSUxEX1RZUEUgU1RSRVFVQUwgRGVidWcpCisgICAgICAgIHNldChVU0VfTERf TExEIE9OKQogICAgIGVuZGlmICgpCitlbHNlICgpCisgICAgc2V0KFVTRV9MRF9MTEQgT0ZGKQor ZW5kaWYgKCkKKworaWYgKFVTRV9MRF9MTEQpCisgICAgc3RyaW5nKEFQUEVORCBDTUFLRV9FWEVf TElOS0VSX0ZMQUdTICIgLWZ1c2UtbGQ9bGxkIikKKyAgICBzdHJpbmcoQVBQRU5EIENNQUtFX1NI QVJFRF9MSU5LRVJfRkxBR1MgIiAtZnVzZS1sZD1sbGQiKQorICAgIHN0cmluZyhBUFBFTkQgQ01B S0VfTU9EVUxFX0xJTktFUl9GTEFHUyAiIC1mdXNlLWxkPWxsZCIpCiBlbmRpZiAoKQogCiAjIERl dGVybWluZSB3aGljaCBsaW5rZXIgaXMgYmVpbmcgdXNlZCB3aXRoIHRoZSBjaG9zZW4gbGlua2Vy IGZsYWdzLgpkaWZmIC0tZ2l0IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDgyMGRlZmNi ZmQwNTA2NjllN2UyNjg3MTk5N2JiNjFlZmFjZGI2MzEuLmEzOTUzYzg0ZTU5N2Q5ZWQzOGY1Yzgw ZGRiYjZiMTI4NDRjMjJjNDIgMTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cK QEAgLTEsMyArMSwxMiBAQAorMjAyMi0wMi0xMCAgQWRyaWFuIFBlcmV6IGRlIENhc3RybyAgPGFw ZXJlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFtDTWFrZV0gVXNlIGxkLmxsZCBieSBkZWZhdWx0 IGZvciBkZXZlbG9wbWVudCBidWlsZHMgd2hlcmUgYXZhaWxhYmxlCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzU5NzkKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zQ29t bW9uLmNtYWtlOiBFbmFibGUgVVNFX0xEX0xMRCBmb3IgZGVidWcgYnVpbGRzIHdoZW4gYXZhaWxh YmxlLgorCiAyMDIyLTAyLTA5ICBSb3NzIEtpcnNsaW5nICA8cm9zcy5raXJzbGluZ0Bzb255LmNv bT4KIAogICAgICAgICBTaGFyZWRNZW1vcnlVbml4IHNob3VsZCB1c2UgU0hNX0FOT04gd2hlbiBh dmFpbGFibGUK 451582 2022-02-10 11:26:22 -0800 2022-02-11 01:18:13 -0800 Patch v2 bug-235979-20220210212621.patch text/plain 1987 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjg5NTMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0NvbW1vbi5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCmluZGV4 IDZhOGFmM2NhODhlNGU5OTE0MDZiNzRiMWEzNTZiYTYyOTI1NDIxNGUuLmFmNDk3ZTI5NWU4MDQ1 MDY4OGEwMGNiZjQxYzQ0ODMxZjI2ZDFlYTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRp b25zQ29tbW9uLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCkBA IC0yMSwxMiArMjEsMTcgQEAgaWYgKFdURl9DUFVfQVJNKQogICAgIENIRUNLX0NYWF9TT1VSQ0Vf Q09NUElMRVMoIiR7QVJNX1RIVU1CMl9URVNUX1NPVVJDRX0iIEFSTV9USFVNQjJfREVURUNURUQp CiBlbmRpZiAoKQogCi0jIFVzZSBsZC5sbGQgd2hlbiBidWlsZGluZyB3aXRoIExUTworIyBVc2Ug bGQubGxkIHdoZW4gYnVpbGRpbmcgd2l0aCBMVE8sIG9yIGZvciBkZWJ1ZyBidWlsZHMsIGlmIGF2 YWlsYWJsZS4KKyMgRklYTUU6IFdpdGggQ01ha2UgMy4yMisgZnVsbCBjb25kaXRpb25hbCBzeW50 YXggY2FuIGJlIHVzZWQgaW4KKyMgICAgICAgIGNtYWtlX2RlcGVuZGVudF9vcHRpb24oKQoraWYg KExUT19NT0RFIE9SIERFVkVMT1BFUl9NT0RFKQorICAgIHNldChUUllfVVNFX0xEX0xMRCBPTikK K2VuZGlmICgpCiBDTUFLRV9ERVBFTkRFTlRfT1BUSU9OKFVTRV9MRF9MTEQgIlVzZSBMTEQgbGlu a2VyIiBPTgotICAgICAgICAgICAgICAgICAgICAgICAiTFRPX01PREU7Tk9UIFdJTjMyIiBPRkYp CisgICAgICAgICAgICAgICAgICAgICAgICJUUllfVVNFX0xEX0xMRDtOT1QgV0lOMzIiIE9GRikK IGlmIChVU0VfTERfTExEKQogICAgIGV4ZWN1dGVfcHJvY2VzcyhDT01NQU5EICR7Q01BS0VfQ19D T01QSUxFUn0gLWZ1c2UtbGQ9bGxkIC1XbCwtLXZlcnNpb24gRVJST1JfUVVJRVQgT1VUUFVUX1ZB UklBQkxFIExEX1ZFUlNJT04pCi0gICAgaWYgKCIke0xEX1ZFUlNJT059IiBNQVRDSEVTICJMTEQi KQorICAgIGlmIChMRF9WRVJTSU9OIE1BVENIRVMgIl5MTEQgIikKICAgICAgICAgc3RyaW5nKEFQ UEVORCBDTUFLRV9FWEVfTElOS0VSX0ZMQUdTICIgLWZ1c2UtbGQ9bGxkIikKICAgICAgICAgc3Ry aW5nKEFQUEVORCBDTUFLRV9TSEFSRURfTElOS0VSX0ZMQUdTICIgLWZ1c2UtbGQ9bGxkIikKICAg ICAgICAgc3RyaW5nKEFQUEVORCBDTUFLRV9NT0RVTEVfTElOS0VSX0ZMQUdTICIgLWZ1c2UtbGQ9 bGxkIikKZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA4MjBkZWZjYmZk MDUwNjY5ZTdlMjY4NzE5OTdiYjYxZWZhY2RiNjMxLi41M2RiZTUxODY0NjI5YmIxNzVmNDRjN2E3 MjU0ZjVmN2QzZDgxZjYyIDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBA IC0xLDMgKzEsMTMgQEAKKzIwMjItMDItMTAgIEFkcmlhbiBQZXJleiBkZSBDYXN0cm8gIDxhcGVy ZXpAaWdhbGlhLmNvbT4KKworICAgICAgICBbQ01ha2VdIFVzZSBsZC5sbGQgYnkgZGVmYXVsdCBm b3IgZGV2ZWxvcG1lbnQgYnVpbGRzIHdoZXJlIGF2YWlsYWJsZQorICAgICAgICBodHRwczovL2J1 Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM1OTc5CisKKyAgICAgICAgUmV2aWV3ZWQg YnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTb3VyY2UvY21ha2UvT3B0aW9uc0NvbW1v bi5jbWFrZTogRW5hYmxlIFVTRV9MRF9MTEQgYnkgZGVmYXVsdCBmb3IgZGV2ZWxvcGVycyBidWls ZHMKKyAgICAgICAgd2hlbiBsZC5sbGQgaXMgYXZhaWxhYmxlLiBXaGlsZSBhdCBpdCwgaW1wcm92 ZSB0aGUgbWF0Y2ggb24gTERfVkVSU0lPTiB0byBiZSBtb3JlIHJvYnVzdC4KKwogMjAyMi0wMi0w OSAgUm9zcyBLaXJzbGluZyAgPHJvc3Mua2lyc2xpbmdAc29ueS5jb20+CiAKICAgICAgICAgU2hh cmVkTWVtb3J5VW5peCBzaG91bGQgdXNlIFNITV9BTk9OIHdoZW4gYXZhaWxhYmxlCg==