235964 2022-02-01 09:57:23 -0800 [GStreamer] Generate webrtc encoder src pad template based on supported platform encoders 2022-02-02 10:56:17 -0800 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pnormand pnormand calvaris eric.carlson ews-watchlist glenn hta jer.noble philipj sergio tommyw vjaquez webkit-bug-importer oldest_to_newest 1836029 0 pnormand 2022-02-01 09:57:23 -0800 . 1836031 1 450542 pnormand 2022-02-01 09:59:58 -0800 Created attachment 450542 Patch 1836343 2 450542 vjaquez 2022-02-01 23:21:09 -0800 Comment on attachment 450542 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450542&action=review > Source/WebCore/platform/mediastream/gstreamer/GStreamerVideoEncoder.cpp:269 > + what about an assert or an error message if caps results empty? 1836346 3 450542 calvaris 2022-02-01 23:26:53 -0800 Comment on attachment 450542 Patch I agree with Víctor, at least a WARNING or ERROR would be in order. 1836377 4 pnormand 2022-02-02 01:26:23 -0800 There is one already in webrtcVideoEncoderSetFormat() 1836532 5 ews-feeder 2022-02-02 10:55:18 -0800 Committed r288971 (246700@main): <https://commits.webkit.org/246700@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450542. 1836534 6 webkit-bug-importer 2022-02-02 10:56:17 -0800 <rdar://problem/88390328> 450542 2022-02-01 09:59:58 -0800 2022-02-02 10:55:20 -0800 Patch bug-235964-20220201095957.patch text/plain 6261 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4ODg0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMmFiODJjMmY2ZTI0ZTdj Y2E5MGFhNjNkOGY2Nzc3OGE5YTczZGFmMi4uNTRkYjljMjA1Yzc5ZmE0ZWVmYzJhZDA4Y2U3ZGY3 ZmFiMmM4YjMyMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDIyLTAyLTAxICBQaGls aXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVy XSBHZW5lcmF0ZSB3ZWJydGMgZW5jb2RlciBzcmMgcGFkIHRlbXBsYXRlIGJhc2VkIG9uIHN1cHBv cnRlZCBwbGF0Zm9ybSBlbmNvZGVycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MjM1OTY0CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgV2l0aG91dCB0aGlzIHBhdGNoIHRoZXJlIHdhcyBubyBndWFyYW50ZWUg dGhlIGVuY29kZXIgd291bGQgc2V0dXAgY29ycmVjdGx5IGluIGNhc2UgdGhlCisgICAgICAgIGVu Y29kZXIgbWF0Y2hpbmcgdGhlIHJlcXVlc3RlZCBjYXBzIGlzIG5vdCBhdmFpbGFibGUgYXQgcnVu dGltZS4KKworICAgICAgICAqIHBsYXRmb3JtL21lZGlhc3RyZWFtL2dzdHJlYW1lci9HU3RyZWFt ZXJWaWRlb0VuY29kZXIuY3BwOgorICAgICAgICAoRW5jb2RlcnM6OnJlZ2lzdGVyRW5jb2Rlcik6 CisgICAgICAgIChjcmVhdGVTcmNQYWRUZW1wbGF0ZUNhcHMpOgorICAgICAgICAod2Via2l0X3dl YnJ0Y192aWRlb19lbmNvZGVyX2NsYXNzX2luaXQpOgorCiAyMDIyLTAyLTAxICBQaGlsaXBwZSBO b3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1N0cmVhbWVyXSBVcGRh dGUgZmxhZ3MgaW4gaW50ZXJuYWwgR1N0cmVhbWVyIHNvdXJjZSBhbmQgc2luayBlbGVtZW50cwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vZ3N0cmVhbWVy L0dTdHJlYW1lclZpZGVvRW5jb2Rlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRp YXN0cmVhbS9nc3RyZWFtZXIvR1N0cmVhbWVyVmlkZW9FbmNvZGVyLmNwcAppbmRleCBmMzdhYTAx OGE3Nzc0N2FmZGJlZTMzOWJjZDJjYmEzNzE5YzQzM2E1Li5mYWM0NzA1ZmI4YTdjZjJkYzIzZWE1 MTFiMTVmY2Y0ODU1MmNmMzNhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9t ZWRpYXN0cmVhbS9nc3RyZWFtZXIvR1N0cmVhbWVyVmlkZW9FbmNvZGVyLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVhbS9nc3RyZWFtZXIvR1N0cmVhbWVyVmlkZW9F bmNvZGVyLmNwcApAQCAtNzEsMTAgKzcxLDE2IEBAIHB1YmxpYzoKICAgICBzdGF0aWMgdm9pZCBy ZWdpc3RlckVuY29kZXIoRW5jb2RlcklkIGlkLCBjb25zdCBjaGFyKiBuYW1lLCBjb25zdCBjaGFy KiBwYXJzZXJOYW1lLCBjb25zdCBjaGFyKiBjYXBzLCBjb25zdCBjaGFyKiBlbmNvZGVkRm9ybWF0 LAogICAgICAgICBTZXR1cEZ1bmMmJiBzZXR1cEVuY29kZXIsIGNvbnN0IGNoYXIqIGJpdHJhdGVQ cm9wZXJ0eU5hbWUsIFNldEJpdHJhdGVGdW5jJiYgc2V0Qml0cmF0ZSwgY29uc3QgY2hhcioga2V5 ZnJhbWVJbnRlcnZhbFByb3BlcnR5TmFtZSkKICAgICB7Ci0gICAgICAgIGF1dG8gZmVhdHVyZSA9 IGFkb3B0R1JlZihnc3RfcmVnaXN0cnlfbG9va3VwX2ZlYXR1cmUoZ3N0X3JlZ2lzdHJ5X2dldCgp LCBuYW1lKSk7Ci0gICAgICAgIGlmICghZmVhdHVyZSkKKyAgICAgICAgYXV0byBlbmNvZGVyRmFj dG9yeSA9IGFkb3B0R1JlZihnc3RfZWxlbWVudF9mYWN0b3J5X2ZpbmQobmFtZSkpOworICAgICAg ICBpZiAoIWVuY29kZXJGYWN0b3J5KQogICAgICAgICAgICAgcmV0dXJuOwogCisgICAgICAgIGlm IChwYXJzZXJOYW1lKSB7CisgICAgICAgICAgICBhdXRvIHBhcnNlckZhY3RvcnkgPSBhZG9wdEdS ZWYoZ3N0X2VsZW1lbnRfZmFjdG9yeV9maW5kKHBhcnNlck5hbWUpKTsKKyAgICAgICAgICAgIGlm ICghcGFyc2VyRmFjdG9yeSkKKyAgICAgICAgICAgICAgICByZXR1cm47CisgICAgICAgIH0KKwog ICAgICAgICBzaW5nbGV0b24oKS5lbXBsYWNlKHN0ZDo6bWFrZV9wYWlyKGlkLCAoRW5jb2RlckRl ZmluaXRpb24pIHsKICAgICAgICAgICAgIC5jYXBzID0gYWRvcHRHUmVmKGdzdF9jYXBzX2Zyb21f c3RyaW5nKGNhcHMpKSwKICAgICAgICAgICAgIC5uYW1lID0gbmFtZSwKQEAgLTI1MCw2ICsyNTYs MjEgQEAgc3RhdGljIHZvaWQgc2V0Qml0cmF0ZUJpdFBlclNlYyhHT2JqZWN0KiBlbmNvZGVyLCBj b25zdCBjaGFyKiBwcm9wZXJ0eU5hbWUsIGludAogICAgIGdfb2JqZWN0X3NldChlbmNvZGVyLCBw cm9wZXJ0eU5hbWUsIGJpdHJhdGUgKiBLQklUX1RPX0JJVCwgbnVsbHB0cik7CiB9CiAKK3N0YXRp YyBHUmVmUHRyPEdzdENhcHM+IGNyZWF0ZVNyY1BhZFRlbXBsYXRlQ2FwcygpCit7CisgICAgYXV0 byogY2FwcyA9IGdzdF9jYXBzX25ld19lbXB0eSgpOworCisgICAgZm9yIChjb25zdCBhdXRvJiBb aWQsIGVuY29kZXJdIDogRW5jb2RlcnM6OnNpbmdsZXRvbigpKSB7CisgICAgICAgIGlmIChlbmNv ZGVyLmVuY29kZWRGb3JtYXQpCisgICAgICAgICAgICBjYXBzID0gZ3N0X2NhcHNfbWVyZ2UoY2Fw cywgZ3N0X2NhcHNfcmVmKGVuY29kZXIuZW5jb2RlZEZvcm1hdC5nZXQoKSkpOworICAgICAgICBl bHNlCisgICAgICAgICAgICBjYXBzID0gZ3N0X2NhcHNfbWVyZ2UoY2FwcywgZ3N0X2NhcHNfcmVm KGVuY29kZXIuY2Fwcy5nZXQoKSkpOworICAgIH0KKworICAgIEdTVF9ERUJVRygiU291cmNlIHBh ZCB0ZW1wbGF0ZSBjYXBzOiAlIiBHU1RfUFRSX0ZPUk1BVCwgY2Fwcyk7CisgICAgcmV0dXJuIGNh cHM7Cit9CisKIHN0YXRpYyB2b2lkIHdlYnJ0Y1ZpZGVvRW5jb2RlckNvbnN0cnVjdGVkKEdPYmpl Y3QqIGVuY29kZXIpCiB7CiAgICAgYXV0byogc2VsZiA9IFdFQktJVF9XRUJSVENfVklERU9fRU5D T0RFUihlbmNvZGVyKTsKQEAgLTI2OCwxNyArMjg5LDYgQEAgc3RhdGljIHZvaWQgd2Via2l0X3dl YnJ0Y192aWRlb19lbmNvZGVyX2NsYXNzX2luaXQoV2ViS2l0V2VicnRjVmlkZW9FbmNvZGVyQ2xh c3MKICAgICBHc3RFbGVtZW50Q2xhc3MqIGVsZW1lbnRDbGFzcyA9IEdTVF9FTEVNRU5UX0NMQVNT KGtsYXNzKTsKICAgICBnc3RfZWxlbWVudF9jbGFzc19zZXRfc3RhdGljX21ldGFkYXRhKGVsZW1l bnRDbGFzcywgIldlYktpdCBXZWJSVEMgdmlkZW8gZW5jb2RlciIsICJDb2RlYy9FbmNvZGVyL1Zp ZGVvIiwgIkVuY29kZXMgdmlkZW8gZm9yIHN0cmVhbWluZyIsICJJZ2FsaWEiKTsKICAgICBnc3Rf ZWxlbWVudF9jbGFzc19hZGRfcGFkX3RlbXBsYXRlKGVsZW1lbnRDbGFzcywgZ3N0X3N0YXRpY19w YWRfdGVtcGxhdGVfZ2V0KCZzaW5rVGVtcGxhdGUpKTsKLSAgICBnc3RfZWxlbWVudF9jbGFzc19h ZGRfcGFkX3RlbXBsYXRlKGVsZW1lbnRDbGFzcywgZ3N0X3N0YXRpY19wYWRfdGVtcGxhdGVfZ2V0 KCZzcmNUZW1wbGF0ZSkpOwotCi0gICAgZ19vYmplY3RfY2xhc3NfaW5zdGFsbF9wcm9wZXJ0eShv YmplY3RDbGFzcywgUFJPUF9GT1JNQVQsIGdfcGFyYW1fc3BlY19ib3hlZCgiZm9ybWF0IiwgIkZv cm1hdCBhcyBjYXBzIiwgIlNldCB0aGUgY2FwcyBvZiB0aGUgZm9ybWF0IHRvIGJlIHVzZWQuIiwg R1NUX1RZUEVfQ0FQUywgV0VCS0lUX1BBUkFNX1JFQURXUklURSkpOwotCi0gICAgZ19vYmplY3Rf Y2xhc3NfaW5zdGFsbF9wcm9wZXJ0eShvYmplY3RDbGFzcywgUFJPUF9FTkNPREVSLCBnX3BhcmFt X3NwZWNfb2JqZWN0KCJlbmNvZGVyIiwgIlRoZSBhY3R1YWwgZW5jb2RlciBlbGVtZW50IiwgIlRo ZSBlbmNvZGVyIGVsZW1lbnQiLCBHU1RfVFlQRV9FTEVNRU5ULCBXRUJLSVRfUEFSQU1fUkVBREFC TEUpKTsKLQotICAgIGdfb2JqZWN0X2NsYXNzX2luc3RhbGxfcHJvcGVydHkob2JqZWN0Q2xhc3Ms IFBST1BfQklUUkFURSwgZ19wYXJhbV9zcGVjX3VpbnQoImJpdHJhdGUiLCAiQml0cmF0ZSIsICJU aGUgYml0cmF0ZSBpbiBrYml0IHBlciBzZWNvbmQiLCAwLCBHX01BWElOVCwgMjA0OCwKLSAgICAg ICAgc3RhdGljX2Nhc3Q8R1BhcmFtRmxhZ3M+KEdfUEFSQU1fUkVBRFdSSVRFIHwgR19QQVJBTV9T VEFUSUNfU1RSSU5HUyB8IEdfUEFSQU1fQ09OU1RSVUNUKSkpOwotCi0gICAgZ19vYmplY3RfY2xh c3NfaW5zdGFsbF9wcm9wZXJ0eShvYmplY3RDbGFzcywgUFJPUF9LRVlGUkFNRV9JTlRFUlZBTCwg Z19wYXJhbV9zcGVjX3VpbnQoImtleWZyYW1lLWludGVydmFsIiwgIktleWZyYW1lIGludGVydmFs IiwgIlRoZSBpbnRlcnZhbCBiZXR3ZWVuIGtleWZyYW1lcyIsIDAsIEdfTUFYSU5ULCAwLAotICAg ICAgICBzdGF0aWNfY2FzdDxHUGFyYW1GbGFncz4oR19QQVJBTV9SRUFEV1JJVEUgfCBHX1BBUkFN X1NUQVRJQ19TVFJJTkdTIHwgR19QQVJBTV9DT05TVFJVQ1QpKSk7CiAKICAgICBFbmNvZGVyczo6 cmVnaXN0ZXJFbmNvZGVyKE9teEgyNjQsICJvbXhoMjY0ZW5jIiwgImgyNjRwYXJzZSIsICJ2aWRl by94LWgyNjQiLAogICAgICAgICAidmlkZW8veC1oMjY0LGFsaWdubWVudD1hdSxzdHJlYW0tZm9y bWF0PWJ5dGUtc3RyZWFtLHByb2ZpbGU9YmFzZWxpbmUiLApAQCAtMzA1LDYgKzMxNSwxOSBAQCBz dGF0aWMgdm9pZCB3ZWJraXRfd2VicnRjX3ZpZGVvX2VuY29kZXJfY2xhc3NfaW5pdChXZWJLaXRX ZWJydGNWaWRlb0VuY29kZXJDbGFzcwogICAgICAgICBbXShXZWJLaXRXZWJydGNWaWRlb0VuY29k ZXIqIHNlbGYpIHsKICAgICAgICAgICAgIGdfb2JqZWN0X3NldChzZWxmLT5wcml2LT5lbmNvZGVy LmdldCgpLCAidGhyZWFkcyIsIDQsICJjcHUtdXNlZCIsIDQsICJ0aWxlLXJvd3MiLCAyLCAicm93 LW10IiwgdHJ1ZSwgbnVsbHB0cik7CiAgICAgICAgIH0sICJ0YXJnZXQtYml0cmF0ZSIsIHNldEJp dHJhdGVCaXRQZXJTZWMsICJrZXlmcmFtZS1tYXgtZGlzdCIpOworCisgICAgYXV0byBzcmNQYWRU ZW1wbGF0ZUNhcHMgPSBjcmVhdGVTcmNQYWRUZW1wbGF0ZUNhcHMoKTsKKyAgICBnc3RfZWxlbWVu dF9jbGFzc19hZGRfcGFkX3RlbXBsYXRlKGVsZW1lbnRDbGFzcywgZ3N0X3BhZF90ZW1wbGF0ZV9u ZXcoInNyYyIsIEdTVF9QQURfU1JDLCBHU1RfUEFEX0FMV0FZUywgc3JjUGFkVGVtcGxhdGVDYXBz LmdldCgpKSk7CisKKyAgICBnX29iamVjdF9jbGFzc19pbnN0YWxsX3Byb3BlcnR5KG9iamVjdENs YXNzLCBQUk9QX0ZPUk1BVCwgZ19wYXJhbV9zcGVjX2JveGVkKCJmb3JtYXQiLCAiRm9ybWF0IGFz IGNhcHMiLCAiU2V0IHRoZSBjYXBzIG9mIHRoZSBmb3JtYXQgdG8gYmUgdXNlZC4iLCBHU1RfVFlQ RV9DQVBTLCBXRUJLSVRfUEFSQU1fUkVBRFdSSVRFKSk7CisKKyAgICBnX29iamVjdF9jbGFzc19p bnN0YWxsX3Byb3BlcnR5KG9iamVjdENsYXNzLCBQUk9QX0VOQ09ERVIsIGdfcGFyYW1fc3BlY19v YmplY3QoImVuY29kZXIiLCAiVGhlIGFjdHVhbCBlbmNvZGVyIGVsZW1lbnQiLCAiVGhlIGVuY29k ZXIgZWxlbWVudCIsIEdTVF9UWVBFX0VMRU1FTlQsIFdFQktJVF9QQVJBTV9SRUFEQUJMRSkpOwor CisgICAgZ19vYmplY3RfY2xhc3NfaW5zdGFsbF9wcm9wZXJ0eShvYmplY3RDbGFzcywgUFJPUF9C SVRSQVRFLCBnX3BhcmFtX3NwZWNfdWludCgiYml0cmF0ZSIsICJCaXRyYXRlIiwgIlRoZSBiaXRy YXRlIGluIGtiaXQgcGVyIHNlY29uZCIsIDAsIEdfTUFYSU5ULCAyMDQ4LAorICAgICAgICBzdGF0 aWNfY2FzdDxHUGFyYW1GbGFncz4oR19QQVJBTV9SRUFEV1JJVEUgfCBHX1BBUkFNX1NUQVRJQ19T VFJJTkdTIHwgR19QQVJBTV9DT05TVFJVQ1QpKSk7CisKKyAgICBnX29iamVjdF9jbGFzc19pbnN0 YWxsX3Byb3BlcnR5KG9iamVjdENsYXNzLCBQUk9QX0tFWUZSQU1FX0lOVEVSVkFMLCBnX3BhcmFt X3NwZWNfdWludCgia2V5ZnJhbWUtaW50ZXJ2YWwiLCAiS2V5ZnJhbWUgaW50ZXJ2YWwiLCAiVGhl IGludGVydmFsIGJldHdlZW4ga2V5ZnJhbWVzIiwgMCwgR19NQVhJTlQsIDAsCisgICAgICAgIHN0 YXRpY19jYXN0PEdQYXJhbUZsYWdzPihHX1BBUkFNX1JFQURXUklURSB8IEdfUEFSQU1fU1RBVElD X1NUUklOR1MgfCBHX1BBUkFNX0NPTlNUUlVDVCkpKTsKIH0KIAogI2VuZGlmIC8vIEVOQUJMRShW SURFTykgJiYgRU5BQkxFKE1FRElBX1NUUkVBTSkgJiYgVVNFKEdTVFJFQU1FUikK