235961 2022-02-01 09:24:42 -0800 REGRESSION (r288869?): webkitpy.w3c.test_converter_unittest.W3CTestConverterTest.test_convert_prefixed_properties is failing 2022-02-02 10:33:22 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=234672 InRadar P2 Normal --- 1 ryanhaddad gsnedders ews-watchlist glenn gsnedders jbedard ntim webkit-bot-watchers-bugzilla webkit-bug-importer oldest_to_newest 1836018 0 ryanhaddad 2022-02-01 09:24:42 -0800 Results history suggests that https://trac.webkit.org/changeset/288869/webkit caused the following webkitpy test to fail: [1854/2186] webkitpy.w3c.test_converter_unittest.W3CTestConverterTest.test_convert_prefixed_properties erred: Traceback (most recent call last): File "/Volumes/Data/worker/catalina-release-tests-wk2/build/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py", line 267, in test_convert_prefixed_properties test_content = self.generate_test_content_properties_and_values(converter.prefixed_properties, converter.prefixed_property_values, 20, test_html) File "/Volumes/Data/worker/catalina-release-tests-wk2/build/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py", line 402, in generate_test_content_properties_and_values test_content_property_values = self.generate_test_content(fully_property_values_list, num_test_properties_and_values, 'propvalue', test_content_properties[1]) File "/Volumes/Data/worker/catalina-release-tests-wk2/build/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py", line 409, in generate_test_content test_list.append(full_list[count]) IndexError: list index out of range https://results.webkit.org/?suite=webkitpy-tests&test=webkitpy.w3c.test_converter_unittest.W3CTestConverterTest.test_convert_prefixed_properties 1836019 1 webkit-bug-importer 2022-02-01 09:25:19 -0800 <rdar://problem/88332029> 1836020 2 ryanhaddad 2022-02-01 09:32:14 -0800 def test_convert_prefixed_properties(self): """ Tests convert_prefixed_properties() file that has 20 properties requiring the -webkit- prefix: 10 in one style block + 5 in another style block + 5 inline styles, including one with multiple prefixed properties. The properties in the test content are in all sorts of wack formatting. """ 1836034 3 ryanhaddad 2022-02-01 10:05:25 -0800 I can reproduce this locally with: test-webkitpy webkitpy.w3c.test_converter_unittest.W3CTestConverterTest.test_convert_prefixed_properties 1836447 4 450650 gsnedders 2022-02-02 08:52:41 -0800 Created attachment 450650 Patch 1836515 5 ews-feeder 2022-02-02 10:33:19 -0800 Committed r288962 (246691@main): <https://commits.webkit.org/246691@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450650. 450650 2022-02-02 08:52:41 -0800 2022-02-02 10:33:20 -0800 Patch bug-235961-20220202165240.patch text/plain 2428 gsnedders U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4OTUyCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYjU5MjA0MzdiMjczYzgzOTdhNmI4OGRmNzA1ZmIxYmU5 OTdlYzgwZS4uODFjZGMyZjE5Zjk2NDQwODM2NjBhNjZjM2E3MjVkOGUwNTczYmMwZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1 IEBACisyMDIyLTAyLTAyICBTYW0gU25lZGRvbiAgPGdzbmVkZGVyc0BhcHBsZS5jb20+CisKKyAg ICAgICAgUkVHUkVTU0lPTiAocjI4ODg2OSk6IHdlYmtpdHB5LnczYy50ZXN0X2NvbnZlcnRlcl91 bml0dGVzdC5XM0NUZXN0Q29udmVydGVyVGVzdC50ZXN0X2NvbnZlcnRfcHJlZml4ZWRfcHJvcGVy dGllcyBpcyBmYWlsaW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0yMzU5NjEKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzg4MzMyMDI5PgorCisgICAg ICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogU2NyaXB0cy93ZWJr aXRweS93M2MvdGVzdF9jb252ZXJ0ZXJfdW5pdHRlc3QucHk6CisgICAgICAgICh0ZXN0X2NvbnZl cnRfcHJlZml4ZWRfcHJvcGVydGllcyk6IENvcnJlY3QgbWFnaWMgY29uc3RhbnQgZm9yIG51bWJl ciBvZiB0ZXN0cy4KKyAgICAgICAgKGdlbmVyYXRlX3Rlc3RfY29udGVudCk6IFNpbXBsaWZ5LCBh ZGQgY2xlYXIgYXNzZXJ0aW9uIHRvIGNhdGNoIGluIGZ1dHVyZS4KKwogMjAyMi0wMi0wMiAgWW91 ZW5uIEZhYmxldCAgPHlvdWVubkBhcHBsZS5jb20+CiAKICAgICAgICAgQ2xhcmlmeSB0aGF0IHNv bWUgVVVJRCByb3V0aW5lcyBhcmUgZGVkaWNhdGVkIHRvIFVVSUQgdjQKZGlmZiAtLWdpdCBhL1Rv b2xzL1NjcmlwdHMvd2Via2l0cHkvdzNjL3Rlc3RfY29udmVydGVyX3VuaXR0ZXN0LnB5IGIvVG9v bHMvU2NyaXB0cy93ZWJraXRweS93M2MvdGVzdF9jb252ZXJ0ZXJfdW5pdHRlc3QucHkKaW5kZXgg ODQ3Yzc1MmJhNzU1MDg4ZjRjZDFkNTBkMTdjM2M4MmVhNmFlZTBjNC4uN2I5ZGNmYWUwMDUwOTgw MjZlNzllODMwNGUwOTJmZDcxYTc5ZmFiZSAxMDA2NDQKLS0tIGEvVG9vbHMvU2NyaXB0cy93ZWJr aXRweS93M2MvdGVzdF9jb252ZXJ0ZXJfdW5pdHRlc3QucHkKKysrIGIvVG9vbHMvU2NyaXB0cy93 ZWJraXRweS93M2MvdGVzdF9jb252ZXJ0ZXJfdW5pdHRlc3QucHkKQEAgLTI2NCw3ICsyNjQsNyBA QCBDT05URU5UIE9GIFRFU1QKIDwvaHRtbD4KICIiIgogICAgICAgICBjb252ZXJ0ZXIgPSBfVzND VGVzdENvbnZlcnRlcihEVU1NWV9QQVRILCBEVU1NWV9GSUxFTkFNRSwgTm9uZSkKLSAgICAgICAg dGVzdF9jb250ZW50ID0gc2VsZi5nZW5lcmF0ZV90ZXN0X2NvbnRlbnRfcHJvcGVydGllc19hbmRf dmFsdWVzKGNvbnZlcnRlci5wcmVmaXhlZF9wcm9wZXJ0aWVzLCBjb252ZXJ0ZXIucHJlZml4ZWRf cHJvcGVydHlfdmFsdWVzLCAyMCwgdGVzdF9odG1sKQorICAgICAgICB0ZXN0X2NvbnRlbnQgPSBz ZWxmLmdlbmVyYXRlX3Rlc3RfY29udGVudF9wcm9wZXJ0aWVzX2FuZF92YWx1ZXMoY29udmVydGVy LnByZWZpeGVkX3Byb3BlcnRpZXMsIGNvbnZlcnRlci5wcmVmaXhlZF9wcm9wZXJ0eV92YWx1ZXMs IDE5LCB0ZXN0X2h0bWwpCiAKICAgICAgICAgd2l0aCBPdXRwdXRDYXB0dXJlKCk6CiAgICAgICAg ICAgICBjb252ZXJ0ZXIuZmVlZCh0ZXN0X2NvbnRlbnRbMl0pCkBAIC00MDMsMTEgKzQwMyw4IEBA IENPTlRFTlQgT0YgVEVTVAogICAgICAgICByZXR1cm4gKHRlc3RfY29udGVudF9wcm9wZXJ0aWVz WzBdLCB0ZXN0X2NvbnRlbnRfcHJvcGVydHlfdmFsdWVzWzBdLCB0ZXN0X2NvbnRlbnRfcHJvcGVy dHlfdmFsdWVzWzFdKQogCiAgICAgZGVmIGdlbmVyYXRlX3Rlc3RfY29udGVudChzZWxmLCBmdWxs X2xpc3QsIG51bV90ZXN0LCBzdWZmaXgsIGh0bWwpOgotICAgICAgICB0ZXN0X2xpc3QgPSBbXQot ICAgICAgICBjb3VudCA9IDAKLSAgICAgICAgd2hpbGUgY291bnQgPCBudW1fdGVzdDoKLSAgICAg ICAgICAgIHRlc3RfbGlzdC5hcHBlbmQoZnVsbF9saXN0W2NvdW50XSkKLSAgICAgICAgICAgIGNv dW50ICs9IDEKKyAgICAgICAgYXNzZXJ0IG51bV90ZXN0IDw9IGxlbihmdWxsX2xpc3QpLCAiY2Fu J3QgZ2VuZXJhdGUgbW9yZSB0ZXN0cyB0aGFuIHdlIGhhdmUgaW5wdXQgZGF0YSBmb3IiCisgICAg ICAgIHRlc3RfbGlzdCA9IGZ1bGxfbGlzdFs6bnVtX3Rlc3RdCiAKICAgICAgICAgIyBSZXBsYWNl IHRoZSB0b2tlbnMgaW4gdGhlIHRlc3RodG1sIHdpdGggdGhlIHRlc3QgcHJvcGVydGllcyBvciB2 YWx1ZXMuCiAgICAgICAgICMgV2FsayBiYWNrd2FyZCB0aHJvdWdoIHRoZSBsaXN0IHRvIHJlcGxh Y2UgdGhlIGRvdWJsZS1kaWdpdCB0b2tlbnMgZmlyc3QuCg==