23592 2009-01-28 11:27:47 -0800 Update appcache manifest signature parsing 2009-01-29 00:32:49 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 ap ap oldest_to_newest 107353 0 ap 2009-01-28 11:27:47 -0800 The spec has changed to allow comments on the signature line. 107355 1 27112 ap 2009-01-28 11:31:20 -0800 Created attachment 27112 proposed patch 107364 2 27112 andersca 2009-01-28 12:05:23 -0800 Comment on attachment 27112 proposed patch r=me! 107481 3 ap 2009-01-29 00:32:49 -0800 Committed revision 40355. 27112 2009-01-28 11:31:20 -0800 2009-01-28 12:05:23 -0800 proposed patch SignatureLine.txt text/plain 7681 ap SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MDMxNSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMDktMDEtMjggIEFsZXhleSBQcm9za3VyeWFrb3YgIDxhcEB3ZWJr aXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzU5MgorICAgICAgICBV cGRhdGUgYXBwY2FjaGUgbWFuaWZlc3Qgc2lnbmF0dXJlIHBhcnNpbmcKKworICAgICAgICBUZXN0 OiBodHRwL3Rlc3RzL2FwcGNhY2hlL3dyb25nLXNpZ25hdHVyZS0yLmh0bWwKKworICAgICAgICAq IGxvYWRlci9hcHBjYWNoZS9NYW5pZmVzdFBhcnNlci5jcHA6IChXZWJDb3JlOjpwYXJzZU1hbmlm ZXN0KTogQWxsb3cgY29tbWVudHMgb24gc2lnbmF0dXJlCisgICAgICAgIGxpbmUuIFJlbW92ZWQg Y29kZSB0aGF0IHJlcGxhY2VkIG51bGxzIHdpdGggMHhGRkZEIGNoYXJhY3RlcnMsIGJlY2F1c2Ug dGhlcmUgaXMgbm8gc3VjaAorICAgICAgICByZXF1aXJlbWVudCBpbiB0aGUgc3BlYy4KKwogMjAw OS0wMS0yOCAgWmFjaGFyeSBLdXpuaWEgIDx6b3JrQGNocm9taXV1bS5vcmc+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgU2FtIFdlaW5pZy4KSW5kZXg6IFdlYkNvcmUvbG9hZGVyL2FwcGNhY2hlL01h bmlmZXN0UGFyc2VyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2xvYWRlci9hcHBjYWNoZS9N YW5pZmVzdFBhcnNlci5jcHAJKHJldmlzaW9uIDQwMzA5KQorKysgV2ViQ29yZS9sb2FkZXIvYXBw Y2FjaGUvTWFuaWZlc3RQYXJzZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00NywzNCArNDcsMjIg QEAgYm9vbCBwYXJzZU1hbmlmZXN0KGNvbnN0IEtVUkwmIG1hbmlmZXN0VQogICAgIE1vZGUgbW9k ZSA9IEV4cGxpY2l0OwogICAgIFN0cmluZyBzID0gVVRGOEVuY29kaW5nKCkuZGVjb2RlKGRhdGEs IGxlbmd0aCk7CiAgICAgCi0gICAgaWYgKHMuaXNFbXB0eSgpKQorICAgIC8vIExvb2sgZm9yIHRo ZSBtYWdpYyBzaWduYXR1cmU6ICJeXHhGRUZGP0NBQ0hFIE1BTklGRVNUWyBcdF0/IiAodGhlIEJP TSBpcyByZW1vdmVkIGJ5IGRlY29kZSgpKS4KKyAgICAvLyBFeGFtcGxlOiAiQ0FDSEUgTUFOSUZF U1QgI2NvbW1lbnQiIGlzIGEgdmFsaWQgc2lnbmF0dXJlLgorICAgIC8vIEV4YW1wbGU6ICJDQUNI RSBNQU5JRkVTVDtWMiIgaXMgbm90LgorICAgIGlmICghcy5zdGFydHNXaXRoKCJDQUNIRSBNQU5J RkVTVCIpKQogICAgICAgICByZXR1cm4gZmFsc2U7CiAgICAgCi0gICAgLy8gUmVwbGFjZSBudWxs cyB3aXRoIFUrRkZGRCBSRVBMQUNFTUVOVCBDSEFSQUNURVIKLSAgICBzLnJlcGxhY2UoMCwgcmVw bGFjZW1lbnRDaGFyYWN0ZXIpOwotICAgIAotICAgIC8vIExvb2sgZm9yIHRoZSBtYWdpYyBzaWdu YXR1cmUKLSAgICBpZiAoIXMuc3RhcnRzV2l0aCgiQ0FDSEUgTUFOSUZFU1QiKSkgewotICAgICAg ICAvLyBUaGUgbWFnaWMgc2lnbmF0dXJlIHdhcyBub3QgZm91bmQuCi0gICAgICAgIHJldHVybiBm YWxzZTsKLSAgICB9Ci0gICAgCiAgICAgY29uc3QgVUNoYXIqIGVuZCA9IHMuY2hhcmFjdGVycygp ICsgcy5sZW5ndGgoKTsgICAgCiAgICAgY29uc3QgVUNoYXIqIHAgPSBzLmNoYXJhY3RlcnMoKSAr IDE0OyAvLyAiQ0FDSEUgTUFOSUZFU1QiIGlzIDE0IGNoYXJhY3RlcnMuCi0gICAgCi0gICAgd2hp bGUgKHAgPCBlbmQpIHsKLSAgICAgICAgLy8gU2tpcCB3aGl0ZXNwYWNlCi0gICAgICAgIGlmICgq cCA9PSAnICcgfHwgKnAgPT0gJ1x0JykgewotICAgICAgICAgICAgcCsrOwotICAgICAgICB9IGVs c2UKLSAgICAgICAgICAgIGJyZWFrOwotICAgIH0KLSAgICAKLSAgICBpZiAocCA8IGVuZCAmJiAq cCAhPSAnXG4nICYmICpwICE9ICdccicpIHsKLSAgICAgICAgLy8gVGhlIG1hZ2ljIHNpZ25hdHVy ZSB3YXMgaW52YWxpZAorCisgICAgaWYgKHAgPCBlbmQgJiYgKnAgIT0gJyAnICYmICpwICE9ICdc dCcgJiYgKnAgIT0gJ1xuJyAmJiAqcCAhPSAnXHInKQogICAgICAgICByZXR1cm4gZmFsc2U7Ci0g ICAgfQotICAgIAorCisgICAgLy8gU2tpcCB0byB0aGUgZW5kIG9mIHRoZSBsaW5lLgorICAgIHdo aWxlIChwIDwgZW5kICYmICpwICE9ICdccicgJiYgKnAgIT0gJ1xuJykKKyAgICAgICAgcCsrOwor CiAgICAgd2hpbGUgKDEpIHsKICAgICAgICAgLy8gU2tpcCB3aGl0ZXNwYWNlCiAgICAgICAgIHdo aWxlIChwIDwgZW5kICYmICgqcCA9PSAnXG4nIHx8ICpwID09ICdccicgfHwgKnAgPT0gJyAnIHx8 ICpwID09ICdcdCcpKQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gNDAzMTUpCisrKyBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwyMSBAQAorMjAwOS0wMS0yOCAgQWxl eGV5IFByb3NrdXJ5YWtvdiAgPGFwQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTIzNTkyCisgICAgICAgIFVwZGF0ZSBhcHBjYWNoZSBtYW5pZmVzdCBzaWduYXR1 cmUgcGFyc2luZworCisgICAgICAgICogaHR0cC90ZXN0cy9hcHBjYWNoZS9tYW5pZmVzdC1wYXJz aW5nLmh0bWw6IEZpeGVkIHRvIHBvaW50IHRvIGEgY29ycmVjdCBtYW5pZmVzdCAob29wcykuCisK KyAgICAgICAgKiBodHRwL3Rlc3RzL2FwcGNhY2hlL3Jlc291cmNlcy9tYW5pZmVzdC1wYXJzaW5n Lm1hbmlmZXN0OiBBZGRlZCBhIGNvbW1lbnQgYXQgdGhlIGVuZCBvZgorICAgICAgICBzaWduYXR1 cmUgbGluZS4KKworICAgICAgICAqIGh0dHAvdGVzdHMvYXBwY2FjaGUvcmVzb3VyY2VzL3dyb25n LXNpZ25hdHVyZS0yLm1hbmlmZXN0OiBBZGRlZC4KKyAgICAgICAgKiBodHRwL3Rlc3RzL2FwcGNh Y2hlL3dyb25nLXNpZ25hdHVyZS0yLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogaHR0 cC90ZXN0cy9hcHBjYWNoZS93cm9uZy1zaWduYXR1cmUtMi5odG1sOiBBZGRlZC4KKyAgICAgICAg KiBodHRwL3Rlc3RzL2FwcGNhY2hlL3dyb25nLXNpZ25hdHVyZS5odG1sOgorICAgICAgICBUZXN0 IHRoYXQgdGhlcmUgbXVzdCBiZSB3aGl0ZXNwYWNlIGJlZm9yZSB0aGUgY29tbWVudC4KKwogMjAw OS0wMS0yNyAgSG9sZ2VyIEhhbnMgUGV0ZXIgRnJleXRoZXIgIDx6ZWNrZUBzZWxmaXNoLm9yZz4K IAogICAgICAgICBSdWJiZXIgc3RhbXBlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IExheW91dFRl c3RzL2h0dHAvdGVzdHMvYXBwY2FjaGUvbWFuaWZlc3QtcGFyc2luZy5odG1sCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL2h0dHAvdGVzdHMvYXBwY2FjaGUvbWFuaWZlc3QtcGFyc2luZy5odG1s CShyZXZpc2lvbiA0MDMwOSkKKysrIExheW91dFRlc3RzL2h0dHAvdGVzdHMvYXBwY2FjaGUvbWFu aWZlc3QtcGFyc2luZy5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC01OSw2ICs1OSw4IEBAIGZ1bmN0 aW9uIHRlc3QoKQogCiBhcHBsaWNhdGlvbkNhY2hlLm9ubm91cGRhdGUgPSBmdW5jdGlvbigpIHsg dGVzdCgpIH0KIGFwcGxpY2F0aW9uQ2FjaGUub25jYWNoZWQgPSBmdW5jdGlvbigpIHsgdGVzdCgp IH0KKworYXBwbGljYXRpb25DYWNoZS5vbmVycm9yID0gZnVuY3Rpb24oKSB7IGxvZygiZXJyb3Ii KSB9CiA8L3NjcmlwdD4KIDwvYm9keT4KIDwvaHRtbD4KSW5kZXg6IExheW91dFRlc3RzL2h0dHAv dGVzdHMvYXBwY2FjaGUvd3Jvbmctc2lnbmF0dXJlLTItZXhwZWN0ZWQudHh0Cj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL2h0dHAvdGVzdHMvYXBwY2FjaGUvd3Jvbmctc2lnbmF0dXJlLTItZXhw ZWN0ZWQudHh0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9hcHBjYWNo ZS93cm9uZy1zaWduYXR1cmUtMi1leHBlY3RlZC50eHQJKHJldmlzaW9uIDApCkBAIC0wLDAgKzEs NiBAQAorVGVzdCB0aGF0IGEgbWFuaWZlc3Qgc2VydmVkIHdpdGggYSB3cm9uZyBzaWduYXR1cmUg aXNuJ3QgdHJlYXRlZCBhcyBzdWNoLgorCitTaG91bGQgc2F5IFNVQ0NFU1M6CisKK1NVQ0NFU1MK KwoKUHJvcGVydHkgY2hhbmdlcyBvbjogTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9hcHBjYWNoZS93 cm9uZy1zaWduYXR1cmUtMi1leHBlY3RlZC50eHQKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpOYW1lOiBzdm46bWltZS10 eXBlCiAgICsgdGV4dC9wbGFpbgpOYW1lOiBzdm46ZW9sLXN0eWxlCiAgICsgbmF0aXZlCgpJbmRl eDogTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9hcHBjYWNoZS93cm9uZy1zaWduYXR1cmUtMi5odG1s Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2h0dHAvdGVzdHMvYXBwY2FjaGUvd3Jvbmctc2ln bmF0dXJlLTIuaHRtbAkocmV2aXNpb24gMCkKKysrIExheW91dFRlc3RzL2h0dHAvdGVzdHMvYXBw Y2FjaGUvd3Jvbmctc2lnbmF0dXJlLTIuaHRtbAkocmV2aXNpb24gMCkKQEAgLTAsMCArMSw0MyBA QAorPGh0bWwgbWFuaWZlc3Q9InJlc291cmNlcy93cm9uZy1zaWduYXR1cmUtMi5tYW5pZmVzdCI+ Cis8Ym9keT4KKzxwPlRlc3QgdGhhdCBhIG1hbmlmZXN0IHNlcnZlZCB3aXRoIGEgd3Jvbmcgc2ln bmF0dXJlIGlzbid0IHRyZWF0ZWQgYXMgc3VjaC48L3A+Cis8cD5TaG91bGQgc2F5IFNVQ0NFU1M6 PC9wPgorPGRpdiBpZD1yZXN1bHQ+PC9kaXY+Cis8c2NyaXB0PgoraWYgKHdpbmRvdy5sYXlvdXRU ZXN0Q29udHJvbGxlcikgeworICAgIGxheW91dFRlc3RDb250cm9sbGVyLmR1bXBBc1RleHQoKQor ICAgIGxheW91dFRlc3RDb250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKK30KKworZnVuY3Rpb24g bG9nKG1lc3NhZ2UpCit7CisgICAgZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoInJlc3VsdCIpLmlu bmVySFRNTCArPSBtZXNzYWdlICsgIjxicj4iOworfQorCitmdW5jdGlvbiBjYWNoZUNhbGxiYWNr KCkKK3sKKyAgICBsb2coIkZBSUw6IEFuIGV2ZW50IHdhcyBkaXNwYXRjaGVkIG9uIHdpbmRvdy5h cHBsaWNhdGlvbkNhY2hlLCBldmVuIHRob3VnaCBpdCB3YXMgbm90IGFzc29jaWF0ZWQgd3V0aCBh bnkgY2FjaGUgeWV0LiIpOworfQorCitmdW5jdGlvbiB0aW1lb3V0KCkKK3sKKyAgICAvLyBXYWl0 IGZvciBjYWNoZSB1cGRhdGUgdG8gZmluaXNoLgorICAgIGlmICh3aW5kb3cuYXBwbGljYXRpb25D YWNoZS5zdGF0dXMgIT0gMCkgeworICAgICAgICBzZXRUaW1lb3V0KHRpbWVvdXQsIDApOworICAg ICAgICByZXR1cm47CisgICAgfQorICAgIAorICAgIGxvZygiU1VDQ0VTUyIpOworICAgIGlmICh3 aW5kb3cubGF5b3V0VGVzdENvbnRyb2xsZXIpCisgICAgICAgIGxheW91dFRlc3RDb250cm9sbGVy Lm5vdGlmeURvbmUoKTsKK30KKworYXBwbGljYXRpb25DYWNoZS5hZGRFdmVudExpc3RlbmVyKCdj YWNoZWQnLCBmdW5jdGlvbigpIHsgbG9nKCJjYWNoZWQiKTsgY2FjaGVDYWxsYmFjaygpIH0sIGZh bHNlKTsKK2FwcGxpY2F0aW9uQ2FjaGUuYWRkRXZlbnRMaXN0ZW5lcignbm91cGRhdGUnLCBmdW5j dGlvbigpIHsgbG9nKCJub3VwZGF0ZSIpOyBjYWNoZUNhbGxiYWNrKCkgfSwgZmFsc2UpOworYXBw bGljYXRpb25DYWNoZS5hZGRFdmVudExpc3RlbmVyKCdlcnJvcicsIGZ1bmN0aW9uKCkgeyBsb2co ImVycm9yIik7IGNhY2hlQ2FsbGJhY2soKSB9LCBmYWxzZSk7CisKK3NldFRpbWVvdXQodGltZW91 dCwgMTAwKTsKKworPC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CgpQcm9wZXJ0eSBjaGFuZ2Vz IG9uOiBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2FwcGNhY2hlL3dyb25nLXNpZ25hdHVyZS0yLmh0 bWwKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwpOYW1lOiBzdm46bWltZS10eXBlCiAgICsgdGV4dC9odG1sCgpJbmRleDog TGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9hcHBjYWNoZS93cm9uZy1zaWduYXR1cmUuaHRtbAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2FwcGNhY2hlL3dyb25nLXNpZ25hdHVy ZS5odG1sCShyZXZpc2lvbiA0MDMwOSkKKysrIExheW91dFRlc3RzL2h0dHAvdGVzdHMvYXBwY2Fj aGUvd3Jvbmctc2lnbmF0dXJlLmh0bWwJKHdvcmtpbmcgY29weSkKQEAgLTEsNCArMSw0IEBACi08 aHRtbCBtYW5pZmVzdD0icmVzb3VyY2VzL3dyb25nLWNvbnRlbnQtdHlwZS5tYW5pZmVzdCI+Cis8 aHRtbCBtYW5pZmVzdD0icmVzb3VyY2VzL3dyb25nLXNpZ25hdHVyZS5tYW5pZmVzdCI+CiA8Ym9k eT4KIDxwPlRlc3QgdGhhdCBhIG1hbmlmZXN0IHNlcnZlZCB3aXRoIGEgd3Jvbmcgc2lnbmF0dXJl IGlzbid0IHRyZWF0ZWQgYXMgc3VjaC48L3A+CiA8cD5TaG91bGQgc2F5IFNVQ0NFU1M6PC9wPgpJ bmRleDogTGF5b3V0VGVzdHMvaHR0cC90ZXN0cy9hcHBjYWNoZS9yZXNvdXJjZXMvbWFuaWZlc3Qt cGFyc2luZy5tYW5pZmVzdAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9odHRwL3Rlc3RzL2Fw cGNhY2hlL3Jlc291cmNlcy9tYW5pZmVzdC1wYXJzaW5nLm1hbmlmZXN0CShyZXZpc2lvbiA0MDMw OSkKKysrIExheW91dFRlc3RzL2h0dHAvdGVzdHMvYXBwY2FjaGUvcmVzb3VyY2VzL21hbmlmZXN0 LXBhcnNpbmcubWFuaWZlc3QJKHdvcmtpbmcgY29weSkKQEAgLTEsNCArMSw0IEBACi3vu79DQUNI RSBNQU5JRkVTVCAKK++7v0NBQ0hFIE1BTklGRVNUIGlnbm9yZWQgdGV4dAogIAkgZW1wdHkudHh0 IAkgCiAgCSAgCQogc2ltcGxlLnR4dCBpZ25vcmVkIHRleHQKSW5kZXg6IExheW91dFRlc3RzL2h0 dHAvdGVzdHMvYXBwY2FjaGUvcmVzb3VyY2VzL3dyb25nLXNpZ25hdHVyZS0yLm1hbmlmZXN0Cj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIExheW91dFRlc3RzL2h0dHAvdGVzdHMvYXBwY2FjaGUvcmVzb3VyY2VzL3dy b25nLXNpZ25hdHVyZS0yLm1hbmlmZXN0CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvaHR0 cC90ZXN0cy9hcHBjYWNoZS9yZXNvdXJjZXMvd3Jvbmctc2lnbmF0dXJlLTIubWFuaWZlc3QJKHJl dmlzaW9uIDApCkBAIC0wLDAgKzEgQEAKK0NBQ0hFIE1BTklGRVNUO1YyCg==