235907 2022-01-31 12:41:20 -0800 null ptr deref in LayoutIntegrationLineLayout LineLayout::adjustForPagination and LineLayout::visualOverflowBoundingBoxRectFor 2022-02-01 10:20:18 -0800 1 1 1 Unclassified WebKit Layout and Rendering WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 gnavamarino gnavamarino bfulgham koivisto simon.fraser webkit-bug-importer zalan oldest_to_newest 1835640 0 gnavamarino 2022-01-31 12:41:20 -0800 m_inlineContent could become null (such as after calling LineLayout::clearInlineContent(), so we add these two checks to protect against an nullptr deref. <rdar://problem/88265059> 1835645 1 450432 gnavamarino 2022-01-31 12:48:16 -0800 Created attachment 450432 Patch 1836026 2 450432 gnavamarino 2022-02-01 09:40:58 -0800 Comment on attachment 450432 Patch The layout test failures on win are appearing in the WebKit Results Database history in past revisions are unrelated to this patch. 1836041 3 ews-feeder 2022-02-01 10:20:12 -0800 Committed r288891 (246638@main): <https://commits.webkit.org/246638@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450432. 450432 2022-01-31 12:48:16 -0800 2022-02-01 10:20:15 -0800 Patch bug-235907-20220131124815.patch text/plain 4790 gnavamarino U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4ODMxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYjBhMDEwMWYxNjc5YWFj NGYxNjIxYjkzOWIwOWY4MjQzZWMxOWQzNS4uMGNjMmQ2NjFhOWVhNDY0MTE3NTMwYmVkMWIxZGRj NWQ3NGZmMWUxMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIyLTAxLTMxICBHYWJy aWVsIE5hdmEgTWFyaW5vICA8Z25hdmFtYXJpbm9AYXBwbGUuY29tPgorCisgICAgICAgIG51bGwg cHRyIGRlcmVmIGluIExheW91dEludGVncmF0aW9uTGluZUxheW91dCBMaW5lTGF5b3V0OjphZGp1 c3RGb3JQYWdpbmF0aW9uIGFuZCBMaW5lTGF5b3V0Ojp2aXN1YWxPdmVyZmxvd0JvdW5kaW5nQm94 UmVjdEZvcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MjM1OTA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg bV9pbmxpbmVDb250ZW50IGNvdWxkIGJlY29tZSBudWxscHRyIChzdWNoIGFzIGFmdGVyIGNhbGxp bmcgTGluZUxheW91dDo6Y2xlYXJJbmxpbmVDb250ZW50KCkpCisgICAgICAgIHNvIHdlIGFkZCB0 aGVzZSBudWxscHRyIGNoZWNrcyB0byBwcm90ZWN0IGFnYWluc3QgYW4gbnVsbHB0ciBkZXJlZiwg aW4gYSBzaW1pbGFyIHdheSB0bworICAgICAgICBob3cgaXQncyBkb25lIGluIHRoZSBvdGhlciBt ZXRob2RzLgorCisgICAgICAgIFRlc3Q6IGZhc3QvbGF5b3V0Zm9ybWF0dGluZ2NvbnRleHQvdmlz dWFsLW92ZXJmbG93LWJvdW5kaW5nLWJveC1yZWN0LWNyYXNoLmh0bWwKKworICAgICAgICAqIGxh eW91dC9pbnRlZ3JhdGlvbi9MYXlvdXRJbnRlZ3JhdGlvbkxpbmVMYXlvdXQuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6TGF5b3V0SW50ZWdyYXRpb246OkxpbmVMYXlvdXQ6OmFkanVzdEZvclBhZ2lu YXRpb24pOgorICAgICAgICAoV2ViQ29yZTo6TGF5b3V0SW50ZWdyYXRpb246OkxpbmVMYXlvdXQ6 OnZpc3VhbE92ZXJmbG93Qm91bmRpbmdCb3hSZWN0Rm9yIGNvbnN0KToKKwogMjAyMi0wMS0zMSAg QW50dGkgS29pdmlzdG8gIDxhbnR0aUBhcHBsZS5jb20+CiAKICAgICAgICAgTGluZUxheW91dDo6 Y29sbGVjdE92ZXJmbG93KCkgc2hvdWxkIG51bGwgY2hlY2sgbV9pbmxpbmVDb250ZW50CmRpZmYg LS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sYXlvdXQvaW50ZWdyYXRpb24vTGF5b3V0SW50ZWdyYXRp b25MaW5lTGF5b3V0LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbnRlZ3JhdGlvbi9MYXlv dXRJbnRlZ3JhdGlvbkxpbmVMYXlvdXQuY3BwCmluZGV4IGZhN2FjODQ3NDgzYjE5NzZjNmVmZWRj YTk0YmI4ZjgzZTQxZDNhMmQuLmM4NWI3Yjg3NWI4MWM2ZGE0YjNkZGNmNjBkZjBmMzMwYmZmMmFj ZjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbnRlZ3JhdGlvbi9MYXlvdXRJ bnRlZ3JhdGlvbkxpbmVMYXlvdXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xheW91dC9pbnRl Z3JhdGlvbi9MYXlvdXRJbnRlZ3JhdGlvbkxpbmVMYXlvdXQuY3BwCkBAIC00MDMsNiArNDAzLDkg QEAgTGF5b3V0VW5pdCBMaW5lTGF5b3V0OjpsYXN0TGluZUJhc2VsaW5lKCkgY29uc3QKIAogdm9p ZCBMaW5lTGF5b3V0OjphZGp1c3RGb3JQYWdpbmF0aW9uKCkKIHsKKyAgICBpZiAoIW1faW5saW5l Q29udGVudCkKKyAgICAgICAgcmV0dXJuOworCiAgICAgYXV0byBwYWdpbmVkSW5saW5lQ29udGVu dCA9IGFkanVzdExpbmVQb3NpdGlvbnNGb3JQYWdpbmF0aW9uKCptX2lubGluZUNvbnRlbnQsIGZs b3coKSk7CiAgICAgaWYgKHBhZ2luZWRJbmxpbmVDb250ZW50LnB0cigpID09IG1faW5saW5lQ29u dGVudCkgewogICAgICAgICBtX2lzUGFnaW5hdGVkQ29udGVudCA9IGZhbHNlOwpAQCAtNTE4LDYg KzUyMSw5IEBAIExheW91dFJlY3QgTGluZUxheW91dDo6ZW5jbG9zaW5nQm9yZGVyQm94UmVjdEZv cihjb25zdCBSZW5kZXJJbmxpbmUmIHJlbmRlcklubGluCiAKIExheW91dFJlY3QgTGluZUxheW91 dDo6dmlzdWFsT3ZlcmZsb3dCb3VuZGluZ0JveFJlY3RGb3IoY29uc3QgUmVuZGVySW5saW5lJiBy ZW5kZXJJbmxpbmUpIGNvbnN0CiB7CisgICAgaWYgKCFtX2lubGluZUNvbnRlbnQpCisgICAgICAg IHJldHVybiB7IH07CisKICAgICBhdXRvJiBsYXlvdXRCb3ggPSBtX2JveFRyZWUubGF5b3V0Qm94 Rm9yUmVuZGVyZXIocmVuZGVySW5saW5lKTsKIAogICAgIExheW91dFJlY3QgcmVzdWx0OwpkaWZm IC0tZ2l0IGEvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCmlu ZGV4IGIxNzI0ZTQzNTVmNmViYzdkZDhmMjI5NDViNTVlNjI1ZDU4YzdiZTUuLmUwMzQwYzcwMGRk MWI0NzRiZTU5OWVkNTdjMTUxODBhNDQ1NTZhOWEgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3RzL0No YW5nZUxvZworKysgYi9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAy Mi0wMS0zMSAgR2FicmllbCBOYXZhIE1hcmlubyAgPGduYXZhbWFyaW5vQGFwcGxlLmNvbT4KKwor ICAgICAgICBudWxsIHB0ciBkZXJlZiBpbiBMYXlvdXRJbnRlZ3JhdGlvbkxpbmVMYXlvdXQgTGlu ZUxheW91dDo6YWRqdXN0Rm9yUGFnaW5hdGlvbiBhbmQgTGluZUxheW91dDo6dmlzdWFsT3ZlcmZs b3dCb3VuZGluZ0JveFJlY3RGb3IKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTIzNTkwNworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogZmFzdC9sYXlvdXRmb3JtYXR0aW5nY29udGV4dC92aXN1YWwtb3ZlcmZs b3ctYm91bmRpbmctYm94LXJlY3QtY3Jhc2gtZXhwZWN0ZWQudHh0OiBBZGRlZC4KKyAgICAgICAg KiBmYXN0L2xheW91dGZvcm1hdHRpbmdjb250ZXh0L3Zpc3VhbC1vdmVyZmxvdy1ib3VuZGluZy1i b3gtcmVjdC1jcmFzaC5odG1sOiBBZGRlZC4KKwogMjAyMi0wMS0zMSAgVGFrZXNoaSBTb25lICA8 dGFrZXNoaS5zb25lQGdtYWlsLmNvbT4KIAogICAgICAgICBBZGRlZCBhIHRlc3QgdG8gdmVyaWZ5 IHRoYXQgc2V0dGluZyB1bmRlZmluZWQgdG8gdmlkZW8ucGxheWJhY2tSYXRlCmRpZmYgLS1naXQg YS9MYXlvdXRUZXN0cy9mYXN0L2xheW91dGZvcm1hdHRpbmdjb250ZXh0L3Zpc3VhbC1vdmVyZmxv dy1ib3VuZGluZy1ib3gtcmVjdC1jcmFzaC1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9mYXN0 L2xheW91dGZvcm1hdHRpbmdjb250ZXh0L3Zpc3VhbC1vdmVyZmxvdy1ib3VuZGluZy1ib3gtcmVj dC1jcmFzaC1leHBlY3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMC4uNDVjNjkwOGZmNGE4YTliZjNiOTBkOTAy OGEwNjBlM2MyNzRjOTZiNwotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvbGF5 b3V0Zm9ybWF0dGluZ2NvbnRleHQvdmlzdWFsLW92ZXJmbG93LWJvdW5kaW5nLWJveC1yZWN0LWNy YXNoLWV4cGVjdGVkLnR4dApAQCAtMCwwICsxLDIgQEAKK1BBU1MgaWYgdGhpcyBkb2Vzbid0IGNy YXNoCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvbGF5b3V0Zm9ybWF0dGluZ2NvbnRl eHQvdmlzdWFsLW92ZXJmbG93LWJvdW5kaW5nLWJveC1yZWN0LWNyYXNoLmh0bWwgYi9MYXlvdXRU ZXN0cy9mYXN0L2xheW91dGZvcm1hdHRpbmdjb250ZXh0L3Zpc3VhbC1vdmVyZmxvdy1ib3VuZGlu Zy1ib3gtcmVjdC1jcmFzaC5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAuLjBmNDdhYjA2NTU3NWQ0MzY3OGViMmEx M2MwNmFlZTgxY2M1OGJhYWEKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2xh eW91dGZvcm1hdHRpbmdjb250ZXh0L3Zpc3VhbC1vdmVyZmxvdy1ib3VuZGluZy1ib3gtcmVjdC1j cmFzaC5odG1sCkBAIC0wLDAgKzEsMjYgQEAKKzwhRE9DVFlQRSBodG1sPgorPHN0eWxlPgorICA6 b25seS1jaGlsZCB7CisgICAgLXdlYmtpdC1saW5lLWNsYW1wOiAxOworICB9Cis8L3N0eWxlPgor PHNjcmlwdD4KKyAgaW50ZXJuYWxzLnNldHRpbmdzLnNldExheWVyQmFzZWRTVkdFbmdpbmVFbmFi bGVkKHRydWUpOworCisgIG9ubG9hZCA9ICgpID0+IHsKKyAgICBsZXQgdHIwID0gZG9jdW1lbnQu Y3JlYXRlRWxlbWVudCgndHInKTsKKyAgICBkb2N1bWVudC5ib2R5LmFwcGVuZCh0cjApOworICAg IGxldCBkaXYwID0gZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgnZGl2Jyk7CisgICAgdHIwLmFwcGVu ZChkaXYwKTsKKyAgICBsZXQgc3BhbjAgPSBkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdzcGFuJyk7 CisgICAgc3BhbjAuc3R5bGUuYXBwZWFyYW5jZSA9ICdidXR0b24nOworICAgIHNwYW4wLnN0eWxl LnNoYXBlT3V0c2lkZSA9ICdjaXJjbGUoKSc7CisgICAgZGl2MC5hcHBlbmQoc3BhbjApOworICAg IHNwYW4wLmFwcGVuZChkb2N1bWVudC5jcmVhdGVFbGVtZW50KCdzcGFuJykpOworICAgIGRvY3Vt ZW50LmJvZHkub2Zmc2V0VG9wOworICAgIHRyMC5hcHBlbmQoZG9jdW1lbnQuY3JlYXRlRWxlbWVu dCgnZGl2JykpOworICAgIGlmICh3aW5kb3cudGVzdFJ1bm5lcikKKyAgICAgIHRlc3RSdW5uZXIu ZHVtcEFzVGV4dCgpOworICB9OworPC9zY3JpcHQ+CitQQVNTIGlmIHRoaXMgZG9lc24ndCBjcmFz aAo=