235890 2022-01-31 05:27:37 -0800 [GTK][a11y] WTR: use AXMenuItemSelected for menu item selection change with ATSPI 2022-01-31 06:17:11 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk, LayoutTestFailure P2 Normal --- 230253 1 cgarcia webkit-unassigned aboxhall andresg_22 aperez apinheiro bugs-noreply cfleizach dmazzoni ews-watchlist jcraig jdiggs samuel_white oldest_to_newest 1835509 0 cgarcia 2022-01-31 05:27:37 -0800 ATSPI uses selection-changed signal for both combo box menus and list boxes, but layout tests expect then to be different events AXMenuItemSelected and AXSelectedChildrenChanged 1835510 1 450404 cgarcia 2022-01-31 05:29:53 -0800 Created attachment 450404 Patch 1835517 2 cgarcia 2022-01-31 06:17:11 -0800 Committed r288812 (246588@trunk): <https://commits.webkit.org/246588@trunk> 450404 2022-01-31 05:29:53 -0800 2022-01-31 05:45:02 -0800 Patch wtr-atspi-menu-selection.diff text/plain 3428 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1MmUzMTEwMjVkNTMuLjIwNzVjNjQ5ODNjMiAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE4IEBACisyMDIyLTAxLTMxICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFA aWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXVthMTF5XSBXVFI6IHVzZSBBWE1lbnVJdGVtU2Vs ZWN0ZWQgZm9yIG1lbnUgaXRlbSBzZWxlY3Rpb24gY2hhbmdlIHdpdGggQVRTUEkKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNTg5MAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFUU1BJIHVzZXMgc2VsZWN0 aW9uLWNoYW5nZWQgc2lnbmFsIGZvciBib3RoIGNvbWJvIGJveCBtZW51cyBhbmQgbGlzdCBib3hl cywgYnV0IGxheW91dCB0ZXN0cyBleHBlY3QgdGhlbiB0byBiZQorICAgICAgICBkaWZmZXJlbnQg ZXZlbnRzIEFYTWVudUl0ZW1TZWxlY3RlZCBhbmQgQVhTZWxlY3RlZENoaWxkcmVuQ2hhbmdlZC4K KworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvYXRzcGkvQWNjZXNzaWJpbGl0eUF0c3BpLmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OkFjY2Vzc2liaWxpdHlBdHNwaTo6c2VsZWN0aW9uQ2hhbmdlZCk6 IENhbGwgbm90aWZ5TWVudVNlbGVjdGlvbkNoYW5nZWQoKSBmb3IgbWVudXMuCisgICAgICAgIChX ZWJDb3JlOjpBY2Nlc3NpYmlsaXR5QXRzcGk6Om5vdGlmeU1lbnVTZWxlY3Rpb25DaGFuZ2VkIGNv bnN0KTogRW1pdCBBWE1lbnVJdGVtU2VsZWN0ZWQuCisgICAgICAgICogYWNjZXNzaWJpbGl0eS9h dHNwaS9BY2Nlc3NpYmlsaXR5QXRzcGkuaDoKKwogMjAyMi0wMS0yOCAgQ2FybG9zIEdhcmNpYSBD YW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAKICAgICAgICAgW0dUS11bYTExeV0gQWRkIHN1 cHBvcnQgZm9yIHBhc3N3b3JkIGZpZWxkcyB0byBBVFNQSQpkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvYWNjZXNzaWJpbGl0eS9hdHNwaS9BY2Nlc3NpYmlsaXR5QXRzcGkuY3BwIGIvU291cmNl L1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9hdHNwaS9BY2Nlc3NpYmlsaXR5QXRzcGkuY3BwCmluZGV4 IDk1ODcyZjEwMTVhOC4uYmJiODhjMzNjZDQxIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9h Y2Nlc3NpYmlsaXR5L2F0c3BpL0FjY2Vzc2liaWxpdHlBdHNwaS5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvYWNjZXNzaWJpbGl0eS9hdHNwaS9BY2Nlc3NpYmlsaXR5QXRzcGkuY3BwCkBAIC0yMiw2 ICsyMiw3IEBACiAjaW5jbHVkZSAiQWNjZXNzaWJpbGl0eUF0c3BpLmgiCiAKICNpZiBFTkFCTEUo QUNDRVNTSUJJTElUWSkgJiYgVVNFKEFUU1BJKQorI2luY2x1ZGUgIkFjY2Vzc2liaWxpdHlBdHNw aUVudW1zLmgiCiAjaW5jbHVkZSAiQWNjZXNzaWJpbGl0eUF0c3BpSW50ZXJmYWNlcy5oIgogI2lu Y2x1ZGUgIkFjY2Vzc2liaWxpdHlSb290QXRzcGkuaCIKICNpbmNsdWRlIDxnaW8vZ2lvLmg+CkBA IC01MzcsNyArNTM4LDEwIEBAIHZvaWQgQWNjZXNzaWJpbGl0eUF0c3BpOjp2YWx1ZUNoYW5nZWQo QWNjZXNzaWJpbGl0eU9iamVjdEF0c3BpJiBhdHNwaU9iamVjdCwgZG91CiB2b2lkIEFjY2Vzc2li aWxpdHlBdHNwaTo6c2VsZWN0aW9uQ2hhbmdlZChBY2Nlc3NpYmlsaXR5T2JqZWN0QXRzcGkmIGF0 c3BpT2JqZWN0KQogewogI2lmIEVOQUJMRShERVZFTE9QRVJfTU9ERSkKLSAgICBub3RpZnlTZWxl Y3Rpb25DaGFuZ2VkKGF0c3BpT2JqZWN0KTsKKyAgICBpZiAoYXRzcGlPYmplY3Qucm9sZSgpID09 IEF0c3BpOjpSb2xlOjpNZW51KQorICAgICAgICBub3RpZnlNZW51U2VsZWN0aW9uQ2hhbmdlZChh dHNwaU9iamVjdCk7CisgICAgZWxzZQorICAgICAgICBub3RpZnlTZWxlY3Rpb25DaGFuZ2VkKGF0 c3BpT2JqZWN0KTsKICNlbmRpZgogCiAgICAgaWYgKCFtX2Nvbm5lY3Rpb24pCkBAIC04NzEsNiAr ODc1LDEyIEBAIHZvaWQgQWNjZXNzaWJpbGl0eUF0c3BpOjpub3RpZnlTZWxlY3Rpb25DaGFuZ2Vk KEFjY2Vzc2liaWxpdHlPYmplY3RBdHNwaSYgYXRzcGlPCiAgICAgICAgIG9ic2VydmVyKGF0c3Bp T2JqZWN0LCAiQVhTZWxlY3RlZENoaWxkcmVuQ2hhbmdlZCIsIG51bGxwdHIpOwogfQogCit2b2lk IEFjY2Vzc2liaWxpdHlBdHNwaTo6bm90aWZ5TWVudVNlbGVjdGlvbkNoYW5nZWQoQWNjZXNzaWJp bGl0eU9iamVjdEF0c3BpJiBhdHNwaU9iamVjdCkgY29uc3QKK3sKKyAgICBmb3IgKGNvbnN0IGF1 dG8mIG9ic2VydmVyIDogbV9ub3RpZmljYXRpb25PYnNlcnZlcnMudmFsdWVzKCkpCisgICAgICAg IG9ic2VydmVyKGF0c3BpT2JqZWN0LCAiQVhNZW51SXRlbVNlbGVjdGVkIiwgbnVsbHB0cik7Cit9 CisKIHZvaWQgQWNjZXNzaWJpbGl0eUF0c3BpOjpub3RpZnlUZXh0Q2hhbmdlZChBY2Nlc3NpYmls aXR5T2JqZWN0QXRzcGkmIGF0c3BpT2JqZWN0KSBjb25zdAogewogICAgIGZvciAoY29uc3QgYXV0 byYgb2JzZXJ2ZXIgOiBtX25vdGlmaWNhdGlvbk9ic2VydmVycy52YWx1ZXMoKSkKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvYXRzcGkvQWNjZXNzaWJpbGl0eUF0c3Bp LmggYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2F0c3BpL0FjY2Vzc2liaWxpdHlBdHNw aS5oCmluZGV4IDIxMDRhNDAyMzIzOS4uOThmZmUwNWNjM2Y1IDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2F0c3BpL0FjY2Vzc2liaWxpdHlBdHNwaS5oCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvYXRzcGkvQWNjZXNzaWJpbGl0eUF0c3BpLmgKQEAg LTExMyw2ICsxMTMsNyBAQCBwcml2YXRlOgogI2lmIEVOQUJMRShERVZFTE9QRVJfTU9ERSkKICAg ICB2b2lkIG5vdGlmeVN0YXRlQ2hhbmdlZChBY2Nlc3NpYmlsaXR5T2JqZWN0QXRzcGkmLCBjb25z dCBjaGFyKiwgYm9vbCkgY29uc3Q7CiAgICAgdm9pZCBub3RpZnlTZWxlY3Rpb25DaGFuZ2VkKEFj Y2Vzc2liaWxpdHlPYmplY3RBdHNwaSYpIGNvbnN0OworICAgIHZvaWQgbm90aWZ5TWVudVNlbGVj dGlvbkNoYW5nZWQoQWNjZXNzaWJpbGl0eU9iamVjdEF0c3BpJikgY29uc3Q7CiAgICAgdm9pZCBu b3RpZnlUZXh0Q2hhbmdlZChBY2Nlc3NpYmlsaXR5T2JqZWN0QXRzcGkmKSBjb25zdDsKICAgICB2 b2lkIG5vdGlmeVRleHRDYXJldE1vdmVkKEFjY2Vzc2liaWxpdHlPYmplY3RBdHNwaSYsIHVuc2ln bmVkKSBjb25zdDsKICAgICB2b2lkIG5vdGlmeUNoaWxkcmVuQ2hhbmdlZChBY2Nlc3NpYmlsaXR5 T2JqZWN0QXRzcGkmLCBBY2Nlc3NpYmlsaXR5T2JqZWN0QXRzcGkmLCBDaGlsZHJlbkNoYW5nZWQp IGNvbnN0Owo=