235871 2022-01-30 08:02:53 -0800 [GStreamer] Update flags in internal GStreamer source and sink elements 2022-02-01 09:21:18 -0800 1 1 1 Unclassified WebKit Platform WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 pnormand pnormand calvaris cgarcia eric.carlson ews-watchlist glenn gustavo hta jer.noble menard philipj sergio tommyw vjaquez webkit-bug-importer oldest_to_newest 1835384 0 pnormand 2022-01-30 08:02:53 -0800 . 1835386 1 450361 pnormand 2022-01-30 08:17:58 -0800 Created attachment 450361 Patch 1835869 2 vjaquez 2022-02-01 01:58:09 -0800 out of curiosity, where is explained this good practice with custom elements based on bins? 1835970 3 pnormand 2022-02-01 08:08:02 -0800 (In reply to Víctor M. Jáquez L. from comment #2) > out of curiosity, where is explained this good practice with custom elements > based on bins? Hm I thought I saw it in the gst-plugins-rs tutorial but that was my imagination it seems :) Most bin-based elements there use this approach though. 1836009 4 ews-feeder 2022-02-01 09:20:14 -0800 Committed r288884 (246636@main): <https://commits.webkit.org/246636@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450361. 1836013 5 webkit-bug-importer 2022-02-01 09:21:18 -0800 <rdar://problem/88331780> 450361 2022-01-30 08:17:58 -0800 2022-02-01 09:20:17 -0800 Patch bug-235871-20220130081757.patch text/plain 5641 pnormand U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4ODAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZDlkMDNiNWM2NTg2ZmY4 ZWE1NjgzODE0MzRhMzEwZjkyMGJkOThiZS4uODc5Zjc1NWI4NmVkZDRjNWYwY2FmMTZhMGQxMWYy ZDAzNGNhNmRlOSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIzIEBACisyMDIyLTAxLTMwICBQaGls aXBwZSBOb3JtYW5kICA8cG5vcm1hbmRAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1N0cmVhbWVy XSBVcGRhdGUgZmxhZ3MgaW4gaW50ZXJuYWwgR1N0cmVhbWVyIHNvdXJjZSBhbmQgc2luayBlbGVt ZW50cworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM1 ODcxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRm9y IGN1c3RvbSBzb3VyY2UgYW5kIHNpbmtzIHN1YmNsYXNzaW5nIEdzdEJpbiBpdCdzIGdvb2QgcHJh Y3RpY2UgdG8gc3VwcHJlc3MgU09VUkNFIGFuZAorICAgICAgICBTSU5LIGZsYWdzIGFuZCB0byBr ZWVwIHRoZSBzdWJjbGFzcyBmbGFncyBhcyBtYXRjaGluZyB0aGUgZWxlbWVudCB0eXBlLgorCisg ICAgICAgICogcGxhdGZvcm0vYXVkaW8vZ3N0cmVhbWVyL1dlYktpdFdlYkF1ZGlvU291cmNlR1N0 cmVhbWVyLmNwcDoKKyAgICAgICAgKHdlYktpdFdlYkF1ZGlvU3JjQ29uc3RydWN0ZWQpOgorICAg ICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9HTFZpZGVvU2lua0dTdHJlYW1lci5j cHA6CisgICAgICAgICh3ZWJLaXRHTFZpZGVvU2lua0NvbnN0cnVjdGVkKToKKyAgICAgICAgKiBw bGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0QXVkaW9TaW5rR1N0cmVhbWVyLmNwcDoK KyAgICAgICAgKHdlYktpdEF1ZGlvU2lua0NvbnN0cnVjdGVkKToKKyAgICAgICAgKHdlYmtpdF9h dWRpb19zaW5rX2NsYXNzX2luaXQpOgorICAgICAgICAqIHBsYXRmb3JtL21lZGlhc3RyZWFtL2dz dHJlYW1lci9HU3RyZWFtZXJNZWRpYVN0cmVhbVNvdXJjZS5jcHA6CisgICAgICAgICh3ZWJraXRN ZWRpYVN0cmVhbVNyY0NvbnN0cnVjdGVkKToKKwogMjAyMi0wMS0zMCAgQWxhbiBCdWp0YXMgIDx6 YWxhbkBhcHBsZS5jb20+CiAKICAgICAgICAgW0xGQ11bSUZDXSBEbyBub3QgYnJlYWsgY29udGVu dCBhdCBhbiBpbmxpbmUgYm94IGJvdW5kYXJ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9hdWRpby9nc3RyZWFtZXIvV2ViS2l0V2ViQXVkaW9Tb3VyY2VHU3RyZWFtZXIuY3Bw IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vYXVkaW8vZ3N0cmVhbWVyL1dlYktpdFdlYkF1ZGlv U291cmNlR1N0cmVhbWVyLmNwcAppbmRleCAxYzY5OWZiZWU0NThhMzg1MjdhNTAyMWYxZjBjYTAy N2QyZDliMTk4Li4wMzU3MTlmMzY3ZjlhODVjZGQyMmZiNmIxYjI4MjBiMmI1NGI1MGM3IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9hdWRpby9nc3RyZWFtZXIvV2ViS2l0V2Vi QXVkaW9Tb3VyY2VHU3RyZWFtZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2F1 ZGlvL2dzdHJlYW1lci9XZWJLaXRXZWJBdWRpb1NvdXJjZUdTdHJlYW1lci5jcHAKQEAgLTIwMyw2 ICsyMDMsOSBAQCBzdGF0aWMgdm9pZCB3ZWJLaXRXZWJBdWRpb1NyY0NvbnN0cnVjdGVkKEdPYmpl Y3QqIG9iamVjdCkKICAgICBBU1NFUlQocHJpdi0+ZGVzdGluYXRpb24pOwogICAgIEFTU0VSVChw cml2LT5zYW1wbGVSYXRlKTsKIAorICAgIEdTVF9PQkpFQ1RfRkxBR19TRVQoR1NUX09CSkVDVF9D QVNUKHNyYyksIEdTVF9FTEVNRU5UX0ZMQUdfU09VUkNFKTsKKyAgICBnc3RfYmluX3NldF9zdXBw cmVzc2VkX2ZsYWdzKEdTVF9CSU5fQ0FTVChzcmMpLCBzdGF0aWNfY2FzdDxHc3RFbGVtZW50Rmxh Z3M+KEdTVF9FTEVNRU5UX0ZMQUdfU09VUkNFIHwgR1NUX0VMRU1FTlRfRkxBR19TSU5LKSk7CisK ICAgICBnc3RfZWxlbWVudF9hZGRfcGFkKEdTVF9FTEVNRU5UKHNyYyksIHByaXYtPnNvdXJjZVBh ZCk7CiAKICAgICBwcml2LT50YXNrID0gYWRvcHRHUmVmKGdzdF90YXNrX25ldyhyZWludGVycHJl dF9jYXN0PEdzdFRhc2tGdW5jdGlvbj4od2ViS2l0V2ViQXVkaW9TcmNSZW5kZXJJdGVyYXRpb24p LCBzcmMsIG51bGxwdHIpKTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL2dzdHJlYW1lci9HTFZpZGVvU2lua0dTdHJlYW1lci5jcHAgYi9Tb3VyY2UvV2ViQ29y ZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvR0xWaWRlb1NpbmtHU3RyZWFtZXIuY3BwCmlu ZGV4IDdkMDgyZjA3ZmMyODM1ODc0YzEwMDlkMzBiNzE4ZmViNTdkOTQxYjAuLjQ4ZGJiOTNhMjBm Y2UyYTcwZDI2NTA5NDgwYmYwM2RjYzQxYmFiMTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9HTFZpZGVvU2lua0dTdHJlYW1lci5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL0dMVmlkZW9TaW5r R1N0cmVhbWVyLmNwcApAQCAtNjQsNiArNjQsOSBAQCBzdGF0aWMgdm9pZCB3ZWJLaXRHTFZpZGVv U2lua0NvbnN0cnVjdGVkKEdPYmplY3QqIG9iamVjdCkKIAogICAgIFdlYktpdEdMVmlkZW9TaW5r KiBzaW5rID0gV0VCS0lUX0dMX1ZJREVPX1NJTksob2JqZWN0KTsKIAorICAgIEdTVF9PQkpFQ1Rf RkxBR19TRVQoR1NUX09CSkVDVF9DQVNUKHNpbmspLCBHU1RfRUxFTUVOVF9GTEFHX1NJTkspOwor ICAgIGdzdF9iaW5fc2V0X3N1cHByZXNzZWRfZmxhZ3MoR1NUX0JJTl9DQVNUKHNpbmspLCBzdGF0 aWNfY2FzdDxHc3RFbGVtZW50RmxhZ3M+KEdTVF9FTEVNRU5UX0ZMQUdfU09VUkNFIHwgR1NUX0VM RU1FTlRfRkxBR19TSU5LKSk7CisKICAgICBzaW5rLT5wcml2LT5hcHBTaW5rID0gbWFrZUdTdHJl YW1lckVsZW1lbnQoImFwcHNpbmsiLCAid2Via2l0LWdsLXZpZGVvLWFwcHNpbmsiKTsKICAgICBB U1NFUlQoc2luay0+cHJpdi0+YXBwU2luayk7CiAgICAgZ19vYmplY3Rfc2V0KHNpbmstPnByaXYt PmFwcFNpbmsuZ2V0KCksICJlbmFibGUtbGFzdC1zYW1wbGUiLCBGQUxTRSwgImVtaXQtc2lnbmFs cyIsIFRSVUUsICJtYXgtYnVmZmVycyIsIDEsIG51bGxwdHIpOwpkaWZmIC0tZ2l0IGEvU291cmNl L1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL1dlYktpdEF1ZGlvU2lua0dTdHJl YW1lci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIvV2Vi S2l0QXVkaW9TaW5rR1N0cmVhbWVyLmNwcAppbmRleCBhZGJkYzViMDhmOWI2NjMzMTc5YjE3Mjg5 YzIwMjBhMDM2ZTE2YmU1Li41YTJmMDQ4ZDdhZTc3NzFkMDZiMDVlMzg1ZGMyY2EwMzgxN2Y3ODQx IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9nc3RyZWFtZXIv V2ViS2l0QXVkaW9TaW5rR1N0cmVhbWVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9nc3RyZWFtZXIvV2ViS2l0QXVkaW9TaW5rR1N0cmVhbWVyLmNwcApAQCAtMjkz LDExICsyOTMsMjAgQEAgc3RhdGljIEdzdFN0YXRlQ2hhbmdlUmV0dXJuIHdlYktpdEF1ZGlvU2lu a0NoYW5nZVN0YXRlKEdzdEVsZW1lbnQqIGVsZW1lbnQsIEdzdFMKICAgICByZXR1cm4gcmVzdWx0 OwogfQogCitzdGF0aWMgdm9pZCB3ZWJLaXRBdWRpb1NpbmtDb25zdHJ1Y3RlZChHT2JqZWN0KiBv YmplY3QpCit7CisgICAgR1NUX0NBTExfUEFSRU5UKEdfT0JKRUNUX0NMQVNTLCBjb25zdHJ1Y3Rl ZCwgKG9iamVjdCkpOworCisgICAgR1NUX09CSkVDVF9GTEFHX1NFVChHU1RfT0JKRUNUX0NBU1Qo b2JqZWN0KSwgR1NUX0VMRU1FTlRfRkxBR19TSU5LKTsKKyAgICBnc3RfYmluX3NldF9zdXBwcmVz c2VkX2ZsYWdzKEdTVF9CSU5fQ0FTVChvYmplY3QpLCBzdGF0aWNfY2FzdDxHc3RFbGVtZW50Rmxh Z3M+KEdTVF9FTEVNRU5UX0ZMQUdfU09VUkNFIHwgR1NUX0VMRU1FTlRfRkxBR19TSU5LKSk7Cit9 CisKIHN0YXRpYyB2b2lkIHdlYmtpdF9hdWRpb19zaW5rX2NsYXNzX2luaXQoV2ViS2l0QXVkaW9T aW5rQ2xhc3MqIGtsYXNzKQogewogICAgIEdPYmplY3RDbGFzcyogb2tsYXNzID0gR19PQkpFQ1Rf Q0xBU1Moa2xhc3MpOwogICAgIG9rbGFzcy0+c2V0X3Byb3BlcnR5ID0gd2ViS2l0QXVkaW9TaW5r U2V0UHJvcGVydHk7CiAgICAgb2tsYXNzLT5nZXRfcHJvcGVydHkgPSB3ZWJLaXRBdWRpb1NpbmtH ZXRQcm9wZXJ0eTsKKyAgICBva2xhc3MtPmNvbnN0cnVjdGVkID0gd2ViS2l0QXVkaW9TaW5rQ29u c3RydWN0ZWQ7CiAKICAgICBnX29iamVjdF9jbGFzc19pbnN0YWxsX3Byb3BlcnR5KG9rbGFzcywg UFJPUF9WT0xVTUUsCiAgICAgICAgIGdfcGFyYW1fc3BlY19kb3VibGUoInZvbHVtZSIsICJWb2x1 bWUiLCAiVGhlIGF1ZGlvIHZvbHVtZSwgMS4wPTEwMCUiLCAwLCAxMCwgMSwKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21lZGlhc3RyZWFtL2dzdHJlYW1lci9HU3RyZWFtZXJN ZWRpYVN0cmVhbVNvdXJjZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9tZWRpYXN0cmVh bS9nc3RyZWFtZXIvR1N0cmVhbWVyTWVkaWFTdHJlYW1Tb3VyY2UuY3BwCmluZGV4IDA3MDhlYzdl YjA1NzQ4ZDA2YWJmNmU3ZjhmNmQ1NmQ0YTNkYjA5NTguLmU1ZDEzNjhhNzg4NWY5YTMxMmJkOTI3 YWFjOTg2MjI0YTQzMjBhNTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL21l ZGlhc3RyZWFtL2dzdHJlYW1lci9HU3RyZWFtZXJNZWRpYVN0cmVhbVNvdXJjZS5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbWVkaWFzdHJlYW0vZ3N0cmVhbWVyL0dTdHJlYW1lck1l ZGlhU3RyZWFtU291cmNlLmNwcApAQCAtNDg1LDYgKzQ4NSw5IEBAIHN0YXRpYyB2b2lkIHdlYmtp dE1lZGlhU3RyZWFtU3JjQ29uc3RydWN0ZWQoR09iamVjdCogb2JqZWN0KQogICAgIFdlYktpdE1l ZGlhU3RyZWFtU3JjKiBzZWxmID0gV0VCS0lUX01FRElBX1NUUkVBTV9TUkNfQ0FTVChvYmplY3Qp OwogICAgIGF1dG8qIHByaXYgPSBzZWxmLT5wcml2OwogCisgICAgR1NUX09CSkVDVF9GTEFHX1NF VChHU1RfT0JKRUNUX0NBU1Qoc2VsZiksIHN0YXRpY19jYXN0PEdzdEVsZW1lbnRGbGFncz4oR1NU X0VMRU1FTlRfRkxBR19TT1VSQ0UgfCBzdGF0aWNfY2FzdDxHc3RFbGVtZW50RmxhZ3M+KEdTVF9C SU5fRkxBR19TVFJFQU1TX0FXQVJFKSkpOworICAgIGdzdF9iaW5fc2V0X3N1cHByZXNzZWRfZmxh Z3MoR1NUX0JJTl9DQVNUKHNlbGYpLCBzdGF0aWNfY2FzdDxHc3RFbGVtZW50RmxhZ3M+KEdTVF9F TEVNRU5UX0ZMQUdfU09VUkNFIHwgR1NUX0VMRU1FTlRfRkxBR19TSU5LKSk7CisKICAgICBwcml2 LT5tZWRpYVN0cmVhbU9ic2VydmVyID0gbWFrZVVuaXF1ZTxXZWJLaXRNZWRpYVN0cmVhbU9ic2Vy dmVyPihHU1RfRUxFTUVOVF9DQVNUKHNlbGYpKTsKICAgICBwcml2LT5mbG93Q29tYmluZXIgPSBH VW5pcXVlUHRyPEdzdEZsb3dDb21iaW5lcj4oZ3N0X2Zsb3dfY29tYmluZXJfbmV3KCkpOwogCg==