<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>235860</bug_id>
          
          <creation_ts>2022-01-29 10:08:14 -0800</creation_ts>
          <short_desc>[ews] Cleanup code by removing patchFailedToBuild and patchFailedTests properties</short_desc>
          <delta_ts>2022-01-31 05:31:16 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>WebKit Nightly Build</version>
          <rep_platform>Unspecified</rep_platform>
          <op_sys>Unspecified</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Aakash Jain">aakash_jain</reporter>
          <assigned_to name="Aakash Jain">aakash_jain</assigned_to>
          <cc>aakash_jain</cc>
    
    <cc>jbedard</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1835294</commentid>
    <comment_count>0</comment_count>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2022-01-29 10:08:14 -0800</bug_when>
    <thetext>Cleanup code by removing patchFailedToBuild and patchFailedTests properties. Those were added in very early days of this instance bringup, when corresponding steps (e.g.: UnApplyPatchIfRequired) were listed statically in factories.py. Later on we started invoking steps dynamically using addStepsAfterCurrentStep and UnApplyPatchIfRequired is no longer called in factories.py. We can just remove all this patchFailedToBuild and patchFailedTests properties logic.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1835511</commentid>
    <comment_count>1</comment_count>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2022-01-31 05:30:10 -0800</bug_when>
    <thetext>Pull Request: https://github.com/WebKit/WebKit/pull/111</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1835512</commentid>
    <comment_count>2</comment_count>
    <who name="Aakash Jain">aakash_jain</who>
    <bug_when>2022-01-31 05:30:30 -0800</bug_when>
    <thetext>Landed https://commits.webkit.org/246587@main (c249047)!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1835513</commentid>
    <comment_count>3</comment_count>
    <who name="Radar WebKit Bug Importer">webkit-bug-importer</who>
    <bug_when>2022-01-31 05:31:16 -0800</bug_when>
    <thetext>&lt;rdar://problem/88264910&gt;</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>