235829 2022-01-28 10:16:17 -0800 [ews] Implement Login with GitHub on EWS 2023-02-23 12:47:14 -0800 1 1 1 Unclassified WebKit Tools / Tests WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=218823 https://bugs.webkit.org/show_bug.cgi?id=252778 InRadar P2 Normal --- 1 aakash_jain aakash_jain aakash_jain ap jbedard psaavedra ryanhaddad webkit-bug-importer oldest_to_newest 1835037 0 aakash_jain 2022-01-28 10:16:17 -0800 Currently EWS doesn't allow login to different users. There is only one account for admins. There are few features which could be benefit for authentication. Since we are anyways going to start using GitHub, we should implement 'Login with GitHub' on EWS. buildbot have some support for Github authentication. https://buildbot.buildbot.net also has 'Login with GitHub' button (on top-right). Reference: https://docs.buildbot.net/latest/developer/auth.html?highlight=authentication#third-party-authentication 1835038 1 webkit-bug-importer 2022-01-28 10:16:39 -0800 <rdar://problem/88192177> 1928315 2 aakash_jain 2023-01-25 16:00:52 -0800 Reference for authorization in buildbot: https://docs.buildbot.net/current/manual/configuration/www.html#authorization-rules 1928703 3 aakash_jain 2023-01-26 14:12:24 -0800 Note that this would allow most of our users to click the 'Retry' button on buildbot builds enabling them to retry failed (or any) build. 1934553 4 aakash_jain 2023-02-17 03:51:27 -0800 Pull request: https://github.com/WebKit/WebKit/pull/10266 1934559 5 aakash_jain 2023-02-17 04:06:34 -0800 *** Bug 244055 has been marked as a duplicate of this bug. *** 1935048 6 ews-feeder 2023-02-20 04:18:53 -0800 Committed 260531@main (a2a8bd0fd59f): <https://commits.webkit.org/260531@main> Reviewed commits have been landed. Closing PR #10266 and removing active labels. 1935253 7 aakash_jain 2023-02-20 14:07:04 -0800 Announcement: https://lists.webkit.org/pipermail/webkit-dev/2023-February/032480.html