235820 2022-01-28 07:59:52 -0800 Web Inspector: [Flexbox] Enable Flexbox Inspector feature 2022-02-17 13:20:25 -0800 1 1 1 Unclassified WebKit Web Inspector WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 236091 236738 236741 1 rcaliman nvasilyev ews-watchlist hi inspector-bugzilla-changes nvasilyev pangle webkit-bug-importer oldest_to_newest 1834973 0 rcaliman 2022-01-28 07:59:52 -0800 . 1834974 1 rcaliman 2022-01-28 08:01:40 -0800 <rdar://87886409> 1842576 2 452263 nvasilyev 2022-02-16 15:49:32 -0800 Created attachment 452263 Patch 1842593 3 452263 pangle 2022-02-16 16:25:17 -0800 Comment on attachment 452263 Patch r=me, thanks! Just needs to wait for bug 236741 to land before landing this. 1843095 4 ews-feeder 2022-02-17 13:20:21 -0800 Committed r290065 (247427@main): <https://commits.webkit.org/247427@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 452263. 452263 2022-02-16 15:49:32 -0800 2022-02-17 13:20:23 -0800 Patch patch.txt text/plain 6258 nvasilyev ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDg2MzE4NzIzYzAxZS4uYjc4ZTUwMjViZDg3IDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNCBAQAorMjAyMi0wMi0xNiAgTmlr aXRhIFZhc2lseWV2ICA8bnZhc2lseWV2QGFwcGxlLmNvbT4KKworICAgICAgICBXZWIgSW5zcGVj dG9yOiBbRmxleGJveF0gRW5hYmxlIEZsZXhib3ggSW5zcGVjdG9yIGZlYXR1cmUKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNTgyMAorICAgICAgICA8 cmRhcjovLzg3ODg2NDA5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFJlbW92ZSB0aGUgZW5naW5lZXJpbmcgc2V0dGluZyBhbmQgZW5hYmxlIHRoZSBm ZWF0dXJlIGJ5IGRlZmF1bHQuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL0Jhc2UvU2V0dGlu Zy5qczoKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0RPTVRyZWVFbGVtZW50LmpzOgor ICAgICAgICAoV0kuRE9NVHJlZUVsZW1lbnQucHJvdG90eXBlLl91cGRhdGVMYXlvdXRCYWRnZSk6 CisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9MYXlvdXREZXRhaWxzU2lkZWJhclBhbmVs LmpzOgorICAgICAgICAoV0kuTGF5b3V0RGV0YWlsc1NpZGViYXJQYW5lbC5wcm90b3R5cGUuaW5p dGlhbExheW91dCk6CisgICAgICAgIChXSS5MYXlvdXREZXRhaWxzU2lkZWJhclBhbmVsLnByb3Rv dHlwZS5sYXlvdXQpOgorICAgICAgICAoV0kuTGF5b3V0RGV0YWlsc1NpZGViYXJQYW5lbC5wcm90 b3R5cGUuX3JlZnJlc2hOb2RlU2V0cyk6CisgICAgICAgIChXSS5MYXlvdXREZXRhaWxzU2lkZWJh clBhbmVsKToKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL1NldHRpbmdzVGFiQ29udGVu dFZpZXcuanM6CisgICAgICAgIChXSS5TZXR0aW5nc1RhYkNvbnRlbnRWaWV3LnByb3RvdHlwZS5f Y3JlYXRlRW5naW5lZXJpbmdTZXR0aW5nc1ZpZXcpOgorCiAyMDIyLTAyLTE0ICBSYXp2YW4gQ2Fs aW1hbiAgPHJjYWxpbWFuQGFwcGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBbRmxl eGJveF0gTGlzdCBmbGV4IGNvbnRhaW5lcnMgaW4gTGF5b3V0IHNpZGViYXIKZGlmZiAtLWdpdCBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvU2V0dGluZy5qcyBiL1Nv dXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvU2V0dGluZy5qcwppbmRleCBj NWNlYjc3NDNiMWUuLjBhY2RkMWExMzVmYyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3Rv clVJL1VzZXJJbnRlcmZhY2UvQmFzZS9TZXR0aW5nLmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9Vc2VySW50ZXJmYWNlL0Jhc2UvU2V0dGluZy5qcwpAQCAtMjM5LDcgKzIzOSw2IEBAIFdJ LnNldHRpbmdzID0gewogICAgIHByb3RvY29sRmlsdGVyTXVsdGlwbGV4aW5nQmFja2VuZE1lc3Nh Z2VzOiBuZXcgV0kuU2V0dGluZygicHJvdG9jb2wtZmlsdGVyLW11bHRpcGxleGluZy1iYWNrZW5k LW1lc3NhZ2VzIiwgdHJ1ZSksCiAKICAgICAvLyBFbmdpbmVlcmluZwotICAgIGVuZ2luZWVyaW5n RW5hYmxlRmxleGJveEluc3BlY3RvcjogbmV3IFdJLkVuZ2luZWVyaW5nU2V0dGluZygiZW5naW5l ZXJpbmctZW5hYmxlLWZsZXhib3gtaW5zcGVjdG9yIiwgZmFsc2UpLAogICAgIGVuZ2luZWVyaW5n U2hvd0ludGVybmFsRXhlY3V0aW9uQ29udGV4dHM6IG5ldyBXSS5FbmdpbmVlcmluZ1NldHRpbmco ImVuZ2luZWVyaW5nLXNob3ctaW50ZXJuYWwtZXhlY3V0aW9uLWNvbnRleHRzIiwgZmFsc2UpLAog ICAgIGVuZ2luZWVyaW5nU2hvd0ludGVybmFsU2NyaXB0czogbmV3IFdJLkVuZ2luZWVyaW5nU2V0 dGluZygiZW5naW5lZXJpbmctc2hvdy1pbnRlcm5hbC1zY3JpcHRzIiwgZmFsc2UpLAogICAgIGVu Z2luZWVyaW5nUGF1c2VGb3JJbnRlcm5hbFNjcmlwdHM6IG5ldyBXSS5FbmdpbmVlcmluZ1NldHRp bmcoImVuZ2luZWVyaW5nLXBhdXNlLWZvci1pbnRlcm5hbC1zY3JpcHRzIiwgZmFsc2UpLApkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRE9NVHJl ZUVsZW1lbnQuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9E T01UcmVlRWxlbWVudC5qcwppbmRleCAxYjViN2UyM2IyNDkuLmVhZjE3YzQ0YzAzZiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRE9NVHJlZUVs ZW1lbnQuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3Mv RE9NVHJlZUVsZW1lbnQuanMKQEAgLTIwMjMsOSArMjAyMyw2IEBAIFdJLkRPTVRyZWVFbGVtZW50 ID0gY2xhc3MgRE9NVHJlZUVsZW1lbnQgZXh0ZW5kcyBXSS5UcmVlRWxlbWVudAogICAgICAgICBp ZiAoIXRoaXMucmVwcmVzZW50ZWRPYmplY3QubGF5b3V0Q29udGV4dFR5cGUpCiAgICAgICAgICAg ICByZXR1cm47CiAKLSAgICAgICAgaWYgKHRoaXMucmVwcmVzZW50ZWRPYmplY3QubGF5b3V0Q29u dGV4dFR5cGUgPT09IFdJLkRPTU5vZGUuTGF5b3V0Q29udGV4dFR5cGUuRmxleCAmJiAhV0kuc2V0 dGluZ3MuZW5naW5lZXJpbmdFbmFibGVGbGV4Ym94SW5zcGVjdG9yLnZhbHVlKQotICAgICAgICAg ICAgcmV0dXJuOwotCiAgICAgICAgIHRoaXMuX2xheW91dEJhZGdlRWxlbWVudCA9IHRoaXMudGl0 bGUuYXBwZW5kQ2hpbGQoZG9jdW1lbnQuY3JlYXRlRWxlbWVudCgic3BhbiIpKTsKICAgICAgICAg dGhpcy5fbGF5b3V0QmFkZ2VFbGVtZW50LmNsYXNzTmFtZSA9ICJsYXlvdXQtYmFkZ2UiOwogCmRp ZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9MYXlv dXREZXRhaWxzU2lkZWJhclBhbmVsLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvTGF5b3V0RGV0YWlsc1NpZGViYXJQYW5lbC5qcwppbmRleCAwY2JlMTg0YzI0 MDkuLjAyMTA2Y2RiMzI2OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJ bnRlcmZhY2UvVmlld3MvTGF5b3V0RGV0YWlsc1NpZGViYXJQYW5lbC5qcworKysgYi9Tb3VyY2Uv V2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9MYXlvdXREZXRhaWxzU2lkZWJhclBh bmVsLmpzCkBAIC0xMDUsMTAgKzEwNSw2IEBAIFdJLkxheW91dERldGFpbHNTaWRlYmFyUGFuZWwg PSBjbGFzcyBMYXlvdXREZXRhaWxzU2lkZWJhclBhbmVsIGV4dGVuZHMgV0kuRE9NRGV0CiAKICAg ICAgICAgdGhpcy5fZ3JpZFNlY3Rpb24gPSBuZXcgV0kuQ1NTR3JpZE5vZGVPdmVybGF5TGlzdFNl Y3Rpb247CiAKLSAgICAgICAgLy8gRklYTUU6IDxodHRwczovL3dlYmtpdC5vcmcvYi8yMzU4MjA+ IEVuYWJsZSBGbGV4Ym94IEluc3BlY3RvciBmZWF0dXJlCi0gICAgICAgIGlmICghV0kuc2V0dGlu Z3MuZW5naW5lZXJpbmdFbmFibGVGbGV4Ym94SW5zcGVjdG9yLnZhbHVlKQotICAgICAgICAgICAg cmV0dXJuOwotCiAgICAgICAgIHRoaXMuX2ZsZXhEZXRhaWxzU2VjdGlvblJvdyA9IG5ldyBXSS5E ZXRhaWxzU2VjdGlvblJvdyhXSS5VSVN0cmluZygiTm8gQ1NTIEZsZXggQ29udGFpbmVycyIsICJO byBDU1MgRmxleCBDb250YWluZXJzIEAgTGF5b3V0IERldGFpbHMgU2lkZWJhciBQYW5lbCIsICJN ZXNzYWdlIHNob3duIHdoZW4gdGhlcmUgYXJlIG5vIENTUyBGbGV4IGNvbnRhaW5lcnMgb24gdGhl IGluc3BlY3RlZCBwYWdlLiIpKTsKICAgICAgICAgbGV0IGZsZXhEZXRhaWxzU2VjdGlvbiA9IG5l dyBXSS5EZXRhaWxzU2VjdGlvbigibGF5b3V0LWNzcy1mbGV4Ym94IiwgV0kuVUlTdHJpbmcoIkZs ZXhib3giLCAiRmxleGJveCBAIEVsZW1lbnRzIGRldGFpbHMgc2lkZWJhciIsICJGbGV4Ym94IGxh eW91dCBzZWN0aW9uIG5hbWUiKSwgW25ldyBXSS5EZXRhaWxzU2VjdGlvbkdyb3VwKFt0aGlzLl9m bGV4RGV0YWlsc1NlY3Rpb25Sb3ddKV0pOwogICAgICAgICB0aGlzLmNvbnRlbnRWaWV3LmVsZW1l bnQuYXBwZW5kQ2hpbGQoZmxleERldGFpbHNTZWN0aW9uLmVsZW1lbnQpOwpAQCAtMTM1LDEwICsx MzEsNiBAQCBXSS5MYXlvdXREZXRhaWxzU2lkZWJhclBhbmVsID0gY2xhc3MgTGF5b3V0RGV0YWls c1NpZGViYXJQYW5lbCBleHRlbmRzIFdJLkRPTURldAogICAgICAgICAgICAgICAgIHRoaXMucmVt b3ZlU3Vidmlldyh0aGlzLl9ncmlkU2VjdGlvbik7CiAgICAgICAgIH0KIAotICAgICAgICAvLyBG SVhNRTogPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzIzNTgyMD4gRW5hYmxlIEZsZXhib3ggSW5zcGVj dG9yIGZlYXR1cmUKLSAgICAgICAgaWYgKCFXSS5zZXR0aW5ncy5lbmdpbmVlcmluZ0VuYWJsZUZs ZXhib3hJbnNwZWN0b3IudmFsdWUpCi0gICAgICAgICAgICByZXR1cm47Ci0KICAgICAgICAgaWYg KHRoaXMuX2ZsZXhOb2RlU2V0LnNpemUpIHsKICAgICAgICAgICAgIHRoaXMuX2ZsZXhEZXRhaWxz U2VjdGlvblJvdy5oaWRlRW1wdHlNZXNzYWdlKCk7CiAgICAgICAgICAgICB0aGlzLl9mbGV4RGV0 YWlsc1NlY3Rpb25Sb3cuZWxlbWVudC5hcHBlbmRDaGlsZCh0aGlzLl9mbGV4U2VjdGlvbi5lbGVt ZW50KTsKQEAgLTIwMyw5ICsxOTUsNiBAQCBXSS5MYXlvdXREZXRhaWxzU2lkZWJhclBhbmVsID0g Y2xhc3MgTGF5b3V0RGV0YWlsc1NpZGViYXJQYW5lbCBleHRlbmRzIFdJLkRPTURldAogICAgIF9y ZWZyZXNoTm9kZVNldHMoKQogICAgIHsKICAgICAgICAgdGhpcy5fZ3JpZE5vZGVTZXQgPSBuZXcg U2V0KFdJLmRvbU1hbmFnZXIubm9kZXNXaXRoTGF5b3V0Q29udGV4dFR5cGUoV0kuRE9NTm9kZS5M YXlvdXRDb250ZXh0VHlwZS5HcmlkKSk7Ci0KLSAgICAgICAgLy8gRklYTUU6IDxodHRwczovL3dl YmtpdC5vcmcvYi8yMzU4MjA+IEVuYWJsZSBGbGV4Ym94IEluc3BlY3RvciBmZWF0dXJlCi0gICAg ICAgIGlmIChXSS5zZXR0aW5ncy5lbmdpbmVlcmluZ0VuYWJsZUZsZXhib3hJbnNwZWN0b3IudmFs dWUpCi0gICAgICAgICAgICB0aGlzLl9mbGV4Tm9kZVNldCA9IG5ldyBTZXQoV0kuZG9tTWFuYWdl ci5ub2Rlc1dpdGhMYXlvdXRDb250ZXh0VHlwZShXSS5ET01Ob2RlLkxheW91dENvbnRleHRUeXBl LkZsZXgpKTsKKyAgICAgICAgdGhpcy5fZmxleE5vZGVTZXQgPSBuZXcgU2V0KFdJLmRvbU1hbmFn ZXIubm9kZXNXaXRoTGF5b3V0Q29udGV4dFR5cGUoV0kuRE9NTm9kZS5MYXlvdXRDb250ZXh0VHlw ZS5GbGV4KSk7CiAgICAgfQogfTsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL1NldHRpbmdzVGFiQ29udGVudFZpZXcuanMgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TZXR0aW5nc1RhYkNvbnRlbnRWaWV3Lmpz CmluZGV4IGZkZGMzZGMyN2FjYi4uNjFkYjc2NjZlYmVhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9TZXR0aW5nc1RhYkNvbnRlbnRWaWV3Lmpz CisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL1NldHRpbmdz VGFiQ29udGVudFZpZXcuanMKQEAgLTQ0Myw3ICs0NDMsNiBAQCBXSS5TZXR0aW5nc1RhYkNvbnRl bnRWaWV3ID0gY2xhc3MgU2V0dGluZ3NUYWJDb250ZW50VmlldyBleHRlbmRzIFdJLlRhYkNvbnRl bnRWaQogCiAgICAgICAgIGxldCBlbGVtZW50c0dyb3VwID0gZW5naW5lZXJpbmdTZXR0aW5nc1Zp ZXcuYWRkR3JvdXAoV0kudW5sb2NhbGl6ZWRTdHJpbmcoIkVsZW1lbnRzOiIpKTsKICAgICAgICAg ZWxlbWVudHNHcm91cC5hZGRTZXR0aW5nKFdJLnNldHRpbmdzLmVuZ2luZWVyaW5nQWxsb3dFZGl0 aW5nVXNlckFnZW50U2hhZG93VHJlZXMsIFdJLnVubG9jYWxpemVkU3RyaW5nKCJBbGxvdyBlZGl0 aW5nIFVzZXJBZ2VudCBzaGFkb3cgdHJlZXMiKSk7Ci0gICAgICAgIGVsZW1lbnRzR3JvdXAuYWRk U2V0dGluZyhXSS5zZXR0aW5ncy5lbmdpbmVlcmluZ0VuYWJsZUZsZXhib3hJbnNwZWN0b3IsIFdJ LnVubG9jYWxpemVkU3RyaW5nKCJFbmFibGUgRmxleGJveCBJbnNwZWN0b3IiKSk7CiAKICAgICAg ICAgZW5naW5lZXJpbmdTZXR0aW5nc1ZpZXcuYWRkU2VwYXJhdG9yKCk7CiAK