<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>23580</bug_id>
          
          <creation_ts>2009-01-27 18:52:46 -0800</creation_ts>
          <short_desc>Add support for GNU mode RVCT compilation</short_desc>
          <delta_ts>2009-07-07 20:57:16 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>New Bugs</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>Other</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          <blocked>27065</blocked>
          <everconfirmed>0</everconfirmed>
          <reporter name="Laszlo Gombos">laszlo.gombos</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>hausmann</cc>
    
    <cc>mrowe</cc>
    
    <cc>vestbo</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>107283</commentid>
    <comment_count>0</comment_count>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2009-01-27 18:52:46 -0800</bug_when>
    <thetext>WebKit today does not compile with RVCT. Various patches has been landed in the past to make steps toward a successful RVCT (ARM C) compilation. This is proposal for another step to the right direction.

RVCT has a compiler option (called --gnu) which turns on &quot;GNU compatibility&quot;. The --gnu option makes RVCT behave more like (but not exactly as) GCC, and it compiles most (but not all) of the WebKit code without changes. 

However the RVCT --gnu option also defines __GNUC__, which makes COMPILER(GCC) defined as well (in addition to COMPILER(RVCT). This makes two compiler defined at the same time, which is confusing and also makes it harder to flag those few code blocks in WebKit that does not compile with GNU mode RVCT.

The proposal is not to define COMPILER(GCC) if WebKit is compiled with RVCT --gnu option. In addition, we should use COMPILER(GCC) consistently across WebKit to mark GCC specific code (instead of using defined __GNUC__).

Patch will follow.. Laszlo.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>107284</commentid>
    <comment_count>1</comment_count>
      <attachid>27093</attachid>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2009-01-27 19:00:12 -0800</bug_when>
    <thetext>Created attachment 27093
Patch to support GNU mode RVCT compilation

Patch to support GNU mode RVCT compilation</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>107289</commentid>
    <comment_count>2</comment_count>
    <who name="Mark Rowe (bdash)">mrowe</who>
    <bug_when>2009-01-27 21:18:17 -0800</bug_when>
    <thetext>Checking both COMPILER(GCC) and defined(__GNUC__) seem redundant.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>107317</commentid>
    <comment_count>3</comment_count>
      <attachid>27103</attachid>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2009-01-28 06:03:21 -0800</bug_when>
    <thetext>Created attachment 27103
Revised patch based on feedback</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>107677</commentid>
    <comment_count>4</comment_count>
      <attachid>27179</attachid>
    <who name="Laszlo Gombos">laszlo.gombos</who>
    <bug_when>2009-01-30 05:23:52 -0800</bug_when>
    <thetext>Created attachment 27179
Revised patch to make it more future proof and readable

Moved the COMPILER(RVCT) rules in from of the COMPILER(GCC) definition, so that when COMPILER(GCC) is defined, we can just check for !COMPILER(RVCT).

Extra comment added to make the code more readable !</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>107694</commentid>
    <comment_count>5</comment_count>
      <attachid>27179</attachid>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2009-01-30 07:16:52 -0800</bug_when>
    <thetext>Comment on attachment 27179
Revised patch to make it more future proof and readable

Looks good to me. When landing I&apos;ll add a note to the ChangeLog, but otherwise it&apos;s ready to go.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>107695</commentid>
    <comment_count>6</comment_count>
    <who name="Simon Hausmann">hausmann</who>
    <bug_when>2009-01-30 07:17:58 -0800</bug_when>
    <thetext>Landed in r40404</thetext>
  </long_desc>
      
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>27093</attachid>
            <date>2009-01-27 19:00:12 -0800</date>
            <delta_ts>2009-01-28 06:03:21 -0800</delta_ts>
            <desc>Patch to support GNU mode RVCT compilation</desc>
            <filename>patch_23580.txt</filename>
            <type>text/plain</type>
            <size>3164</size>
            <attacher name="Laszlo Gombos">laszlo.gombos</attacher>
            
              <data encoding="base64">SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQwMzAxKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMDEtMjcgIExhc3psbyBH
b21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5
IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyAyMzU4MDogR05VIG1vZGUgUlZDVCBjb21w
aWxhdGlvbiBzdXBwb3J0CisgICAgICAgIDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1
Zy5jZ2k/aWQ9MjM1ODA+CisKKyAgICAgICAgKiBwY3JlL3BjcmVfZXhlYy5jcHA6CisgICAgICAg
ICogd3RmL0Zhc3RNYWxsb2MuY3BwOgorICAgICAgICAoV1RGOjpUQ01hbGxvY1N0YXRzOjopOgor
ICAgICAgICAqIHd0Zi9QbGF0Zm9ybS5oOgorCiAyMDA5LTAxLTI2ICBBZGVsZSBQZXRlcnNvbiAg
PGFkZWxlQGFwcGxlLmNvbT4KIAogICAgICAgICBCdWlsZCBmaXguICAKSW5kZXg6IEphdmFTY3Jp
cHRDb3JlL3BjcmUvcGNyZV9leGVjLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9w
Y3JlL3BjcmVfZXhlYy5jcHAJKHJldmlzaW9uIDQwMjk0KQorKysgSmF2YVNjcmlwdENvcmUvcGNy
ZS9wY3JlX2V4ZWMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01Niw3ICs1Niw3IEBAIHRoZSBKYXZh
U2NyaXB0IHNwZWNpZmljYXRpb24uIFRoZXJlIGFyZSAKIAogdXNpbmcgbmFtZXNwYWNlIFdURjsK
IAotI2lmZGVmIF9fR05VQ19fCisjaWYgQ09NUElMRVIoR0NDKSAmJiBkZWZpbmVkKF9fR05VQ19f
KQogI2RlZmluZSBVU0VfQ09NUFVURURfR09UT19GT1JfTUFUQ0hfUkVDVVJTSU9OCiAvLyNkZWZp
bmUgVVNFX0NPTVBVVEVEX0dPVE9fRk9SX01BVENIX09QQ09ERV9MT09QCiAjZW5kaWYKSW5kZXg6
IEphdmFTY3JpcHRDb3JlL3d0Zi9GYXN0TWFsbG9jLmNwcAo9PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2Ny
aXB0Q29yZS93dGYvRmFzdE1hbGxvYy5jcHAJKHJldmlzaW9uIDQwMjk0KQorKysgSmF2YVNjcmlw
dENvcmUvd3RmL0Zhc3RNYWxsb2MuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNTcxLDcgKzM1NzEs
NyBAQCBleHRlcm4gIkMiIHN0cnVjdCBtYWxsaW5mbyBtYWxsaW5mbyh2b2lkCiAKICNpZiBkZWZp
bmVkKF9fR0xJQkNfXykKIGV4dGVybiAiQyIgewotIyBpZiBkZWZpbmVkKF9fR05VQ19fKSAmJiAh
ZGVmaW5lZChfX01BQ0hfXykgJiYgZGVmaW5lZChIQVZFX19fQVRUUklCVVRFX18pCisjaWYgQ09N
UElMRVIoR0NDKSAmJiBkZWZpbmVkKF9fR05VQ19fKSAmJiAhZGVmaW5lZChfX01BQ0hfXykgJiYg
ZGVmaW5lZChIQVZFX19fQVRUUklCVVRFX18pCiAgIC8vIFBvdGVudGlhbGx5IGZhc3RlciB2YXJp
YW50cyB0aGF0IHVzZSB0aGUgZ2NjIGFsaWFzIGV4dGVuc2lvbi4KICAgLy8gTWFjaC1PIChEYXJ3
aW4pIGRvZXMgbm90IHN1cHBvcnQgd2VhayBhbGlhc2VzLCBoZW5jZSB0aGUgX19NQUNIX18gY2hl
Y2suCiAjIGRlZmluZSBBTElBUyh4KSBfX2F0dHJpYnV0ZV9fICgod2VhaywgYWxpYXMgKHgpKSkK
SW5kZXg6IEphdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCj09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIEphdmFT
Y3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCShyZXZpc2lvbiA0MDI5NCkKKysrIEphdmFTY3JpcHRD
b3JlL3d0Zi9QbGF0Zm9ybS5oCSh3b3JraW5nIGNvcHkpCkBAIC0yNDMsNyArMjQzLDcgQEAKICNl
bmRpZgogCiAvKiBDT01QSUxFUihHQ0MpICovCi0jaWYgZGVmaW5lZChfX0dOVUNfXykKKyNpZiBk
ZWZpbmVkKF9fR05VQ19fKSAmJiAhZGVmaW5lZChfX0NDX0FSTSkgJiYgIWRlZmluZWQoX19BUk1D
Q19fKQogI2RlZmluZSBXVEZfQ09NUElMRVJfR0NDIDEKICNlbmRpZgogCkluZGV4OiBXZWJDb3Jl
L0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gNDAz
MDEpCisrKyBXZWJDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEyIEBA
CisyMDA5LTAxLTI3ICBMYXN6bG8gR29tYm9zICA8bGFzemxvLjEuZ29tYm9zQG5va2lhLmNvbT4K
KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBCdWcgMjM1
ODA6IEdOVSBtb2RlIFJWQ1QgY29tcGlsYXRpb24gc3VwcG9ydAorICAgICAgICA8aHR0cHM6Ly9i
dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNTgwPgorCisgICAgICAgICogaHRtbC9Q
cmVsb2FkU2Nhbm5lci5jcHA6CisKIDIwMDktMDEtMjcgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZy
YXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2ZSBIeWF0dApJbmRleDog
V2ViQ29yZS9odG1sL1ByZWxvYWRTY2FubmVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2h0
bWwvUHJlbG9hZFNjYW5uZXIuY3BwCShyZXZpc2lvbiA0MDI5NCkKKysrIFdlYkNvcmUvaHRtbC9Q
cmVsb2FkU2Nhbm5lci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQzLDcgKzQzLDcgQEAKICNpbmNs
dWRlIDx3dGYvQ3VycmVudFRpbWUuaD4KICNpbmNsdWRlIDx3dGYvdW5pY29kZS9Vbmljb2RlLmg+
CiAKLSNpZmRlZiBfX0dOVUNfXworI2lmIENPTVBJTEVSKEdDQykKIC8vIFRoZSBtYWluIHRva2Vu
aXplciBpbmNsdWRlcyB0aGlzIHRvbyBzbyB3ZSBhcmUgZ2V0dGluZyB0d28gY29waWVzIG9mIHRo
ZSBkYXRhLiBIb3dldmVyLCB0aGlzIHdheSB0aGUgY29kZSBnZXRzIGlubGluZWQuCiAjaW5jbHVk
ZSAiSFRNTEVudGl0eU5hbWVzLmMiCiAjZWxzZQo=
</data>

          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>27103</attachid>
            <date>2009-01-28 06:03:21 -0800</date>
            <delta_ts>2009-01-30 05:23:52 -0800</delta_ts>
            <desc>Revised patch based on feedback </desc>
            <filename>patch_23580_v2.txt</filename>
            <type>text/plain</type>
            <size>3122</size>
            <attacher name="Laszlo Gombos">laszlo.gombos</attacher>
            
              <data encoding="base64">SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQwMzAxKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMDEtMjcgIExhc3psbyBH
b21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5
IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyAyMzU4MDogR05VIG1vZGUgUlZDVCBjb21w
aWxhdGlvbiBzdXBwb3J0CisgICAgICAgIDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1
Zy5jZ2k/aWQ9MjM1ODA+CisKKyAgICAgICAgKiBwY3JlL3BjcmVfZXhlYy5jcHA6CisgICAgICAg
ICogd3RmL0Zhc3RNYWxsb2MuY3BwOgorICAgICAgICAoV1RGOjpUQ01hbGxvY1N0YXRzOjopOgor
ICAgICAgICAqIHd0Zi9QbGF0Zm9ybS5oOgorCiAyMDA5LTAxLTI2ICBBZGVsZSBQZXRlcnNvbiAg
PGFkZWxlQGFwcGxlLmNvbT4KIAogICAgICAgICBCdWlsZCBmaXguICAKSW5kZXg6IEphdmFTY3Jp
cHRDb3JlL3BjcmUvcGNyZV9leGVjLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9w
Y3JlL3BjcmVfZXhlYy5jcHAJKHJldmlzaW9uIDQwMjk0KQorKysgSmF2YVNjcmlwdENvcmUvcGNy
ZS9wY3JlX2V4ZWMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01Niw3ICs1Niw3IEBAIHRoZSBKYXZh
U2NyaXB0IHNwZWNpZmljYXRpb24uIFRoZXJlIGFyZSAKIAogdXNpbmcgbmFtZXNwYWNlIFdURjsK
IAotI2lmZGVmIF9fR05VQ19fCisjaWYgQ09NUElMRVIoR0NDKQogI2RlZmluZSBVU0VfQ09NUFVU
RURfR09UT19GT1JfTUFUQ0hfUkVDVVJTSU9OCiAvLyNkZWZpbmUgVVNFX0NPTVBVVEVEX0dPVE9f
Rk9SX01BVENIX09QQ09ERV9MT09QCiAjZW5kaWYKSW5kZXg6IEphdmFTY3JpcHRDb3JlL3d0Zi9G
YXN0TWFsbG9jLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS93dGYvRmFzdE1hbGxv
Yy5jcHAJKHJldmlzaW9uIDQwMjk0KQorKysgSmF2YVNjcmlwdENvcmUvd3RmL0Zhc3RNYWxsb2Mu
Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNTcxLDcgKzM1NzEsNyBAQCBleHRlcm4gIkMiIHN0cnVj
dCBtYWxsaW5mbyBtYWxsaW5mbyh2b2lkCiAKICNpZiBkZWZpbmVkKF9fR0xJQkNfXykKIGV4dGVy
biAiQyIgewotIyBpZiBkZWZpbmVkKF9fR05VQ19fKSAmJiAhZGVmaW5lZChfX01BQ0hfXykgJiYg
ZGVmaW5lZChIQVZFX19fQVRUUklCVVRFX18pCisjaWYgQ09NUElMRVIoR0NDKSAmJiAhZGVmaW5l
ZChfX01BQ0hfXykgJiYgZGVmaW5lZChIQVZFX19fQVRUUklCVVRFX18pCiAgIC8vIFBvdGVudGlh
bGx5IGZhc3RlciB2YXJpYW50cyB0aGF0IHVzZSB0aGUgZ2NjIGFsaWFzIGV4dGVuc2lvbi4KICAg
Ly8gTWFjaC1PIChEYXJ3aW4pIGRvZXMgbm90IHN1cHBvcnQgd2VhayBhbGlhc2VzLCBoZW5jZSB0
aGUgX19NQUNIX18gY2hlY2suCiAjIGRlZmluZSBBTElBUyh4KSBfX2F0dHJpYnV0ZV9fICgod2Vh
aywgYWxpYXMgKHgpKSkKSW5kZXg6IEphdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCj09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCShyZXZpc2lvbiA0MDI5NCkK
KysrIEphdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCSh3b3JraW5nIGNvcHkpCkBAIC0yNDMs
NyArMjQzLDcgQEAKICNlbmRpZgogCiAvKiBDT01QSUxFUihHQ0MpICovCi0jaWYgZGVmaW5lZChf
X0dOVUNfXykKKyNpZiBkZWZpbmVkKF9fR05VQ19fKSAmJiAhZGVmaW5lZChfX0NDX0FSTSkgJiYg
IWRlZmluZWQoX19BUk1DQ19fKQogI2RlZmluZSBXVEZfQ09NUElMRVJfR0NDIDEKICNlbmRpZgog
CkluZGV4OiBXZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL0NoYW5nZUxv
ZwkocmV2aXNpb24gNDAzMDEpCisrKyBXZWJDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpA
QCAtMSwzICsxLDEyIEBACisyMDA5LTAxLTI3ICBMYXN6bG8gR29tYm9zICA8bGFzemxvLjEuZ29t
Ym9zQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor
ICAgICAgICBCdWcgMjM1ODA6IEdOVSBtb2RlIFJWQ1QgY29tcGlsYXRpb24gc3VwcG9ydAorICAg
ICAgICA8aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIzNTgwPgorCisg
ICAgICAgICogaHRtbC9QcmVsb2FkU2Nhbm5lci5jcHA6CisKIDIwMDktMDEtMjcgIFNpbW9uIEZy
YXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGF2
ZSBIeWF0dApJbmRleDogV2ViQ29yZS9odG1sL1ByZWxvYWRTY2FubmVyLmNwcAo9PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
Ci0tLSBXZWJDb3JlL2h0bWwvUHJlbG9hZFNjYW5uZXIuY3BwCShyZXZpc2lvbiA0MDI5NCkKKysr
IFdlYkNvcmUvaHRtbC9QcmVsb2FkU2Nhbm5lci5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTQzLDcg
KzQzLDcgQEAKICNpbmNsdWRlIDx3dGYvQ3VycmVudFRpbWUuaD4KICNpbmNsdWRlIDx3dGYvdW5p
Y29kZS9Vbmljb2RlLmg+CiAKLSNpZmRlZiBfX0dOVUNfXworI2lmIENPTVBJTEVSKEdDQykKIC8v
IFRoZSBtYWluIHRva2VuaXplciBpbmNsdWRlcyB0aGlzIHRvbyBzbyB3ZSBhcmUgZ2V0dGluZyB0
d28gY29waWVzIG9mIHRoZSBkYXRhLiBIb3dldmVyLCB0aGlzIHdheSB0aGUgY29kZSBnZXRzIGlu
bGluZWQuCiAjaW5jbHVkZSAiSFRNTEVudGl0eU5hbWVzLmMiCiAjZWxzZQo=
</data>

          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>27179</attachid>
            <date>2009-01-30 05:23:52 -0800</date>
            <delta_ts>2009-01-30 07:16:52 -0800</delta_ts>
            <desc>Revised patch to make it more future proof and readable</desc>
            <filename>patch_23580_v3.txt</filename>
            <type>text/plain</type>
            <size>3522</size>
            <attacher name="Laszlo Gombos">laszlo.gombos</attacher>
            
              <data encoding="base64">SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDQwMzAxKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl
TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMDktMDEtMjcgIExhc3psbyBH
b21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5
IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEJ1ZyAyMzU4MDogR05VIG1vZGUgUlZDVCBjb21w
aWxhdGlvbiBzdXBwb3J0CisgICAgICAgIDxodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1
Zy5jZ2k/aWQ9MjM1ODA+CisKKyAgICAgICAgKiBwY3JlL3BjcmVfZXhlYy5jcHA6CisgICAgICAg
ICogd3RmL0Zhc3RNYWxsb2MuY3BwOgorICAgICAgICAoV1RGOjpUQ01hbGxvY1N0YXRzOjopOgor
ICAgICAgICAqIHd0Zi9QbGF0Zm9ybS5oOgorCiAyMDA5LTAxLTI2ICBBZGVsZSBQZXRlcnNvbiAg
PGFkZWxlQGFwcGxlLmNvbT4KIAogICAgICAgICBCdWlsZCBmaXguICAKSW5kZXg6IEphdmFTY3Jp
cHRDb3JlL3BjcmUvcGNyZV9leGVjLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS9w
Y3JlL3BjcmVfZXhlYy5jcHAJKHJldmlzaW9uIDQwMjk0KQorKysgSmF2YVNjcmlwdENvcmUvcGNy
ZS9wY3JlX2V4ZWMuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01Niw3ICs1Niw3IEBAIHRoZSBKYXZh
U2NyaXB0IHNwZWNpZmljYXRpb24uIFRoZXJlIGFyZSAKIAogdXNpbmcgbmFtZXNwYWNlIFdURjsK
IAotI2lmZGVmIF9fR05VQ19fCisjaWYgQ09NUElMRVIoR0NDKQogI2RlZmluZSBVU0VfQ09NUFVU
RURfR09UT19GT1JfTUFUQ0hfUkVDVVJTSU9OCiAvLyNkZWZpbmUgVVNFX0NPTVBVVEVEX0dPVE9f
Rk9SX01BVENIX09QQ09ERV9MT09QCiAjZW5kaWYKSW5kZXg6IEphdmFTY3JpcHRDb3JlL3d0Zi9G
YXN0TWFsbG9jLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0Q29yZS93dGYvRmFzdE1hbGxv
Yy5jcHAJKHJldmlzaW9uIDQwMjk0KQorKysgSmF2YVNjcmlwdENvcmUvd3RmL0Zhc3RNYWxsb2Mu
Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC0zNTcxLDcgKzM1NzEsNyBAQCBleHRlcm4gIkMiIHN0cnVj
dCBtYWxsaW5mbyBtYWxsaW5mbyh2b2lkCiAKICNpZiBkZWZpbmVkKF9fR0xJQkNfXykKIGV4dGVy
biAiQyIgewotIyBpZiBkZWZpbmVkKF9fR05VQ19fKSAmJiAhZGVmaW5lZChfX01BQ0hfXykgJiYg
ZGVmaW5lZChIQVZFX19fQVRUUklCVVRFX18pCisjaWYgQ09NUElMRVIoR0NDKSAmJiAhZGVmaW5l
ZChfX01BQ0hfXykgJiYgZGVmaW5lZChIQVZFX19fQVRUUklCVVRFX18pCiAgIC8vIFBvdGVudGlh
bGx5IGZhc3RlciB2YXJpYW50cyB0aGF0IHVzZSB0aGUgZ2NjIGFsaWFzIGV4dGVuc2lvbi4KICAg
Ly8gTWFjaC1PIChEYXJ3aW4pIGRvZXMgbm90IHN1cHBvcnQgd2VhayBhbGlhc2VzLCBoZW5jZSB0
aGUgX19NQUNIX18gY2hlY2suCiAjIGRlZmluZSBBTElBUyh4KSBfX2F0dHJpYnV0ZV9fICgod2Vh
aywgYWxpYXMgKHgpKSkKSW5kZXg6IEphdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCj09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCShyZXZpc2lvbiA0MDI5NCkK
KysrIEphdmFTY3JpcHRDb3JlL3d0Zi9QbGF0Zm9ybS5oCSh3b3JraW5nIGNvcHkpCkBAIC0yNDIs
OCArMjQyLDE0IEBACiAjZW5kaWYKICNlbmRpZgogCisvKiBDT01QSUxFUihSVkNUKSAqLworI2lm
IGRlZmluZWQoX19DQ19BUk0pIHx8IGRlZmluZWQoX19BUk1DQ19fKQorI2RlZmluZSBXVEZfQ09N
UElMRVJfUlZDVCAxCisjZW5kaWYKKwogLyogQ09NUElMRVIoR0NDKSAqLwotI2lmIGRlZmluZWQo
X19HTlVDX18pCisvKiAtLWdudSBvcHRpb24gb2YgdGhlIFJWQ1QgY29tcGlsZXIgYWxzbyBkZWZp
bmVzIF9fR05VQ19fICovCisjaWYgZGVmaW5lZChfX0dOVUNfXykgJiYgIUNPTVBJTEVSKFJWQ1Qp
CiAjZGVmaW5lIFdURl9DT01QSUxFUl9HQ0MgMQogI2VuZGlmCiAKQEAgLTI2NCwxMSArMjcwLDYg
QEAKICNkZWZpbmUgV1RGX0NPTVBJTEVSX0NZR1dJTiAxCiAjZW5kaWYKIAotLyogQ09NUElMRVIo
UlZDVCkgKi8KLSNpZiBkZWZpbmVkKF9fQ0NfQVJNKSB8fCBkZWZpbmVkKF9fQVJNQ0NfXykKLSNk
ZWZpbmUgV1RGX0NPTVBJTEVSX1JWQ1QgMQotI2VuZGlmCi0KIC8qIENPTVBJTEVSKFdJTlNDVykg
Ki8KICNpZiBkZWZpbmVkKF9fV0lOU0NXX18pCiAjZGVmaW5lIFdURl9DT01QSUxFUl9XSU5TQ1cg
MQpJbmRleDogV2ViQ29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9DaGFuZ2VM
b2cJKHJldmlzaW9uIDQwMzAxKQorKysgV2ViQ29yZS9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkK
QEAgLTEsMyArMSwxMiBAQAorMjAwOS0wMS0yNyAgTGFzemxvIEdvbWJvcyAgPGxhc3psby4xLmdv
bWJvc0Bub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK
KyAgICAgICAgQnVnIDIzNTgwOiBHTlUgbW9kZSBSVkNUIGNvbXBpbGF0aW9uIHN1cHBvcnQKKyAg
ICAgICAgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzU4MD4KKwor
ICAgICAgICAqIGh0bWwvUHJlbG9hZFNjYW5uZXIuY3BwOgorCiAyMDA5LTAxLTI3ICBTaW1vbiBG
cmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERh
dmUgSHlhdHQKSW5kZXg6IFdlYkNvcmUvaHRtbC9QcmVsb2FkU2Nhbm5lci5jcHAKPT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PQotLS0gV2ViQ29yZS9odG1sL1ByZWxvYWRTY2FubmVyLmNwcAkocmV2aXNpb24gNDAyOTQpCisr
KyBXZWJDb3JlL2h0bWwvUHJlbG9hZFNjYW5uZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00Myw3
ICs0Myw3IEBACiAjaW5jbHVkZSA8d3RmL0N1cnJlbnRUaW1lLmg+CiAjaW5jbHVkZSA8d3RmL3Vu
aWNvZGUvVW5pY29kZS5oPgogCi0jaWZkZWYgX19HTlVDX18KKyNpZiBDT01QSUxFUihHQ0MpCiAv
LyBUaGUgbWFpbiB0b2tlbml6ZXIgaW5jbHVkZXMgdGhpcyB0b28gc28gd2UgYXJlIGdldHRpbmcg
dHdvIGNvcGllcyBvZiB0aGUgZGF0YS4gSG93ZXZlciwgdGhpcyB3YXkgdGhlIGNvZGUgZ2V0cyBp
bmxpbmVkLgogI2luY2x1ZGUgIkhUTUxFbnRpdHlOYW1lcy5jIgogI2Vsc2UK
</data>
<flag name="review"
          id="13075"
          type_id="1"
          status="+"
          setter="hausmann"
    />
          </attachment>
      

    </bug>

</bugzilla>