235792 2022-01-28 07:37:06 -0800 css/css-fonts/animations/font-variation-settings-interpolation.html has failures 2026-01-12 09:01:21 -0800 1 1 1 Unclassified WebKit Animations WebKit Nightly Build Unspecified Unspecified NEW InRadar P2 Normal --- 232087 246579 1 graouts webkit-unassigned ahmad.saleem792 darin dino graouts nmouchtaris webkit-bug-importer oldest_to_newest 1834945 0 graouts 2022-01-28 07:37:06 -0800 css/css-fonts/animations/font-variation-settings-interpolation.html has 4 failures, we need to investigate and fix them. 1837395 1 webkit-bug-importer 2022-02-04 07:40:49 -0800 <rdar://problem/88488519> 1907555 2 darin 2022-10-22 10:39:38 -0700 I believe the failure has something to do with cubic bezier timing. 1907626 3 graouts 2022-10-23 03:20:08 -0700 Our failures are: FAIL CSS Transitions: property <font-variation-settings> from ['aaaa' 30, 'bbbb' 20] to ['aaaa' 20, 'bbbb' 30] at (3.40282e+38) should be ['aaaa' -3.40282e+38, 'bbbb' 3.40282e+38] assert_array_equals: expected property 0 to be "\"aaaa\" -3.40282e+38" but got "\"aaaa\" -Infinity" (expected array ["\"aaaa\" -3.40282e+38", "\"bbbb\" 3.40282e+38"] got ["\"aaaa\" -Infinity", "\"bbbb\" Infinity"]) FAIL CSS Transitions with transition: all: property <font-variation-settings> from ['aaaa' 30, 'bbbb' 20] to ['aaaa' 20, 'bbbb' 30] at (3.40282e+38) should be ['aaaa' -3.40282e+38, 'bbbb' 3.40282e+38] assert_array_equals: expected property 0 to be "\"aaaa\" -3.40282e+38" but got "\"aaaa\" -Infinity" (expected array ["\"aaaa\" -3.40282e+38", "\"bbbb\" 3.40282e+38"] got ["\"aaaa\" -Infinity", "\"bbbb\" Infinity"]) FAIL CSS Animations: property <font-variation-settings> from ['aaaa' 30, 'bbbb' 20] to ['aaaa' 20, 'bbbb' 30] at (3.40282e+38) should be ['aaaa' -3.40282e+38, 'bbbb' 3.40282e+38] assert_array_equals: expected property 0 to be "\"aaaa\" -3.40282e+38" but got "\"aaaa\" -Infinity" (expected array ["\"aaaa\" -3.40282e+38", "\"bbbb\" 3.40282e+38"] got ["\"aaaa\" -Infinity", "\"bbbb\" Infinity"]) FAIL Web Animations: property <font-variation-settings> from ['aaaa' 30, 'bbbb' 20] to ['aaaa' 20, 'bbbb' 30] at (3.40282e+38) should be ['aaaa' -3.40282e+38, 'bbbb' 3.40282e+38] assert_array_equals: expected property 0 to be "\"aaaa\" -3.40282e+38" but got "\"aaaa\" -Infinity" (expected array ["\"aaaa\" -3.40282e+38", "\"bbbb\" 3.40282e+38"] got ["\"aaaa\" -Infinity", "\"bbbb\" Infinity"]) It looks like a serialization problem to me where we use "Infinity" here. 1907640 4 darin 2022-10-23 04:35:14 -0700 The large number ends up getting rounded to Infinity at some point during the animation process. I think it has to do with conversion between double and float, but I can’t pinpoint exactly where it happens. 1907642 5 darin 2022-10-23 04:39:00 -0700 By the time the serialization happens, the value is a floating point infinity, so it does not seem to be a bug in the serialization code itself, but rather in the animation code. 1907661 6 graouts 2022-10-23 09:16:17 -0700 The issue is that we're animating font-variation-settings values which are floats and using a very large progress value for blending that itself is represented as a double. The blending happens in this method: static inline float blendFunc(float from, float to, const CSSPropertyBlendingContext& context) { if (context.compositeOperation == CompositeOperation::Replace) return narrowPrecisionToFloat(from + (to - from) * context.progress); return narrowPrecisionToFloat(from + from + (to - from) * context.progress); } If we returned a double here, we would retain the precision, but narrowPrecisionToFloat() leads to the Infinity value. 1914486 7 ahmad.saleem792 2022-11-24 07:46:10 -0800 (In reply to Antoine Quint from comment #6) > The issue is that we're animating font-variation-settings values which are > floats and using a very large progress value for blending that itself is > represented as a double. The blending happens in this method: > > static inline float blendFunc(float from, float to, const > CSSPropertyBlendingContext& context) > { > if (context.compositeOperation == CompositeOperation::Replace) > return narrowPrecisionToFloat(from + (to - from) * context.progress); > return narrowPrecisionToFloat(from + from + (to - from) * > context.progress); > } > > If we returned a double here, we would retain the precision, but > narrowPrecisionToFloat() leads to the Infinity value. In the past, I tried to clamp narrowPrecisionToFloat in bug 245356 and it changed this test from infinity to value. PR - https://github.com/WebKit/WebKit/pull/4580 1914492 8 ahmad.saleem792 2022-11-24 08:02:12 -0800 Also Blink templatize the blend function in following crbug.com/276109 by fixing underflow issues in current code.