23574 2009-01-27 12:50:21 -0800 add #if ENABLE(PAN_SCROLLING) around EventHandler::setPanScrollCursor 2009-02-07 18:48:44 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Other Linux RESOLVED FIXED P2 Normal --- 1 feng webkit-unassigned caryclark oldest_to_newest 107236 0 feng 2009-01-27 12:50:21 -0800 EventHanlder::setPanScrollCursor is a private method of EventHandler class, and it is only used by autoscrollTimerFired when ENABLE(PAN_SCROLLING) is true. Putting #if ENABLE(PAN_SCROLLING) around Event::setPanScrollCursor can save some bytes for platforms that do not support pan scrolling. 107237 1 27082 feng 2009-01-27 12:54:37 -0800 Created attachment 27082 patch v1 107851 2 zecke 2009-01-31 12:10:20 -0800 Can't you compile the libWebCore to an archive (.a) file and let the linker sort that out? 107976 3 feng 2009-02-02 09:31:30 -0800 On Android platform, libwebcore is compiled as a shared library (used by browser and other apps). In this case, I think a smart linker should be able to strip setPanScrollCursor off since the function is private and not used, but the linker seems not as smart as we want :( (In reply to comment #2) > Can't you compile the libWebCore to an archive (.a) file and let the linker > sort that out? > 108717 4 27082 eric 2009-02-06 14:23:07 -0800 Comment on attachment 27082 patch v1 The patch looks fine. The ChangeLog needs your full name. You should investigate setting the CHANGE_LOG_NAME environment variable. see prepare-ChangeLog for more info. 108751 5 27430 feng 2009-02-06 15:58:05 -0800 Created attachment 27430 patch with my name Thanks, Eric Updated the patch with fixed name in the changeLog. 108752 6 27430 eric 2009-02-06 15:59:35 -0800 Comment on attachment 27430 patch with my name Still looks good. :) 108858 7 bfulgham 2009-02-07 18:48:44 -0800 Committed in http://trac.webkit.org/changeset/40767 27082 2009-01-27 12:54:37 -0800 2009-02-06 15:58:05 -0800 patch v1 23574patch.txt text/plain 1721 feng SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MDI5NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDktMDEtMjcgIGZxaWFuICA8ZmVuZ0BjaHJvbWl1bS5vcmc+CisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUHV0ICNpZiBF TkFCTEUoUEFOX1NDUk9MTElORykgYXJvdW5kIEV2ZW50SGFuZGxlcjo6c2V0UGFuU2Nyb2xsQ3Vy c29yLiAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTIz NTc0CisKKyAgICAgICAgKiBwYWdlL0V2ZW50SGFuZGxlci5jcHA6CisgICAgICAgICogcGFnZS9F dmVudEhhbmRsZXIuaDoKKwogMjAwOS0wMS0yNyAgQWRlbGUgUGV0ZXJzb24gIDxhZGVsZUBhcHBs ZS5jb20+CiAKICAgICAgICAgUlMgYnkgRGF2ZSBIeWF0dCAgCkluZGV4OiBXZWJDb3JlL3BhZ2Uv RXZlbnRIYW5kbGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVy LmNwcAkocmV2aXNpb24gNDAyOTcpCisrKyBXZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNwcAko d29ya2luZyBjb3B5KQpAQCAtNjIyLDYgKzYyMiw3IEBAIHZvaWQgRXZlbnRIYW5kbGVyOjphdXRv c2Nyb2xsVGltZXJGaXJlZCgKICAgICB9CiB9CiAKKyNpZiBFTkFCTEUoUEFOX1NDUk9MTElORykK IHZvaWQgRXZlbnRIYW5kbGVyOjpzZXRQYW5TY3JvbGxDdXJzb3IoKQogewogICAgIC8vIEF0IHRo ZSBvcmlnaW5hbCBjbGljayBsb2NhdGlvbiB3ZSBkcmF3IGEgNCBhcnJvd2VkIGljb24uIE92ZXIg dGhpcyBpY29uIHRoZXJlIHdvbid0IGJlIGFueSBzY3JvbGwKQEAgLTY1Myw2ICs2NTQsNyBAQCB2 b2lkIEV2ZW50SGFuZGxlcjo6c2V0UGFuU2Nyb2xsQ3Vyc29yKCkKICAgICBlbHNlCiAgICAgICAg IG1fZnJhbWUtPnZpZXcoKS0+c2V0Q3Vyc29yKG1pZGRsZVBhbm5pbmdDdXJzb3IoKSk7CiB9Cisj ZW5kaWYgIC8vIEVOQUJMRShQQU5fU0NST0xMSU5HKQogCiBSZW5kZXJPYmplY3QqIEV2ZW50SGFu ZGxlcjo6YXV0b3Njcm9sbFJlbmRlcmVyKCkgY29uc3QKIHsKSW5kZXg6IFdlYkNvcmUvcGFnZS9F dmVudEhhbmRsZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmgJ KHJldmlzaW9uIDQwMjk3KQorKysgV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5oCSh3b3JraW5n IGNvcHkpCkBAIC0yMTYsNyArMjE2LDkgQEAgcHJpdmF0ZToKICAgICB2b2lkIGhhbmRsZUtleWJv YXJkU2VsZWN0aW9uTW92ZW1lbnQoS2V5Ym9hcmRFdmVudCopOwogICAgIAogICAgIEN1cnNvciBz ZWxlY3RDdXJzb3IoY29uc3QgTW91c2VFdmVudFdpdGhIaXRUZXN0UmVzdWx0cyYsIFNjcm9sbGJh ciopOworI2lmIEVOQUJMRShQQU5fU0NST0xMSU5HKQogICAgIHZvaWQgc2V0UGFuU2Nyb2xsQ3Vy c29yKCk7CisjZW5kaWYKIAogICAgIHZvaWQgaG92ZXJUaW1lckZpcmVkKFRpbWVyPEV2ZW50SGFu ZGxlcj4qKTsKIAo= 27430 2009-02-06 15:58:05 -0800 2009-02-06 15:59:35 -0800 patch with my name 23574patch.txt text/plain 1724 feng SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA0MDI5NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMDktMDEtMjcgIEZlbmcgUWlhbiA8ZmVuZ0BjaHJvbWl1bS5vcmc+ CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUHV0ICNp ZiBFTkFCTEUoUEFOX1NDUk9MTElORykgYXJvdW5kIEV2ZW50SGFuZGxlcjo6c2V0UGFuU2Nyb2xs Q3Vyc29yLiAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk PTIzNTc0CisKKyAgICAgICAgKiBwYWdlL0V2ZW50SGFuZGxlci5jcHA6CisgICAgICAgICogcGFn ZS9FdmVudEhhbmRsZXIuaDoKKwogMjAwOS0wMS0yNyAgQWRlbGUgUGV0ZXJzb24gIDxhZGVsZUBh cHBsZS5jb20+CiAKICAgICAgICAgUlMgYnkgRGF2ZSBIeWF0dCAgCkluZGV4OiBXZWJDb3JlL3Bh Z2UvRXZlbnRIYW5kbGVyLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvRXZlbnRIYW5k bGVyLmNwcAkocmV2aXNpb24gNDAyOTcpCisrKyBXZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmNw cAkod29ya2luZyBjb3B5KQpAQCAtNjIyLDYgKzYyMiw3IEBAIHZvaWQgRXZlbnRIYW5kbGVyOjph dXRvc2Nyb2xsVGltZXJGaXJlZCgKICAgICB9CiB9CiAKKyNpZiBFTkFCTEUoUEFOX1NDUk9MTElO RykKIHZvaWQgRXZlbnRIYW5kbGVyOjpzZXRQYW5TY3JvbGxDdXJzb3IoKQogewogICAgIC8vIEF0 IHRoZSBvcmlnaW5hbCBjbGljayBsb2NhdGlvbiB3ZSBkcmF3IGEgNCBhcnJvd2VkIGljb24uIE92 ZXIgdGhpcyBpY29uIHRoZXJlIHdvbid0IGJlIGFueSBzY3JvbGwKQEAgLTY1Myw2ICs2NTQsNyBA QCB2b2lkIEV2ZW50SGFuZGxlcjo6c2V0UGFuU2Nyb2xsQ3Vyc29yKCkKICAgICBlbHNlCiAgICAg ICAgIG1fZnJhbWUtPnZpZXcoKS0+c2V0Q3Vyc29yKG1pZGRsZVBhbm5pbmdDdXJzb3IoKSk7CiB9 CisjZW5kaWYgIC8vIEVOQUJMRShQQU5fU0NST0xMSU5HKQogCiBSZW5kZXJPYmplY3QqIEV2ZW50 SGFuZGxlcjo6YXV0b3Njcm9sbFJlbmRlcmVyKCkgY29uc3QKIHsKSW5kZXg6IFdlYkNvcmUvcGFn ZS9FdmVudEhhbmRsZXIuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVy LmgJKHJldmlzaW9uIDQwMjk3KQorKysgV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5oCSh3b3Jr aW5nIGNvcHkpCkBAIC0yMTYsNyArMjE2LDkgQEAgcHJpdmF0ZToKICAgICB2b2lkIGhhbmRsZUtl eWJvYXJkU2VsZWN0aW9uTW92ZW1lbnQoS2V5Ym9hcmRFdmVudCopOwogICAgIAogICAgIEN1cnNv ciBzZWxlY3RDdXJzb3IoY29uc3QgTW91c2VFdmVudFdpdGhIaXRUZXN0UmVzdWx0cyYsIFNjcm9s bGJhciopOworI2lmIEVOQUJMRShQQU5fU0NST0xMSU5HKQogICAgIHZvaWQgc2V0UGFuU2Nyb2xs Q3Vyc29yKCk7CisjZW5kaWYKIAogICAgIHZvaWQgaG92ZXJUaW1lckZpcmVkKFRpbWVyPEV2ZW50 SGFuZGxlcj4qKTsKIAo=