235737 2022-01-27 14:45:20 -0800 [CMake] Do not require GNU Gold usage to enable DEBUG_FISSION 2022-01-28 02:25:19 -0800 1 1 1 Unclassified WebKit CMake WebKit Local Build Unspecified Unspecified RESOLVED FIXED P2 Normal --- 235476 1 aperez aperez achristensen annulen cgarcia ews-watchlist gyuyoung.kim mcatanzaro ryuan.choi saam sergio ysuzuki oldest_to_newest 1834714 0 aperez 2022-01-27 14:45:20 -0800 As per my comment at https://bugs.webkit.org/show_bug.cgi?id=235476#c4 all of ld.bfd, lld, and mold support split-debug builds, and there is not reason whatsoever to make the DEBUG_FISSION option depend on the value of the USE_LD_GOLD one. % cat hello.cc #include <cstdio> extern const char* whom(); int main() { std::printf("Hello, %s!\n", whom()); } % cat other.cc const char* whom() { return "Pete"; } % g++ -gsplit-dwarf -ggdb -c hello.cc % g++ -gsplit-dwarf -ggdb -c other.cc % g++ -gsplit-dwarf -ggdb -fuse-ld=bfd -o hello hello.o other.o % dwarfdump hello | grep DW_AT_dwo_name | sort -u DW_AT_dwo_name hello.dwo DW_AT_dwo_name other.dwo (Replacing g++ with clang++ above also works, plus the Clang compiler driver will happily accept any -fuse-ld=whatever as long as there is a “ld.whatever” binary in the $PATH.) 1834732 1 450187 aperez 2022-01-27 15:16:18 -0800 Created attachment 450187 Patch 1834786 2 ews-feeder 2022-01-27 17:24:54 -0800 Committed r288718 (246511@main): <https://commits.webkit.org/246511@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450187. 1834867 3 aperez 2022-01-28 02:25:19 -0800 For the record: I did some tests, and debug builds now take about the same time with ld.bfd after applying this patch, and ld.lld is faster than both ld.gold and ld.bfd (no surprises there!). I have not tried with ld.mold because we do not yet have it in the Flatpak SDK. 450187 2022-01-27 15:16:18 -0800 2022-01-27 17:24:57 -0800 Patch bug-235737-20220128011617.patch text/plain 2132 aperez U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4NzAwCmRpZmYgLS1naXQgYS9Tb3VyY2UvY21ha2UvT3B0 aW9uc0NvbW1vbi5jbWFrZSBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCmluZGV4 IDE0MTZjNTg3ZjViMTFmZWY2YWFhNGNmNzVjMjg2MGY5OTNhZjQyMmYuLmZiNmU4YTEyMjE0NWM2 MjUxNzk4ZmQ0MjFmNmFmNzAyOWNiMjI5MGIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9jbWFrZS9PcHRp b25zQ29tbW9uLmNtYWtlCisrKyBiL1NvdXJjZS9jbWFrZS9PcHRpb25zQ29tbW9uLmNtYWtlCkBA IC03Myw3ICs3Myw3IEBAIGlmIChVU0VfTERfR09MRCkKIGVuZGlmICgpCiAKIHNldChFTkFCTEVf REVCVUdfRklTU0lPTl9ERUZBVUxUIE9GRikKLWlmIChVU0VfTERfR09MRCBBTkQgQ01BS0VfQlVJ TERfVFlQRSBTVFJFUVVBTCAiRGVidWciKQoraWYgKENNQUtFX0JVSUxEX1RZUEUgU1RSRVFVQUwg IkRlYnVnIikKICAgICBjaGVja19jeHhfY29tcGlsZXJfZmxhZygtZ3NwbGl0LWR3YXJmIENYWF9D T01QSUxFUl9TVVBQT1JUU19HU1BMSVRfRFdBUkYpCiAgICAgaWYgKENYWF9DT01QSUxFUl9TVVBQ T1JUU19HU1BMSVRfRFdBUkYpCiAgICAgICAgIHNldChFTkFCTEVfREVCVUdfRklTU0lPTl9ERUZB VUxUIE9OKQpAQCAtODMsMTMgKzgzLDE0IEBAIGVuZGlmICgpCiBvcHRpb24oREVCVUdfRklTU0lP TiAiVXNlIERlYnVnIEZpc3Npb24gc3VwcG9ydCIgJHtFTkFCTEVfREVCVUdfRklTU0lPTl9ERUZB VUxUfSkKIAogaWYgKERFQlVHX0ZJU1NJT04pCi0gICAgaWYgKE5PVCBVU0VfTERfR09MRCkKLSAg ICAgICAgbWVzc2FnZShGQVRBTF9FUlJPUiAiTmVlZCBHTlUgZ29sZCBsaW5rZXIgZm9yIERlYnVn IEZpc3Npb24gc3VwcG9ydCIpCi0gICAgZW5kaWYgKCkKICAgICBzZXQoQ01BS0VfQ19GTEFHUyAi JHtDTUFLRV9DX0ZMQUdTfSAtZ3NwbGl0LWR3YXJmIikKICAgICBzZXQoQ01BS0VfQ1hYX0ZMQUdT ICIke0NNQUtFX0NYWF9GTEFHU30gLWdzcGxpdC1kd2FyZiIpCi0gICAgc2V0KENNQUtFX0VYRV9M SU5LRVJfRkxBR1MgIiR7Q01BS0VfRVhFX0xJTktFUl9GTEFHU30gLVdsLC0tZ2RiLWluZGV4IikK LSAgICBzZXQoQ01BS0VfU0hBUkVEX0xJTktFUl9GTEFHUyAiJHtDTUFLRV9FWEVfTElOS0VSX0ZM QUdTfSAtV2wsLS1nZGItaW5kZXgiKQorCisgICAgIyBUaGUgbGQuYmZkIGxpbmtlciBkb2VzIG5v dCBzdXBwb3J0IC0tZ2RiLWluZGV4LCBwb3NzaWJseSBvdGhlcnMgYXMgd2VsbC4KKyAgICBpZiAo VVNFX0xEX0dPTEQgT1IgVVNFX0xEX0xMRCkKKyAgICAgICAgc2V0KENNQUtFX0VYRV9MSU5LRVJf RkxBR1MgIiR7Q01BS0VfRVhFX0xJTktFUl9GTEFHU30gLVdsLC0tZ2RiLWluZGV4IikKKyAgICAg ICAgc2V0KENNQUtFX1NIQVJFRF9MSU5LRVJfRkxBR1MgIiR7Q01BS0VfRVhFX0xJTktFUl9GTEFH U30gLVdsLC0tZ2RiLWluZGV4IikKKyAgICBlbmRpZiAoKQogZW5kaWYgKCkKIAogc2V0KEdDQ19P RkZMSU5FQVNNX1NPVVJDRV9NQVBfREVGQVVMVCBPRkYpCmRpZmYgLS1naXQgYS9DaGFuZ2VMb2cg Yi9DaGFuZ2VMb2cKaW5kZXggZGY5NDA1NTMyYTBiOTdlNTllNTU2M2ZmNWU1YjM5Y2IwMzBiOTkz YS4uNWUxMjU3OGZmM2MxMzAxNmYyYmI2ZWE4ZDU3ZDQ3NzIwODAwODlkOSAxMDA2NDQKLS0tIGEv Q2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDIyLTAxLTI3ICBB ZHJpYW4gUGVyZXogZGUgQ2FzdHJvICA8YXBlcmV6QGlnYWxpYS5jb20+CisKKyAgICAgICAgW0NN YWtlXSBEbyBub3QgcmVxdWlyZSBHTlUgR29sZCB1c2FnZSB0byBlbmFibGUgREVCVUdfRklTU0lP TgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM1NzM3 CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBTb3Vy Y2UvY21ha2UvT3B0aW9uc0NvbW1vbi5jbWFrZTogQWxsb3cgZW5hYmxpbmcgREVCVUdfRklTU0lP TiB3aXRoIGFueSBsaW5rZXIuCisKIDIwMjItMDEtMjYgIEFkcmlhbiBQZXJleiBkZSBDYXN0cm8g IDxhcGVyZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBbQ01ha2VdIFBhc3MgLXBpcGUgdG8gY29t cGlsZXJzIHRoYXQgc3VwcG9ydCBpdAo=