23573 2009-01-27 12:29:49 -0800 Make PlatformWidget an intptr_t on Chromium 2009-01-28 10:52:32 -0800 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 agl webkit-unassigned ap sam oldest_to_newest 107234 0 agl 2009-01-27 12:29:49 -0800 2009-01-27 Adam Langley <agl@google.com> Reviewed by NOBODY (OOPS!). Make PlatformWidget on chromium an intptr_t * platform/chromium/PlatformWidget.h: 107235 1 27081 agl 2009-01-27 12:30:50 -0800 Created attachment 27081 Proposed patch 107258 2 27081 sam 2009-01-27 14:38:24 -0800 Comment on attachment 27081 Proposed patch +#include <wtf/Assertions.h> // for intptr_t This doesn't make a lot of sense. Please use the correct system header. 107260 3 agl 2009-01-27 14:43:29 -0800 The correct system header (stdint.h) doesn't exist on Windows. Assertions.h contains this code: #if COMPILER(MSVC) #include <stddef.h> #else #include <inttypes.h> #endif Which I can duplicate if you wish, but it seemed better to keep the #ifdefs down. 107264 4 ap 2009-01-27 14:51:46 -0800 I think that it could go in StdLibExtras.h (which in fact includes Assertions.h now). 107272 5 27089 agl 2009-01-27 15:30:54 -0800 Created attachment 27089 proposed patch 107273 6 agl 2009-01-27 15:31:11 -0800 Updated to use StdLibExtras.h 107279 7 27089 sam 2009-01-27 17:20:29 -0800 Comment on attachment 27089 proposed patch > @@ -1,3 +1,11 @@ > +2009-01-27 Adam Langley <agl@google.com> > + > + Reviewed by NOBODY (OOPS!). > + > + Make PlatformWidget on chromium an intptr_t This should include a why, not just a what. 107348 8 fishd 2009-01-28 10:52:32 -0800 http://trac.webkit.org/changeset/40314 27081 2009-01-27 12:30:50 -0800 2009-01-27 15:30:54 -0800 Proposed patch wkpatch text/plain 1240 agl Y29tbWl0IDRkNGEzNTkzMTA2ZGE5NWNjN2U0MjdiMzVmZThlOGY0ZDVhODhjNGIKQXV0aG9yOiBB ZGFtIExhbmdsZXkgPGFnbEBnb29nbGUuY29tPgpEYXRlOiAgIFR1ZSBKYW4gMjcgMTI6MTY6MDUg MjAwOSAtMDgwMAoKICAgIE1ha2UgUGxhdGZvcm1XaWRnZXQgb24gY2hyb21pdW0gYW4gaW50cHRy X3QKCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmlu ZGV4IDhjMzVlNmQuLjMwNjVjMTggMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBi L1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTEgQEAKKzIwMDktMDEtMjcgIEFkYW0gTGFu Z2xleSAgPGFnbEBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIE1ha2UgUGxhdGZvcm1XaWRnZXQgb24gY2hyb21pdW0gYW4gaW50cHRy X3QKKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL1BsYXRmb3JtV2lkZ2V0Lmg6CisKIDIw MDktMDEtMjcgIEFkZWxlIFBldGVyc29uICA8YWRlbGVAYXBwbGUuY29tPgogCiAgICAgICAgIFJT IGJ5IERhdmUgSHlhdHQgIApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9Q bGF0Zm9ybVdpZGdldC5oIGIvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9QbGF0Zm9ybVdpZGdl dC5oCmluZGV4IGU0ZTZhMTguLjFhZTVmNzcgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0v Y2hyb21pdW0vUGxhdGZvcm1XaWRnZXQuaAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVt L1BsYXRmb3JtV2lkZ2V0LmgKQEAgLTMxLDEwICszMSwxMiBAQAogI2lmbmRlZiBQbGF0Zm9ybVdp ZGdldF9oCiAjZGVmaW5lIFBsYXRmb3JtV2lkZ2V0X2gKIAorI2luY2x1ZGUgPHd0Zi9Bc3NlcnRp b25zLmg+ICAvLyBmb3IgaW50cHRyX3QKKwogLy8gUGxhdGZvcm1XaWRnZXQgaXMgYW4gb3BhcXVl IGlkZW50aWZpZXIgY29ycmVzcG9uZGluZyB0byB3aGF0ZXZlciBuYXRpdmUKIC8vIHZpZXcgdHlw ZSB0aGUgZW1iZWRkZXIgbWF5IHVzZS4gIFBsYXRmb3JtV2lkZ2V0IENBTk5PVCBiZSBhc3N1bWVk IHRvIGJlCiAvLyBhIHZhbGlkIHBvaW50ZXIuICBTb21lIGVtYmVkZGVycyBtYXkgbm90IHVzZSB0 aGlzIGlkZW50aWZpZXIgYXQgYWxsLgogCi10eXBlZGVmIHZvaWQqIFBsYXRmb3JtV2lkZ2V0Owor dHlwZWRlZiBpbnRwdHJfdCBQbGF0Zm9ybVdpZGdldDsKIAogI2VuZGlmCg== 27089 2009-01-27 15:30:54 -0800 2009-01-27 17:20:29 -0800 proposed patch wkpatch text/plain 1242 agl Y29tbWl0IGVlMTY2ZmFjYzE5NTQ3NDg3ZmEyZWJkMDMwNWExODVmNmIwZTBjZTUKQXV0aG9yOiBB ZGFtIExhbmdsZXkgPGFnbEBnb29nbGUuY29tPgpEYXRlOiAgIFR1ZSBKYW4gMjcgMTI6MTY6MDUg MjAwOSAtMDgwMAoKICAgIE1ha2UgUGxhdGZvcm1XaWRnZXQgb24gY2hyb21pdW0gYW4gaW50cHRy X3QKCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmlu ZGV4IDhjMzVlNmQuLjMwNjVjMTggMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBi L1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTEgQEAKKzIwMDktMDEtMjcgIEFkYW0gTGFu Z2xleSAgPGFnbEBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIE1ha2UgUGxhdGZvcm1XaWRnZXQgb24gY2hyb21pdW0gYW4gaW50cHRy X3QKKworICAgICAgICAqIHBsYXRmb3JtL2Nocm9taXVtL1BsYXRmb3JtV2lkZ2V0Lmg6CisKIDIw MDktMDEtMjcgIEFkZWxlIFBldGVyc29uICA8YWRlbGVAYXBwbGUuY29tPgogCiAgICAgICAgIFJT IGJ5IERhdmUgSHlhdHQgIApkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9Q bGF0Zm9ybVdpZGdldC5oIGIvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9QbGF0Zm9ybVdpZGdl dC5oCmluZGV4IGU0ZTZhMTguLmI5ZGRkZjMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0v Y2hyb21pdW0vUGxhdGZvcm1XaWRnZXQuaAorKysgYi9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVt L1BsYXRmb3JtV2lkZ2V0LmgKQEAgLTMxLDEwICszMSwxMiBAQAogI2lmbmRlZiBQbGF0Zm9ybVdp ZGdldF9oCiAjZGVmaW5lIFBsYXRmb3JtV2lkZ2V0X2gKIAorI2luY2x1ZGUgPHd0Zi9TdGRMaWJF eHRyYXMuaD4gIC8vIGZvciBpbnRwdHJfdAorCiAvLyBQbGF0Zm9ybVdpZGdldCBpcyBhbiBvcGFx dWUgaWRlbnRpZmllciBjb3JyZXNwb25kaW5nIHRvIHdoYXRldmVyIG5hdGl2ZQogLy8gdmlldyB0 eXBlIHRoZSBlbWJlZGRlciBtYXkgdXNlLiAgUGxhdGZvcm1XaWRnZXQgQ0FOTk9UIGJlIGFzc3Vt ZWQgdG8gYmUKIC8vIGEgdmFsaWQgcG9pbnRlci4gIFNvbWUgZW1iZWRkZXJzIG1heSBub3QgdXNl IHRoaXMgaWRlbnRpZmllciBhdCBhbGwuCiAKLXR5cGVkZWYgdm9pZCogUGxhdGZvcm1XaWRnZXQ7 Cit0eXBlZGVmIGludHB0cl90IFBsYXRmb3JtV2lkZ2V0OwogCiAjZW5kaWYK