235728 2022-01-27 13:01:01 -0800 AXIsolatedObject::children should honor the parameter updateChildrenIfNeeded. 2022-01-27 14:24:46 -0800 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 andresg_22 andresg_22 aboxhall andresg_22 apinheiro cfleizach dmazzoni ews-watchlist jcraig jdiggs samuel_white webkit-bug-importer oldest_to_newest 1834663 0 andresg_22 2022-01-27 13:01:01 -0800 AXIsolatedObject::children should honor the parameter updateChildrenIfNeeded. 1834664 1 webkit-bug-importer 2022-01-27 13:01:12 -0800 <rdar://problem/88149344> 1834671 2 450169 andresg_22 2022-01-27 13:08:26 -0800 Created attachment 450169 Patch 1834674 3 450169 cfleizach 2022-01-27 13:17:07 -0800 Comment on attachment 450169 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=450169&action=review > Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:538 > +const AXCoreObject::AccessibilityChildrenVector& AXIsolatedObject::children(bool updateChildrenIfNeeded) too many spaces "bool updateChildrenIfNeeded" 1834678 4 450170 andresg_22 2022-01-27 13:28:21 -0800 Created attachment 450170 Patch 1834680 5 andresg_22 2022-01-27 13:30:14 -0800 (In reply to chris fleizach from comment #3) > Comment on attachment 450169 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=450169&action=review > > > Source/WebCore/accessibility/isolatedtree/AXIsolatedObject.cpp:538 > > +const AXCoreObject::AccessibilityChildrenVector& AXIsolatedObject::children(bool updateChildrenIfNeeded) > > too many spaces > "bool updateChildrenIfNeeded" Fixed. 1834703 6 ews-feeder 2022-01-27 14:24:41 -0800 Committed r288703 (246501@main): <https://commits.webkit.org/246501@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450170. 450169 2022-01-27 13:08:26 -0800 2022-01-27 13:28:18 -0800 Patch bug-235728-20220127160825.patch text/plain 2660 andresg_22 U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4NDM3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTQ0Mjk4OGQzNjMwZWIx YmUyYzYyOWM3M2Y0YWIxOWIwZGVmYmE5NC4uYWFmZmRiMTkxMmViYWI2Mzc5ZmQzMmQwMWE4NmQz YWJmM2IwYWU3YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIyLTAxLTI3ICBBbmRy ZXMgR29uemFsZXogIDxhbmRyZXNnXzIyQGFwcGxlLmNvbT4KKworICAgICAgICBBWElzb2xhdGVk T2JqZWN0OjpjaGlsZHJlbiBzaG91bGQgaG9ub3IgdGhlIHBhcmFtZXRlciB1cGRhdGVDaGlsZHJl bklmTmVlZGVkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjM1NzI4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84ODE0OTM0ND4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIHdpbGwgYWxsb3cgdG8g Z2V0IGEgbW9yZSBhY2N1cmF0ZSBzbWFwc2hvdCBvZiB0aGUgaXNvbGF0ZWQgdHJlZQorICAgICAg ICBkdXJpbmcgZGVidWdnaW5nLiBGb3IgaW5zdGFuY2UgaXQgd2lsbCBhbGxvdyB0byBkbyBBWExP RyBvZiB0aGUgaXNvbGF0ZWQKKyAgICAgICAgdHJlZSBpbiBhcHBseVBlbmRpbmdDaGFuZ2VzIHdo aWNoIGlzIGN1cnJlbnRseSBub3QgcG9zc2libGUgYmVjYXVzZQorICAgICAgICByZXN1bHRzIGlu IGluZmluaXRlIHJlY3Vyc2lvbi4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvaXNvbGF0ZWR0 cmVlL0FYSXNvbGF0ZWRPYmplY3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QVhJc29sYXRlZE9i amVjdDo6Y2hpbGRyZW4pOgorCiAyMDIyLTAxLTI0ICBBZHJpYW4gUGVyZXogZGUgQ2FzdHJvICA8 YXBlcmV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgRml4IG5vbi11bmlmaWVkIGJ1aWxkIGFmdGVy IHIyODg0MzIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvaXNvbGF0 ZWR0cmVlL0FYSXNvbGF0ZWRPYmplY3QuY3BwIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0 eS9pc29sYXRlZHRyZWUvQVhJc29sYXRlZE9iamVjdC5jcHAKaW5kZXggZWNmODE4YjFhNmIxNjI3 MjcwMzgwYmNlODg2ZjlhNjA0Y2ZhNzdhZi4uZjIyNmM4MmIxZGViMGY1NzFhMTYzMGE5ZDM4MWNk ZjJhNzQ1MmI2MiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9pc29s YXRlZHRyZWUvQVhJc29sYXRlZE9iamVjdC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvYWNjZXNz aWJpbGl0eS9pc29sYXRlZHRyZWUvQVhJc29sYXRlZE9iamVjdC5jcHAKQEAgLTUzNSw3ICs1MzUs NyBAQCB2b2lkIEFYSXNvbGF0ZWRPYmplY3Q6OmRldGFjaEZyb21QYXJlbnQoKQogICAgIG1fcGFy ZW50SUQgPSB7IH07CiB9CiAKLWNvbnN0IEFYQ29yZU9iamVjdDo6QWNjZXNzaWJpbGl0eUNoaWxk cmVuVmVjdG9yJiBBWElzb2xhdGVkT2JqZWN0OjpjaGlsZHJlbihib29sKQorY29uc3QgQVhDb3Jl T2JqZWN0OjpBY2Nlc3NpYmlsaXR5Q2hpbGRyZW5WZWN0b3ImIEFYSXNvbGF0ZWRPYmplY3Q6OmNo aWxkcmVuKGJvb2wgIHVwZGF0ZUNoaWxkcmVuSWZOZWVkZWQpCiB7CiAjaWYgVVNFKEFQUExFX0lO VEVSTkFMX1NESykKICAgICBBU1NFUlQoX0FYU0lzb2xhdGVkVHJlZU1vZGVGdW5jdGlvbklzQXZh aWxhYmxlKCkgJiYgKChfQVhTSXNvbGF0ZWRUcmVlTW9kZV9Tb2Z0KCkgPT0gQVhTSXNvbGF0ZWRU cmVlTW9kZVNlY29uZGFyeVRocmVhZCAmJiAhaXNNYWluVGhyZWFkKCkpCkBAIC01NDMsMTIgKzU0 MywxNCBAQCBjb25zdCBBWENvcmVPYmplY3Q6OkFjY2Vzc2liaWxpdHlDaGlsZHJlblZlY3RvciYg QVhJc29sYXRlZE9iamVjdDo6Y2hpbGRyZW4oYm9vbAogI2VsaWYgVVNFKEFUU1BJKQogICAgIEFT U0VSVCghaXNNYWluVGhyZWFkKCkpOwogI2VuZGlmCi0gICAgdXBkYXRlQmFja2luZ1N0b3JlKCk7 Ci0gICAgbV9jaGlsZHJlbi5jbGVhcigpOwotICAgIG1fY2hpbGRyZW4ucmVzZXJ2ZUluaXRpYWxD YXBhY2l0eShtX2NoaWxkcmVuSURzLnNpemUoKSk7Ci0gICAgZm9yIChjb25zdCBhdXRvJiBjaGls ZElEIDogbV9jaGlsZHJlbklEcykgewotICAgICAgICBpZiAoYXV0byBjaGlsZCA9IHRyZWUoKS0+ bm9kZUZvcklEKGNoaWxkSUQpKQotICAgICAgICAgICAgbV9jaGlsZHJlbi51bmNoZWNrZWRBcHBl bmQoY2hpbGQpOworICAgIGlmICh1cGRhdGVDaGlsZHJlbklmTmVlZGVkKSB7CisgICAgICAgIHVw ZGF0ZUJhY2tpbmdTdG9yZSgpOworICAgICAgICBtX2NoaWxkcmVuLmNsZWFyKCk7CisgICAgICAg IG1fY2hpbGRyZW4ucmVzZXJ2ZUluaXRpYWxDYXBhY2l0eShtX2NoaWxkcmVuSURzLnNpemUoKSk7 CisgICAgICAgIGZvciAoY29uc3QgYXV0byYgY2hpbGRJRCA6IG1fY2hpbGRyZW5JRHMpIHsKKyAg ICAgICAgICAgIGlmIChhdXRvIGNoaWxkID0gdHJlZSgpLT5ub2RlRm9ySUQoY2hpbGRJRCkpCisg ICAgICAgICAgICAgICAgbV9jaGlsZHJlbi51bmNoZWNrZWRBcHBlbmQoY2hpbGQpOworICAgICAg ICB9CiAgICAgfQogICAgIHJldHVybiBtX2NoaWxkcmVuOwogfQo= 450170 2022-01-27 13:28:21 -0800 2022-01-27 14:24:44 -0800 Patch bug-235728-20220127162820.patch text/plain 2706 andresg_22 U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4Njk4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYzg4NmY2MjUzZDkzYmU4 Yjg1OTg4N2JkZjhiOGQ5MjMzZGI1OTM0OC4uMWVkNDdkZDNhNDRjZjE0OWE0ZWIxNDEzN2ViZGVm OGRhMjU1ZGQyYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDIyLTAxLTI3ICBBbmRy ZXMgR29uemFsZXogIDxhbmRyZXNnXzIyQGFwcGxlLmNvbT4KKworICAgICAgICBBWElzb2xhdGVk T2JqZWN0OjpjaGlsZHJlbiBzaG91bGQgaG9ub3IgdGhlIHBhcmFtZXRlciB1cGRhdGVDaGlsZHJl bklmTmVlZGVkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MjM1NzI4CisgICAgICAgIDxyZGFyOi8vcHJvYmxlbS84ODE0OTM0ND4KKworICAgICAgICBS ZXZpZXdlZCBieSBDaHJpcyBGbGVpemFjaC4KKworICAgICAgICBUaGlzIHdpbGwgYWxsb3cgdG8g Z2V0IGEgbW9yZSBhY2N1cmF0ZSBzbWFwc2hvdCBvZiB0aGUgaXNvbGF0ZWQgdHJlZQorICAgICAg ICBkdXJpbmcgZGVidWdnaW5nLiBGb3IgaW5zdGFuY2UgaXQgd2lsbCBhbGxvdyB0byBkbyBBWExP RyBvZiB0aGUgaXNvbGF0ZWQKKyAgICAgICAgdHJlZSBpbiBhcHBseVBlbmRpbmdDaGFuZ2VzIHdo aWNoIGlzIGN1cnJlbnRseSBub3QgcG9zc2libGUgYmVjYXVzZQorICAgICAgICByZXN1bHRzIGlu IGluZmluaXRlIHJlY3Vyc2lvbi4KKworICAgICAgICAqIGFjY2Vzc2liaWxpdHkvaXNvbGF0ZWR0 cmVlL0FYSXNvbGF0ZWRPYmplY3QuY3BwOgorICAgICAgICAoV2ViQ29yZTo6QVhJc29sYXRlZE9i amVjdDo6Y2hpbGRyZW4pOgorCiAyMDIyLTAxLTI3ICBEZXZpbiBSb3Vzc28gIDxkcm91c3NvQGFw cGxlLmNvbT4KIAogICAgICAgICBbUGF5bWVudCBSZXF1ZXN0XSBhbGxvdyBhZGRpdGlvbmFsIHBh eW1lbnQgbWV0aG9kIHNwZWNpZmljIGRhdGEgdG8gYmUgcGFzc2VkIHRvIGBjb21wbGV0ZSgpYApk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9pc29sYXRlZHRyZWUvQVhJ c29sYXRlZE9iamVjdC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2lzb2xhdGVk dHJlZS9BWElzb2xhdGVkT2JqZWN0LmNwcAppbmRleCBlZmZmZDJkZTVhMWEyOTBkN2E3ZGJmNjk2 NWEwZTU0ODFmZGViMGMyLi43ZWFmZmIzMGFiODk2ODVlZjdiMThmMDBhMjg4OTU2ODhmNjQ4MjZh IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2lzb2xhdGVkdHJlZS9B WElzb2xhdGVkT2JqZWN0LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2lz b2xhdGVkdHJlZS9BWElzb2xhdGVkT2JqZWN0LmNwcApAQCAtNTMxLDcgKzUzMSw3IEBAIHZvaWQg QVhJc29sYXRlZE9iamVjdDo6ZGV0YWNoRnJvbVBhcmVudCgpCiAgICAgbV9wYXJlbnRJRCA9IHsg fTsKIH0KIAotY29uc3QgQVhDb3JlT2JqZWN0OjpBY2Nlc3NpYmlsaXR5Q2hpbGRyZW5WZWN0b3Im IEFYSXNvbGF0ZWRPYmplY3Q6OmNoaWxkcmVuKGJvb2wpCitjb25zdCBBWENvcmVPYmplY3Q6OkFj Y2Vzc2liaWxpdHlDaGlsZHJlblZlY3RvciYgQVhJc29sYXRlZE9iamVjdDo6Y2hpbGRyZW4oYm9v bCB1cGRhdGVDaGlsZHJlbklmTmVlZGVkKQogewogI2lmIFVTRShBUFBMRV9JTlRFUk5BTF9TREsp CiAgICAgQVNTRVJUKF9BWFNJc29sYXRlZFRyZWVNb2RlRnVuY3Rpb25Jc0F2YWlsYWJsZSgpICYm ICgoX0FYU0lzb2xhdGVkVHJlZU1vZGVfU29mdCgpID09IEFYU0lzb2xhdGVkVHJlZU1vZGVTZWNv bmRhcnlUaHJlYWQgJiYgIWlzTWFpblRocmVhZCgpKQpAQCAtNTM5LDEyICs1MzksMTQgQEAgY29u c3QgQVhDb3JlT2JqZWN0OjpBY2Nlc3NpYmlsaXR5Q2hpbGRyZW5WZWN0b3ImIEFYSXNvbGF0ZWRP YmplY3Q6OmNoaWxkcmVuKGJvb2wKICNlbGlmIFVTRShBVFNQSSkKICAgICBBU1NFUlQoIWlzTWFp blRocmVhZCgpKTsKICNlbmRpZgotICAgIHVwZGF0ZUJhY2tpbmdTdG9yZSgpOwotICAgIG1fY2hp bGRyZW4uY2xlYXIoKTsKLSAgICBtX2NoaWxkcmVuLnJlc2VydmVJbml0aWFsQ2FwYWNpdHkobV9j aGlsZHJlbklEcy5zaXplKCkpOwotICAgIGZvciAoY29uc3QgYXV0byYgY2hpbGRJRCA6IG1fY2hp bGRyZW5JRHMpIHsKLSAgICAgICAgaWYgKGF1dG8gY2hpbGQgPSB0cmVlKCktPm5vZGVGb3JJRChj aGlsZElEKSkKLSAgICAgICAgICAgIG1fY2hpbGRyZW4udW5jaGVja2VkQXBwZW5kKGNoaWxkKTsK KyAgICBpZiAodXBkYXRlQ2hpbGRyZW5JZk5lZWRlZCkgeworICAgICAgICB1cGRhdGVCYWNraW5n U3RvcmUoKTsKKyAgICAgICAgbV9jaGlsZHJlbi5jbGVhcigpOworICAgICAgICBtX2NoaWxkcmVu LnJlc2VydmVJbml0aWFsQ2FwYWNpdHkobV9jaGlsZHJlbklEcy5zaXplKCkpOworICAgICAgICBm b3IgKGNvbnN0IGF1dG8mIGNoaWxkSUQgOiBtX2NoaWxkcmVuSURzKSB7CisgICAgICAgICAgICBp ZiAoYXV0byBjaGlsZCA9IHRyZWUoKS0+bm9kZUZvcklEKGNoaWxkSUQpKQorICAgICAgICAgICAg ICAgIG1fY2hpbGRyZW4udW5jaGVja2VkQXBwZW5kKGNoaWxkKTsKKyAgICAgICAgfQogICAgIH0K ICAgICByZXR1cm4gbV9jaGlsZHJlbjsKIH0K