235726 2022-01-27 12:09:21 -0800 AX: Isolated tree object frames no longer encode content offsets, so hit testing should be updated accordingly 2022-01-28 08:10:15 -0800 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 tyler_w tyler_w andresg_22 cfleizach webkit-bug-importer oldest_to_newest 1834637 0 tyler_w 2022-01-27 12:09:21 -0800 In -[WKAccessibilityWebPageObjectMac accessibilityHitTest], we have a special isolated tree case: // Isolated tree frames have the offset encoded into them so we don't need to undo here. #if ENABLE(ACCESSIBILITY_ISOLATED_TREE) applyContentOffset = !WebCore::AXObjectCache::isIsolatedTreeEnabled(); #endif The statement in the comment no longer seems to be true, as applying this content offset results in hit testing working incorrectly -- specifically, you have to hit test for a larger y-value than your target is actually located at. 1834638 1 webkit-bug-importer 2022-01-27 12:09:34 -0800 <rdar://problem/88146867> 1834757 2 450193 tyler_w 2022-01-27 16:18:27 -0800 Created attachment 450193 Patch 1834793 3 tyler_w 2022-01-27 17:46:09 -0800 My original comment should say: as **NOT** applying this content offset results in hit testing working incorrectly It's correct in the Changelog. 1834978 4 ews-feeder 2022-01-28 08:10:14 -0800 Committed r288741 (246534@main): <https://commits.webkit.org/246534@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450193. 450193 2022-01-27 16:18:27 -0800 2022-01-28 08:10:14 -0800 Patch bug-235726-20220127181826.patch text/plain 2968 tyler_w U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4Njc0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0L0No YW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGE2MGZkYjk2NzhlOWM0NDg3 MjhlMDYyZTM5ZDBlYmIyY2I1NDFmM2EuLmNhNWFlMjUyNWMxZDY1MDM0ZGYwZmEyYzdiMWIwMGUw ZWNjNWZkZTQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQvQ2hhbmdlTG9nCisrKyBiL1NvdXJj ZS9XZWJLaXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMzMgQEAKKzIwMjItMDEtMjcgIFR5bGVyIFdp bGNvY2sgIDx0eWxlcl93QGFwcGxlLmNvbT4KKworICAgICAgICBBWDogSXNvbGF0ZWQgdHJlZSBv YmplY3QgZnJhbWVzIG5vIGxvbmdlciBlbmNvZGUgY29udGVudCBvZmZzZXRzLCBzbyBoaXQgdGVz dGluZyBzaG91bGQgYmUgdXBkYXRlZCBhY2NvcmRpbmdseQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM1NzI2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW4gLVtXS0FjY2Vzc2liaWxpdHlXZWJQYWdlT2Jq ZWN0TWFjIGFjY2Vzc2liaWxpdHlIaXRUZXN0XSwgd2UgaGF2ZSBhIHNwZWNpYWwgaXNvbGF0ZWQg dHJlZSBjYXNlOgorCisgICAgICAgIC8vIElzb2xhdGVkIHRyZWUgZnJhbWVzIGhhdmUgdGhlIG9m ZnNldCBlbmNvZGVkIGludG8gdGhlbSBzbyB3ZSBkb24ndCBuZWVkIHRvIHVuZG8gaGVyZS4KKyAg ICAgICAgI2lmIEVOQUJMRShBQ0NFU1NJQklMSVRZX0lTT0xBVEVEX1RSRUUpCisgICAgICAgICAg ICBhcHBseUNvbnRlbnRPZmZzZXQgPSAhV2ViQ29yZTo6QVhPYmplY3RDYWNoZTo6aXNJc29sYXRl ZFRyZWVFbmFibGVkKCk7CisgICAgICAgICNlbmRpZgorCisgICAgICAgIFRoZSBzdGF0ZW1lbnQg aW4gdGhlIGNvbW1lbnQgbm8gbG9uZ2VyIHNlZW1zIHRvIGJlIHRydWUsIGFzIG5vdCBhcHBseWlu ZyB0aGlzIGNvbnRlbnQgb2Zmc2V0IHJlc3VsdHMKKyAgICAgICAgaW4gaGl0IHRlc3Rpbmcgd29y a2luZyBpbmNvcnJlY3RseSAodGhlIHBvaW50IGdpdmVuIHRvIFdlYkNvcmUgaXMgdG9vIHNtYWxs KS4KKworICAgICAgICBUaGlzIGlzIGJlY2F1c2UgaXNvbGF0ZWQgdHJlZSBoaXQgdGVzdGluZyB1 c2VkIHRvIHVzZSByZWxhdGl2ZSBmcmFtZXM6CisKKyAgICAgICAgaHR0cHM6Ly9naXRodWIuY29t L1dlYktpdC9XZWJLaXQvYmxvYi9mNTUyNTkyMWFhYzA5MGNhOTU0NGNjZTJhM2FjMjhlMzhmOTJj OWJhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvaXNvbGF0ZWR0cmVlL0FYSXNvbGF0ZWRU cmVlTm9kZS5jcHAjTDExNQorCisgICAgICAgIEJ1dCBub3cgZG9lc24ndCwgaW5zdGVhZCBkZWZl cnJpbmcgdG8gdGhlIGxpdmUsIG1haW4tdGhyZWFkIEFYIG9iamVjdCwgd2hpY2ggZG9lc24ndCB1 c2UgcmVsYXRpdmUgZnJhbWVzOgorCisgICAgICAgIGh0dHBzOi8vZ2l0aHViLmNvbS9XZWJLaXQv V2ViS2l0L2Jsb2IvNDIyMWE1MTBmZTQ2NzhjZjFhMDNlNWMwNjg3OGNmMmQzZjBjMTczOC9Tb3Vy Y2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L2lzb2xhdGVkdHJlZS9BWElzb2xhdGVkT2JqZWN0LmNw cCNMODE0CisKKyAgICAgICAgVGhpcyBwYXRjaCByZW1vdmVzIHRoaXMgaXNvbGF0ZWQtdHJlZS1z cGVjaWZpYyBiZWhhdmlvci4KKworICAgICAgICAqIFdlYlByb2Nlc3MvV2ViUGFnZS9tYWMvV0tB Y2Nlc3NpYmlsaXR5V2ViUGFnZU9iamVjdE1hYy5tbToKKyAgICAgICAgKC1bV0tBY2Nlc3NpYmls aXR5V2ViUGFnZU9iamVjdCBhY2Nlc3NpYmlsaXR5SGl0VGVzdDpdKToKKwogMjAyMi0wMS0yNyAg QW50b2luZSBRdWludCAgPGdyYW91dHNAd2Via2l0Lm9yZz4KIAogICAgICAgICA8bW9kZWw+IHNo b3VsZCBvbmx5IGJlIGRyYWdnYWJsZSBvbiBpT1MKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQv V2ViUHJvY2Vzcy9XZWJQYWdlL21hYy9XS0FjY2Vzc2liaWxpdHlXZWJQYWdlT2JqZWN0TWFjLm1t IGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1dLQWNjZXNzaWJpbGl0eVdl YlBhZ2VPYmplY3RNYWMubW0KaW5kZXggM2ViMzMwY2FkN2IzYzRlNjU0MzVlNWFmMWNmOTRlODYz MWQwNGNjMi4uMzNlODI3ZDdmY2U4ZWEwMzQ3ODBmNTM3MzJkZWM4YzBmZTExNjc3NiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBhZ2UvbWFjL1dLQWNjZXNzaWJpbGl0 eVdlYlBhZ2VPYmplY3RNYWMubW0KKysrIGIvU291cmNlL1dlYktpdC9XZWJQcm9jZXNzL1dlYlBh Z2UvbWFjL1dLQWNjZXNzaWJpbGl0eVdlYlBhZ2VPYmplY3RNYWMubW0KQEAgLTI3NiwxMCArMjc2 LDYgQEAgQUxMT1dfREVQUkVDQVRFRF9ERUNMQVJBVElPTlNfQkVHSU4KICAgICAgICAgLy8gU29t ZSBwbHVnaW5zIG1heSBiZSBhYmxlIHRvIGZpZ3VyZSBvdXQgdGhlIHNjcm9sbCBwb3NpdGlvbiBh bmQgaW5zZXQgb24gdGhlaXIgb3duLgogICAgICAgICBib29sIGFwcGx5Q29udGVudE9mZnNldCA9 IHRydWU7CiAKLSAgICAgICAgLy8gSXNvbGF0ZWQgdHJlZSBmcmFtZXMgaGF2ZSB0aGUgb2Zmc2V0 IGVuY29kZWQgaW50byB0aGVtIHNvIHdlIGRvbid0IG5lZWQgdG8gdW5kbyBoZXJlLgotI2lmIEVO QUJMRShBQ0NFU1NJQklMSVRZX0lTT0xBVEVEX1RSRUUpCi0gICAgICAgIGFwcGx5Q29udGVudE9m ZnNldCA9ICFXZWJDb3JlOjpBWE9iamVjdENhY2hlOjppc0lzb2xhdGVkVHJlZUVuYWJsZWQoKTsK LSNlbmRpZgogICAgICAgICBpZiAoYXV0byBwbHVnaW5WaWV3ID0gV2ViS2l0OjpXZWJQYWdlOjpw bHVnaW5WaWV3Rm9yRnJhbWUocHJvdGVjdGVkU2VsZi0+bV9wYWdlLT5tYWluRnJhbWUoKSkpCiAg ICAgICAgICAgICBhcHBseUNvbnRlbnRPZmZzZXQgPSAhcGx1Z2luVmlldy0+cGx1Z2luKCktPnBs dWdpbkhhbmRsZXNDb250ZW50T2Zmc2V0Rm9yQWNjZXNzaWJpbGl0eUhpdFRlc3QoKTsKICAgICAg ICAgCg==