235715 2022-01-27 07:54:43 -0800 AXLogger::add should not cause tree updates via children() 2022-01-27 11:56:55 -0800 1 1 1 Unclassified WebKit Accessibility WebKit Nightly Build All All RESOLVED FIXED InRadar P2 Normal --- 1 tyler_w tyler_w aboxhall andresg_22 apinheiro cfleizach dmazzoni ews-watchlist jcraig jdiggs samuel_white webkit-bug-importer oldest_to_newest 1834516 0 tyler_w 2022-01-27 07:54:43 -0800 AXLogger::add(TextStream&, const RefPtr<AXCoreObject>&, bool) currently calls the update version of children, causing behavior to potentially be different between builds with logging enabled and logging disabled. void AXLogger::add(TextStream& stream, const RefPtr<AXCoreObject>& object, bool recursive) { ...truncated... if (recursive) { for (auto& child : object->children()) add(stream, child, true); } ...truncated } The logger should only read the current state of the object / tree, never modify it. 1834517 1 webkit-bug-importer 2022-01-27 07:55:13 -0800 <rdar://problem/88132984> 1834521 2 450137 tyler_w 2022-01-27 07:58:34 -0800 Created attachment 450137 Patch 1834570 3 ews-feeder 2022-01-27 10:00:04 -0800 Committed r288676 (246482@main): <https://commits.webkit.org/246482@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 450137. 450137 2022-01-27 07:58:34 -0800 2022-01-27 11:56:55 -0800 Patch bug-235715-20220127095833.patch text/plain 1669 tyler_w U3VidmVyc2lvbiBSZXZpc2lvbjogMjg4NTk0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZGVkNDQ2YjQ0OGI5ZjIz YmExZmNmMDI2MzVkYTcyYmUwMTVjMTlkZi4uMjY5NzA2M2NhYTJlZjEzM2FhYjBlNTQ3YjY0NDA1 NTE1N2E4YTRjNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDIyLTAxLTI3ICBUeWxl ciBXaWxjb2NrICA8dHlsZXJfd0BhcHBsZS5jb20+CisKKyAgICAgICAgQVhMb2dnZXI6OmFkZCBz aG91bGQgbm90IGNhdXNlIHRyZWUgdXBkYXRlcyB2aWEgY2hpbGRyZW4oKQorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MjM1NzE1CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQVhMb2dnZXI6OmFkZChUZXh0U3Ry ZWFtJiwgY29uc3QgUmVmUHRyPEFYQ29yZU9iamVjdD4mLCBib29sKSBjdXJyZW50bHkKKyAgICAg ICAgY2FsbHMgdGhlIHVwZGF0ZSB2ZXJzaW9uIG9mIEFYQ29yZU9iamVjdDo6Y2hpbGRyZW4oYm9v bCksIGNhdXNpbmcgYmVoYXZpb3IKKyAgICAgICAgdG8gcG90ZW50aWFsbHkgYmUgZGlmZmVyZW50 IGJldHdlZW4gYnVpbGRzIHdpdGggbG9nZ2luZyBlbmFibGVkIGFuZCBsb2dnaW5nCisgICAgICAg IGRpc2FibGVkLgorCisgICAgICAgIFRoZSBsb2dnZXIgc2hvdWxkIG9ubHkgcmVhZCB0aGUgY3Vy cmVudCBzdGF0ZSBvZiB0aGUgb2JqZWN0IC8gdHJlZSwgbmV2ZXIgbW9kaWZ5IGl0LgorCisgICAg ICAgICogYWNjZXNzaWJpbGl0eS9BWExvZ2dlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBWExv Z2dlcjo6YWRkKToKKwogMjAyMi0wMS0yNSAgQWxleGV5IFNodmF5a2EgIDxhc2h2YXlrYUBhcHBs ZS5jb20+CiAKICAgICAgICAgW1dlYklETF0gUmVtb3ZlIHRoZSBub3ctdW51c2VkIFtDdXN0b21F bmFibGVkXSBleHRlbmRlZCBhdHRyaWJ1dGUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Fj Y2Vzc2liaWxpdHkvQVhMb2dnZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9B WExvZ2dlci5jcHAKaW5kZXggMTQ3YmJhOTk1MzMxN2FhYzc4MGJiNTI5NTNiOGEyYzFlNTQyNjVk MC4uOWRlNGViNWJiNGFlYTBmYjY5MDBjYWRlYTg5MjAyZjAzODRkYTFjMSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvYWNjZXNzaWJpbGl0eS9BWExvZ2dlci5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvYWNjZXNzaWJpbGl0eS9BWExvZ2dlci5jcHAKQEAgLTEwMCw3ICsxMDAsNyBAQCB2b2lk IEFYTG9nZ2VyOjphZGQoVGV4dFN0cmVhbSYgc3RyZWFtLCBjb25zdCBSZWZQdHI8QVhDb3JlT2Jq ZWN0PiYgb2JqZWN0LCBib29sCiAgICAgc3RyZWFtIDw8ICpvYmplY3Q7CiAKICAgICBpZiAocmVj dXJzaXZlKSB7Ci0gICAgICAgIGZvciAoYXV0byYgY2hpbGQgOiBvYmplY3QtPmNoaWxkcmVuKCkp CisgICAgICAgIGZvciAoYXV0byYgY2hpbGQgOiBvYmplY3QtPmNoaWxkcmVuKGZhbHNlKSkKICAg ICAgICAgICAgIGFkZChzdHJlYW0sIGNoaWxkLCB0cnVlKTsKICAgICB9CiAgICAgc3RyZWFtLmRl Y3JlYXNlSW5kZW50KCk7Cg==