235711 2022-01-27 06:30:51 -0800 [GTK][a11y] Return the list of column/row headers from header cells too with ATSPI 2022-01-28 07:26:09 -0800 1 1 1 Unclassified WebKit WebKitGTK WebKit Nightly Build Unspecified Unspecified RESOLVED FIXED Gtk, LayoutTestFailure P2 Normal --- 230253 1 cgarcia webkit-unassigned aboxhall andresg_22 aperez apinheiro bugs-noreply cfleizach dmazzoni ews-watchlist jcraig jdiggs samuel_white oldest_to_newest 1834499 0 cgarcia 2022-01-27 06:30:51 -0800 We are only returning the list of column/row headers from cells that are not headers for consistency with chromium. However, our layout tests don't expect that and firefox doesn't do it either. 1834854 1 450211 cgarcia 2022-01-28 01:21:26 -0800 Created attachment 450211 Patch 1834937 2 cgarcia 2022-01-28 07:26:09 -0800 Committed r288738 (246531@trunk): <https://commits.webkit.org/246531@trunk> 450211 2022-01-28 01:21:26 -0800 2022-01-28 02:34:10 -0800 Patch wcore-atspi-cell-headers.diff text/plain 5425 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA3OTY4Nzg2YzQ4NjguLmNiMTk1ODY5MjA5NSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAt MSwzICsxLDE3IEBACisyMDIyLTAxLTI4ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFA aWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXVthMTF5XSBSZXR1cm4gdGhlIGxpc3Qgb2YgY29s dW1uL3JvdyBoZWFkZXJzIGZyb20gaGVhZGVyIGNlbGxzIHRvbyB3aXRoIEFUU1BJCisgICAgICAg IGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0yMzU3MTEKKworICAgICAg ICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBhcmUgb25seSByZXR1 cm5pbmcgdGhlIGxpc3Qgb2YgY29sdW1uL3JvdyBoZWFkZXJzIGZyb20gY2VsbHMgdGhhdCBhcmUg bm90IGhlYWRlcnMgZm9yIGNvbnNpc3RlbmN5IHdpdGgKKyAgICAgICAgY2hyb21pdW0uIEhvd2V2 ZXIsIG91ciBsYXlvdXQgdGVzdHMgZG9uJ3QgZXhwZWN0IHRoYXQgYW5kIGZpcmVmb3ggZG9lc24n dCBkbyBpdCBlaXRoZXIuCisKKyAgICAgICAgKiBhY2Nlc3NpYmlsaXR5L2F0c3BpL0FjY2Vzc2li aWxpdHlPYmplY3RUYWJsZUNlbGxBdHNwaS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpBY2Nlc3Np YmlsaXR5T2JqZWN0QXRzcGk6OmNlbGxSb3dIZWFkZXJzIGNvbnN0KToKKyAgICAgICAgKFdlYkNv cmU6OkFjY2Vzc2liaWxpdHlPYmplY3RBdHNwaTo6Y2VsbENvbHVtbkhlYWRlcnMgY29uc3QpOgor CiAyMDIyLTAxLTI3ICBDYXJsb3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4K IAogICAgICAgICBbV1BFXVthMTF5XSBBZGQgb3B0aW9uIHRvIGJ1aWxkIHdpdGggQVRTUEkKZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvYXRzcGkvQWNjZXNzaWJpbGl0 eU9iamVjdFRhYmxlQ2VsbEF0c3BpLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkv YXRzcGkvQWNjZXNzaWJpbGl0eU9iamVjdFRhYmxlQ2VsbEF0c3BpLmNwcAppbmRleCBmNTFiMTY2 NjFmYzEuLjczM2E0MzIyNzk5OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvYWNjZXNzaWJp bGl0eS9hdHNwaS9BY2Nlc3NpYmlsaXR5T2JqZWN0VGFibGVDZWxsQXRzcGkuY3BwCisrKyBiL1Nv dXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvYXRzcGkvQWNjZXNzaWJpbGl0eU9iamVjdFRhYmxl Q2VsbEF0c3BpLmNwcApAQCAtOTUsMTAgKzk1LDYgQEAgVmVjdG9yPFJlZlB0cjxBY2Nlc3NpYmls aXR5T2JqZWN0QXRzcGk+PiBBY2Nlc3NpYmlsaXR5T2JqZWN0QXRzcGk6OmNlbGxSb3dIZWFkZXIK ICAgICBpZiAoIW1fY29yZU9iamVjdCkKICAgICAgICAgcmV0dXJuIHsgfTsKIAotICAgIC8vIE9u bHkgcmV0dXJuIGhlYWRlcnMgZm9yIGNlbGxzIHRoYXQgYXJlIG5vdCBoZWFkZXJzLgotICAgIGlm IChyb2xlKCkgIT0gQXRzcGk6OlJvbGU6OlRhYmxlQ2VsbCkKLSAgICAgICAgcmV0dXJuIHsgfTsK LQogICAgIHJldHVybiB3cmFwcGVyVmVjdG9yKG1fY29yZU9iamVjdC0+cm93SGVhZGVycygpKTsK IH0KIApAQCAtMTA3LDEwICsxMDMsNiBAQCBWZWN0b3I8UmVmUHRyPEFjY2Vzc2liaWxpdHlPYmpl Y3RBdHNwaT4+IEFjY2Vzc2liaWxpdHlPYmplY3RBdHNwaTo6Y2VsbENvbHVtbkhlYQogICAgIGlm ICghbV9jb3JlT2JqZWN0KQogICAgICAgICByZXR1cm4geyB9OwogCi0gICAgLy8gT25seSByZXR1 cm4gaGVhZGVycyBmb3IgY2VsbHMgdGhhdCBhcmUgbm90IGhlYWRlcnMuCi0gICAgaWYgKHJvbGUo KSAhPSBBdHNwaTo6Um9sZTo6VGFibGVDZWxsKQotICAgICAgICByZXR1cm4geyB9OwotCiAgICAg cmV0dXJuIHdyYXBwZXJWZWN0b3IobV9jb3JlT2JqZWN0LT5jb2x1bW5IZWFkZXJzKCkpOwogfQog CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cgYi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggYTdj NzRkZWUyNjBmLi5hYTM1Mzg1YzU4ODAgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0NoYW5nZUxvZworKysg Yi9Ub29scy9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAyMi0wMS0yOCAgQ2FybG9zIEdh cmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CisKKyAgICAgICAgW0dUS11bYTExeV0g UmV0dXJuIHRoZSBsaXN0IG9mIGNvbHVtbi9yb3cgaGVhZGVycyBmcm9tIGhlYWRlciBjZWxscyB0 b28gd2l0aCBBVFNQSQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MjM1NzExCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBUZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdEd0ay9UZXN0V2ViS2l0QWNjZXNzaWJp bGl0eS5jcHA6CisgICAgICAgICh0ZXN0VGFibGVCYXNpYyk6CisKIDIwMjItMDEtMjcgIENhcmxv cyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtXUEVdW2Ex MXldIEFkZCBvcHRpb24gdG8gYnVpbGQgd2l0aCBBVFNQSQpkaWZmIC0tZ2l0IGEvVG9vbHMvVGVz dFdlYktpdEFQSS9UZXN0cy9XZWJLaXRHdGsvVGVzdFdlYktpdEFjY2Vzc2liaWxpdHkuY3BwIGIv VG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRHdGsvVGVzdFdlYktpdEFjY2Vzc2liaWxp dHkuY3BwCmluZGV4IDhlNzA5NGRhMmQ1OC4uNDJkMWFiNTA0NGMwIDEwMDY0NAotLS0gYS9Ub29s cy9UZXN0V2ViS2l0QVBJL1Rlc3RzL1dlYktpdEd0ay9UZXN0V2ViS2l0QWNjZXNzaWJpbGl0eS5j cHAKKysrIGIvVG9vbHMvVGVzdFdlYktpdEFQSS9UZXN0cy9XZWJLaXRHdGsvVGVzdFdlYktpdEFj Y2Vzc2liaWxpdHkuY3BwCkBAIC0yODIyLDcgKzI4MjIsOSBAQCBzdGF0aWMgdm9pZCB0ZXN0VGFi bGVCYXNpYyhBY2Nlc3NpYmlsaXR5VGVzdCogdGVzdCwgZ2NvbnN0cG9pbnRlcikKICAgICBjZWxs VGFibGUgPSBhZG9wdEdSZWYoYXRzcGlfdGFibGVfY2VsbF9nZXRfdGFibGUoQVRTUElfVEFCTEVf Q0VMTChjZWxsMS5nZXQoKSksIG51bGxwdHIpKTsKICAgICBnX2Fzc2VydF90cnVlKHRhYmxlLmdl dCgpID09IGNlbGxUYWJsZS5nZXQoKSk7CiAgICAgcm93SGVhZGVycyA9IGFkb3B0R1JlZihhdHNw aV90YWJsZV9jZWxsX2dldF9yb3dfaGVhZGVyX2NlbGxzKEFUU1BJX1RBQkxFX0NFTEwoY2VsbDEu Z2V0KCkpLCBudWxscHRyKSk7Ci0gICAgZ19hc3NlcnRfY21waW50KHJvd0hlYWRlcnMtPmxlbiwg PT0sIDApOworICAgIGdfYXNzZXJ0X2NtcGludChyb3dIZWFkZXJzLT5sZW4sID09LCAxKTsKKyAg ICBnX2Fzc2VydF90cnVlKHJvd0hlYWRlcnMtPnBkYXRhWzBdID09IGNvbHVtbkhlYWRlcjAuZ2V0 KCkpOworICAgIGdfcHRyX2FycmF5X2ZvcmVhY2gocm93SGVhZGVycy5nZXQoKSwgcmVpbnRlcnBy ZXRfY2FzdDxHRnVuYz4ocmVpbnRlcnByZXRfY2FzdDxHQ2FsbGJhY2s+KGdfb2JqZWN0X3VucmVm KSksIG51bGxwdHIpOwogICAgIGNvbHVtbkhlYWRlcnMgPSBhZG9wdEdSZWYoYXRzcGlfdGFibGVf Y2VsbF9nZXRfY29sdW1uX2hlYWRlcl9jZWxscyhBVFNQSV9UQUJMRV9DRUxMKGNlbGwxLmdldCgp KSwgbnVsbHB0cikpOwogICAgIGdfYXNzZXJ0X2NtcGludChjb2x1bW5IZWFkZXJzLT5sZW4sID09 LCAwKTsKICAgICBnX2Fzc2VydF90cnVlKEFUU1BJX0lTX1RFWFQoY2VsbDEuZ2V0KCkpKTsKQEAg LTI4NTYsNyArMjg1OCw5IEBAIHN0YXRpYyB2b2lkIHRlc3RUYWJsZUJhc2ljKEFjY2Vzc2liaWxp dHlUZXN0KiB0ZXN0LCBnY29uc3Rwb2ludGVyKQogICAgIGNlbGxUYWJsZSA9IGFkb3B0R1JlZihh dHNwaV90YWJsZV9jZWxsX2dldF90YWJsZShBVFNQSV9UQUJMRV9DRUxMKGNlbGwyLmdldCgpKSwg bnVsbHB0cikpOwogICAgIGdfYXNzZXJ0X3RydWUodGFibGUuZ2V0KCkgPT0gY2VsbFRhYmxlLmdl dCgpKTsKICAgICByb3dIZWFkZXJzID0gYWRvcHRHUmVmKGF0c3BpX3RhYmxlX2NlbGxfZ2V0X3Jv d19oZWFkZXJfY2VsbHMoQVRTUElfVEFCTEVfQ0VMTChjZWxsMi5nZXQoKSksIG51bGxwdHIpKTsK LSAgICBnX2Fzc2VydF9jbXBpbnQocm93SGVhZGVycy0+bGVuLCA9PSwgMCk7CisgICAgZ19hc3Nl cnRfY21waW50KHJvd0hlYWRlcnMtPmxlbiwgPT0sIDEpOworICAgIGdfYXNzZXJ0X3RydWUocm93 SGVhZGVycy0+cGRhdGFbMF0gPT0gY29sdW1uSGVhZGVyMC5nZXQoKSk7CisgICAgZ19wdHJfYXJy YXlfZm9yZWFjaChyb3dIZWFkZXJzLmdldCgpLCByZWludGVycHJldF9jYXN0PEdGdW5jPihyZWlu dGVycHJldF9jYXN0PEdDYWxsYmFjaz4oZ19vYmplY3RfdW5yZWYpKSwgbnVsbHB0cik7CiAgICAg Y29sdW1uSGVhZGVycyA9IGFkb3B0R1JlZihhdHNwaV90YWJsZV9jZWxsX2dldF9jb2x1bW5faGVh ZGVyX2NlbGxzKEFUU1BJX1RBQkxFX0NFTEwoY2VsbDIuZ2V0KCkpLCBudWxscHRyKSk7CiAgICAg Z19hc3NlcnRfY21waW50KGNvbHVtbkhlYWRlcnMtPmxlbiwgPT0sIDApOwogICAgIGdfYXNzZXJ0 X3RydWUoQVRTUElfSVNfVEVYVChjZWxsMi5nZXQoKSkpOwpAQCAtMjg5Miw3ICsyODk2LDkgQEAg c3RhdGljIHZvaWQgdGVzdFRhYmxlQmFzaWMoQWNjZXNzaWJpbGl0eVRlc3QqIHRlc3QsIGdjb25z dHBvaW50ZXIpCiAgICAgcm93SGVhZGVycyA9IGFkb3B0R1JlZihhdHNwaV90YWJsZV9jZWxsX2dl dF9yb3dfaGVhZGVyX2NlbGxzKEFUU1BJX1RBQkxFX0NFTEwoY2VsbDMuZ2V0KCkpLCBudWxscHRy KSk7CiAgICAgZ19hc3NlcnRfY21waW50KHJvd0hlYWRlcnMtPmxlbiwgPT0sIDApOwogICAgIGNv bHVtbkhlYWRlcnMgPSBhZG9wdEdSZWYoYXRzcGlfdGFibGVfY2VsbF9nZXRfY29sdW1uX2hlYWRl cl9jZWxscyhBVFNQSV9UQUJMRV9DRUxMKGNlbGwzLmdldCgpKSwgbnVsbHB0cikpOwotICAgIGdf YXNzZXJ0X2NtcGludChjb2x1bW5IZWFkZXJzLT5sZW4sID09LCAwKTsKKyAgICBnX2Fzc2VydF9j bXBpbnQoY29sdW1uSGVhZGVycy0+bGVuLCA9PSwgMSk7CisgICAgZ19hc3NlcnRfdHJ1ZShjb2x1 bW5IZWFkZXJzLT5wZGF0YVswXSA9PSBjb2x1bW5IZWFkZXIwLmdldCgpKTsKKyAgICBnX3B0cl9h cnJheV9mb3JlYWNoKGNvbHVtbkhlYWRlcnMuZ2V0KCksIHJlaW50ZXJwcmV0X2Nhc3Q8R0Z1bmM+ KHJlaW50ZXJwcmV0X2Nhc3Q8R0NhbGxiYWNrPihnX29iamVjdF91bnJlZikpLCBudWxscHRyKTsK ICAgICBnX2Fzc2VydF90cnVlKEFUU1BJX0lTX1RFWFQoY2VsbDMuZ2V0KCkpKTsKICAgICB0ZXh0 LnJlc2V0KGF0c3BpX3RleHRfZ2V0X3RleHQoQVRTUElfVEVYVChjZWxsMy5nZXQoKSksIDAsIC0x LCBudWxscHRyKSk7CiAgICAgZ19hc3NlcnRfY21wc3RyKHRleHQuZ2V0KCksID09LCAiUm93IDEg Q2VsbCAxIik7Cg==